reapack-index 1.0 → 1.1beta1

data/test/test_git.rb

@@ -142,4 +142,14 @@ class TestGit < MiniTest::Test
 
     assert_equal content, @git.last_commit.each_diff.first.new_content
   end
+
+  def test_path_encoding
+    path = mkpath 'еуые'
+    Dir.mkdir path
+    path.encode! Encoding::Windows_1251
+    path.freeze
+
+    git = ReaPack::Index::Git.new path # should not throw
+    assert_equal @git.path, git.path
+  end
 end

data/test/test_index.rb

@@ -9,34 +9,44 @@ class TestIndex < MiniTest::Test
   end
 
   def test_type_of
-    assert_equal [nil, nil, nil, :script, :script, :extension, :effect, :data],
-      [
-        'src/main.cpp', 'src/noext', 'in_root',
-        'Cat/test.lua', 'Cat/test.eel',
-        'Cat/test.ext',
-        'Cat/test.jsfx',
-        'Cat/test.data',
-      ].map {|fn| ReaPack::Index.type_of fn }
+    {
+      'src/main.cpp'   => nil,
+      'src/noext'      => nil,
+      'in_root'        => nil,
+      'Cat/test.lua'   => :script,
+      'Cat/test.eel'   => :script,
+      'Cat/test.py'    => :script,
+      'Cat/test.ext'   => :extension,
+      'Cat/test.jsfx'  => :effect,
+      'Cat/test.data'  => :data,
+      'Cat/test.theme' => :theme,
+    }.each {|fn, type|
+      actual = ReaPack::Index.type_of fn
+      assert_equal type, actual,
+        "%s was not of type %s, got %s instead" %
+          [fn.inspect, type.inspect, actual.inspect]
+    }
   end
 
   def test_resolve_type
-    expected = [
-      nil,
-      :script, :script, :script,
-      :effect, :effect, :effect,
-      :extension, :extension,
-      :data,
-    ]
-
-    actual = [
-      'hello',
-      :script, 'lua', 'eel',
-      'effect', :jsfx, 'jsfx',
-      'extension', 'ext',
-      'data',
-    ].map {|fn| ReaPack::Index.resolve_type fn }
-
-    assert_equal expected, actual
+    {
+      'hello'     => nil,
+      :script     => :script,
+      'lua'       => :script,
+      'eel'       => :script,
+      'effect'    => :effect,
+      :jsfx       => :effect,
+      'jsfx'      => :effect,
+      'extension' => :extension,
+      'ext'       => :extension,
+      'data'      => :data,
+      'theme'     => :theme,
+    }.each {|input, type|
+      actual = ReaPack::Index.resolve_type input
+      assert_equal type, actual,
+        "%s was not of type %s, got %s instead" %
+          [input.inspect, type.inspect, actual.inspect]
+    }
   end
 
   def test_url_template

data/test/test_metadata.rb

@@ -14,11 +14,13 @@ class TestMetadata < MiniTest::Test
     XML
 
     md = ReaPack::Index::Metadata.new before
+    assert_equal false, md.modified?
     assert_empty md.links(:website)
 
     link = md.push_link :website, 'http://cfillion.tk'
     assert_equal true, link.is_new?
     assert_equal true, link.modified?
+    assert_equal true, md.modified?
 
     links = md.links :website
     assert_equal 1, links.size
@@ -56,6 +58,29 @@ class TestMetadata < MiniTest::Test
     assert_equal after.chomp, before.to_s
   end
 
+  def test_screenshot_link
+    before = make_node '<index/>'
+    after = <<-XML
+<index>
+  <metadata>
+    <link rel="screenshot">http://cfillion.tk</link>
+  </metadata>
+</index>
+    XML
+
+    md = ReaPack::Index::Metadata.new before
+    assert_empty md.links(:donation)
+
+    md.push_link :screenshot, 'http://cfillion.tk'
+
+    links = md.links :screenshot
+    assert_equal 1, links.size
+    assert_equal links.first.url, links.first.name
+    assert_equal 'http://cfillion.tk', links.first.url
+
+    assert_equal after.chomp, before.to_s
+  end
+
   def test_invalid_type
     md = ReaPack::Index::Metadata.new make_node('<index/>')
 
@@ -65,6 +90,7 @@ class TestMetadata < MiniTest::Test
 
     assert_raises ArgumentError do
       md.push_link :hello, 'world'
+      assert_equal false, md.modified?
     end
 
     assert_raises ArgumentError do
@@ -122,6 +148,17 @@ class TestMetadata < MiniTest::Test
     assert_equal links[3].name, links[3].url
   end
 
+  def test_split_link
+    assert_equal ['http://perdu.com'],
+      ReaPack::Index::Link.split('http://perdu.com')
+
+    assert_equal ['Hello World', 'http://perdu.com/a=b'],
+      ReaPack::Index::Link.split('Hello World=http://perdu.com/a=b')
+
+    assert_equal ['Hello World', 'http://perdu.com/a=b'],
+      ReaPack::Index::Link.split('Hello World http://perdu.com/a=b')
+  end
+
   def test_invalid_link
     after = '<index/>'
     before = make_node after
@@ -151,9 +188,11 @@ class TestMetadata < MiniTest::Test
 
     md = ReaPack::Index::Metadata.new before
     assert_equal 2, md.links(:website).size
+    assert_equal false, md.modified?
 
     md.remove_link :website, 'http://cfillion.tk'
     assert_equal 1, md.links(:website).size
+    assert_equal true, md.modified?
 
     md.remove_link :website, 'Search'
     assert_equal 0, md.links(:website).size
@@ -241,7 +280,41 @@ class TestMetadata < MiniTest::Test
     assert_equal after.chomp, before.to_s
   end
 
-  def test_read_description
+  def test_replace_links
+    before = make_node <<-XML
+<index>
+  <metadata>
+    <link rel="website" href="http://cfillion.tk">A</link>
+    <link rel="donation">http://google.com</link>
+  </metadata>
+</index>
+    XML
+
+    after = <<-XML
+<index>
+  <metadata>
+    <link rel="donation">http://google.com</link>
+  </metadata>
+</index>
+    XML
+
+    md = ReaPack::Index::Metadata.new before
+    assert_equal false, md.modified?
+
+    md.replace_links :website do
+      link1 = md.push_link :website, 'A', 'http://cfillion.tk'
+    end
+
+    assert_equal false, md.modified?
+
+    md.replace_links :website do
+    end
+
+    assert_equal true, md.modified?
+    assert_equal after.chomp, before.to_s
+  end
+
+  def test_read_about
     md = ReaPack::Index::Metadata.new make_node <<-XML
 <index>
   <metadata>
@@ -250,20 +323,20 @@ class TestMetadata < MiniTest::Test
 </index>
     XML
 
-    assert_equal 'Hello World', md.description
+    assert_equal 'Hello World', md.about
   end
 
-  def test_read_description_empty
+  def test_read_about_empty
     md = ReaPack::Index::Metadata.new make_node <<-XML
 <index>
   <metadata/>
 </index>
     XML
 
-    assert_empty md.description
+    assert_empty md.about
   end
 
-  def test_write_description
+  def test_write_about
     rtf = <<-RTF
 {\\rtf1\\ansi\\deff0{\\fonttbl{\\f0 \\fswiss Helvetica;}{\\f1 Courier;}}
 {\\colortbl;\\red255\\green0\\blue0;\\red0\\green0\\blue255;}
@@ -283,15 +356,17 @@ class TestMetadata < MiniTest::Test
     XML
 
     md = ReaPack::Index::Metadata.new before
-    assert_empty md.description
+    assert_empty md.about
+    assert_equal false, md.modified?
 
-    md.description = 'Hello World'
-    assert_equal rtf, md.description
+    md.about = 'Hello World'
+    assert_equal true, md.modified?
+    assert_equal rtf, md.about
 
     assert_equal after.chomp, before.to_s
   end
 
-  def test_write_description_rtf
+  def test_write_about_rtf
     rtf = <<-RTF
 {\\rtf1\\ansi\\deff0{\\fonttbl{\\f0 \\fswiss Helvetica;}{\\f1 Courier;}}
 {\\colortbl;\\red255\\green0\\blue0;\\red0\\green0\\blue255;}
@@ -311,15 +386,15 @@ class TestMetadata < MiniTest::Test
     XML
 
     md = ReaPack::Index::Metadata.new before
-    assert_empty md.description
+    assert_empty md.about
 
-    md.description = rtf
-    assert_equal rtf, md.description
+    md.about = rtf
+    assert_equal rtf, md.about
 
     assert_equal after.chomp, before.to_s
   end
 
-  def test_replace_description
+  def test_replace_about
     before = make_node <<-XML
 <index>
   <metadata>
@@ -349,12 +424,12 @@ class TestMetadata < MiniTest::Test
     XML
 
     md = ReaPack::Index::Metadata.new before
-    md.description = 'Chunky Bacon'
+    md.about = 'Chunky Bacon'
 
     assert_equal after.chomp, before.to_s
   end
 
-  def test_remove_description
+  def test_remove_about
     rtf = <<-RTF
 {\\rtf1\\ansi\\deff0{\\fonttbl{\\f0 \\fswiss Helvetica;}{\\f1 Courier;}}
 {\\colortbl;\\red255\\green0\\blue0;\\red0\\green0\\blue255;}
@@ -375,14 +450,35 @@ class TestMetadata < MiniTest::Test
     after = '<index/>'
 
     md = ReaPack::Index::Metadata.new before
-    refute_empty md.description
+    refute_empty md.about
 
-    md.description = String.new
-    assert_empty md.description
+    md.about = String.new
+    assert_empty md.about
+    assert_equal true, md.modified?
 
     assert_equal after, before.to_s
   end
 
+  def test_set_same_about
+    before = make_node <<-XML
+<index>
+  <metadata>
+    <description><![CDATA[{\\rtf1\\ansi\\deff0{\\fonttbl{\\f0 \\fswiss Helvetica;}{\\f1 Courier;}}
+{\\colortbl;\\red255\\green0\\blue0;\\red0\\green0\\blue255;}
+\\widowctrl\\hyphauto
+
+{\\pard \\ql \\f0 \\sa180 \\li0 \\fi0 Hello World\\par}
+}
+]]></description>
+  </metadata>
+</index>
+    XML
+
+    md = ReaPack::Index::Metadata.new before
+    md.about = 'Hello World'
+    assert_equal false, md.modified?
+  end
+
   def test_pandoc_not_found
     old_path = ENV['PATH']
     ENV['PATH'] = String.new
@@ -390,7 +486,7 @@ class TestMetadata < MiniTest::Test
     md = ReaPack::Index::Metadata.new make_node('<index/>')
 
     error = assert_raises ReaPack::Index::Error do
-      md.description = 'test'
+      md.about = 'test'
     end
 
     assert_match /pandoc executable cannot be found in your PATH/i, error.message

data/test/test_package.rb

@@ -4,8 +4,8 @@ class TestPackage < MiniTest::Test
   include XMLHelper
 
   def test_change_type
-    before = make_node '<reapack name="1.0"/>'
-    after = '<reapack name="1.0" type="script"/>'
+    before = make_node '<reapack name="pkg"/>'
+    after = '<reapack name="pkg" type="script"/>'
 
     pkg = ReaPack::Index::Package.new before
     assert_nil pkg.type
@@ -18,7 +18,7 @@ class TestPackage < MiniTest::Test
   end
 
   def test_set_same_type
-    before = make_node '<reapack name="1.0" type="script"/>'
+    before = make_node '<reapack name="pkg" type="script"/>'
 
     pkg = ReaPack::Index::Package.new before
 
@@ -28,9 +28,59 @@ class TestPackage < MiniTest::Test
     refute pkg.modified?, 'package is modified'
   end
 
+  def test_set_description
+    before = make_node '<reapack name="pkg"/>'
+    after = '<reapack name="pkg" desc="hello world"/>'
+
+    pkg = ReaPack::Index::Package.new before
+    assert_empty pkg.description
+
+    pkg.description = 'hello world'
+    assert pkg.modified?, 'package is not modified'
+    assert_equal 'hello world', pkg.description
+
+    assert_equal after, before.to_s
+  end
+
+  def test_set_same_description
+    before = make_node '<reapack name="pkg" desc="hello world"/>'
+
+    pkg = ReaPack::Index::Package.new before
+
+    assert_equal 'hello world', pkg.description
+    pkg.description = pkg.description
+
+    refute pkg.modified?, 'package is modified'
+  end
+
+  def test_remove_description
+    before = make_node '<reapack name="pkg" desc="hello world"/>'
+    after = '<reapack name="pkg"/>'
+
+    pkg = ReaPack::Index::Package.new before
+    assert_equal 'hello world', pkg.description
+
+    pkg.description = nil
+    assert pkg.modified?, 'package is not modified'
+
+    assert_equal after, before.to_s
+  end
+
+  def test_set_metadata
+    before = make_node '<reapack name="pkg"/>'
+
+    pkg = ReaPack::Index::Package.new before
+    refute pkg.modified?, 'package is modified'
+
+    pkg.metadata.about = 'hello world'
+    assert pkg.modified?, 'package is not modified'
+
+    assert_match /<metadata>.+<description>/m, before.to_s
+  end
+
   def test_versions
     before = make_node <<-XML
-    <reapack name="1.0" type="script">
+    <reapack name="pkg" type="script">
       <version name="1.0" />
     </reapack>
     XML
@@ -47,7 +97,7 @@ class TestPackage < MiniTest::Test
 
   def test_get_or_create_version
     before = make_node <<-XML
-    <reapack name="1.0" type="script">
+    <reapack name="pkg" type="script">
       <version name="1.0" />
     </reapack>
     XML

data/test/test_scanner.rb

@@ -1,194 +1,167 @@
 require File.expand_path '../helper', __FILE__
 
 class TestScanner < MiniTest::Test
-  class TestMakeUrl < MiniTest::Test
-    def setup
-      @cat = MiniTest::Mock.new
+  include XMLHelper
 
-      @pkg = MiniTest::Mock.new
-      @pkg.expect :path, 'Hello/World.lua'
-      @pkg.expect :path, 'Hello/World.lua'
+  def setup
+    @mock = MiniTest::Mock.new
 
-      @ver = MiniTest::Mock.new
-      @ver.expect :name, '1.0'
+    @mh = MetaHeader.new String.new
+    @mh[:version] = '1.0'
 
-      @mh = MiniTest::Mock.new
-      @mh.expect :[], true, [:metapackage]
+    @doc = Nokogiri::XML <<-XML
+    <category name="Hello">
+      <reapack type="script" name="World.lua"/>
+    </category>
+    XML
 
-      @cdetector = MiniTest::Mock.new
-      @cdetector.expect :[], nil, ['Hello/World.lua']
+    @pkg = ReaPack::Index::Package.new @doc.css('reapack').first
 
-      @index = MiniTest::Mock.new
-      @index.expect :cdetector, @cdetector
+    @index = MiniTest::Mock.new
+    @index.expect :cdetector, ReaPack::Index::ConflictDetector.new
+    @index.expect :url_template, 'https://google.com/$path'
+    @index.expect :files, ['Hello/World.lua']
+    @index.expect :commit, 'master'
+    2.times { @index.expect :time, Time.at(42) }
 
-      @scanner = ReaPack::Index::Scanner.new @cat, @pkg, @mh, @index
-      @scanner.instance_variable_set :@ver, @ver
-    end
-
-    def teardown
-      [@cat, @pkg, @ver, @mh, @index, @cdetector].each {|mock| mock.verify }
-    end
-
-    def test_path
-      @index.expect :files, ['Category/script.lua']
-      @index.expect :url_template, '$path'
-      @index.expect :commit, 'C0FF33'
+    @scanner = ReaPack::Index::Scanner.new nil, @pkg, @mh, @index
+  end
 
-      assert_equal 'Category/script.lua', @scanner.make_url('Category/script.lua')
-    end
+  def teardown
+    @mock.verify
+  end
 
-    def test_commit
-      @index.expect :files, ['Hello/World.lua']
-      @index.expect :url_template, '$commit'
-      @index.expect :commit, 'C0FF33'
+  def test_author
+    @mh[:author] = 'cfillion'
+    @mock.expect :author=, nil, ['cfillion']
 
-      assert_equal 'C0FF33', @scanner.make_url('Hello/World.lua')
+    @pkg.version('1.0').stub :author=, -> (arg) { @mock.author= arg } do
+      @scanner.run
     end
+  end
 
-    def test_defaut_branch
-      @index.expect :commit, nil
+  def test_version_time
+    @mock.expect :time=, nil, [Time.at(42)]
 
-      assert_match 'master', @scanner.make_url('Category/script.lua', '$commit')
+    @pkg.version('1.0').stub :time=, -> (arg) { @mock.time= arg } do
+      @scanner.run
     end
+  end
 
-    def test_version
-      @index.expect :files, ['Category/script.lua']
-      @index.expect :url_template, '$version'
-      @index.expect :commit, 'C0FF33'
+  def test_edit_version_amend_off
+    ver = make_node '<version name="1.0"/>'
+    ver.parent = @pkg.node
 
-      assert_equal '1.0', @scanner.make_url('Category/script.lua')
+    @index.expect :amend, false
+    @pkg.version('1.0').stub :replace_sources, -> (*) { fail 'version was altered' } do
+      @scanner.run
     end
+  end
 
-    def test_package
-      @index.expect :files, ['Category/script.lua']
-      @index.expect :url_template, '$package'
-      @index.expect :commit, 'C0FF33'
+  def test_edit_version_amend_on
+    ver = make_node '<version name="1.0"/>'
+    ver.parent = @pkg.node
 
-      assert_equal 'Hello/World.lua', @scanner.make_url('Category/script.lua')
+    @index.expect :amend, true
+    @mock.expect :replace_sources, nil
+    @pkg.version('1.0').stub :replace_sources, -> (*) { @mock.replace_sources } do
+      @scanner.run
     end
+  end
 
-    def test_without_template
-      @index.expect :commit, nil
-      @scanner.make_url 'script.lua', 'ok if explicit template'
-
-      @index.expect :url_template, nil
-      error = assert_raises ReaPack::Index::Error do
-        @scanner.make_url 'script.lua'
-      end
+  def test_metapackage_on
+    @mh[:metapackage] = true
 
-      assert_match /url template/i, error.message
+    error = assert_raises ReaPack::Index::Error do
+      @scanner.run
     end
 
-    def test_unlisted
-      @index.expect :commit, nil
-      @index.expect :files, []
-      @index.expect :url_template, 'http://implicit/url/template'
+    assert_equal 'no files provided', error.message
+  end
 
-      @scanner.make_url 'unlisted.lua', 'ok with explicit url template'
+  def test_metapackage_off
+    @mh[:metapackage] = false
+    @pkg.type = ReaPack::Index::Scanner::META_TYPES.first
+    @scanner.run
+  end
 
-      error = assert_raises ReaPack::Index::Error do
-        @scanner.make_url 'unlisted.lua'
-      end
+  def test_description
+    @mh[:description] = 'From the New World'
+    @mock.expect :description=, nil, ['From the New World']
 
-      assert_equal "file not found 'unlisted.lua'", error.message
+    @pkg.stub :description=, -> (arg) { @mock.description= arg } do
+      @scanner.run
     end
+  end
 
-    def test_repeat
-      @index.expect :files, ['Category/script.lua']
-      @index.expect :url_template, '$path $path'
-      @index.expect :commit, 'C0FF33'
+  def test_description_alias_rescript_name
+    @mh[:reascript_name] = 'Right'
+    @mh[:description] = 'Wrong'
+    @mock.expect :description=, nil, ['Right']
 
-      assert_equal 'Category/script.lua Category/script.lua',
-        @scanner.make_url('Category/script.lua')
+    @pkg.stub :description=, -> (arg) { @mock.description= arg } do
+      @scanner.run
     end
   end
 
-  class TestValidation < MiniTest::Test
-    def setup
-      @pkg = MiniTest::Mock.new
-      @pkg.expect :type, :script
-      @pkg.expect :path, 'cat/test'
+  def test_description_alias_desc
+    @mh[:desc] = 'Right'
+    @mh[:description] = 'Wrong'
+    @mock.expect :description=, nil, ['Right']
 
-      @mh = MetaHeader.new String.new
-      @mh[:version] = '1.0'
-
-      @index = MiniTest::Mock.new
-      @index.expect :cdetector, ReaPack::Index::ConflictDetector.new
-
-      @scanner = ReaPack::Index::Scanner.new nil, @pkg, @mh, @index
+    @pkg.stub :description=, -> (arg) { @mock.description= arg } do
+      @scanner.run
     end
+  end
 
-    def test_validation
-      mh_mock = MiniTest::Mock.new
-      mh_mock.expect :validate, ['first', 'second'], [Hash]
-
-      @scanner.instance_variable_set :@mh, mh_mock
-
-      error = assert_raises(ReaPack::Index::Error) { @scanner.run }
+  def test_about
+    @mh[:about] = '# Hello World'
+    @mock.expect :about=, nil, ['# Hello World']
 
-      assert_equal "first\nsecond", error.message
-      mh_mock.verify
+    @pkg.metadata.stub :about=, -> (arg) { @mock.about= arg } do
+      @scanner.run
     end
+  end
 
-    def test_version
-      @mh.delete :version
-      error = assert_raises(ReaPack::Index::Error) { @scanner.run }
-      assert_equal "missing tag 'version'", error.message
-
-      @mh[:version] = 'no.numbers'
-      error = assert_raises(ReaPack::Index::Error) { @scanner.run }
-      assert_equal "invalid value for tag 'version'", error.message
-
-      @mh[:version] = 'v1.0'
-      error = assert_raises(ReaPack::Index::Error) { @scanner.run }
-      assert_equal "invalid value for tag 'version'", error.message
+  def test_website_links
+    @mh[:website] = [
+      'http://cfillion.tk',
+      'Label http://cfillion.tk',
+    ].join "\n"
 
-      @mh[:version] = true
-      error = assert_raises(ReaPack::Index::Error) { @scanner.run }
-      assert_equal "missing value for tag 'version'", error.message
+    @mock.expect :push_link, nil, [:website, 'http://cfillion.tk']
+    @mock.expect :push_link, nil, [:website, 'Label', 'http://cfillion.tk']
 
-      @mh[:version] = "hello\nworld"
-      error = assert_raises(ReaPack::Index::Error) { @scanner.run }
-      assert_equal "tag 'version' must be singleline", error.message
+    @pkg.metadata.stub :push_link, -> (*arg) { @mock.push_link *arg } do
+      @scanner.run
     end
+  end
 
-    def test_author
-      @mh[:author] = true
-      error = assert_raises(ReaPack::Index::Error) { @scanner.run }
-      assert_equal "missing value for tag 'author'", error.message
+  def test_screenshot_links
+    @mh[:screenshot] = [
+      'http://i.imgur.com/1.png',
+      'Label http://i.imgur.com/2.png',
+    ].join "\n"
 
-      @mh[:author] = "hello\nworld"
-      error = assert_raises(ReaPack::Index::Error) { @scanner.run }
-      assert_equal "tag 'author' must be singleline", error.message
-    end
+    @mock.expect :push_link, nil, [:screenshot, 'http://i.imgur.com/1.png']
+    @mock.expect :push_link, nil, [:screenshot, 'Label', 'http://i.imgur.com/2.png']
 
-    def test_changelog
-      @mh[:changelog] = true
-      error = assert_raises(ReaPack::Index::Error) { @scanner.run }
-      assert_equal "missing value for tag 'changelog'", error.message
+    @pkg.metadata.stub :push_link, -> (*arg) { @mock.push_link *arg } do
+      @scanner.run
     end
+  end
 
-    def test_provides
-      @mh[:provides] = true
-      error = assert_raises(ReaPack::Index::Error) { @scanner.run }
-      assert_equal "missing value for tag 'provides'", error.message
-
-      @mh[:provides] = '[hello] world'
-      error = assert_raises(ReaPack::Index::Error) { @scanner.run }
-      assert_equal "invalid value for tag 'provides': unknown option 'hello'",
-        error.message
-    end
+  def test_donation_links
+    @mh[:donation] = [
+      'https://www.paypal.me/cfillion',
+      'Label https://www.paypal.me/cfillion',
+    ].join "\n"
 
-    def test_index
-      @mh[:noindex] = 'value'
-      error = assert_raises(ReaPack::Index::Error) { @scanner.run }
-      assert_equal "tag 'noindex' cannot have a value", error.message
-    end
+    @mock.expect :push_link, nil, [:donation, 'https://www.paypal.me/cfillion']
+    @mock.expect :push_link, nil, [:donation, 'Label', 'https://www.paypal.me/cfillion']
 
-    def test_metapackage
-      @mh[:metapackage] = 'value'
-      error = assert_raises(ReaPack::Index::Error) { @scanner.run }
-      assert_equal "tag 'metapackage' cannot have a value", error.message
+    @pkg.metadata.stub :push_link, -> (*arg) { @mock.push_link *arg } do
+      @scanner.run
     end
   end
 end