real_data_tests 0.3.2 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 21f2ee14eda8fe0a048506c0ac7948c0f1c3cacb603ddb9c6490f1abef0e7fda
-  data.tar.gz: '0698d429e6feb3f2dfd358014ff71b7cca4415d2393cbab950f99776191ec43c'
+  metadata.gz: 89206c96e781984f28f3efd5c3e138c15693367fcad3bf5a80bd525a7fdff88d
+  data.tar.gz: 40af166854587b8fe9c7e446d0ac1240aa73912bc8ebf4e21a2cebe28530b6ab
 SHA512:
-  metadata.gz: 7839506386159938f4d5764bc0871876d7bb02ebac18ed522f23fc822e137757ea5a8a8dda7c36c4c43a91e48fa44cc0b8d69dfdca6fde402a12fe743c606fc9
-  data.tar.gz: bc74ab0ab3c19d1766714ebe35b25c310360a7b2d0154b675b223b46e0ee8610dd37ada15de1620867895fb922cba7edaf63a3d252e2d86dcaeb070bb9716b5b
+  metadata.gz: 97a33efa24925c0bd452be680119d55f03a4790f1b545aa1250a2388d26cb55482b09c310094eb3d07eb2f8c0c92eadfea2f2061a7b0611d1ff15df1367680eb
+  data.tar.gz: e4c69341c9a4a21b6d08649b393d5594d5c6e2066a8bbf981366e377a6f7b9f2bce6aac4394ccc86026853a821aa746630b2cc49a923aee5faa4da60bbf0d6c9

data/CHANGELOG.md

@@ -1,5 +1,21 @@
 ## [Unreleased]
 
+## [0.3.3] - 2025-01-14
+### Fixed
+- Improved circular dependency handling in PgDumpGenerator for self-referential associations
+  - Added robust checks for self-referential associations during topological sort
+  - Updated dependency graph building to properly exclude prevented circular dependencies
+  - Fixed model name handling in circular dependency error messages
+  - Improved error reporting for circular dependency detection
+- Enhanced PresetConfiguration circular dependency prevention
+  - Added more reliable tracking of prevented reciprocal associations using Sets
+  - Improved handling of both class and string model names in prevention checks
+  - Better support for multiple prevented dependencies per model
+- Updated record collection depth handling
+  - Fixed max depth enforcement for nested associations
+  - Added proper depth tracking for self-referential relationships
+  - Improved interaction between max depth and circular dependency prevention
+
 ## [0.3.2] - 2025-01-14
 ### Fixed
 - Enhanced association statistics tracking in RecordCollector

data/lib/real_data_tests/configuration.rb

@@ -87,6 +87,14 @@ module RealDataTests
       @prevented_reciprocals << key
     end
 
+    def max_self_ref_depth=(depth)
+      @max_self_ref_depth = depth
+    end
+
+    def get_max_self_ref_depth(model)
+      @max_self_ref_depth
+    end
+
     def has_circular_dependency?(klass, association_name)
       key = if klass.is_a?(String)
         "#{klass}:#{association_name}"

data/lib/real_data_tests/pg_dump_generator.rb

@@ -34,15 +34,19 @@ module RealDataTests
 
     def build_dependency_graph(models)
       models.each_with_object({}) do |model, deps|
-        # We only need to consider belongs_to associations since they represent
-        # the true foreign key dependencies that affect insert order
+        # Get direct dependencies from belongs_to associations
         direct_dependencies = model.reflect_on_all_associations(:belongs_to)
           .reject(&:polymorphic?) # Skip polymorphic associations
+          .reject do |assoc|
+            # Skip self-referential associations that are configured to prevent circular deps
+            assoc.klass == model &&
+            RealDataTests.configuration.current_preset.prevent_reciprocal?(model, assoc.name)
+          end
           .map(&:klass)
-          .select { |klass| models.include?(klass) } # Only include models we actually have records for
+          .select { |klass| models.include?(klass) }
           .uniq
 
-        # For HABTM associations, we need to ensure the join tables are handled correctly
+        # Handle HABTM associations
         habtm_dependencies = model.reflect_on_all_associations(:has_and_belongs_to_many)
           .map { |assoc| assoc.join_table_model }
           .compact
@@ -69,9 +73,12 @@ module RealDataTests
       return if visited.include?(model)
 
       if temporary.include?(model)
-        # Provide more context in the error message
-        cycle = detect_cycle(model, dependencies, temporary)
-        raise "Circular dependency detected: #{cycle.map(&:name).join(' -> ')}"
+        # Only raise if this isn't a prevented self-reference
+        unless RealDataTests.configuration.current_preset.prevent_reciprocal?(model, model.model_name.singular)
+          cycle = detect_cycle(model, dependencies, temporary)
+          raise "Circular dependency detected: #{cycle.map(&:name).join(' -> ')}"
+        end
+        return
       end
 
       temporary.add(model)

data/lib/real_data_tests/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RealDataTests
-  VERSION = "0.3.2"
+  VERSION = "0.3.3"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: real_data_tests
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.3.3
 platform: ruby
 authors:
 - Kevin Dias