readymade 0.3.7 → 0.3.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a99833ca151368c750c36d51cdd6be713210f846b1cdd78b2ba533b188fa3d63
-  data.tar.gz: f65962b9ddfebc091f7f799825e7db62e579ee8ad14c3f86afeae782f3f2692b
+  metadata.gz: 37150c92279da3c7ecb29441fccbf188572039fe69712cf99824121c8ebeb889
+  data.tar.gz: f94ab00a9af6b37097958c1a386932f8667e7e37ea55ec30530a2e92a423738d
 SHA512:
-  metadata.gz: aefb0039b18326b3c8b47b77a8259f8957adf897bfbce727d14e2c2498652539c49ef271d1ff7281fd911e7c43577f9f2eb5c3c65f5827a6dc43f1c6a2556c7e
-  data.tar.gz: 328f459c616399fab211b04db587ef586caf0a79a030850d14bf1b23b66e1a49944c881b656ebff0118b8bdf7c1be8d2aa98e5a7ef4a21bb15edd4dfe9b4d7f6
+  metadata.gz: b7b562dd8614ca64c8821d71c89ecff73c9556d8c8b5ea4ed95046ba8841354e193ae5e6d61ce05e673cdf8c8ef3946322165761862ca1aee7d8cdc44ecc6b99
+  data.tar.gz: 2608dd0e7def9ea166ec4c0edb391a748d02602e4c8a2e6fd3f0a536397fae5c0e286330fdd07901196f4316bdcf578630f14c5ff985e32896fee35a8f284cb1

data/CHANGELOG.md

@@ -1,6 +1,14 @@
 Changelog
 All notable changes to this project will be documented in this file.
 
+## [0.3.9] - 2024-01-04
+
+* Update `Readymade::Model::Filterable` to support and/or joins
+
+## [0.3.8] - 2023-10-06
+
+* Add `conisder_success` argument to Response
+
 ## [0.3.7] - 2023-08-08
 
 * Fix invalid behaviour of `call!` method

data/Gemfile.lock

@@ -1,19 +1,19 @@
 PATH
   remote: .
   specs:
-    readymade (0.3.7)
+    readymade (0.3.9)
       activejob
       activemodel
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activejob (7.0.6)
-      activesupport (= 7.0.6)
+    activejob (7.0.8)
+      activesupport (= 7.0.8)
       globalid (>= 0.3.6)
-    activemodel (7.0.6)
-      activesupport (= 7.0.6)
-    activesupport (7.0.6)
+    activemodel (7.0.8)
+      activesupport (= 7.0.8)
+    activesupport (7.0.8)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
@@ -21,11 +21,11 @@ GEM
     byebug (11.1.3)
     concurrent-ruby (1.2.2)
     diff-lcs (1.4.4)
-    globalid (1.1.0)
-      activesupport (>= 5.0)
+    globalid (1.2.1)
+      activesupport (>= 6.1)
     i18n (1.14.1)
       concurrent-ruby (~> 1.0)
-    minitest (5.18.1)
+    minitest (5.20.0)
     rake (13.0.6)
     rspec (3.10.0)
       rspec-core (~> 3.10.0)

data/README.md

@@ -169,6 +169,24 @@ end
 
 Orders::Actions::SendNotifications.call!(order: order) # raise error if response is fail
 ```
+
+### `.call` + `conisder_success: true`
+```ruby
+class Orders::Actions::SendNotifications < Readymade::Action
+  def call!
+    send_email
+    return response(:skip, consider_success: true) if skip_email?
+    send_push
+    send_slack
+
+    response(:success, record: record, any_other_data: data)
+  end
+  ...
+end
+
+Orders::Actions::SendNotifications.call!(order: order) # does not raise error if skip_email? returns true
+```
+
 ### `.call_async!` - runs in background and raise error unless response is success
 (action must return Readymade::Response.new(:success))
 
@@ -266,6 +284,7 @@ end
 
 ```ruby
 User.all.filter_collection({ by_status: 'active', by_role: 'manager' })
+User.all.filter_collection({ by_status: 'active', by_role: 'manager' }, chain_with: :or) # active OR manager
 ```
 
 ## Development

data/lib/readymade/action.rb

@@ -15,9 +15,9 @@ module Readymade
 
     def self.call!(*args, &block)
       new(*args, &block).call!.then do |res|
-        raise UnSuccessError unless res.try(:success?)
+        return res if res.try(:success?) || res.try(:consider_success?)
 
-        res
+        raise UnSuccessError
       end
     end
 

data/lib/readymade/model/filterable.rb

@@ -2,6 +2,8 @@ require 'active_support/concern'
 
 module Readymade
   module Model
+    # frozen_string_literal: true
+
     module Filterable
       extend ActiveSupport::Concern
 
@@ -20,13 +22,36 @@ module Readymade
           end
         end
 
-        def filter_collection(filtering_params)
+        def send_chain_with_or(methods, scope = self)
+          return scope if methods.blank?
+
+          conditions = []
+          if methods.respond_to?(:keys)
+            methods.each do |scope_name, argument|
+              conditions << send(scope_name, argument)
+            end
+          else
+            methods.each do |scope_name|
+              conditions << send(scope_name)
+            end
+          end
+
+          where(id: conditions.inject(:or).select(:id))
+        end
+
+        def filter_collection(filtering_params, chain_with: :and)
           filtering_params.permit! if filtering_params.respond_to?(:permit)
 
           regular_params = filtering_params.select { |_key, value| value.present? }.to_h
           custom_params = filtering_params.to_h.select { |_key, value| value.is_a?(String) && value.start_with?('without_') }.values
 
-          send_chain(regular_params, send_chain(custom_params)).distinct
+          if chain_with == :and
+            send_chain(regular_params, send_chain(custom_params)).all
+          elsif chain_with.to_sym == :or
+            send_chain_with_or(regular_params, send_chain_with_or(custom_params)).all
+          else
+            none
+          end
         end
       end
     end

data/lib/readymade/response.rb

@@ -20,6 +20,7 @@ module Readymade
       raise NonKeywordArgumentsError if args.present? && !args[0].is_a?(Hash)
 
       @args = @data = args[0]
+      @consider_success = @args.delete(:consider_success) if @args.present?
 
       define_singleton_method("#{status}?") do
         true
@@ -30,6 +31,10 @@ module Readymade
       args[:errors].presence || {}
     end
 
+    def consider_success?
+      @consider_success
+    end
+
     def method_missing(method_name, *args, &block)
       return false if method_name.to_s.end_with?('?')
 

data/lib/readymade/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Readymade
-  VERSION = '0.3.7'
+  VERSION = '0.3.9'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: readymade
 version: !ruby/object:Gem::Version
-  version: 0.3.7
+  version: 0.3.9
 platform: ruby
 authors:
 - OrestF
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-08-08 00:00:00.000000000 Z
+date: 2024-01-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: byebug