readymade 0.3.6 → 0.3.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 90f0eb0091bea1e29078e83958d77aedfa989c39af4d21213bec81347f4d73df
-  data.tar.gz: b96a07f92350bee6be041456b979dc781ad1324ad8ef38e95547f9af34a250a8
+  metadata.gz: d23f98bdcf35999cfdad659cf75fb3e5f103da34508ec1b05cd18eb45465751e
+  data.tar.gz: 15d45fadf8ad68e6603959d6c6ae51b43407733c7458aa4ca20c94ad76bf6fd3
 SHA512:
-  metadata.gz: 82b0f5dbc204ea624d84c48edc4b6619216c300d447f1cae69a1828b88d4533b2048960757f2e354f5adf15400b993b2efff92e0e44f4e2c6e8e38a50a7a8221
-  data.tar.gz: 21b076ad062a65ed5afde67521ee433f99228cedf0d0b229079270e6f3793b7e4097a48ba02c9c81e7f5f84eedef8b0fc565f1ade7dbdfd518c91cbfb346227c
+  metadata.gz: f5ec8fa06c4198d1281decc771ea8a9ed721a4ca75f17f983b82fc4dd000ad67a3c3b7116e57ae0324edc266055da18a394f36431c7ca2ed68a4a3fb29f31538
+  data.tar.gz: 5b14c12db646986bb0746e783ca04f075739f84b23f3ef2db12595c993108586350a11aff2ce3bc3257b3861c8625ac487d91a84a8a6baf0608f2175b55595c8

data/CHANGELOG.md

@@ -1,6 +1,14 @@
 Changelog
 All notable changes to this project will be documented in this file.
 
+## [0.3.8] - 2023-10-06
+
+* Add `conisder_success` argument to Response
+
+## [0.3.7] - 2023-08-08
+
+* Fix invalid behaviour of `call!` method
+
 ## [0.3.6] - 2023-07-21
 
 * Add `queue_as: :name` argument to `Readymade::BackgroundJob` to select queue name when using `.call_async(args.merge(queue_as: :my_queue))`

data/Gemfile.lock

@@ -1,19 +1,19 @@
 PATH
   remote: .
   specs:
-    readymade (0.3.6)
+    readymade (0.3.8)
       activejob
       activemodel
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activejob (7.0.5)
-      activesupport (= 7.0.5)
+    activejob (7.0.7.2)
+      activesupport (= 7.0.7.2)
       globalid (>= 0.3.6)
-    activemodel (7.0.5)
-      activesupport (= 7.0.5)
-    activesupport (7.0.5)
+    activemodel (7.0.7.2)
+      activesupport (= 7.0.7.2)
+    activesupport (7.0.7.2)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
@@ -21,11 +21,11 @@ GEM
     byebug (11.1.3)
     concurrent-ruby (1.2.2)
     diff-lcs (1.4.4)
-    globalid (1.1.0)
-      activesupport (>= 5.0)
+    globalid (1.2.1)
+      activesupport (>= 6.1)
     i18n (1.14.1)
       concurrent-ruby (~> 1.0)
-    minitest (5.18.1)
+    minitest (5.19.0)
     rake (13.0.6)
     rspec (3.10.0)
       rspec-core (~> 3.10.0)

data/README.md

@@ -169,6 +169,24 @@ end
 
 Orders::Actions::SendNotifications.call!(order: order) # raise error if response is fail
 ```
+
+### `.call` + `conisder_success: true`
+```ruby
+class Orders::Actions::SendNotifications < Readymade::Action
+  def call!
+    send_email
+    return response(:skip, consider_success: true) if skip_email?
+    send_push
+    send_slack
+
+    response(:success, record: record, any_other_data: data)
+  end
+  ...
+end
+
+Orders::Actions::SendNotifications.call!(order: order) # does not raise error if skip_email? returns true
+```
+
 ### `.call_async!` - runs in background and raise error unless response is success
 (action must return Readymade::Response.new(:success))
 

data/lib/readymade/action.rb

@@ -15,9 +15,9 @@ module Readymade
 
     def self.call!(*args, &block)
       new(*args, &block).call!.then do |res|
-        raise UnSuccessError unless res.try(:success?)
+        return res if res.try(:success?) || res.try(:consider_success?)
 
-        res
+        raise UnSuccessError
       end
     end
 
@@ -42,7 +42,9 @@ module Readymade
 
     def call; end
 
-    def call!; end
+    def call!
+      call
+    end
 
     def call_async
       ::Readymade::BackgroundJob.perform_later(class_name: self.class.name, **args)

data/lib/readymade/response.rb

@@ -20,6 +20,7 @@ module Readymade
       raise NonKeywordArgumentsError if args.present? && !args[0].is_a?(Hash)
 
       @args = @data = args[0]
+      @consider_success = @args.delete(:consider_success) if @args.present?
 
       define_singleton_method("#{status}?") do
         true
@@ -30,6 +31,10 @@ module Readymade
       args[:errors].presence || {}
     end
 
+    def consider_success?
+      @consider_success
+    end
+
     def method_missing(method_name, *args, &block)
       return false if method_name.to_s.end_with?('?')
 

data/lib/readymade/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Readymade
-  VERSION = '0.3.6'
+  VERSION = '0.3.8'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: readymade
 version: !ruby/object:Gem::Version
-  version: 0.3.6
+  version: 0.3.8
 platform: ruby
 authors:
 - OrestF
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-07-21 00:00:00.000000000 Z
+date: 2023-10-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: byebug