readymade 0.1.1 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6238e89120aa1988137e3d64457133724e61843dc214efb5e726703498f24c13
-  data.tar.gz: 9eafa5715b2835be68c39f5b0880d0c43f9f9c58a0bce4ed14b91dbb132b34b8
+  metadata.gz: aefd7011aa28dd0d0e9d5c1d219bc27d2ccbce37d3f28ffc6139a488847c9d8d
+  data.tar.gz: 2d5698abc2a38900d633f52315bfd5b05014eb77a6db7958d62146f3cda6be7c
 SHA512:
-  metadata.gz: 904961a82ae288d9f086e443b471d14b2f48fb2ed0c854e858129eb127f5c95b805f808090229320740daf859cfff41edd97e5e153ed41e9e889a86d857db968
-  data.tar.gz: 4f33390f55c6650a366349c6126350049671382171d77d765c8f72c7acae4764501939cd429ba219fb882455560517d10992613393920981ffdea7b17e492599
+  metadata.gz: d35e1e55adebd637434ebcae14bdfb99203f6cf4807fa940f019edf87a2c4f14bf36bc7d45dd8af1385740ca06e4445bcaa6ad8b3b18cc4f3e4eef3897d63624
+  data.tar.gz: f09669c314759e0b72e9754e0a842f87fcf8a280a94c7994801f9851e739a40b0dc7144c69628bc461b4588a9e13284c29039a3682c7e842d50839c5ca5a2ac6

data/CHANGELOG.md

@@ -0,0 +1,24 @@
+Changelog
+All notable changes to this project will be documented in this file.
+
+## [0.1.5] - 2021-12-07
+
+### Improvements
+
+* Better errors with Rails 6.1.
+
+## [0.1.4] - 2021-11-22
+
+### Features
+
+* Add `Readymade::InstantForm`
+
+### Improvements
+
+* Call `build_form` inside `form_valid?` if `@form` is not defined
+
+## [0.1.3] - 2021-11-20
+
+### Improvements
+
+* Fix error when required param for instant form is not defined

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    readymade (0.1.1)
+    readymade (0.1.4)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -1,8 +1,6 @@
-# Lead
+# Readymade
 
-Welcome to your new gem! In this directory, you'll find the files you need to be able to package up your Ruby library into a gem. Put your Ruby code in the file `lib/readymade`. To experiment with that code, run `bin/console` for an interactive prompt.
-
-TODO: Delete this and the text above, and describe your gem
+This gems contains basic components to follow [ABDI architecture](https://github.com/OrestF/OrestF/blob/master/abdi/ABDI_architecture.md)
 
 ## Installation
 
@@ -22,7 +20,37 @@ Or install it yourself as:
 
 ## Usage
 
-TODO: Write usage instructions here
+Inherit your components from:
+* `Readymade::Response`
+* `Readymade::Form`
+* `Readymade::InstantForm`
+* `Readymade::Action`
+* `Readymade::Operation`
+
+### Readymade::Response
+
+```TODO: add```
+
+### Readymade::Form
+
+```TODO: add```
+
+### Readymade::InstantForm
+
+Permit params and validates presence inline
+
+```ruby
+Readymade::InstantForm.new(my_params, permitted: %i[name phone], required: %i[email]) # permits: name, phone, email; validates on presence: email
+```
+
+### Readymade::Action
+
+```TODO: add```
+
+### Readymade::Operation
+
+```TODO: add```
+
 
 ## Development
 

data/lib/readymade/action.rb

@@ -20,8 +20,6 @@ module Readymade
       @args.each do |name, value|
         instance_variable_set("@#{name}", value)
       end
-
-      # yield if block_given?
     end
 
     def call; end

data/lib/readymade/form.rb

@@ -26,7 +26,7 @@ module Readymade
       @params&.slice!(*permitted_attributes) # if permitted_attributes.present?
 
       # dynamically creates attr accessors
-      @params&.keys&.each do |key|
+      @permitted_attributes&.each do |key|
         singleton_class.class_eval do
           attr_accessor key
         end
@@ -84,11 +84,15 @@ module Readymade
     def sync_errors(from: self, to: record)
       return if [from, to].any?(&:blank?)
 
-      errors = from.errors.instance_variable_get('@messages')
-      errors.to_h.merge!(to.errors.instance_variable_get('@messages'))
+      if Rails.version.to_f > 6.0
+        to.errors.merge!(from.errors)
+      else
+        errors = from.errors.instance_variable_get('@messages').to_h
+        errors.merge!(to.errors.instance_variable_get('@messages').to_h)
 
-      to.errors.instance_variable_set('@messages', errors)
-      to.errors.messages.transform_values!(&:uniq) # Does not work with rails 6.1
+        to.errors.instance_variable_set('@messages', errors)
+        to.errors.messages.transform_values!(&:uniq) # Does not work with rails 6.1
+      end
     rescue FrozenError => _e
     end
 

data/lib/readymade/instant_form.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+module Readymade
+  class InstantForm < Form
+
+  end
+end

data/lib/readymade/operation.rb

@@ -14,6 +14,8 @@ module Readymade
     end
 
     def form_valid?
+      build_form if @form.nil? && defined?(:build_form)
+
       form.validate
     end
 
@@ -24,7 +26,7 @@ module Readymade
     def record_valid?
       return true if record.errors.none? && record.valid?
 
-      sync_errors_to_form && false
+      false
     end
 
     def save_record
@@ -41,6 +43,7 @@ module Readymade
 
     def validation_fail(status = :validation_fail, args = {})
       sync_errors_to_form
+
       response(status, args.merge!(record: record,
                                    record_params: record_params,
                                    form: form,

data/lib/readymade/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Readymade
-  VERSION = '0.1.1'
+  VERSION = '0.1.5'
 end

data/lib/readymade.rb

@@ -2,6 +2,7 @@
 
 require 'readymade/action'
 require 'readymade/form'
+require 'readymade/instant_form'
 require 'readymade/operation'
 require 'readymade/response'
 require 'readymade/version'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: readymade
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.5
 platform: ruby
 authors:
 - OrestF
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-11-03 00:00:00.000000000 Z
+date: 2021-12-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: byebug
@@ -62,6 +62,7 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".travis.yml"
+- CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - Gemfile
 - Gemfile.lock
@@ -73,6 +74,7 @@ files:
 - lib/readymade.rb
 - lib/readymade/action.rb
 - lib/readymade/form.rb
+- lib/readymade/instant_form.rb
 - lib/readymade/operation.rb
 - lib/readymade/response.rb
 - lib/readymade/version.rb
@@ -99,7 +101,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
+rubygems_version: 3.1.4
 signing_key:
 specification_version: 4
 summary: Set of base classes for ABDI architecture