readthis 0.6.0 → 0.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 55fdafde7fa30d64c803d3952bf663d08c8c3f7a
-  data.tar.gz: 4f69451b0992644c1bf160bdd4d2a1b68bf3e495
+  metadata.gz: 526a587fdb24dce81997fc27843cea6e4f3ae5f0
+  data.tar.gz: 545038b4b9ccd67e896a67c2bae81d8644fed8dc
 SHA512:
-  metadata.gz: 3602ac1b8a9296aef0c802b3cbd60b9689b496fe0efa9086024e4cbd69afa91dd59f57c1f0882ad4be933ddb678bd4039642dc679f55c65547366426d09f0cba
-  data.tar.gz: 121272db5ae46a67209ef7644bd2a352b197373222f608b5d53d981369f37fea410fd9d5e4a20e313432ac1dda12b95d7323cb606f6db44d169caed8405dc794
+  metadata.gz: 2245689f28e842a9271c3a2c5f68c5ad680b8aebc308ab6a4ac41d292d70a01092357a83aba0033b40bd2038997f5f364b97cec0734e8c8134283387fb45db78
+  data.tar.gz: e8ecd9e34667d681ea220fe60715a5238f8bf65f58faa55cbb5a4c2baa602fe717f68c65c325d6d81915038e36300418bd1230e95501b2b7933f090cf7874a13

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## v0.6.1 2015-04-28
+
+- Changed: Expiration values are always cast to an integer before use in write
+  operations. This prevents subtle ActiveSupport bugs where the value would be
+  ignored by `setex`.
+
 ## v0.6.0 2015-03-09
 
 - Fixed: Safely handle calling `read_multi` without any keys. [Michael Rykov]

data/README.md

@@ -35,7 +35,7 @@ rails environment config:
 
 ```ruby
 config.cache_store = :readthis_store, ENV.fetch('REDIS_URL'), {
-  expires_in: 2.weeks,
+  expires_in: 2.weeks.to_i,
   namespace: 'cache'
 }
 ```
@@ -45,7 +45,7 @@ Otherwise you can use it anywhere, without any reliance on ActiveSupport:
 ```ruby
 require 'readthis'
 
-cache = Readthis::Cache.new(ENV.fetch('REDIS_URL'), expires_in: 2.weeks)
+cache = Readthis::Cache.new(ENV.fetch('REDIS_URL'), expires_in: 2.weeks.to_i)
 ```
 
 You'll want to use a specific database for caching, just in case you need to
@@ -56,6 +56,11 @@ redis database, which defaults to 0. For example, using database 2:
 REDIS_URL=redis://localhost:6379/2
 ```
 
+Be sure to use an integer value when setting expiration time. The default
+representation of `ActiveSupport::Duration` values won't work when setting
+expiration time, which will cause all keys to have `-1` as the TTL. Expiration
+values are always cast as an integer on write.
+
 [store]: http://api.rubyonrails.org/classes/ActiveSupport/Cache/Store.html
 
 ### Compression

data/lib/readthis/cache.rb

@@ -42,7 +42,7 @@ module Readthis
     #
     def initialize(url, options = {})
       @expires_in = options.fetch(:expires_in, nil)
-      @namespace  = options.fetch(:namespace,  nil)
+      @namespace  = options.fetch(:namespace, nil)
 
       @entity = Readthis::Entity.new(
         marshal:   options.fetch(:marshal, Marshal),
@@ -323,7 +323,7 @@ module Readthis
       namespaced = namespaced_key(key, options)
 
       if expiration = options[:expires_in]
-        store.setex(namespaced, expiration, entity.dump(value))
+        store.setex(namespaced, expiration.to_i, entity.dump(value))
       else
         store.set(namespaced, entity.dump(value))
       end

data/lib/readthis/version.rb

@@ -1,3 +1,3 @@
 module Readthis
-  VERSION = '0.6.0'
+  VERSION = '0.6.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: readthis
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.6.1
 platform: ruby
 authors:
 - Parker Selbert
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-09 00:00:00.000000000 Z
+date: 2015-04-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis