readthis 0.5.2 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f71b3b7fac83a8203aa382cb87a4684240d427df
-  data.tar.gz: 8e87900ed9f5fb0199d20fb674ef7b8c988886b6
+  metadata.gz: 55fdafde7fa30d64c803d3952bf663d08c8c3f7a
+  data.tar.gz: 4f69451b0992644c1bf160bdd4d2a1b68bf3e495
 SHA512:
-  metadata.gz: 47a9479f67d9550b32798f8122209c569281e16d1d85402cf47af4ae7676de0fc65e6d6f5ffa87c99cc18606774f9d30a4ced4f8867ede0bdf8bb38872fbc50e
-  data.tar.gz: 2fe39b8a2f99bc1b4a55865cd114f49280311593ac157511874934f198f104b70ff04f3f4cdd90c1fd95794dd1b1d83965014db0afe69c60523fe7052e74549a
+  metadata.gz: 3602ac1b8a9296aef0c802b3cbd60b9689b496fe0efa9086024e4cbd69afa91dd59f57c1f0882ad4be933ddb678bd4039642dc679f55c65547366426d09f0cba
+  data.tar.gz: 121272db5ae46a67209ef7644bd2a352b197373222f608b5d53d981369f37fea410fd9d5e4a20e313432ac1dda12b95d7323cb606f6db44d169caed8405dc794

data/CHANGELOG.md

@@ -1,3 +1,12 @@
+## v0.6.0 2015-03-09
+
+- Fixed: Safely handle calling `read_multi` without any keys. [Michael Rykov]
+- Fixed: Pointed `redis-activesupport` at master. Only effected development and
+  testing.
+- Added: A `write_multi` method is no available to bulk set keys and values. It
+  is used by `fetch_multi` internally to ensure that there are at most two Redis
+  calls.
+
 ## v0.5.2 2015-01-09
 
 - Fixed: Remove the `pipeline` around `fetch_multi` writing. This will slow down

data/Gemfile

@@ -8,5 +8,5 @@ group :benchmarking do
   gem 'benchmark-ips'
   gem 'dalli'
   gem 'oj'
-  gem 'redis-activesupport', github: 'sorentwo/redis-activesupport'
+  gem 'redis-activesupport'
 end

data/README.md

@@ -80,16 +80,17 @@ Readthis uses Ruby's `Marshal` module for dumping and loading all values by
 default. This isn't always the fastest option, depending on your use case it may
 be desirable to use a faster but less flexible marshaller.
 
-Use Oj for JSON marshalling, extremely fast, limited types:
+Use Oj for JSON marshalling, extremely fast, but supports limited types:
 
 ```ruby
-Readthis::Cache.new(marshal: Oj)
+Readthis::Cache.new(url, marshal: Oj)
 ```
 
-If you don't mind everything being a string then use the Passthrough marshal:
+If you don't mind everything handles as a string then use the pass-through
+marshaller:
 
 ```ruby
-Readthis::Cache.new(marshal: Readthis::Passthrough)
+Readthis::Cache.new(url, marshal: Readthis::Passthrough)
 ```
 
 ## Differences

data/lib/readthis/cache.rb

@@ -216,6 +216,8 @@ module Readthis
       options = merged_options(extract_options!(keys))
       mapping = keys.map { |key| namespaced_key(key, options) }
 
+      return {} if keys.empty?
+
       invoke(:read_multi, keys) do |store|
         values = store.mget(mapping).map { |value| entity.load(value) }
 
@@ -223,6 +225,31 @@ module Readthis
       end
     end
 
+    # Write multiple key value pairs simultaneously. This is an atomic
+    # operation that will always succeed and will overwrite existing
+    # values.
+    #
+    # This is a non-standard, but useful, cache method.
+    #
+    # @param [Hash] Key value hash to write
+    # @param [Hash] Optional overrides
+    #
+    # @example
+    #
+    #   cache.write_multi('a', 1, 'b', 2) # => true
+    #
+    def write_multi(hash, options = {})
+      options = merged_options(options)
+      values  = hash.each_with_object([]) do |(key, value), memo|
+        memo << namespaced_key(key, options)
+        memo << entity.dump(value)
+      end
+
+      invoke(:write_multi, values) do |store|
+        store.mset(values)
+      end
+    end
+
     # Fetches multiple keys from the cache using a single call to the server
     # and filling in any cache misses. All read and write operations are
     # executed atomically.
@@ -243,20 +270,23 @@ module Readthis
     #   end
     #
     def fetch_multi(*keys)
-      results = read_multi(*keys)
-      options = merged_options(extract_options!(keys))
+      results   = read_multi(*keys)
+      extracted = extract_options!(keys)
+      missing   = {}
 
       invoke(:fetch_multi, keys) do |store|
         results.each do |key, value|
           if value.nil?
             value = yield(key)
-            write_entity(key, value, store, options)
+            missing[key] = value
             results[key] = value
           end
         end
-
-        results
       end
+
+      write_multi(missing, extracted) if missing.any?
+
+      results
     end
 
     # Returns `true` if the cache contains an entry for the given key.

data/lib/readthis/version.rb

@@ -1,3 +1,3 @@
 module Readthis
-  VERSION = '0.5.2'
+  VERSION = '0.6.0'
 end

data/spec/readthis/cache_spec.rb

@@ -144,6 +144,27 @@ RSpec.describe Readthis::Cache do
         'e' => 2,
       )
     end
+
+    it 'returns {} with no keys' do
+      expect(cache.read_multi(namespace: 'cache')).to eq({})
+    end
+  end
+
+  describe '#write_multi' do
+    it 'writes multiple key value pairs simultaneously' do
+      response = cache.write_multi('a' => 1, 'b' => 2)
+
+      expect(response).to be_truthy
+      expect(cache.read('a')).to eq(1)
+      expect(cache.read('b')).to eq(2)
+    end
+
+    it 'respects passed options' do
+      cache.write_multi({ 'a' => 1, 'b' => 2 }, namespace: 'multi')
+
+      expect(cache.read('a')).to be_nil
+      expect(cache.read('a', namespace: 'multi')).to eq(1)
+    end
   end
 
   describe '#fetch_multi' do
@@ -175,6 +196,11 @@ RSpec.describe Readthis::Cache do
       expect(cache.read('b')).to be_nil
       expect(cache.read('b', namespace: 'alph')).not_to be_nil
     end
+
+    it 'return empty results without keys' do
+      results = cache.fetch_multi(namespace: 'alph') { |key| key }
+      expect(results).to eq({})
+    end
   end
 
   describe '#exist?' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: readthis
 version: !ruby/object:Gem::Version
-  version: 0.5.2
+  version: 0.6.0
 platform: ruby
 authors:
 - Parker Selbert
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-09 00:00:00.000000000 Z
+date: 2015-03-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis
@@ -151,7 +151,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Pooled active support compliant caching with redis