readthis 0.5.1 → 0.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 39c546b2720bf3e983c15c8fe9d7a60fea06cf75
-  data.tar.gz: 0a41d522ce9f5a096bf967a344d3e71ab1c01b56
+  metadata.gz: f71b3b7fac83a8203aa382cb87a4684240d427df
+  data.tar.gz: 8e87900ed9f5fb0199d20fb674ef7b8c988886b6
 SHA512:
-  metadata.gz: 669ad6115ac86b13bb8ff8108a839d6c9890fbf4ca456ee8bd5f06dfe53578532559a8507a9cdd8a7ed7458341def6acee7e7e051b479fef2828c3312b0f32b8
-  data.tar.gz: 15ebfbe02678355846db403aa48b800212aeb5115c05b3b14107ba603db2e74445403ad24988b2161eaff7c5d8e0662b8c7fa1bab2a0927f290ccbf943fa5648
+  metadata.gz: 47a9479f67d9550b32798f8122209c569281e16d1d85402cf47af4ae7676de0fc65e6d6f5ffa87c99cc18606774f9d30a4ced4f8867ede0bdf8bb38872fbc50e
+  data.tar.gz: 2fe39b8a2f99bc1b4a55865cd114f49280311593ac157511874934f198f104b70ff04f3f4cdd90c1fd95794dd1b1d83965014db0afe69c60523fe7052e74549a

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## v0.5.2 2015-01-09
+
+- Fixed: Remove the `pipeline` around `fetch_multi` writing. This will slow down
+  `fetch_multi` in cache miss situations for now. It prevents a difficult to
+  track down exception in multi-threaded situations.
+
 ## v0.5.1 2014-12-30
 
 - Fixed: The `clear` method now accepts an argument for compatibility with other

data/lib/readthis/cache.rb

@@ -113,6 +113,38 @@ module Readthis
       end
     end
 
+    # Fetches data from the cache, using the given key. If there is data in the
+    # cache with the given key, then that data is returned.
+    #
+    # If there is no such data in the cache (a cache miss), then `nil` will be
+    # returned. However, if a block has been passed, that block will be passed
+    # the key and executed in the event of a cache miss. The return value of
+    # the block will be written to the cache under the given cache key, and
+    # that return value will be returned.
+    #
+    # @param [String] Key for lookup
+    # @param [Block] Optional block for generating the value when missing
+    # @param options [Hash] Optional overrides
+    # @option options [Boolean] :force Force a cache miss
+    #
+    # @example Typical
+    #
+    #   cache.write('today', 'Monday')
+    #   cache.fetch('today') # => "Monday"
+    #   cache.fetch('city')  # => nil
+    #
+    # @example With a block
+    #
+    #   cache.fetch('city') do
+    #     'Duckburgh'
+    #   end
+    #   cache.fetch('city')   # => "Duckburgh"
+    #
+    # @example Cache Miss
+    #
+    #   cache.write('today', 'Monday')
+    #   cache.fetch('today', force: true) # => nil
+    #
     def fetch(key, options = {})
       value = read(key, options) unless options[:force]
 
@@ -166,6 +198,20 @@ module Readthis
       end
     end
 
+    # Read multiple values at once from the cache. Options can be passed in the
+    # last argument.
+    #
+    # @overload read_multi(keys)
+    #   Return all values for the given keys.
+    #   @param [String] One or more keys to fetch
+    #
+    # @return [Hash] A hash mapping keys to the values found.
+    #
+    # @example
+    #
+    #   cache.write('a', 1)
+    #   cache.read_multi('a', 'b') # => { 'a' => 1, 'b' => nil }
+    #
     def read_multi(*keys)
       options = merged_options(extract_options!(keys))
       mapping = keys.map { |key| namespaced_key(key, options) }
@@ -182,7 +228,7 @@ module Readthis
     # executed atomically.
     #
     # @overload fetch_multi(keys)
-    #   Return all values fro the given keys, applying the block to the key
+    #   Return all values for the given keys, applying the block to the key
     #   when a value is missing.
     #   @param [String] One or more keys to fetch
     #
@@ -195,18 +241,17 @@ module Readthis
     #   cache.fetch_multi('a', 'b', expires_in: 60) do |key|
     #     key * 2
     #   end
+    #
     def fetch_multi(*keys)
       results = read_multi(*keys)
       options = merged_options(extract_options!(keys))
 
       invoke(:fetch_multi, keys) do |store|
-        store.pipelined do
-          results.each do |key, value|
-            if value.nil?
-              value = yield(key)
-              write_entity(key, value, store, options)
-              results[key] = value
-            end
+        results.each do |key, value|
+          if value.nil?
+            value = yield(key)
+            write_entity(key, value, store, options)
+            results[key] = value
           end
         end
 

data/lib/readthis/version.rb

@@ -1,3 +1,3 @@
 module Readthis
-  VERSION = '0.5.1'
+  VERSION = '0.5.2'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: readthis
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.5.2
 platform: ruby
 authors:
 - Parker Selbert
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-31 00:00:00.000000000 Z
+date: 2015-01-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis