readable_password_generator 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3a2e7085db65b76b910ff634abf7f2b6b8f2fb970a32f5f1f38584eac46e63bb
-  data.tar.gz: d7113c876ca76e3813f960f30e7ceee306b3e8e2f6d418c57612e76f16a9f904
+  metadata.gz: db4418d1296eae022c92822a1defde63cf838941a3b2c32604e0504b0aef00aa
+  data.tar.gz: 39aab9b7a2e3f2bfd13fe887de01386e17cc8e8e87f659de99b10222cedcd24b
 SHA512:
-  metadata.gz: 50e5d39e65d6372cde0daf4e34d1a2dc1cf893ad4ba883c5343e96c1d95a0f25390afbecfac5e7a5d07074ad1b327666afe34855833f2ca462f659a193d6f0e9
-  data.tar.gz: 428a23df865243504e135a02d33544905a7b08452e8c522aadf3c449e7f0e1fde990d2d32db9749c7ae827c5f7cd68e4437ccd2bb48830cd6cf119e930d60db7
+  metadata.gz: 3ec54ee71b155699db8aef82ceaaaa59cc4f576d76f1333725ad07af50bc04f3a365d74168df32226b7aece5a00721502fb4c17aabf8cb997b1292267f577b5a
+  data.tar.gz: a260c9167ecce3f566ca9566357d1a37941b9b88a0859d98bdbdf365d909e1b04fd3a70933e6ee8b8e93fc34f4ca29bfcafed896b1a4e47251e9032d419819f7

data/lib/readable_password_generator.rb

@@ -1,72 +1,51 @@
 class Password
 
-  #minimum default length is set to 10 by security concerns of a readable password
-  DEFAULT_PW_LENGTH = [10,11,12,13,14,15,16,17,18]
-
-  attr_reader :pw_length
-
-  def initialize(a_pw_length = DEFAULT_PW_LENGTH.sample)
-    @pw_length = check_length_value(a_pw_length) #checking on password length value
-    @vowel_pos = 0 # by default start password with a vowel
-  end
+  VOWELS = %w(a e i o u y)
+  CONSONANTS = %w(b c d f g h j k l m n p r s t v w x z)
+  DOUBLE_CONSONANTS = %w(ch cr fr nd ng nk nt ph pr rd sh sl sp st th tr)
+  DEFAULT_LENGTH = 8
 
-  #generate password of a required length
-  def gener_passw
-    #set position for a vowel: either to start a password with it first or not:
-    # 0 - start password with a vowel
-    # 1 - start password with a consonat(s)
-    @vowel_pos = [1, 2].sample
-    size, result = @pw_length, ""
-    count = 0
+  def generate(length = DEFAULT_LENGTH)
+    length = validate_length(length)
+    vowel_position = rand(0...1)
+    size, password = length, ""
+    char_set = 0
     size.times do |char|
-      count = 0 if count==2
-      count+=1
-      result << take_char(count)
+      password << pick_letter(char_set, vowel_position)
+      char_set+=1
+      char_set = 0 if char_set==2
     end
-    return result = result[0...size]
-  end
-
-  def set_length(a_pw_length)
-    @pw_length = check_length_value(a_pw_length)
-    return nil
+    password = password[0...size]
   end
 
   private
 
-  #sets of character used in generating
-  VOWELS = %w(a e i o u y)
-  CONSONANTS = %w(b c d f g h j k l m n p r s t v w x z)
-  #to diversify the end result
-  DOUBLE_CONSONANTS = %w(ch cr fr nd ng nk nt ph pr rd sh sl sp st th tr)
-
-  #take a sample char from a set of letters
-  def take_char(set_type)
-    if set_type == @vowel_pos
-      return VOWELS.sample
-    else
-      #prioritize randomness to choosing CONSONANTS over DOUBLE_CONSONANTS (3:1)
-      if [1,2,3,4].sample == 4
-        return CONSONANTS.sample
-      else
-        return DOUBLE_CONSONANTS.sample
+  def validate_length(length)
+    if length.is_a?(NilClass)
+      return DEFAULT_LENGTH
+    elsif length.is_a?(Array)
+      length = length.sample
+    elsif length.is_a?(Range)
+      length = rand(length)
+    if length.is_a?(Integer)
+      if (length < 1) || (length > 100)
+        raise Exception.new("Length cannot be #{length}, length must be in range of 1-100!")
       end
+    else
+      raise Exception.new("Length must be either an Integer or an Array or a Range value!\n#{length.class} data type is given.")
     end
+    length
   end
 
-  #checking length value - does it meet specified criteria:
-  # - must consist of numeric value or numeric range
-  def check_length_value(a_pw_length)
-    if a_pw_length.is_a?(NilClass)
-      a_pw_length = DEFAULT_PW_LENGTH.sample
-    elsif a_pw_length.is_a?(Array)
-      a_pw_length = a_pw_length.sample
-    elsif a_pw_length.is_a?(Integer)
-      if (a_pw_length < 1) || (a_pw_length > 100)
-        raise ArgumentError, "Length cannot be #{a_pw_length}, length must be in range of 1-100!"
-      end
+  def pick_letter(char_set, vowel_position)
+    if char_set == vowel_position
+      VOWELS.sample
     else
-      raise ArgumentError, "Length must be either an Integer or a Range value!\n#{a_pw_length.class} data type is given. "
+      if rand(1...4) == 4
+        CONSONANTS.sample
+      else
+        DOUBLE_CONSONANTS.sample
+      end
     end
-    return a_pw_length
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: readable_password_generator
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Vitaly Platonov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-04 00:00:00.000000000 Z
+date: 2018-10-10 00:00:00.000000000 Z
 dependencies: []
 description: 
 email: viitaly.platonov@gmail.com
@@ -40,5 +40,5 @@ rubyforge_project:
 rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
-summary: Home for the project is
+summary: Generates readable passwords!
 test_files: []