reactor 0.8.1 → 0.8.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c458036301b887cea2e6e656cd94ed497750ebed
-  data.tar.gz: 706f502c1bbbac9172374b7b065ddb627f3de656
+  metadata.gz: 95dc37409d0b41598fd79e08c761e3024bffd663
+  data.tar.gz: dc006fba8540a1a2ee3d18b2a0280c83fac78364
 SHA512:
-  metadata.gz: 1b5ebaf7f01782274bbd324789f138e6fc82af0de759d624d63e6c50f553783ff4be37b774d365086984e64ef11367777d4f98f108533a6b1ebc3a6532d64c65
-  data.tar.gz: e0f664ec820fcaa59c7a181bceffdb3b049799f841ccced731392e21b1e6453bacfafc2460b3010fca64ae083d17fcd0ae674484c0c955ecb5f208399c4d6487
+  metadata.gz: c96bc020fefc6c9eb331e32a7b71db10403088ba23228cf73c0b9d66a0861a720351f1773293bf0c80b0296186e20f31af0d141f0707ae8af33556001f91ef96
+  data.tar.gz: 8e934d6d187cb1f08f8492758f87441a023db7d164a8272f4632e5f164244f7fff6f91819efb2e808b9f254ced744f652f4d2dde849be3d0377c33fe834de5fc

data/lib/reactor/event.rb

@@ -2,8 +2,6 @@ class Reactor::Event
   include Reactor::OptionallySubclassable
   include Sidekiq::Worker
 
-  class UnserializableModelKeysIncluded < StandardError; end;
-
   attr_accessor :data
 
   def initialize(data = {})
@@ -37,8 +35,6 @@ class Reactor::Event
     end
 
     def publish(name, data = {})
-      enforce_serializable_model_keys!(data)
-
       message = new(data.merge(event: name))
 
       if message.at.nil?
@@ -59,22 +55,6 @@ class Reactor::Event
       job.delete
       publish(name, data.except(:was)) if data[:at].future?
     end
-
-    private
-
-    def enforce_serializable_model_keys!(event_signature)
-      event_signature = event_signature.stringify_keys
-      serializable_models = event_signature.keys.map(&:to_s).select { |k| k.end_with?('_id') || k.end_with?('_type') }
-      .map { |k| k.gsub(/_id\Z/, '') }
-      .map { |k| k.gsub(/_type\Z/, '') }
-      .uniq
-
-      serializable_models.each do |model_relation_name|
-        raise UnserializableModelKeysIncluded, "#{model_relation_name}_type is missing corresponding _id key" if event_signature["#{model_relation_name}_id"].blank?
-        raise UnserializableModelKeysIncluded, "#{model_relation_name}_id is missing corresponding _type key" if event_signature["#{model_relation_name}_type"].blank?
-
-      end
-    end
   end
 
   private

data/lib/reactor/version.rb

@@ -1,3 +1,3 @@
 module Reactor
-  VERSION = "0.8.1"
+  VERSION = "0.8.2"
 end

data/spec/event_spec.rb

@@ -18,20 +18,8 @@ describe Reactor::Event do
 
   describe 'publish' do
     it 'fires the first perform and sets message event_id' do
-      expect(Reactor::Event).to receive(:perform_async).with(event_name, 'actor_id' => '1', 'actor_type' => 'Pet', 'event' => :user_did_this)
-      Reactor::Event.publish(:user_did_this, actor_id: '1', actor_type: 'Pet')
-    end
-
-    context 'x_id is included but x_type is not' do
-      it 'raises an exception' do
-        expect { Reactor::Event.publish(:user_did_something, actor_id: '1') }.to raise_error
-      end
-    end
-
-    context 'x_type is included but x_id is not' do
-      it 'raises an exception' do
-        expect { Reactor::Event.publish(:user_did_something, actor_type: 'Pet') }.to raise_error
-      end
+      Reactor::Event.should_receive(:perform_async).with(event_name, 'actor_id' => '1', 'event' => :user_did_this)
+      Reactor::Event.publish(:user_did_this, actor_id: '1')
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reactor
 version: !ruby/object:Gem::Version
-  version: 0.8.1
+  version: 0.8.2
 platform: ruby
 authors:
 - winfred