reactor 0.7.1 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d90cd996f2190605f1a5371b4f53e6c4bc3e06c1
-  data.tar.gz: 8f1fc2b3238366005a058b9682d69401075ef0ba
+  metadata.gz: 48d54ad63bce2589fbe3d6e39d8d9fe7e2d1fca6
+  data.tar.gz: 484fbf659d971b11479a0bd24392657ba4e9a031
 SHA512:
-  metadata.gz: 29323bb0100ec4d4b912d44238c989aa9d5a94c94740cfa681917c62f42bf6c3d50f65ad4d7d170a863d3f3c1a3a55c656a9f0f74517bd4b47a3f297c0f1b27b
-  data.tar.gz: fefd3d99e793f80d9a18f9989e303daf5ef193b83c04b4858874aec341ce8ea7560b08bdd64c9888f50b16c0dae96499a9c605ecf2c1a0ba5e5c99bd95043e77
+  metadata.gz: 32f14db9aba4a493b5a8765cf8b7d1a50723cc585215a40e0cb5bd8b8369d504871ec0288232e3dd647eb50ae5521b89577123af8708cf03bb8df61b413da995
+  data.tar.gz: 3c854cf77e8188db2598dba97e80cb40856fc3f70f497861508c99447147e1743840d7cc06c9c1997c87f6baa6a360d56257ae8a57b8074d96a65591f3e1b2a1

data/README.md

@@ -220,16 +220,7 @@ for your testing convenience.
 4. Push to the branch (`git push origin my-new-feature`)
 5. Create new Pull Request
 
-## Open Source by Hired
-
-[Hired](https://hired.com/?utm_source=opensource&utm_medium=reactor&utm_campaign=readme) wants to make sure every developer in the world has a kick-ass job with an awesome salary and great coworkers. 
-
-Our site allows you to quickly create a profile and then get offers from some of the top companies in the world - with salary and equity disclosed up-front. Average Ruby engineer salaries on Hired are around $120,000 per year, but if you are smart enough to use Reactor you'll probably be able to get more like $150,000 :).
-
-
-<a href="https://hired.com/?utm_source=opensource&utm_medium=reactor&utm_campaign=readme-banner" target="_blank">
-<img src="https://dmrxx81gnj0ct.cloudfront.net/public/hired-banner-light-1-728x90.png" alt="Hired" width="728" height="90" align="center"/>
-</a>
+## Open Source by [Hired](https://hired.com/?utm_source=opensource&utm_medium=reactor&utm_campaign=readme)
 
 We are Ruby developers ourselves, and we use all of our open source projects in production. We always encourge forks, pull requests, and issues. Get in touch with the Hired Engineering team at _opensource@hired.com_.
 

data/lib/reactor/event.rb

@@ -2,6 +2,8 @@ class Reactor::Event
   include Reactor::OptionallySubclassable
   include Sidekiq::Worker
 
+  class UnserializableModelKeysIncluded < StandardError; end;
+
   attr_accessor :data
 
   def initialize(data = {})
@@ -35,6 +37,8 @@ class Reactor::Event
     end
 
     def publish(name, data = {})
+      enforce_serializable_model_keys!(data)
+
       message = new(data.merge(event: name))
 
       if message.at.nil?
@@ -55,6 +59,22 @@ class Reactor::Event
       job.delete
       publish(name, data.except(:was)) if data[:at].future?
     end
+
+    private
+
+    def enforce_serializable_model_keys!(event_signature)
+      event_signature = event_signature.stringify_keys
+      serializable_models = event_signature.keys.map(&:to_s).select { |k| k.include?('_id') || k.include?('_type') }
+      .map { |k| k.gsub('_id', '') }
+      .map { |k| k.gsub('_type', '') }
+      .uniq
+
+      serializable_models.each do |model_relation_name|
+        raise UnserializableModelKeysIncluded, "#{model_relation_name}_type is missing corresponding _id key" if event_signature["#{model_relation_name}_id"].blank?
+        raise UnserializableModelKeysIncluded, "#{model_relation_name}_id is missing corresponding _type key" if event_signature["#{model_relation_name}_type"].blank?
+
+      end
+    end
   end
 
   private

data/lib/reactor/version.rb

@@ -1,3 +1,3 @@
 module Reactor
-  VERSION = "0.7.1"
+  VERSION = "0.8.0"
 end

data/spec/event_spec.rb

@@ -18,8 +18,20 @@ describe Reactor::Event do
 
   describe 'publish' do
     it 'fires the first perform and sets message event_id' do
-      Reactor::Event.should_receive(:perform_async).with(event_name, 'actor_id' => '1', 'event' => :user_did_this)
-      Reactor::Event.publish(:user_did_this, actor_id: '1')
+      Reactor::Event.should_receive(:perform_async).with(event_name, 'actor_id' => '1', 'actor_type' => 'Pet', 'event' => :user_did_this)
+      Reactor::Event.publish(:user_did_this, actor_id: '1', actor_type: 'Pet')
+    end
+
+    context 'x_id is included but x_type is not' do
+      it 'raises an exception' do
+        expect { Reactor::Event.publish(:user_did_something, actor_id: '1') }.to raise_error
+      end
+    end
+
+    context 'x_type is included but x_id is not' do
+      it 'raises an exception' do
+        expect { Reactor::Event.publish(:user_did_something, actor_type: 'Pet') }.to raise_error
+      end
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reactor
 version: !ruby/object:Gem::Version
-  version: 0.7.1
+  version: 0.8.0
 platform: ruby
 authors:
 - winfred
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-26 00:00:00.000000000 Z
+date: 2014-07-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sidekiq