reactor 0.6.2 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0abc4277ddd966a53c908760c99f67e32c4753e9
-  data.tar.gz: a5990f202fda7c2987d66c68d738bc126f568f75
+  metadata.gz: fde04277711d635f472dbd5f930d8d229439977f
+  data.tar.gz: defa897759a608c46676c26ba1552887d24fb0e7
 SHA512:
-  metadata.gz: 1d8af444ef13fc7e8e142b3392d04a841a340ef84ef5a2155a882fbedf30f1d2b94b90f90b76579b33ec7390fb9ee3bffc0aeccdc00ab0db8fd12aa8173feb07
-  data.tar.gz: 788bb1bda4586fbcdd2d6c6f19da8de2cc5d17f161b33517beb7459f7f9b2e9b26f7a5557acdf3017ce3a1d377f4ccd2e7c1fa7322ae2300d8fcfa25b089cbf8
+  metadata.gz: 2a461f780da7909000cf0b9487f63a731bdbef965d2329cc8cfb7b7129fb0f0adcb16c74f4e297ed4fcbc33ccdcef675bc0b682f147c93128b74712ffd09f807
+  data.tar.gz: 35616c16d05954d319bc4fa55029d5432b1444332aa3ede44fc9bc8e97fb64bafbb3bc32587c3b0e66a61f0a3867a445445a95cb6024ec9426ec24ea540bed4f

data/.gitignore

@@ -19,3 +19,4 @@ tags
 .rvmrc
 .ruby-version
 .ruby-gemset
+.idea

data/.rspec

@@ -0,0 +1 @@
+--colour

data/.travis.yml

@@ -0,0 +1,5 @@
+language: ruby
+rvm:
+  - 2.1.2
+services:
+  - redis-server

data/Gemfile

@@ -2,9 +2,3 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in reactor.gemspec
 gemspec
-
-group :test do
-  gem 'pry'
-  gem 'rspec'
-  gem 'sqlite3'
-end

data/README.md

@@ -1,6 +1,8 @@
-# Reactor
+# reactor.gem
 
-Warning: this is under active development!
+### A Sidekiq-backed pub/sub layer for your Rails app.
+
+[![Build Status](https://travis-ci.org/hired/reactor.svg?branch=master)](https://travis-ci.org/hired/reactor)
 
 This gem aims to provide the following tools to augment your ActiveRecord & Sidekiq stack.
 
@@ -31,7 +33,9 @@ Well, this is evolving, so it's probably best to go read the specs.
 
 ### Barebones API
 
-   Event.publish(:event_name, any: 'data', you: 'want')
+```ruby
+Reactor::Event.publish(:event_name, any: 'data', you: 'want')
+```
 
 ### ActiveModel extensions
 
@@ -39,24 +43,174 @@ Well, this is evolving, so it's probably best to go read the specs.
 
   Describe lifecycle events like so
 
-    publishes :my_model_created
-    publishes :state_has_changed, if: -> { state_has_changed? }
+```ruby
+publishes :my_model_created
+publishes :state_has_changed, if: -> { state_has_changed? }
+```
 
 #### Subscribable
 
   You can now bind any block to an event in your models like so
 
-    on_event :any_event do |event|
-      event.target.do_something_about_it!
-    end
+```ruby
+on_event :any_event do |event|
+  event.target.do_something_about_it!
+end
+```
 
   Static subscribers like these are automatically placed into Sidekiq and executed in the background
 
   It's also possible to run a subscriber block in memory like so
 
-    on_event :any_event, in_memory: true do |event|
-      event.target.do_something_about_it_and_make_the_user_wait!
+```ruby
+on_event :any_event, in_memory: true do |event|
+  event.target.do_something_about_it_and_make_the_user_wait!
+end
+```
+
+#### ResourceActionable
+
+    Enforce a strict 1:1 match between your event model and database model with this controller mixin.
+
+
+```ruby
+class PetsController < ApplicationController
+  include Reactor::ResourceActionable
+  actionable_resource :@pet
+
+  # GET /pets
+  # GET /pets.json
+  def index
+    @pets = current_user.pets
+
+    respond_to do |format|
+      format.html # index.html.erb
+      format.json { render json: @pets }
     end
+  end
+
+  def show
+    @pet = current_user.pets.find(params[:id])
+    respond_to do |format|
+      format.html # index.html.erb
+      format.json { render json: @pet }
+    end
+  end
+end
+
+```
+
+Now your index action (and any of the other RESTful actions in that controller) will fire a useful event for you to bind to and log.
+
+*Important* Reactor::ResourceActionable has one major usage constraints:
+
+Your controller *must* have a method called "action_event" with this signature.
+```ruby
+def action_event(name, options = {})
+  # Here's what ours looks like, but yours may look different.
+  actor = options[:actor] || current_user
+  actor.publish(name, options.merge(default_action_parameters))
+  #where default_action_parameters includes things like ip_address, referrer, user_agent
+end
+```
+
+Once you write your own action_event to describe your event data model's base attributes, your ResourceActionable endpoints will now fire events that map like so (for the example above):
+
+<dl>
+<dt>index =></dt>
+<dd>"pets_indexed"</dd>
+</dl>
+ 
+<dl>
+<dt>show =></dt>
+<dd>"pet_viewed", target: @pet</dd>
+</dl>
+
+<dl>
+<dt>new =></dt>
+<dd>"new_pet_form_viewed"</dd>
+</dl>
+
+<dl>
+<dt>edit =></dt>
+<dd> "edit_pet_form_viewed", target: @pet</dd>
+</dl>
+
+<dl>
+<dt>create =></dt>
+<dd> when valid => "pet_created", target: @pet, attributes: params[:pet]
+<br />
+  when invalid => "pet_create_failed", errors: @pet.errors, attributes: params[:pet]</dd>
+</dl>
+
+<dl>
+<dt>update =></dt>
+<dd> 
+when valid => "pet_updated", target: @pet, changes: @pet.previous_changes.as_json
+<br />
+  when invalid => "pet_update_failed", target: @pet,
+                  errors: @pet.errors.as_json, attributes: params[:pet]
+</dd>
+</dl>
+
+<dl>
+<dt>destroy =></dt>
+<dd>"pet_destroyed", last_snapshot: @pet.as_jsont</dd>
+</dl>
+
+
+##### What for?
+
+If you're obsessive about data like us, you'll have written a '*' subscriber that logs every event fired in the system. With information-dense resource information logged for each action a user performs, it will be trivial for a data analyst to determine patterns in user activity. For example, with the above data being logged for the pet resource, we can easily
+* determine which form field validations are constantly being hit by users
+* see if there are any fields that are consistently ignored on that form until later
+* recover data from the last_snapshot of a destroyed record
+* write a small conversion funnel analysis to see who never makes it back to a record to update it
+* bind arbitrary logic anywhere in the codebase (see next example) to that specific request without worrying about the logic being run during the request (all listeners are run in the background by Sidekiq)
+
+For example, in an action mailer.
+
+```ruby
+class MyMailer < ActionMailer::Base
+  include Reactor::EventMailer
+
+  on_event :pet_created do |event|
+    @user = event.actor
+    @pet = event.target
+    mail to: @user.email, subject: "Your pet is already hungry!", body: "feed it."
+  end
+end
+```
+
+Or in a model, concern, or other business logic file.
+
+```ruby
+class MyClass
+  include Reactor::Subscribable
+
+  on_event :pet_updated do |event|
+     event.actor.recalculate_expensive_something_for(event.target)
+  end
+end
+```
+
+### Testing
+
+Calling `Reactor.test_mode!` enables test mode.  (You should call this as early as possible, before your subscriber classes
+are declared).  In test mode, no subscribers will fire unless they are specifically enabled, which can be accomplished
+by calling
+```ruby
+Reactor.enable_test_mode_subscriber(MyAwesomeSubscriberClass)
+```
+
+We also provide
+```ruby
+Reactor.with_subscriber_enabled(MyClass) do
+  # stuff
+end
+```
+
+for your testing convenience.
 
 ## Contributing
 
@@ -65,3 +219,17 @@ Well, this is evolving, so it's probably best to go read the specs.
 3. Commit your changes (`git commit -am 'Add some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)
 5. Create new Pull Request
+
+## Open Source by Hired
+
+[Hired](https://hired.com/?utm_source=opensource&utm_medium=reactor&utm_campaign=readme) wants to make sure every developer in the world has a kick-ass job with an awesome salary and great coworkers. 
+
+Our site allows you to quickly create a profile and then get offers from some of the top companies in the world - with salary and equity disclosed up-front. Average Ruby engineer salaries on Hired are around $120,000 per year, but if you are smart enough to use Reactor you'll probably be able to get more like $150,000 :).
+
+
+<a href="https://hired.com/?utm_source=opensource&utm_medium=reactor&utm_campaign=readme-banner" target="_blank">
+<img src="https://dmrxx81gnj0ct.cloudfront.net/public/hired-banner-light-1-728x90.png" alt="Hired" width="728" height="90" align="center"/>
+</a>
+
+We are Ruby developers ourselves, and we use all of our open source projects in production. We always encourge forks, pull requests, and issues. Get in touch with the Hired Engineering team at _opensource@hired.com_.
+

data/Rakefile

@@ -1 +1,7 @@
 require "bundler/gem_tasks"
+
+require 'rspec/core/rake_task'
+
+RSpec::Core::RakeTask.new(:spec)
+
+task :default => :spec

data/lib/reactor/controllers/concerns/actions/action_event.rb

@@ -0,0 +1,9 @@
+class Reactor::ResourceActionable::ActionEvent
+  def self.perform(&block)
+    @perform_block = block
+  end
+
+  def self.perform_on(ctx)
+    ctx.instance_exec(&@perform_block)
+  end
+end

data/lib/reactor/controllers/concerns/actions/create_event.rb

@@ -0,0 +1,14 @@
+class Reactor::ResourceActionable::CreateEvent < Reactor::ResourceActionable::ActionEvent
+  perform do
+    if actionable_resource.valid?
+      action_event "#{resource_name}_created",
+                   target: actionable_resource,
+                   attributes: params[resource_name]
+    else
+      action_event "#{resource_name}_create_failed",
+                   errors: actionable_resource.errors.as_json,
+                   attributes: params[resource_name],
+                   target: nested_resource
+    end
+  end
+end

data/lib/reactor/controllers/concerns/actions/destroy_event.rb

@@ -0,0 +1,5 @@
+class Reactor::ResourceActionable::DestroyEvent < Reactor::ResourceActionable::ActionEvent
+  perform do
+    action_event "#{resource_name}_destroyed", last_snapshot: actionable_resource.as_json
+  end
+end

data/lib/reactor/controllers/concerns/actions/edit_event.rb

@@ -0,0 +1,5 @@
+class Reactor::ResourceActionable::EditEvent < Reactor::ResourceActionable::ActionEvent
+  perform do
+    action_event "edit_#{resource_name}_form_viewed", target: actionable_resource
+  end
+end

data/lib/reactor/controllers/concerns/actions/index_event.rb

@@ -0,0 +1,5 @@
+class Reactor::ResourceActionable::IndexEvent < Reactor::ResourceActionable::ActionEvent
+  perform do
+    action_event "#{resource_name.pluralize}_indexed", target: nested_resource
+  end
+end

data/lib/reactor/controllers/concerns/actions/new_event.rb

@@ -0,0 +1,5 @@
+class Reactor::ResourceActionable::NewEvent < Reactor::ResourceActionable::ActionEvent
+  perform do
+    action_event "new_#{resource_name}_form_viewed", target: nested_resource
+  end
+end

data/lib/reactor/controllers/concerns/actions/show_event.rb

@@ -0,0 +1,5 @@
+class Reactor::ResourceActionable::ShowEvent < Reactor::ResourceActionable::ActionEvent
+  perform do
+    action_event "#{resource_name}_viewed", target: actionable_resource
+  end
+end

data/lib/reactor/controllers/concerns/actions/update_event.rb

@@ -0,0 +1,14 @@
+class Reactor::ResourceActionable::UpdateEvent < Reactor::ResourceActionable::ActionEvent
+  perform do
+    if actionable_resource.valid?
+      action_event "#{resource_name}_updated",
+                   target: actionable_resource,
+                   changes: actionable_resource.previous_changes.as_json
+    else
+      action_event "#{resource_name}_update_failed",
+                   target: actionable_resource,
+                   errors: actionable_resource.errors.as_json,
+                   attributes: params[resource_name]
+    end
+  end
+end

data/lib/reactor/controllers/concerns/resource_actionable.rb

@@ -0,0 +1,53 @@
+module Reactor::ResourceActionable
+  extend ActiveSupport::Concern
+
+  included do
+    around_filter :infer_basic_action_event
+  end
+
+  def infer_basic_action_event
+    yield if block_given?
+
+    if (event_descriptor = "Reactor::ResourceActionable::#{action_name.camelize}Event".safe_constantize).present?
+      event_descriptor.perform_on self
+    else
+      action_event "#{resource_name}_#{action_name}"
+    end
+  end
+
+  module ClassMethods
+    def actionable_resource(ivar_name = nil)
+      @resource_ivar_name ||= ivar_name
+    end
+
+    def nested_resource(ivar_name = nil)
+      @nested_resource_ivar_name ||= ivar_name
+    end
+
+    # this is so our API controller subclasses can re-use the resource declarations
+    def inherited(subclass)
+      [:resource_ivar_name, :nested_resource_ivar_name].each do |inheritable_attribute|
+        instance_var = "@#{inheritable_attribute}"
+        subclass.instance_variable_set(instance_var, instance_variable_get(instance_var))
+      end
+    end
+  end
+
+  def actionable_resource; instance_variable_get(self.class.actionable_resource); end
+  def nested_resource; self.class.nested_resource && instance_variable_get(self.class.nested_resource); end
+
+  private
+
+  def resource_name
+    self.class.actionable_resource.to_s.gsub('@','').underscore
+  end
+end
+
+require "reactor/controllers/concerns/actions/action_event"
+require "reactor/controllers/concerns/actions/new_event"
+require "reactor/controllers/concerns/actions/index_event"
+require "reactor/controllers/concerns/actions/edit_event"
+require "reactor/controllers/concerns/actions/create_event"
+require "reactor/controllers/concerns/actions/update_event"
+require "reactor/controllers/concerns/actions/destroy_event"
+require "reactor/controllers/concerns/actions/show_event"

data/lib/reactor/event.rb

@@ -85,13 +85,9 @@ class Reactor::Event
   end
 
   def fire_database_driven_subscribers(data, name)
-    Reactor::Subscriber.where(event: name).each do |subscriber|
-      Reactor::Subscriber.delay.fire subscriber.id, data
-    end
-
     #TODO: support more matching?
-    Reactor::Subscriber.where(event: '*').each do |s|
-      Reactor::Subscriber.delay.fire s.id, data
+    Reactor::Subscriber.where(event_name: [name, '*']).each do |subscriber|
+      Reactor::Subscriber.delay.fire subscriber.id, data
     end
   end
 

data/lib/reactor/models/concerns/publishable.rb

@@ -2,7 +2,8 @@ module Reactor::Publishable
   extend ActiveSupport::Concern
 
   included do
-    after_commit :schedule_events, if: :persisted?
+    after_commit :schedule_events, if: :persisted?, on: :create
+    after_commit :schedule_conditional_events, if: :persisted?, on: [:create, :update]
     after_commit :reschedule_events, if: :persisted?, on: :update
   end
 
@@ -24,20 +25,8 @@ module Reactor::Publishable
 
   def schedule_events
     self.class.events.each do |name, data|
-      event = data.merge(
-          actor: ( data[:actor] ? send(data[:actor]) : self ),
-          target: ( data[:target] ? self : nil),
-          at: ( data[:at] ? send(data[:at]) : nil)
-      ).except(:watch, :if)
-      need_to_fire = case (ifarg = data[:if])
-                       when Proc
-                         instance_exec(&ifarg)
-                       when Symbol
-                         send(ifarg)
-                       else
-                         transaction_include_action?(:create)
-                     end
-      Reactor::Event.publish name, event if need_to_fire
+      event = event_data_for_signature(data)
+      Reactor::Event.publish name, event
     end
   end
 
@@ -55,4 +44,25 @@ module Reactor::Publishable
     end
   end
 
+  def schedule_conditional_events
+    self.class.events.select { |k,v| v.has_key?(:if) }.each do |name, data|
+      event = event_data_for_signature(data)
+      need_to_fire = case (ifarg = data[:if])
+                       when Proc
+                         instance_exec(&ifarg)
+                       when Symbol
+                         send(ifarg)
+                     end
+      Reactor::Event.publish name, event if need_to_fire
+    end
+  end
+
+  def event_data_for_signature(signature)
+    signature.merge(
+        actor: (signature[:actor] ? send(signature[:actor]) : self),
+        target: (signature[:target] ? self : nil),
+        at: (signature[:at] ? send(signature[:at]) : nil)
+    ).except(:watch, :if)
+  end
+
 end

data/lib/reactor/models/concerns/subscribable.rb

@@ -19,37 +19,39 @@ module Reactor::Subscribable
         i+= 1
       end while Reactor::StaticSubscribers.const_defined?(new_class)
 
-      eval %Q{
-        class Reactor::StaticSubscribers::#{new_class}
-          include Sidekiq::Worker
-
-          cattr_accessor :method, :delay, :source, :in_memory
-
-          def perform(data)
-            event = Reactor::Event.new(data)
-            if @@method.is_a?(Symbol)
-              @@source.delay_for(@@delay).send(@@method, event)
-            else
-              @@method.call(event)
-            end
+      klass = Class.new do
+        include Sidekiq::Worker
+
+        class_attribute :method, :delay, :source, :in_memory, :dont_perform
+
+        def perform(data)
+          return :__perform_aborted__ if dont_perform && !Reactor::TEST_MODE_SUBSCRIBERS.include?(source)
+          event = Reactor::Event.new(data)
+          if method.is_a?(Symbol)
+            source.delay_for(delay).send(method, event)
+          else
+            method.call(event)
           end
+        end
 
-          def self.perform_where_needed(data)
-            if @@in_memory
-              new.perform(data)
-            else
-              perform_async(data)
-            end
+        def self.perform_where_needed(data)
+          if in_memory
+            new.perform(data)
+          else
+            perform_async(data)
           end
         end
-      }
-
-      new_class = "Reactor::StaticSubscribers::#{new_class}".constantize
-      new_class.method = method || block
-      new_class.delay = options[:delay] || 0
-      new_class.source = options[:source]
-      new_class.in_memory = options[:in_memory]
-      new_class
+      end
+
+      Reactor::StaticSubscribers.const_set(new_class, klass)
+
+      klass.tap do |k|
+        k.method = method || block
+        k.delay = options[:delay] || 0
+        k.source = options[:source]
+        k.in_memory = options[:in_memory]
+        k.dont_perform = Reactor.test_mode?
+      end
     end
   end
-end
+end

data/lib/reactor/models/subscriber.rb

@@ -1,12 +1,12 @@
 class Reactor::Subscriber < ActiveRecord::Base
-  attr_accessor :message
+  attr_accessor :event
 
-  def event=(event)
-    write_attribute :event, event.to_s
+  def event_name=(event)
+    write_attribute :event_name, event.to_s
   end
 
   def fire(data)
-    self.message = Reactor::Event.new(data)
+    self.event = Reactor::Event.new(data)
     instance_exec &self.class.on_fire
     self
   end
@@ -22,19 +22,5 @@ class Reactor::Subscriber < ActiveRecord::Base
     def fire(subscriber_id, data)
       Reactor::Subscriber.find(subscriber_id).fire data
     end
-
-    def subscribes_to(name = nil, data = {})
-      #subscribers << name
-      #TODO: REMEMBER SUBSCRIBERS so we can define them in code as well as with a row in the DB
-      # until then, here's a helper to make it easy to create with random data in postgres
-      # total crap I know but whatever
-      define_singleton_method :exists! do
-        chain = where(event: name)
-        data.each do |key, value|
-          chain = chain.where("subscribers.data @> ?", "#{key}=>#{value}")
-        end
-        chain.first_or_create!(data)
-      end
-    end
   end
 end

data/lib/reactor/version.rb

@@ -1,3 +1,3 @@
 module Reactor
-  VERSION = "0.6.2"
+  VERSION = "0.7.0"
 end

data/lib/reactor.rb

@@ -3,13 +3,48 @@ require "reactor/models/concerns/publishable"
 require "reactor/models/concerns/subscribable"
 require "reactor/models/concerns/optionally_subclassable"
 require "reactor/models/subscriber"
+require "reactor/controllers/concerns/resource_actionable"
 require "reactor/event"
 
 module Reactor
   SUBSCRIBERS = {}
+  TEST_MODE_SUBSCRIBERS = Set.new
+  @@test_mode = false
+
   module StaticSubscribers
   end
+
+  def self.test_mode?
+    @@test_mode
+  end
+
+  def self.test_mode!
+    @@test_mode = true
+  end
+
+  def self.disable_test_mode!
+    @@test_mode = false
+  end
+
+  def self.in_test_mode
+    test_mode!
+    (yield if block_given?).tap { disable_test_mode! }
+  end
+
+  def self.enable_test_mode_subscriber(klass)
+    TEST_MODE_SUBSCRIBERS << klass
+  end
+
+  def self.disable_test_mode_subscriber(klass)
+    TEST_MODE_SUBSCRIBERS.delete klass
+  end
+
+  def self.with_subscriber_enabled(klass)
+    enable_test_mode_subscriber klass
+    yield if block_given?
+    disable_test_mode_subscriber klass
+  end
 end
 
 ActiveRecord::Base.send(:include, Reactor::Publishable)
-ActiveRecord::Base.send(:include, Reactor::Subscribable)
+ActiveRecord::Base.send(:include, Reactor::Subscribable)

data/reactor.gemspec

@@ -6,8 +6,8 @@ require 'reactor/version'
 Gem::Specification.new do |spec|
   spec.name          = "reactor"
   spec.version       = Reactor::VERSION
-  spec.authors       = ["winfred", "walt", "nate", "cgag", "petermin"]
-  spec.email         = ["winfred@developerauction.com", "walt@developerauction.com", "curtis@developerauction.com", "nate@developerauction.com", "kengteh.min@gmail.com"]
+  spec.authors       = ["winfred", "walt", "nate", "petermin"]
+  spec.email         = ["winfred@hired.com", "walt@hired.com", "nate@hired.com", "kengteh.min@gmail.com"]
   spec.description   = %q{ rails chrono reactor }
   spec.summary       = %q{ Sidekiq/ActiveRecord pubsub lib }
   spec.homepage      = ""
@@ -18,9 +18,13 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "sidekiq", ">= 2.13.0"
-  spec.add_dependency 'activerecord', '~> 3.2.13'
+  spec.add_dependency "sidekiq", "> 2.0"
+  spec.add_dependency 'activerecord', '> 3.0'
+
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec"
+  spec.add_development_dependency "rspec", "~> 2.14.1"
+  spec.add_development_dependency "pry"
+  spec.add_development_dependency "sqlite3"
+  spec.add_development_dependency "test_after_commit"
 end

data/spec/controllers/concerns/resource_actionable_spec.rb

@@ -0,0 +1,140 @@
+require 'spec_helper'
+
+class RandomActionController
+
+  def self.around_filter(method)
+    @around_filter ||= method
+  end
+
+  include Reactor::ResourceActionable
+  actionable_resource :@cat
+  nested_resource :@owner
+
+  attr_accessor :action_name
+  def initialize
+    self.action_name = 'create'
+  end
+
+  def create
+    #because I dont feel like re-implementing around_filter for this stub
+    infer_basic_action_event do
+      @owner = ArbitraryModel.create!
+      @cat = Pet.create!
+    end
+  end
+
+end
+
+describe Reactor::ResourceActionable do
+  let(:controller_stub) { RandomActionController.new }
+
+  describe "when action strategy class exists" do
+    it 'runs the strategy of the matching name' do
+      Reactor::ResourceActionable::CreateEvent.should_receive(:perform_on).with(controller_stub)
+      controller_stub.create
+    end
+  end
+
+  describe "when action is non-standard rails CRUD action" do
+    it 'fires a basic action_event' do
+      controller_stub.action_name = 'do_thing'
+      controller_stub.should_receive(:action_event).with("cat_do_thing")
+      controller_stub.create
+    end
+  end
+end
+
+describe "ActionEvents" do
+  let(:actionable_resource) { ArbitraryModel.create! }
+  let(:nested_resource) { Pet.create! }
+  let(:ctrl_stub) { stub(resource_name: "cat", actionable_resource: actionable_resource, nested_resource: nested_resource, params: {'cat' => {name: "Sasha"}} ) }
+
+  describe "ShowEvent" do
+    after { Reactor::ResourceActionable::ShowEvent.perform_on(ctrl_stub) }
+    specify { ctrl_stub.should_receive(:action_event).with("cat_viewed", target: actionable_resource) }
+  end
+
+  describe "EditEvent" do
+    after { Reactor::ResourceActionable::EditEvent.perform_on(ctrl_stub) }
+    specify { ctrl_stub.should_receive(:action_event).with("edit_cat_form_viewed", target: actionable_resource) }
+  end
+
+  describe "NewEvent" do
+    after { Reactor::ResourceActionable::NewEvent.perform_on(ctrl_stub) }
+    specify { ctrl_stub.should_receive(:action_event).with("new_cat_form_viewed", target: nested_resource) }
+  end
+
+  describe "IndexEvent" do
+    after { Reactor::ResourceActionable::IndexEvent.perform_on(ctrl_stub) }
+    specify { ctrl_stub.should_receive(:action_event).with("cats_indexed", target: nested_resource) }
+  end
+
+  describe "DestroyEvent" do
+    after { Reactor::ResourceActionable::DestroyEvent.perform_on(ctrl_stub) }
+    specify { ctrl_stub.should_receive(:action_event).with("cat_destroyed", last_snapshot: actionable_resource.as_json) }
+  end
+
+  describe "CreateEvent" do
+    after { Reactor::ResourceActionable::CreateEvent.perform_on(ctrl_stub) }
+
+    describe "when resource is valid" do
+      before { actionable_resource.should_receive(:valid?).and_return(true) }
+
+      specify do
+        ctrl_stub.should_receive(:action_event)
+          .with("cat_created",
+                target: actionable_resource,
+                attributes: {name: "Sasha"})
+      end
+    end
+
+    describe "when resource is not valid" do
+      before do
+        actionable_resource.should_receive(:valid?).and_return(false)
+        actionable_resource.should_receive(:errors).and_return('awesomeness' => 'too awesome')
+      end
+
+      specify do
+        ctrl_stub.should_receive(:action_event)
+          .with("cat_create_failed",
+                errors: {'awesomeness' => 'too awesome'},
+                target: nested_resource,
+                attributes: {name: "Sasha"})
+      end
+    end
+  end
+
+  describe "UpdateEvent" do
+    after { Reactor::ResourceActionable::UpdateEvent.perform_on(ctrl_stub) }
+
+    describe "when resource is valid" do
+      before do
+        actionable_resource.should_receive(:valid?).and_return(true)
+        actionable_resource.should_receive(:previous_changes).and_return({'name' => [nil, "Sasha"]})
+      end
+
+      specify do
+        ctrl_stub.should_receive(:action_event)
+          .with("cat_updated",
+                target: actionable_resource,
+                changes: {'name' => [nil, "Sasha"]})
+      end
+    end
+
+    describe "when resource is not valid" do
+      before do
+        actionable_resource.should_receive(:valid?).and_return(false)
+        actionable_resource.should_receive(:errors).and_return('awesomeness' => 'too awesome')
+      end
+
+      specify do
+        ctrl_stub.should_receive(:action_event)
+          .with("cat_update_failed",
+              target: actionable_resource,
+              errors: {'awesomeness' => 'too awesome'},
+              attributes: {name: "Sasha"})
+      end
+    end
+  end
+
+end

data/spec/event_spec.rb

@@ -24,7 +24,7 @@ describe Reactor::Event do
   end
 
   describe 'perform' do
-    before { Reactor::Subscriber.create(event: :user_did_this) }
+    before { Reactor::Subscriber.create(event_name: :user_did_this) }
     after { Reactor::Subscriber.destroy_all }
     it 'fires all subscribers' do
       Reactor::Subscriber.any_instance.should_receive(:fire).with(hash_including(actor_id: '1'))

data/spec/models/concerns/publishable_spec.rb

@@ -1,8 +1,5 @@
 require 'spec_helper'
 
-class Pet < ActiveRecord::Base
-end
-
 class Auction < ActiveRecord::Base
   attr_accessor :we_want_it
   belongs_to :pet
@@ -85,7 +82,7 @@ describe Reactor::Publishable do
     end
 
     it 'supports immediate events (on create) that get fired once' do
-      TestSubscriber.create! event: :bell
+      TestSubscriber.create! event_name: :bell
       auction
       TestSubscriber.class_variable_get(:@@called).should be_true
       TestSubscriber.class_variable_set(:@@called, false)
@@ -95,19 +92,20 @@ describe Reactor::Publishable do
     end
 
     it 'does not publish an event scheduled for the past' do
-      TestSubscriber.create! event: :begin
+      TestSubscriber.create! event_name: :begin
       auction
       TestSubscriber.class_variable_get(:@@called).should be_false
     end
 
     it 'does publish an event scheduled for the future' do
-      TestSubscriber.create! event: :begin
+      TestSubscriber.create! event_name: :begin
       Auction.create!(pet: pet, start_at: Time.current + 1.week)
+
       TestSubscriber.class_variable_get(:@@called).should be_true
     end
 
     it 'can fire events onsave for any condition' do
-      TestSubscriber.create! event: :conditional_event_on_save
+      TestSubscriber.create! event_name: :conditional_event_on_save
       auction
       TestSubscriber.class_variable_set(:@@called, false)
       auction.start_at = 1.day.from_now

data/spec/models/concerns/subscribable_spec.rb

@@ -22,6 +22,12 @@ class Auction < ActiveRecord::Base
   end
 end
 
+Reactor.in_test_mode do
+  class TestModeAuction < ActiveRecord::Base
+    on_event :test_puppy_delivered, -> (event) { pp "success" }
+  end
+end
+
 describe Reactor::Subscribable do
   let(:scheduled) { Sidekiq::ScheduledSet.new }
 
@@ -73,5 +79,18 @@ describe Reactor::Subscribable do
         Reactor::Event.publish(:puppy_delivered)
       end
     end
+
+    describe '#perform' do
+      it 'returns :__perform_aborted__ when Reactor is in test mode' do
+        Reactor::StaticSubscribers::TestPuppyDeliveredHandler0.new.perform({}).should == :__perform_aborted__
+        Reactor::Event.publish(:test_puppy_delivered)
+      end
+
+      it 'performs normally when specifically enabled' do
+        Reactor.enable_test_mode_subscriber(TestModeAuction)
+        Reactor::StaticSubscribers::TestPuppyDeliveredHandler0.new.perform({}).should_not == :__perform_aborted__
+        Reactor::Event.publish(:test_puppy_delivered)
+      end
+    end
   end
 end

data/spec/models/subscriber_spec.rb

@@ -11,22 +11,20 @@ end
 describe Reactor::Subscriber do
 
   describe 'fire' do
-    subject { MySubscriber.create(event: :you_name_it).fire some: 'random', event: 'data' }
+    subject { MySubscriber.create(event_name: :you_name_it).fire some: 'random', event: 'data' }
 
-    its(:message) { should be_a Reactor::Event }
-    its('message.some') { should == 'random' }
+    its(:event) { should be_a Reactor::Event }
+    its('event.some') { should == 'random' }
 
     it 'executes block given' do
       subject.was_called.should be_true
     end
   end
 
-  describe '.subscribes_to class helper' do
-  end
 
   describe 'matcher' do
     it 'can be set to star to bind to all events' do
-      MySubscriber.create!(event: '*')
+      MySubscriber.create!(event_name: '*')
       MySubscriber.any_instance.should_receive(:fire).with(hash_including('random' => 'data', 'event' => 'this_event'))
       Reactor::Event.publish(:this_event, {random: 'data'})
     end

data/spec/reactor_spec.rb

@@ -0,0 +1,39 @@
+require 'spec_helper'
+
+
+describe Reactor do
+  let(:subscriber) do
+    Reactor.in_test_mode do
+      Class.new(ActiveRecord::Base) do
+        on_event :test_event, -> (event) { self.spy_on_me }
+      end
+    end
+  end
+
+  describe '.test_mode!' do
+    it 'sets Reactor into test mode' do
+      Reactor.test_mode?.should be_false
+      Reactor.test_mode!
+      Reactor.test_mode?.should be_true
+    end
+  end
+
+  context 'in test mode' do
+    before { Reactor.test_mode! }
+    after  { Reactor.disable_test_mode! }
+
+    it 'subscribers created in test mode are disabled' do
+      subscriber.should_not_receive :spy_on_me
+      Reactor::Event.publish :test_event
+    end
+
+    describe '.with_subscriber_enabled' do
+      it 'enables a subscriber during test mode' do
+        subscriber.should_receive :spy_on_me
+        Reactor.with_subscriber_enabled(subscriber) do
+          Reactor::Event.publish :test_event
+        end
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -5,6 +5,7 @@ require 'pry'
 require 'support/active_record'
 require 'sidekiq'
 require 'sidekiq/testing/inline'
+require 'sidekiq/api'
 require 'reactor'
 require 'reactor/testing/matchers'
 

data/spec/support/active_record.rb

@@ -14,7 +14,7 @@ ActiveRecord::Migration.create_table :auctions do |t|
 end
 
 ActiveRecord::Migration.create_table :subscribers do |t|
-  t.string :event
+  t.string :event_name
   t.string :type
 
   t.timestamps
@@ -33,3 +33,9 @@ ActiveRecord::Migration.create_table :arbitrary_models do |t|
 
   t.timestamps
 end
+
+class Pet < ActiveRecord::Base
+end
+
+class ArbitraryModel < ActiveRecord::Base
+end

metadata

@@ -1,106 +1,157 @@
 --- !ruby/object:Gem::Specification
 name: reactor
 version: !ruby/object:Gem::Version
-  version: 0.6.2
+  version: 0.7.0
 platform: ruby
 authors:
 - winfred
 - walt
 - nate
-- cgag
 - petermin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-11 00:00:00.000000000 Z
+date: 2014-06-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sidekiq
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">"
       - !ruby/object:Gem::Version
-        version: 2.13.0
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">"
       - !ruby/object:Gem::Version
-        version: 2.13.0
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">"
       - !ruby/object:Gem::Version
-        version: 3.2.13
+        version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">"
       - !ruby/object:Gem::Version
-        version: 3.2.13
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.14.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.14.1
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: test_after_commit
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: ' rails chrono reactor '
+description: " rails chrono reactor "
 email:
-- winfred@developerauction.com
-- walt@developerauction.com
-- curtis@developerauction.com
-- nate@developerauction.com
+- winfred@hired.com
+- walt@hired.com
+- nate@hired.com
 - kengteh.min@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
+- ".gitignore"
+- ".rspec"
+- ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
 - lib/reactor.rb
+- lib/reactor/controllers/concerns/actions/action_event.rb
+- lib/reactor/controllers/concerns/actions/create_event.rb
+- lib/reactor/controllers/concerns/actions/destroy_event.rb
+- lib/reactor/controllers/concerns/actions/edit_event.rb
+- lib/reactor/controllers/concerns/actions/index_event.rb
+- lib/reactor/controllers/concerns/actions/new_event.rb
+- lib/reactor/controllers/concerns/actions/show_event.rb
+- lib/reactor/controllers/concerns/actions/update_event.rb
+- lib/reactor/controllers/concerns/resource_actionable.rb
 - lib/reactor/event.rb
 - lib/reactor/models/concerns/optionally_subclassable.rb
 - lib/reactor/models/concerns/publishable.rb
@@ -109,10 +160,12 @@ files:
 - lib/reactor/testing/matchers.rb
 - lib/reactor/version.rb
 - reactor.gemspec
+- spec/controllers/concerns/resource_actionable_spec.rb
 - spec/event_spec.rb
 - spec/models/concerns/publishable_spec.rb
 - spec/models/concerns/subscribable_spec.rb
 - spec/models/subscriber_spec.rb
+- spec/reactor_spec.rb
 - spec/spec_helper.rb
 - spec/support/active_record.rb
 homepage: ''
@@ -125,24 +178,26 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.1.11
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Sidekiq/ActiveRecord pubsub lib
 test_files:
+- spec/controllers/concerns/resource_actionable_spec.rb
 - spec/event_spec.rb
 - spec/models/concerns/publishable_spec.rb
 - spec/models/concerns/subscribable_spec.rb
 - spec/models/subscriber_spec.rb
+- spec/reactor_spec.rb
 - spec/spec_helper.rb
 - spec/support/active_record.rb