reactor 0.11.0 → 0.11.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e47dd61c52db1bfaa846f2fbb50876b081a1c60b
-  data.tar.gz: 917e730109e0f193c63706ba55025d2ebb877ee3
+  metadata.gz: a676751a31b8f702d1cbd084a9363e6bfcc5cf26
+  data.tar.gz: a67b5fdac18be4bb1b61a950af4e23e3d9e0d686
 SHA512:
-  metadata.gz: 10185cdd733e3d93292dc9a94f48a35a100411f030dfa4e7d47f687fe794cb659e77d57ae0ad287daa367b203fe6230621430c8292e8aa3abf933cbee8856c00
-  data.tar.gz: 6687577b3635233ba535a8ada13ab83446c6a90a2273d44157717ac48d9faceafb161913ca6cab4fac56fce158c2996f8f9d67c0f37972c69967b66d993607ca
+  metadata.gz: 0cafbfba4b07912a67188de843589fe97e5b7bc00a445803ef8f2b6836173336e37a46f9c9c7bcd0517f65cf0c5cdb9461db63e869b30504236dff2e0b9f8c31
+  data.tar.gz: 41616d18f3ef3a6244d084aff2c326f389c061d8839b8fa33aff312c3ab41aefe9c327ac0c776bba18d0c386e45c399c8c4f968dec4a1b24272a1910bd395c75

data/Changes.md

@@ -1,5 +1,9 @@
 # Reactor Change Log
 
+0.11.1
+-----------
+Bug fix for namespaced Subscribable objects
+
 0.11.0
 -----------
 Static Subscriber class names have changed to be more deterministic. THIS _MAY BE_ A BREAKING CHANGE.
@@ -9,5 +13,6 @@ Previously, when you added an `on_event :foo` block to an object, say `MyObject`
 
 In 0.11.0, the naming of this dynamically generated worker class has changed to `Reactor::StaticSubscribers::MyObject::FooHandler`.
 If you require more than one `on_event` block for the same event, you must name the handler so that it is unique and deterministic: i.e. `on_event :foo, handler_name: :do_better` otherwise an exception will be raised at load time.
+This example would generate a `Reactor::StaticSubscribers::MyObject::DoBetter` class for the worker.
 
 Because the worker class names are changing, when deploying this change it's important that your Sidekiq queue not have any pending jobs with the old naming scheme, otherwise they will fail to deserialize!

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    reactor (0.11.0)
+    reactor (0.11.1)
       activerecord (< 5.0)
       sidekiq
 
@@ -25,7 +25,7 @@ GEM
     builder (3.2.2)
     byebug (8.2.2)
     coderay (1.1.0)
-    concurrent-ruby (1.0.0)
+    concurrent-ruby (1.0.1)
     connection_pool (2.2.0)
     diff-lcs (1.2.5)
     i18n (0.7.0)
@@ -57,7 +57,7 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.4.0)
     rspec-support (3.4.1)
-    sidekiq (4.1.0)
+    sidekiq (4.1.1)
       concurrent-ruby (~> 1.0)
       connection_pool (~> 2.2, >= 2.2.0)
       redis (~> 3.2, >= 3.2.1)

data/lib/reactor/models/concerns/subscribable.rb

@@ -68,11 +68,12 @@ module Reactor::Subscribable
     end
 
     def static_subscriber_namespace
-      unless Reactor::StaticSubscribers.const_defined?(self.name, false)
-        Reactor::StaticSubscribers.const_set(self.name, Module.new)
+      ns = self.name.demodulize
+      unless Reactor::StaticSubscribers.const_defined?(ns, false)
+        Reactor::StaticSubscribers.const_set(ns, Module.new)
       end
 
-      Reactor::StaticSubscribers.const_get(self.name, false)
+      Reactor::StaticSubscribers.const_get(ns, false)
     end
   end
 end

data/lib/reactor/version.rb

@@ -1,3 +1,3 @@
 module Reactor
-  VERSION = "0.11.0"
+  VERSION = "0.11.1"
 end

data/spec/models/concerns/subscribable_spec.rb

@@ -24,6 +24,17 @@ class Auction < ActiveRecord::Base
   end
 end
 
+module MyNamespace
+  class MyClass
+    include Reactor::Subscribable
+    on_event :rain, :umbrella
+  end
+
+  def self.umbrella
+    puts 'get an umbrella'
+  end
+end
+
 Reactor.in_test_mode do
   class TestModeAuction < ActiveRecord::Base
     on_event :test_puppy_delivered, -> (event) { "success" }
@@ -45,6 +56,10 @@ describe Reactor::Subscribable do
         expect(Reactor::SUBSCRIBERS['puppy_delivered'][0]).to eq(Reactor::StaticSubscribers::Auction::PuppyDeliveredHandler)
         expect(Reactor::SUBSCRIBERS['puppy_delivered'][1]).to eq(Reactor::StaticSubscribers::Auction::DoNothingHandler)
       end
+
+      it 'adds a static subscriber for namespaced classes' do
+        expect(Reactor::SUBSCRIBERS['rain'][0]).to eq(Reactor::StaticSubscribers::MyClass::RainHandler)
+      end
     end
 
     describe 'binding symbol of class method' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reactor
 version: !ruby/object:Gem::Version
-  version: 0.11.0
+  version: 0.11.1
 platform: ruby
 authors:
 - winfred
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-11 00:00:00.000000000 Z
+date: 2016-03-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sidekiq