reactor 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0a4ebfd7804d09982d8a0f41393dc6f66e9631fb
-  data.tar.gz: 64432277671680520c27306e2bc45c5e5c58b044
+  metadata.gz: 3f30c15c4574595a8879b7dd9a6058605dad0ad1
+  data.tar.gz: 14ae0caff4f4487d87be51e55e0408811ca7f576
 SHA512:
-  metadata.gz: c813a25c6be9cb5fba1cfa19adeb00d4573026d3dd60e574450dd834bb54c6a904a9d3c0c5b5a9a6273dc19061ec31050dc363f64ca57ea67b5b40ea5564d976
-  data.tar.gz: 802c5f3fa50a9e8a5dfa3f051c682b8a208c6a67b1b8109c15d15be92c214652dca1400c26050e510ee99fa180ecfa133ab59342b21ec5b93d21ab2dfe44c623
+  metadata.gz: 74d22941c9ead4ab5ec852d77f9ffce49c0045947a9ed993cfabf4ab47b98ff225db226566458faa74f6c4ea73071aec62c10eb24f1724835cae4dd87b7f50a5
+  data.tar.gz: 90e8a390c1128c75e3bb93bd35e47c1b16e3d784bb540f59a9c5b787318058aba0d592cf6c34174360fba11d6db74665c0966cfa8c8c993d9116a997ef9e7a34

data/lib/reactor/event.rb

@@ -40,6 +40,7 @@ class Reactor::Event
   end
 
   def self.process(name, data)
+    # fire database listeners
     Reactor::Subscriber.where(event: name.to_s).each do |subscriber|
       Reactor::Subscriber.delay.fire subscriber.id, data
     end

data/lib/reactor/models/concerns/eventable.rb

@@ -2,8 +2,8 @@ module Reactor::Eventable
   extend ActiveSupport::Concern
 
   included do
-    after_create :schedule_events
-    after_update :reschedule_events
+    after_commit :schedule_events, if: :persisted?, on: :create
+    after_commit :reschedule_events, if: :persisted?, on: :update
   end
 
   def publish(name, data = {})
@@ -24,15 +24,16 @@ module Reactor::Eventable
 
   def schedule_events
     self.class.events.each do |name, data|
-      Reactor::Event.delay.publish name, data.merge(
-        at: send(data[:at]), actor: self
+      data = data.merge(
+          at: ( data[:at] ? send(data[:at]) : nil), actor: self
       ).except(:watch)
+      Reactor::Event.delay.publish name, data
     end
   end
 
   def reschedule_events
     self.class.events.each do |name, data|
-      if send("#{data[:watch] || data[:at]}_changed?")
+      if data[:at] && send("#{data[:watch] || data[:at]}_changed?")
         Reactor::Event.delay.reschedule name,
           at: send(data[:at]),
           actor: self,

data/lib/reactor/version.rb

@@ -1,3 +1,3 @@
 module Reactor
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/spec/models/concerns/eventable_spec.rb

@@ -1,20 +1,47 @@
 require 'spec_helper'
 
 class Auction < ActiveRecord::Base
-  def ring_timeout(was: false)
-    created_at + (was ? 10.seconds : 30.seconds)
+  def ring_timeout
+    created_at + 30.seconds
   end
 
+  def ring_timeout_was
+    created_at + 10.seconds
+  end
+
+  publishes :bell
   publishes :ring, at: :ring_timeout, watch: :name
 end
 
+class TestSubscriber < Reactor::Subscriber
+
+  on_fire do
+    @@called = true
+  end
+end
+
 describe Reactor::Eventable do
   describe 'publish' do
-    let(:auction) { Auction.create }
+    let(:auction) { Auction.create! }
 
     it 'publishes an event with actor_id and actor_type set as self' do
-      Reactor::Event.should_receive(:publish).with(:an_event, {what: 'the', actor: auction}).twice
+      auction
+      Reactor::Event.should_receive(:publish) do |name, data|
+        name.should == :an_event
+        data[:what].should == 'the'
+        data[:actor].should == auction
+      end
       auction.publish(:an_event, {what: 'the'})
     end
+
+    it 'supports immediate events (on create) that get fired once' do
+      TestSubscriber.create! event: :bell
+      auction
+      TestSubscriber.class_variable_get(:@@called).should be_true
+      TestSubscriber.class_variable_set(:@@called, false)
+      auction.start_at = 1.day.from_now
+      auction.save
+      TestSubscriber.class_variable_get(:@@called).should be_false
+    end
   end
 end

data/spec/models/subscriber_spec.rb

@@ -22,36 +22,6 @@ describe Reactor::Subscriber do
   end
 
   describe '.subscribes_to class helper' do
-    #describe 'ensuring subscriber exists and is tied to event' do
-    #  it 'binds 1-1 when name given' do
-    #    expect {
-    #      MySubscriber.class_eval do
-    #        subscribes_to :event_times
-    #      end
-    #    }.to change { Reactor::Subscriber.count }.by(1)
-    #  end
-    #
-    #  context 'binds to all when star is given' do
-    #    after { MySubscriber.destroy_all }
-    #
-    #    it 'creates new subscriber' do
-    #      expect {
-    #        MySubscriber.class_eval do
-    #          subscribes_to '*'
-    #        end
-    #      }.to change { Reactor::Subscriber.count }.by(1)
-    #    end
-    #
-    #    it 'doesnt create' do
-    #      MySubscriber.where(event: '*').first_or_create!
-    #      expect {
-    #        MySubscriber.class_eval do
-    #          subscribes_to '*'
-    #        end
-    #      }.to change { Reactor::Subscriber.count }.by(0)
-    #    end
-    #  end
-    #end
   end
 
   describe 'matcher' do

data/spec/spec_helper.rb

@@ -6,6 +6,7 @@ require 'support/active_record'
 require 'sidekiq'
 require 'sidekiq/testing/inline'
 require 'reactor'
+require 'reactor/testing/matchers'
 
 Sidekiq.configure_server do |config|
   config.redis = { url: ENV["REDISTOGO_URL"] }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reactor
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - winfred
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-01 00:00:00.000000000 Z
+date: 2013-07-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler