reactive-ruby 0.7.38 → 0.7.39

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 23600ed81f6cdbfd4492addb059c2fc226147f32
-  data.tar.gz: 7ae2faaeacc75627e86614168cd7a79f250165a8
+  metadata.gz: 0cea406dc7bbeab7ecb30d5ce6656b560fa5e666
+  data.tar.gz: d9ff3e6794442ed3f443de03e4a2e84f611c4f32
 SHA512:
-  metadata.gz: b56872543b2db22c8b3682de518415f84a7753c0402365cbf39679d13aa5e16d7c65ae756d92917646cd51283d05671aeef33d85e662a2e82ef63cd9c60991fc
-  data.tar.gz: 787ef02379630312653277931881a916f8183f9998f634fb01545b78083102518e63de11fb120dcde63f70ac8ccdae318e8a7874410b2bd994316bb1dd9ebe33
+  metadata.gz: 41ee7e60bf8c39e39942e8d9976601f7f85ccb24835e3e2b013f94113ad469af2e9e283394f15ec7a558d8c5b3df474bff2dbe80657bb472f2e20ddf27055af3
+  data.tar.gz: 49a1603e9b00ee55bd9f4c4b4781031250e7c35c24c3485aeefb4063ad65f6198b862f4aed7bf6d0693df37766b2401dff6b05cea866e978102ea85f66fad376

data/lib/react/component.rb

@@ -179,7 +179,7 @@ module React
 
     def component_will_update(next_props, next_state)
       State.set_state_context_to(self) { self.run_callback(:before_update, Hash.new(next_props), Hash.new(next_state)) }
-      @props_wrapper = self.class.props_wrapper.new(Hash.new(next_props))
+      @props_wrapper = self.class.props_wrapper.new(Hash.new(next_props), @props_wrapper)
     rescue Exception => e
       self.class.process_exception(e, self)
     end

data/lib/react/component/props_wrapper.rb

@@ -33,23 +33,39 @@ module React
           end
         else
           define_method("#{name}") do
-            @processed_params[name] ||= if param_type.respond_to? :_react_param_conversion
-              param_type._react_param_conversion props[name]
-            elsif param_type.is_a?(Array) &&
-              param_type[0].respond_to?(:_react_param_conversion)
-              props[name].collect do |param|
-                param_type[0]._react_param_conversion param
-              end
+            if @processed_params.has_key? name
+              @processed_params[name]
             else
-              props[name]
+              @processed_params[name] = if param_type.respond_to? :_react_param_conversion
+                param_type._react_param_conversion props[name]
+              elsif param_type.is_a?(Array) &&
+                param_type[0].respond_to?(:_react_param_conversion)
+                props[name].collect do |param|
+                  param_type[0]._react_param_conversion param
+                end
+              else
+                props[name]
+              end
             end
           end
         end
       end
 
-      def initialize(props)
+      def unchanged_processed_params(new_props)
+        Hash[
+          *@processed_params.collect do |key, value|
+            [key, value] if @props[key] == new_props[key]
+          end.compact.flatten(1)
+        ]
+      end
+
+      def initialize(props, current_props_wrapper=nil)
         @props = props || {}
-        @processed_params = {}
+        @processed_params = if current_props_wrapper
+          current_props_wrapper.unchanged_processed_params(props)
+        else
+          {}
+        end
       end
 
       def [](prop)

data/lib/reactive-ruby/version.rb

@@ -1,3 +1,3 @@
 module React
-  VERSION = "0.7.38"
+  VERSION = "0.7.39"
 end

data/spec/react/param_declaration_spec.rb

@@ -195,25 +195,55 @@ describe 'the param macro' do
       expect(`window.dummy_log`).to eq(["Warning: Failed propType: In component `Foo`\nProvided prop `foo` could not be converted to BazWoggle"])
     end
 
-    it "can will only convert once" do
-      stub_const "BazWoggle", Class.new
-      BazWoggle.class_eval do
-        def initialize(kind)
-          @kind = kind
+    describe "converts params only once" do
+
+      it "not on every access" do
+        stub_const "BazWoggle", Class.new
+        BazWoggle.class_eval do
+          def initialize(kind)
+            @kind = kind
+          end
+          attr_accessor :kind
+          def self._react_param_conversion(json, validate_only)
+            new(json[:bazwoggle]) if json[:bazwoggle]
+          end
         end
-        attr_accessor :kind
-        def self._react_param_conversion(json, validate_only)
-          new(json[:bazwoggle]) if json[:bazwoggle]
+        Foo.class_eval do
+          param :foo, type: BazWoggle
+          def render
+            params.foo.kind = params.foo.kind+1
+            "#{params.foo.kind}"
+          end
         end
+        expect(React.render_to_static_markup(React.create_element(Foo, foo: {bazwoggle: 1}))).to eq('<span>2</span>')
       end
-      Foo.class_eval do
-        param :foo, type: BazWoggle
-        def render
-          params.foo.kind = params.foo.kind+1
-          "#{params.foo.kind}"
+
+      it "not after state update" do
+        stub_const "BazWoggle", Class.new
+        BazWoggle.class_eval do
+          def initialize(kind)
+            @kind = kind
+          end
+          attr_accessor :kind
+          def self._react_param_conversion(json, validate_only)
+            new(json[:bazwoggle]) if json[:bazwoggle]
+          end
+        end 
+        Foo.class_eval do
+          param :foo, type: BazWoggle
+          export_state :change_me
+          before_mount do
+            params.foo.kind = params.foo.kind+1
+          end
+          def render
+            "#{params.foo.kind} - #{Foo.change_me}"
+          end
         end
+        div = `document.createElement("div")`
+        React.render(React.create_element(Foo, foo: {bazwoggle: 1}), div)
+        Foo.change_me! "updated"
+        expect(`div.children[0].innerHTML`).to eq("2 - updated")
       end
-      expect(React.render_to_static_markup(React.create_element(Foo, foo: {bazwoggle: 1}))).to eq('<span>2</span>')
     end
 
     it "will alias a Proc type param" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: reactive-ruby
 version: !ruby/object:Gem::Version
-  version: 0.7.38
+  version: 0.7.39
 platform: ruby
 authors:
 - David Chang
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-30 00:00:00.000000000 Z
+date: 2016-02-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: opal