react_webpack_rails 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b7b168e4c9e7963d9286b677dfda26cb75faf04f
-  data.tar.gz: e7c801d0011fc8a2a4ae35dbf1b35af41b4ab4de
+  metadata.gz: 63660480d9bc4607d4ed78cf2f51224cabf6ffbb
+  data.tar.gz: 7a2c1e3d02812e344fee8d76a851de4d51f1df90
 SHA512:
-  metadata.gz: d89a10bb7c891f157a382fbb6c6865043ff142db3094ee6cea4ca714c990ca2af203d2ed62252677891d64683fa1ac3f57ad7644ada1eb37019a7817b21a023f
-  data.tar.gz: 711c3ce95858e08945893afc8e13d5068cbef85bcf13b08fa65ad63da40b2f10e488c96f1b0ca5a0ebaff0a2e839b72fb210250f7f90b20be13ea3690ec9d216
+  metadata.gz: d341a43a62f93cfdcadfbb15e3ea6a871c9e6bd616d906f7518b5b9dc77553fb429fa72f53f358ca5e83bd1e4576c6d78e19b156a5f363eda815ee3abc973d26
+  data.tar.gz: b6f51b56c5962acb48aeaffb74fdc156cf98c876b48b0f717d49c41eca405e54f8d21cf045febebe6767c520c7e8bf9522f2c3fb497d09207bee93a18785f57f

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.3.1
+* show depreciation warning only when integrations/react-router is used
+* throw an error when integration is missing
+
 ## 0.3.0
 * move integration with react-router to external plugin: https://github.com/netguru/rwr-react_router
 * add redux integration by external plugin: https://github.com/netguru/rwr-redux

data/README.md

@@ -18,6 +18,7 @@ See [0.3-stable](https://github.com/netguru/react_webpack_rails/tree/0.3-stable)
 ### Plugins:
 * [rwr-alt](https://github.com/netguru/rwr-alt) plugin that makes it possible to populate and share Alt stores between react component located in different parts of rails views.
 * [rwr-redux](https://github.com/netguru/rwr-redux) allows to use redux state containers in a rails views.
+* [rwr-react_router](https://github.com/netguru/rwr-react_router) react-router integration.
 
 ## Installation
 

data/js/src/integrations/react-router.js

@@ -2,13 +2,13 @@ import ReactDOM from 'react-dom';
 
 function deprecationWarning() {
   if (typeof console !== 'undefined' && console.warn) {
-      const msg = [
-        'Deprecation warning - since v0.3.0: current integration with react-router was extracted and moved to external plugin.',
-        'Use https://github.com/netguru/rwr-react_router instead.'
-      ]
+    const msg = [
+      'Deprecation warning - since v0.3.0: current integration with react-router was extracted and moved to external plugin.',
+      'Use https://github.com/netguru/rwr-react_router instead.',
+    ];
 
-      console.warn(msg.join('\n'));
-    }
+    console.warn(msg.join('\n'));
+  }
 }
 
 class ReactRouterIntegration {
@@ -18,10 +18,10 @@ class ReactRouterIntegration {
     this.registerRouter = this.registerRouter.bind(this);
     this.getRouter = this.getRouter.bind(this);
     this.renderRouter = this.renderRouter.bind(this);
-    deprecationWarning();
   }
 
   registerRouter(name, route) {
+    deprecationWarning();
     this.routers[name] = route;
   }
 

data/js/src/integrations-manager.js

@@ -10,8 +10,14 @@ class IntegrationsManager {
   }
 
   get(name) {
-    // handle missing one here;
-    return this.integrations[name];
+    const integration = this.integrations[name];
+    if (integration === undefined) {
+      throw new Error(
+        `Missing '${name}' integration, register appropriate integration in react/index.js`
+      );
+    }
+
+    return integration;
   }
 
   register(name, integration) {

data/js/src/version.js

@@ -1 +1 @@
-export default '0.3.0';
+export default '0.3.1';

data/js/test/integrations-manager.spec.js

@@ -23,8 +23,12 @@ describe('IntegrationsManager', function () {
       );
     });
 
-    it('returns undefined if name is invalid', function () {
-      expect(subject.get('invalidName')).toBe(undefined);
+    it('throws an error if name is invalid', function () {
+      const errorMsg = (
+        "Missing 'invalidName' integration, register appropriate integration in react/index.js"
+      );
+
+      expect(() => subject.get('invalidName')).toThrow(errorMsg);
     });
   });
 

data/lib/react_webpack_rails/version.rb

@@ -1,3 +1,3 @@
 module ReactWebpackRails
-  VERSION = '0.3.0'
+  VERSION = '0.3.1'
 end

data/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-webpack-rails",
-  "version": "0.2.1",
+  "version": "0.3.1",
   "description": "Js part of react_webpack_rails - webpack based React & Rails integration.",
   "main": "js/lib/index.js",
   "files": [

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: react_webpack_rails
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Rafał Gawlik
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-03-23 00:00:00.000000000 Z
+date: 2016-03-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler