react_on_rails_pro 16.2.0.beta.19 → 16.2.0.rc.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '0948b2364bf24887f838e2f27fc5ed8b1d8b79bc353501d9d13b05bc1678ad24'
-  data.tar.gz: f15f10243f24c7f66211d9cf281428be7657aab395b862110e4ce4b303eaecfd
+  metadata.gz: 8a646e0fc2f72d012e57cf12d2f3439e226ac56e176705a2934ef824b29d4236
+  data.tar.gz: cfe6963cd813e7a885e30a11fb2d8f2b28adb3a4943ebcc6ddebd140f72042e9
 SHA512:
-  metadata.gz: 15850fdf3f3d8b756f213e864ab0d245c7d941fa18d6eae9005cc4f49b8007e73e409a2a748d0e422ddcea504a741cc9d6191dc5d17652736b4ce91b15f5f1dd
-  data.tar.gz: 250fb9336012cd4ece659212cd076503d30d7959f148581d16fa26ed32eb09e584dab20272614d44b27afbcd15c489656dbd5289fea969045c4197e66d488aa9
+  metadata.gz: 23900984ebb5758264088d9bcfa0c05341ce1b586702927f715aaa6b98794545df1b2ff1de92b548b5f16a8cbdc622dea8b8816c7c47269f0c161a302339e17f
+  data.tar.gz: 351b76344a8ea9477ac553249407678e71ab535ae1687df3c1318528042902f72cca662c16ecbd749ce1948ad13dc3710502bd1f8a9bce78a1ff678aa5de2d5b

data/CHANGELOG.md

@@ -50,6 +50,8 @@ Changes since the last non-beta release.
 
 ### Fixed
 
+- **Thread-Safe Connection Management**: Fixed race conditions in `ReactOnRailsPro::Request` connection management. The lazy initialization (`@connection ||= create_connection`) was not atomic, allowing multiple threads to create duplicate connections at startup. Now uses a mutex with double-checked locking pattern for thread-safe initialization while maintaining lock-free reads for optimal performance. [PR 2259](https://github.com/shakacode/react_on_rails/pull/2259) by [AbanoubGhadban](https://github.com/AbanoubGhadban).
+
 - **SECURITY: CVE-2025-55182 - React Server Components RCE Vulnerability**: by updating `react-on-rails-rsc` peer dependency to `v19.0.3` which mitigates that vulnerability. Also, users should update `react` and `react-dom` package versions to `v19.0.1` to ensure complete mitigation. [PR 2175](https://github.com/shakacode/react_on_rails/pull/2175) by [AbanoubGhadban](https://github.com/AbanoubGhadban).
 
 - Fixed compatibility issue with httpx 1.6.x by explicitly requiring http-2 >= 1.1.1. [PR 2141](https://github.com/shakacode/react_on_rails/pull/2141) by [AbanoubGhadban](https://github.com/AbanoubGhadban).
@@ -102,7 +104,7 @@ Changes since the last non-beta release.
   - Seamlessly use React Server Components in your Rails apps
   - Reduce client bundle sizes
   - Enable powerful new patterns for data fetching
-  - [See the full tutorial](https://www.shakacode.com/react-on-rails-pro/docs/react-server-components-tutorial)
+  - [See the full tutorial](https://www.shakacode.com/react-on-rails-pro/docs/react-server-components/tutorial)
 
 [PR 422](https://github.com/shakacode/react_on_rails_pro/pull/422) by [AbanoubGhadban](https://github.com/AbanoubGhadban).
 

data/CONTRIBUTING.md

@@ -4,34 +4,36 @@
 
 Install [yalc](https://github.com/wclr/yalc).
 
-
 ```sh
+pnpm install -r
 cd react_on_rails_pro
-bundle && yarn && cd spec/dummy && bundle && yarn
+bundle && cd spec/dummy && bundle && pnpm install
 ```
+
 To use the `React 18 Apollo with GraphQL` example you need to seed the testing database inside `spec/dummy` directory.
+
 ```sh
 rake db:seed
 ```
 
-
 See the example apps under `/spec`
 
 ## Summary
 
 For non-doc fixes:
 
-* Provide changelog entry in the [unreleased section of the CHANGELOG.md](https://github.com/shakacode/react_on_rails_pro/blob/master/CHANGELOG.md#unreleased).
-* Ensure CI passes and that you added a test that passes with the fix and fails without the fix.
-* Squash all commits down to one with a nice commit message *ONLY* once final review is given. Make sure this single commit is rebased on top of master.
-* Please address all code review comments.
-* Ensure that docs are updated accordingly if a feature is added.
+- Provide changelog entry in the [unreleased section of the CHANGELOG.md](https://github.com/shakacode/react_on_rails_pro/blob/master/CHANGELOG.md#unreleased).
+- Ensure CI passes and that you added a test that passes with the fix and fails without the fix.
+- Squash all commits down to one with a nice commit message _ONLY_ once final review is given. Make sure this single commit is rebased on top of master.
+- Please address all code review comments.
+- Ensure that docs are updated accordingly if a feature is added.
 
 ## Commit Messages
 
 From [How to Write a Git Commit Message](http://chris.beams.io/posts/git-commit/)
 
-#### The seven rules of a great git commit message
+### The seven rules of a great git commit message
+
 > Keep in mind: This has all been said before.
 
 1. Separate subject from body with a blank line
@@ -42,21 +44,21 @@ From [How to Write a Git Commit Message](http://chris.beams.io/posts/git-commit/
 1. Wrap the body at 72 characters
 1. Use the body to explain what and why vs. how
 
-
 ## Doc Changes
 
-When making doc changes, we want the change to work on both https://www.shakacode.com/react-on-rails-pro/docs/ and when browsing the GitHub repo. 
+When making doc changes, we want the change to work on both [the ShakaCode docs site](https://www.shakacode.com/react-on-rails-pro/docs/) and when browsing the GitHub repo.
 The issue is that the Shakacode site is generated only from files in [`docs`](./docs), so any references from them to non-doc files must use the full GitHub URL.
 
 ### Links to other docs:
-* When making references to doc files, use a relative URL path like:
-`[Installation Overview](docs/basics/installation-overview.md)`
 
-* When making references to source code files, use a full url path like:
-`[spec/dummy/config/initializers/react_on_rails.rb](https://github.com/shakacode/react_on_rails_pro/tree/master/spec/dummy/config/initializers/react_on_rails.rb)`
+- When making references to doc files, use a relative URL path like:
+  `[Installation Overview](docs/basics/installation-overview.md)`
 
+- When making references to source code files, use a full url path like:
+  `[spec/dummy/config/initializers/react_on_rails.rb](https://github.com/shakacode/react_on_rails_pro/tree/master/spec/dummy/config/initializers/react_on_rails.rb)`
 
 ## To run tests:
+
 See [Run NPM JS tests](#run-npm-js-tests) for the JS tests and [RSpec Testing](#rspec-testing) for the Ruby tests.
 
 See [Dev Initial Setup](#dev-initial-setup) below for, well... initial setup.
@@ -107,30 +109,33 @@ script/ci-changes-detector origin/master
 ### CI Best Practices for Pro
 
 ✅ **DO:**
+
 - Run `bin/ci-local` from repository root before pushing
 - Test Pro changes alongside main gem changes if modifying both
 - Use `bin/ci-local --fast` during rapid iteration
 
 ❌ **DON'T:**
+
 - Push Pro changes without testing locally first
 - Modify both Pro and main gem without running full tests
 
 For comprehensive CI documentation, see [`../docs/CI_OPTIMIZATION.md`](../docs/CI_OPTIMIZATION.md) in the repository root.
 
 # IDE/Editor Setup
-It's critical to configure your IDE/editor to ignore certain directories. Otherwise your IDE might slow to a crawl!
 
-* /coverage
-* /tmp
-* /node_modules
-* /spec/dummy/app/assets/webpack
-* /spec/dummy/log
-* /spec/dummy/node_modules
-* /spec/dummy/client/node_modules
-* /spec/dummy/tmp
+It's critical to configure your IDE/editor to ignore certain directories. Otherwise your IDE might slow to a crawl!
 
+- /coverage
+- /tmp
+- /node_modules
+- /spec/dummy/app/assets/webpack
+- /spec/dummy/log
+- /spec/dummy/node_modules
+- /spec/dummy/client/node_modules
+- /spec/dummy/tmp
 
 # Configuring your test app to use your local fork
+
 You can test the `react_on_rails_pro` gem using your own external test_app or the gem's internal `spec/dummy` app. The `spec/dummy` app is an example of the various setup techniques you can use with the gem.
 As of 2018-04-28, this directory mirrors the test app spec/dummy on https://github.com/shakacode/react_on_rails plus a few additional tests.
 
@@ -143,15 +148,17 @@ As of 2018-04-28, this directory mirrors the test app spec/dummy on https://gith
 ```
 
 ## Testing the Ruby Gem
+
 If you want to test the ruby parts of the gem with an application before you release a new version of the gem, you can specify the path to your local version via your test app's Gemfile:
 
 ```ruby
 gem "react_on_rails_pro", path: "../path-to-react_on_rails_pro"
 gem "react_on_rails"
 ```
+
 ================================================================================
 
-Set `config.server_renderer = "NodeRenderer"` in your  `ReactOnRailsPro.configure` block in the initializer.
+Set `config.server_renderer = "NodeRenderer"` in your `ReactOnRailsPro.configure` block in the initializer.
 
 After making this change, run `bundle install`.
 
@@ -159,6 +166,7 @@ After making this change, run `bundle install`.
 > You will need to restart your Rails application if you make any changes to the gem.
 
 ## Testing the Node package for react_on_rails_pro
+
 In addition to testing the Ruby parts out, you can also test the node package parts of the gem with an external application.
 
 To do this, follow the instructions in the
@@ -166,19 +174,21 @@ To do this, follow the instructions in the
 
 ### Example: Testing NPM changes with the dummy app
 
-1. Add `console.log('Hello!')` [here](https://github.com/shakacode/react_on_rails_pro/blob/more_test_and_docs/packages/node-renderer/src/ReactOnRailsProNodeRenderer.js#L6) in `packages/node-renderer/src/ReactOnRailsProNodeRenderer.js` to confirm we're getting an update to the node package.
-2. The `preinstall` script of `spec/dummy` builds the NPM package and sets up `yalc` to use it for the renderer. 
-   It's run automatically when you run `yarn install`. 
+1. Add `console.log('Hello!')` [here](https://github.com/shakacode/react_on_rails_pro/blob/master/packages/node-renderer/src/ReactOnRailsProNodeRenderer.ts#L6) in `packages/node-renderer/src/ReactOnRailsProNodeRenderer.ts` to confirm we're getting an update to the node package.
+2. The `preinstall` script of `spec/dummy` builds the NPM package and sets up `yalc` to use it for the renderer.
+   It's run automatically when you run `pnpm install`.
 3. Refresh the browser if the server is already running or start the server using `foreman start -f Procfile.dev` from `spec/dummy` and navigate to `http://localhost:3000/`. You will now see the `Hello!` message printed in the browser's console.
 
+<!-- prettier-ignore -->
 > [!NOTE]
 > `yalc` makes the NPM package available globally on the machine.
 > So, if you have the repo checked out more than once to compare behavior between branches,
-> make sure to run `yarn install` every time you switch to a new copy.
+> make sure to run `pnpm install` every time you switch to a new copy.
 
 # Development Setup for Gem and Node Package Contributors
 
 ## Checklist before Committing
+
 1. Run all JS tests, dummy app tests and linters.
 2. Did you need any more tests for your change?
 3. Did you document your change? Update the README.md?
@@ -186,12 +196,13 @@ To do this, follow the instructions in the
 ## Dev Initial Setup
 
 ### Prereqs
-After checking out the repo, making sure you have rvm and nvm setup (setup ruby and node), cd to `spec/dummy` and run `bin/setup` to install ruby dependencies. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
 
+After checking out the repo, making sure you have rvm and nvm setup (setup ruby and node), cd to `spec/dummy` and run `bin/setup` to install ruby dependencies. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
 
 ### Building the Node Package for Development
 
 At the root:
+
 ```
 nps build
 ```
@@ -207,6 +218,7 @@ This is a possible update to package.json to debug the lockfile. Notice the `NOD
 See https://nodejs.org/api/util.html#util_util_debuglog_section for details on `debuglog`.
 
 ### Local Node Package
+
 Because the example and dummy apps rely on the `react_on_rails_pro` node package, they should link directly to your local version to pick up any changes you may have made to that package.
 To achieve this, you can use `yalc`.
 The easy way to do this is to run the command below in the dummy app root directory.
@@ -215,11 +227,11 @@ For more information check the script section of the
 
 ```sh
 cd spec/dummy
-yarn install
+pnpm install -r
 ```
 
 > [!NOTE]
-> This runs npm under the hood as explained in the **Test NPM for react_on_rails_pro** section above.
+> This uses yalc under the hood as explained in the **Example: Testing NPM changes with the dummy app** section above.
 
 From now on, the example and dummy apps will use your local packages/node-renderer folder as the `react_on_rails_pro` node package.
 
@@ -227,51 +239,55 @@ From now on, the example and dummy apps will use your local packages/node-render
 
 ```sh
 cd react_on_rails_pro
-yarn install
+pnpm install -r
 ```
 
-Or run this, which builds the yarn package, then the webpack files for spec/dummy, and finally runs tests in
+Or run this, which builds the pnpm package, then the webpack files for spec/dummy, and finally runs tests in
 spec/dummy.
 
-
 ```sh
 # Optionally change default selenium_firefox driver
 # export DRIVER=poltergeist
 cd react_on_rails_pro
-yarn run dummy:spec
+pnpm run dummy:spec
 ```
 
 ### Run NPM JS tests
 
 ```sh
 cd react_on_rails_pro
-yarn test
+pnpm test
 ```
 
 ### Debugging NPM JS tests
 
 Example of using ndb to debug a test
+
 ```bash
-ndb $(yarn bin)/jest --runInBand  packages/node-renderer/tests/**/*.test.[jt]s -t 'FriendsAndGuests bundle for commit 1a7fe417'
+ndb $(pnpm bin)/jest --runInBand  packages/node-renderer/tests/**/*.test.[jt]s -t 'FriendsAndGuests bundle for commit 1a7fe417'
 ```
+
 Hit F8 and then a debugger statement within the test will get hit.
 
 ### Creating new VM tests
+
 1. copy a server bundle to `packages/node-renderer/tests/fixtures/projects/<project-name>/<commit>`
 2. create a directory with a hash representing the commit of the project
 
 ### Async issues with Jest
+
 Beware that Jest runs multiple test files synchronously, so you can't use the same temporary directory
-between tests. See the file [`packages/node-renderer/tests/helper.ts`](packages/node-renderer/tests/helper.ts) for how we handle this.
+between tests. See the file [`packages/node-renderer/tests/helper.ts`](https://github.com/shakacode/react_on_rails_pro/blob/master/packages/node-renderer/tests/helper.ts) for how we handle this.
 
 ### Run most tests and linting
 
 ```sh
 cd react_on_rails_pro
-yarn run check
+pnpm run check
 ```
 
 ### Starting the Dummy App
+
 Before running the dummy app,
 you need to generate JavaScript packs in the dummy app project.
 To do this,
@@ -298,15 +314,17 @@ Before running Ruby tests ensure you have done the following steps in `spec/dumm
 
 ```sh
 # in the root directory
+pnpm install -r
+
+cd react_on_rails
 bundle install
-yarn install
 
 cd spec/dummy
 
 bundle install
 bundle exec rake react_on_rails:generate_packs
 
-yarn install
+pnpm install -r
 
 RAILS_ENV=test bin/shakapacker # to generate assets for test environment
 ```
@@ -315,7 +333,7 @@ Then in a separate terminal, run the following to run the Node renderer and the
 
 ```sh
 # in spec/dummy directory
-yarn run node-renderer
+pnpm run node-renderer
 RAILS_ENV=test bin/dev&
 ```
 
@@ -330,6 +348,7 @@ If you run `rspec` at the top level, you'll see this message: `require': cannot
 After running a test, you can view the coverage results in SimpleCov reports by opening `coverage/index.html`.
 
 ### Debugging
+
 Start the sample app like this for some debug printing:
 
 ```sh
@@ -350,6 +369,7 @@ Contact Justin Gordon, [justin@shakacode.com](mailto:justin@shakacode.com) for r
 You need authentication for public package registries:
 
 **Public packages (npmjs.org + rubygems.org):**
+
 - NPM: Run `npm login`
 - RubyGems: Standard credentials via `gem push`
 
@@ -372,5 +392,6 @@ rake release[17.0.0,false,verdaccio]
 ```
 
 For complete documentation, see:
+
 - [Root Release Documentation](../docs/contributor-info/releasing.md)
 - Run `rake -D release` for inline help

data/Gemfile.lock

@@ -9,7 +9,7 @@ GIT
 PATH
   remote: ..
   specs:
-    react_on_rails (16.2.0.beta.19)
+    react_on_rails (16.2.0.rc.0)
       addressable
       connection_pool
       execjs (~> 2.5)
@@ -20,7 +20,7 @@ PATH
 PATH
   remote: .
   specs:
-    react_on_rails_pro (16.2.0.beta.19)
+    react_on_rails_pro (16.2.0.rc.0)
       addressable
       async (>= 2.6)
       connection_pool
@@ -29,7 +29,7 @@ PATH
       httpx (~> 1.5)
       jwt (~> 2.7)
       rainbow
-      react_on_rails (= 16.2.0.beta.19)
+      react_on_rails (= 16.2.0.rc.0)
 
 GEM
   remote: https://rubygems.org/
@@ -336,7 +336,7 @@ GEM
     regexp_parser (2.9.2)
     reline (0.6.3)
       io-console (~> 0.5)
-    rexml (3.3.9)
+    rexml (3.4.4)
     rspec-core (3.13.0)
       rspec-support (~> 3.13.0)
     rspec-expectations (3.13.1)

data/README.md

@@ -3,7 +3,7 @@
 [![License](https://img.shields.io/badge/license-Commercial-blue.svg)](./LICENSE)
 [![Build Integration Tests](https://github.com/shakacode/react_on_rails/actions/workflows/pro-integration-tests.yml/badge.svg)](https://github.com/shakacode/react_on_rails/actions/workflows/pro-integration-tests.yml)
 [![Build Lint](https://github.com/shakacode/react_on_rails/actions/workflows/pro-lint.yml/badge.svg)](https://github.com/shakacode/react_on_rails/actions/workflows/pro-lint.yml)
-[![Build Package Tests](https://github.com/shakacode/react_on_rails/actions/workflows/pro-package-tests.yml/badge.svg)](https://github.com/shakacode/react_on_rails/actions/workflows/pro-package-tests.yml)
+[![Build Package Tests](https://github.com/shakacode/react_on_rails/actions/workflows/pro-test-package-and-gem.yml/badge.svg)](https://github.com/shakacode/react_on_rails/actions/workflows/pro-test-package-and-gem.yml)
 
 **Performance enhancements and advanced features for [React on Rails](https://github.com/shakacode/react_on_rails).**
 

data/docs/bundle-caching.md

@@ -1,16 +1,19 @@
 # Bundle Caching
 
 ## Why?
+
 Building webpack bundles is often time-consuming, and the same bundles are built many times.
 For example, you might build the production bundles during CI, then for a Review app, then
-for Staging, and maybe even for Production. Or you might want to deploy a small Ruby only
+for Staging, and maybe even for Production. Or you might want to deploy a small Ruby-only
 change to production, but you will have to wait minutes for your bundles to be built again.
 
 ## Solution
+
 React on Rails 2.1.0 introduces bundle caching based on a digest of all the source files, defined
 in the `config/shakapacker.yml` file, plus other files defined with `config.dependency_globs` and
 excluding any files from `config.excluded_dependency_globs`. Creating this hash key takes at most a
-few seconds for even large projects. Additionally, the cache key includes 
+few seconds for even large projects. Additionally, the cache key includes
+
 1. NODE_ENV
 2. Version of React on Rails Pro
 3. Configurable additional env values by supplying an array in method cache_keys on the `remote_bundle_cache_adapter`. See examples below.
@@ -18,6 +21,7 @@ few seconds for even large projects. Additionally, the cache key includes
 This cache key is used for saving files to some remote storage, typically S3.
 
 ## Bonus for local development with multiple directories building production builds
+
 Bundle caching can help save time if you have multiple directories for the same repository.
 
 The bundles are cached in `Rails.root.join('tmp', 'bundle_cache')`
@@ -32,6 +36,7 @@ ln -s ../../my_project/tmp/bundle_cache
 ## Configuration
 
 ### 1. React on Rails Configuration
+
 First, we need to tell React on Rails to use a custom build module. In
 `config/initializers/react_on_rails`, set this value:
 
@@ -49,7 +54,7 @@ ReactOnRails.configure do |config|
 end
 ```
 
-And define it like this:   
+And define it like this:
 
 ```ruby
 module CustomBuildCommand
@@ -61,6 +66,7 @@ end
 ```
 
 ### 2. React on Rails Pro Configuration
+
 Next, we need to configure the `config/initializers/react_on_rails_pro.rb` with some module,
 say called S3BundleCacheAdapter.
 
@@ -79,21 +85,26 @@ cached_react_component and cached_react_component_hash, add those as well to `co
 To simplify your configuration, entire directories can be added to `config.dependency_globs` & then any irrelevant files or subdirectories can be added to `config.excluded_dependency_globs`
 
 For example:
+
 ```ruby
   config.dependency_globs = [ File.join(Rails.root, "app", "views", "**", "*.jbuilder") ]
   config.excluded_dependency_globs = [ File.join(Rails.root, "app", "views", "**", "dont_hash_this.jbuilder") ]
 ```
+
 will hash all files in `app/views` that have the `jbuilder` extension except for any file named `dont_hash_this.jbuilder`.
 
 The goal is that Ruby only changes that don't affect your webpack bundles don't change the cache keys, and anything that could affect the bundles MUST change the cache keys!
 
 ### 3. Remove any call to rake task `react_on_rails_pro:pre_stage_bundle_for_node_renderer`
-This task is called automaticaly if you're using bundle caching.
+
+This task is called automatically if you're using bundle caching.
+
 ```ruby
   Rake::Task['react_on_rails_pro:pre_stage_bundle_for_node_renderer'].invoke
 ```
 
 #### Custom ENV cache keys
+
 Check your webpack config for the webpack.DefinePlugin. That allows JS code to use
 `process.env.MY_ENV_VAR` resulting in bundles that differ depending on the ENV value set.
 
@@ -115,12 +126,14 @@ Another use of the ENV values would be a cache version, so incrementing this ENV
 would force a new cache value.
 
 ## Disabling via an ENV value
+
 Once configured for bundle caching, ReactOnRailsPro::AssetsPrecompile's caching functionality
 can be disabled by setting ENV["DISABLE_PRECOMPILE_CACHE"] equal to "true"
 
 ### Examples of `remote_bundle_cache_adapter`:
 
 #### S3BundleCacheAdapter
+
 Example of a module for custom methods for the `remote_bundle_cache_adapter`.
 
 Note, S3UploadService is your own code that fetches and uploads.
@@ -140,7 +153,7 @@ class S3BundleCacheAdapter
   def self.cache_keys
     [Rails.env, ENV['SOME_ENV_VALUE']]
   end
-  
+
   # return value is unused
   # This command should build the bundles
   def self.build
@@ -153,8 +166,8 @@ class S3BundleCacheAdapter
     result = S3UploadService.new.fetch_object(zipped_bundles_filename)
     result.get.body.read if result
   end
-  
-  # Optional: method to return an array of extra files paths, that require caching. 
+
+  # Optional: method to return an array of extra files paths, that require caching.
   # These files get placed at the `extra_files` directory at the top of the zipfile
   # and are moved to the original places after unzipping the bundles.
   def self.extra_files_to_cache
@@ -180,6 +193,7 @@ end
 ```
 
 #### LocalBundleCacheAdapter
+
 Example of a module for custom methods for the `remote_bundle_cache_adapter` that does not save files
 remotely. Only local files are used.
 
@@ -189,7 +203,7 @@ class LocalBundleCacheAdapter
     # if no additional cache keys, return an empty array
     []
   end
-  
+
   def self.build
     Rake.sh(ReactOnRails::Utils.prepend_cd_node_modules_directory('yarn start build.prod').to_s)
   end