react_on_rails 9.0.0.beta.9 → 9.0.0.beta.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2ba6646e46775e165a0d0f7c8e43de2dad2eb1fc
-  data.tar.gz: c422212818cb28ef17dffd3a7da41410099dce0c
+  metadata.gz: 1b78d18af7d1cec47bbcbd58c3656487cbb800c0
+  data.tar.gz: d93af368b0c21769e0040f0665b09b6fbdc05eb6
 SHA512:
-  metadata.gz: bc8d53a1b6b89290382b2b12736116f33cf54d1bb7c8efb6f5b6ad45886bb534d4192709fb39fb7af11c2ae3ef0670477f36f8da7c9561ee835bc7efeb6e2b5d
-  data.tar.gz: 16e42224c49bbda250b2ecf3e23bb3eafb0d9f199d7991c0402433eafc48f38d8b4bb1175a35696493a54f244841f8c43e641e08e8107514943a8e05ade82656
+  metadata.gz: 262fb81eea87383f5bc2acd2a756eb5f73b1ac4835fd33b512bc3c202f1bffc1543ce7b11c9d4838fb1595dca6d8c8dafdbd5884f024001fa6e83db97752d65b
+  data.tar.gz: 3d630cbc5e0bdf911b79a1ee48f225357b64ec80b2f1017da76d18a9c4d30af9fc987daa518dc25db2d927036195a2be743a8a45fbe6591f914cc8712760b01f

data/CHANGELOG.md

@@ -57,6 +57,11 @@ gem "webpacker", git: "https://github.com/shakacode/webpacker.git",
   - Add a default setting
     ```
     custom_compile: true
+    cache_manifest: false
+    ```
+  - For production, set:  
+    ```
+    cache_manifest: true
     ```
   - Add a section like this under your development env:
     ```
@@ -86,6 +91,9 @@ gem "webpacker", git: "https://github.com/shakacode/webpacker.git",
 ### [9.0.0]
 *Diffs for the beta to master*
 
+### [9.0.0-beta.10]
+- Updated for the latest rails/webpacker. Added the cache_manifest setting.
+
 ### [9.0.0-beta.9]
 - Fixes precompile task going to Webpacker's. You need to set `custom_compile: true` in your `webpacker.yml`.
 - Changed webpack-bundle.js name to hello-world-bundle.js

data/lib/generators/react_on_rails/templates/base/base/config/webpacker.yml

@@ -3,6 +3,8 @@ default: &default
   # Critical to set compile as false for React on Rails projects
   compile: false
   custom_compile: true
+  # Cache manifest.json for performance
+  cache_manifest: false
 
 development:
   <<: *default
@@ -24,3 +26,4 @@ production:
   <<: *default
   # generated files for production, in /public/webpack/production
   public_output_path: webpack/production
+  cache_manifest: true

data/lib/react_on_rails/test_helper.rb

@@ -57,6 +57,7 @@ module ReactOnRails
                                     client_dir: nil,
                                     generated_assets_dir: nil,
                                     webpack_generated_files: nil)
+      ReactOnRails::Utils.check_manifest_not_cached
       if webpack_assets_status_checker.nil?
         client_dir ||= Rails.root.join("client")
         generated_assets_dir ||= ReactOnRails.configuration.generated_assets_dir

data/lib/react_on_rails/utils.rb

@@ -21,7 +21,6 @@ module ReactOnRails
     # Wraps message and makes it colored.
     # Pass in the msg and color as a symbol.
     def self.wrap_message(msg, color = :red)
-      # binding.pry
       wrapper_line = ("=" * 80).to_s
       # rubocop:disable Layout/IndentHeredoc
       fenced_msg = <<-MSG
@@ -91,10 +90,6 @@ exitstatus: #{status.exitstatus}#{stdout_msg}#{stderr_msg}
       end
     end
 
-    def self.using_webpacker?
-      ActionController::Base.helpers.respond_to?(:asset_pack_path)
-    end
-
     def self.running_on_windows?
       (/cygwin|mswin|mingw|bccwin|wince|emx/ =~ RUBY_PLATFORM) != nil
     end
@@ -115,14 +110,33 @@ exitstatus: #{status.exitstatus}#{stdout_msg}#{stderr_msg}
       rails_version_less_than("4.1.1")
     end
 
-    def self.manifest_exists?
-      Webpacker.config.public_manifest_path.exist?
-    end
-
     module Required
       def required(arg_name)
         raise ArgumentError, "#{arg_name} is required"
       end
     end
+
+    ###########################################################################
+    # WEBPACKER WRAPPERS
+    ###########################################################################
+
+    def self.using_webpacker?
+      ActionController::Base.helpers.respond_to?(:asset_pack_path)
+    end
+
+    def self.manifest_exists?
+      Webpacker.config.public_manifest_path.exist?
+    end
+
+    def self.check_manifest_not_cached
+      return unless using_webpacker? && Webpacker.config.cache_manifest?
+      msg = <<-MSG.strip_heredoc
+          ERROR: you have enabled cache_manifest in the #{Rails.env} env when using the
+          ReactOnRails::TestHelper.configure_rspec_to_compile_assets helper
+          To fix this: edit your config/webpacker.yml file and set cache_manifest to false for test.
+      MSG
+      puts wrap_message(msg)
+      exit!
+    end
   end
 end

data/lib/react_on_rails/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ReactOnRails
-  VERSION = "9.0.0.beta.9"
+  VERSION = "9.0.0.beta.10"
 end

data/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-on-rails",
-  "version": "9.0.0-beta.9",
+  "version": "9.0.0-beta.10",
   "description": "react-on-rails JavaScript for react_on_rails Ruby gem",
   "main": "node_package/lib/ReactOnRails.js",
   "directories": {

data/webpackConfigLoader.js

@@ -28,6 +28,8 @@ function formatPublicPath(host = '', path = '') {
 /**
  * @param configPath, location where webpacker.yml will be found
  * Return values are consistent with Webpacker's js helpers
+ * For example, you might define:
+ *   const isHMR = settings.dev_server && settings.dev_server.hmr
  * @returns {{
      settings,
      resolvedModules,

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: react_on_rails
 version: !ruby/object:Gem::Version
-  version: 9.0.0.beta.9
+  version: 9.0.0.beta.10
 platform: ruby
 authors:
 - Justin Gordon
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-08-17 00:00:00.000000000 Z
+date: 2017-08-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rainbow