react_on_rails 6.8.1 → 6.8.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: dc8f8c909150f3c94e83be4c4bfd84e825719bd9
-  data.tar.gz: a781fe780fcbed2447441b0f897f6b8b7dd2a2f1
+  metadata.gz: 330b3bfdba74e7185714c89c06b0e6ed85511d55
+  data.tar.gz: fbbb20768dad8d656c5d9d53132f6507a976d31f
 SHA512:
-  metadata.gz: b350e72c6b4ab2ea3a634112ec02bbbf4f063301bc8e4ab10c0f7bbfeecf3f7a12f42722f5057c9b57c5e32b67ad1584674342448134b46be2b4e8f558f5a1e7
-  data.tar.gz: ad7c94f6049fbce20494dc0be0c0fbaf0cdbbc5bd441dae460df912117e7753ebea44a65ef2dddb402009e82f14e22879fcf25809ce561a7efadea4de5563312
+  metadata.gz: c1e98356761f51eaef235c49efcab92333bb5e75683639ecc68e2a3658b0db4b8a314a4b48be5f66b9644af0f16e7eee4955c2f9f4780315ef8210e824393ba0
+  data.tar.gz: afad9d48c7aa908c641e052123e8ca265077aedeeb7d89ab56cc89331990cc20f9fc29dbc8711ec0e131cec7880634e48315183f9aeaabd2c533a1c568510613

data/CHANGELOG.md

@@ -5,6 +5,8 @@ Contributors: please follow the recommendations outlined at [keepachangelog.com]
 
 ## [Unreleased]
 *Please add entries here for your pull requests.*
+## Changed
+- Change webpack output path to absolute and update webpack to version ^2.3.1. [#771](https://github.com/shakacode/react_on_rails/pull/771) by [cheremukhin23](https://github.com/cheremukhin23).
 
 ## [6.8.1] - 2017-03-21
 ### Fixed

data/KUDOS.md

@@ -2,6 +2,10 @@ This is a sibling file to [PROJECTS.md](./PROJECTS.md).
 
 I'm looking for quotes on why you like using React on Rails. You might mention any benefits you particularly like and if you've migrated from react-rails. Just click to edit and github will automatically open up a PR. Thanks to everybody that contributes!
 
+### March 23, 2017
+Github issue [#766](https://github.com/shakacode/react_on_rails/issues/766).
+![2017-03-23_17-43-17](https://cloud.githubusercontent.com/assets/1118459/24279884/badab166-0ff0-11e7-87ab-94253f55a3d9.png)
+
 ### March 2, 2017
 ![2017-03-05_21-34-34](https://cloud.githubusercontent.com/assets/1118459/23600716/0d8c40d6-01ec-11e7-998d-4ce9e6abcacb.png)
 

data/PROJECTS.md

@@ -1,9 +1,10 @@
-#Projects using React on Rails
+# Projects using React on Rails
 
 *Please add your project to this list.*
 
 ## Commercial Products Live
 * **[Friends and Guests](https://www.friendsandguests.com/)**, the signature product of [ShakaCode](http://www.shakacode.com), which is a "Network Connecting Hosts and Guests".
+* **[KissKissBankBank](https://www.kisskissbankbank.com/)**, large French crowdfunding platform.
 * **[Nootrobox](https://nootrobox.com)**: Web ecommerce site for "biohacking" products.
 * **[GuavaPass](https://guavapass.com/)**: Coaching client of [ShakaCode](http://www.shakacode.com) and React on Rails fan!
 * **[Pivotal Tracker](http://www.pivotaltracker.com/)**: The first (and most-loved) agile project management tool built on Rails.  React on Rails has greatly simplified integration and workflow for our React components in Rails!
@@ -38,3 +39,4 @@
 
 * [github.com/Limenius/symfony-react-sandbox](https://github.com/Limenius/symfony-react-sandbox)
 * [github.com/tswayne/react-helper](https://github.com/tswayne/react-helper)
+* [github.com/KissKissBankBank/kitten](https://github.com/KissKissBankBank/kitten)

data/docs/additional-reading/hot-reloading-rails-development.md

@@ -1,10 +1,15 @@
 # Hot Reloading of Assets For Rails Development
 
-This document outlines the steps to setup your React On Rails Environment so that you can experience the pleasure of hot reloading of JavaScript and Sass during your Rails development work. There are 2 examples of this setup:
+This document outlines the steps to setup your React On Rails Environment so that you can experience the pleasure of hot reloading of JavaScript and Sass during your Rails development work. See [Issue 332](https://github.com/shakacode/react_on_rails/issues/332) for troubleshooting. There are 3 examples of this setup:
 
+1. [minimal demo here](https://github.com/retroalgic/react-on-rails-hot-minimal): The most simple and updated hot reloading setup.
 1. [spec/dummy](https://github.com/shakacode/react_on_rails/tree/master/spec/dummy): Simpler setup used for integration testing this gem.
 1. [shakacode/react-webpack-rails-tutorial](https://github.com/shakacode/react-webpack-rails-tutorial/). Full featured setup using Twitter bootstrap.
 
+## Help Wanted
+
+This doc might be outdated. PRs welcome!
+
 ## High Level Strategy
 
 We'll use a Webpack Dev server on port 3500 to provide the assets to Rails, rather than the asset pipeline, and only during development mode. This is configured via the `Procfile.hot`. 

data/docs/additional-reading/images.md

@@ -0,0 +1,35 @@
+# Images
+
+A full example can be found at [spec/dummy/client/app/components/ImageExample/ImageExample.js](../../spec/dummy/client/app/components/ImageExample/ImageExample.js)
+
+You are free to use images either in image tags or as background images in SCSS files. You can 
+use a "global" location of /client/app/assets/images or a relative path to your JS or SCSS file, as
+is done with CSS modules.
+
+**images** is a defined alias, so "images/foobar.jpg" would point to the file at 
+`/client/app/assets/images/foobar.jpg.`
+
+# Usage as Background Images or for `img` Tags
+
+Background images for CSS/SCSS need slightly different handling than images used with `img` tags,
+and thus we need to configure the webpack loaders slightly differently.
+
+The example shows you how to put either `bg-` or `bg_` in any file to be used as a background image. A regexp match
+will ensure the appropriate version of the url-loader to be used depending on if the image is used
+as a background image or within an `img` tag.
+
+The reason why this is done is that the sass-loader assumes that images will be relative to the
+deployed sass file, which will already be `/assets/some-file.css`. Thus, the sass-loader is already
+going to prepend `/assets` to all images. The file-loader needs an option to specify that the
+public path is `/assets` and that will get prepended to any image path. Consequently, if we didn't
+distinguish background images from images for `img` tags, then the background image tags will get
+an image path like `/assets/assets/some-file.svg` because the sass-loader thinks the path should be
+`/assets/some-file.svg` and that gets added to what the file-loader will be doing.
+
+We solve this by requiring a naming convention of `bg-` or `bg_` in the image names. Be warned that
+the regexp does not check that these three characters are the beginning of a name or path. They can
+be anywhere in the string. Of course, you can create your convention.
+
+You can see this configured: [spec/dummy/client/webpack.common.js](../../spec/dummy/client/webpack.common.js)
+
+_Note, all of this may change when we skip the asset pipeline for processing files in the near future._

data/docs/additional-reading/webpack.md

@@ -4,7 +4,7 @@
 You can try out example app, [shakacode/react-webpack-rails-tutorial](https://github.com/shakacode/react-webpack-rails-tutorial). We're building comprehensive production examples in our new, premium product, [**React on Rails Pro**](https://forum.shakacode.com/t/introducing-react-on-rails-pro-subscriptions/785). If you're interested, please see the details in [this forum post](https://forum.shakacode.com/t/introducing-react-on-rails-pro-subscriptions/785).
 
 ## Webpack v1 or v2?
-We recommend using Webpack version 2.2.1 or greater.
+We recommend using Webpack version 2.3.1 or greater.
 
 ## yarn or npm?
 Yarn is the current recommendation!

data/lib/generators/react_on_rails/templates/base/base/client/package.json.tt

@@ -32,7 +32,7 @@
     "react-redux": "^5.0.3",
     "redux": "^3.6.0",
     <%- end -%>
-    "webpack": "^2.2.1"
+    "webpack": "^2.3.1"
   },
   "devDependencies": {
   }

data/lib/generators/react_on_rails/templates/base/base/client/webpack.config.js

@@ -3,6 +3,7 @@
  "only-multiline"} ] */
 
 const webpack = require('webpack');
+const pathLib = require('path');
 
 const devBuild = process.env.NODE_ENV !== 'production';
 
@@ -16,7 +17,7 @@ const config = {
 
   output: {
     filename: 'webpack-bundle.js',
-    path: '../app/assets/webpack',
+    path: pathLib.resolve(__dirname, '../app/assets/webpack'),
   },
 
   resolve: {

data/lib/react_on_rails/version.rb

@@ -1,3 +1,3 @@
 module ReactOnRails
-  VERSION = "6.8.1".freeze
+  VERSION = "6.8.2".freeze
 end

data/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-on-rails",
-  "version": "6.8.1",
+  "version": "6.8.2",
   "description": "react-on-rails JavaScript for react_on_rails Ruby gem",
   "main": "node_package/lib/ReactOnRails.js",
   "directories": {
@@ -35,7 +35,7 @@
     "release-it": "^2.5.4",
     "tap-spec": "^4.1.1",
     "tape": "^4.6.3",
-    "webpack": "^2.2.1"
+    "webpack": "^2.3.1"
   },
   "peerDependencies": {
     "babel-runtime": ">= 6",

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: react_on_rails
 version: !ruby/object:Gem::Version
-  version: 6.8.1
+  version: 6.8.2
 platform: ruby
 authors:
 - Justin Gordon
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-03-21 00:00:00.000000000 Z
+date: 2017-03-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: connection_pool
@@ -326,6 +326,7 @@ files:
 - docs/additional-reading/foreman-issues.md
 - docs/additional-reading/heroku-deployment.md
 - docs/additional-reading/hot-reloading-rails-development.md
+- docs/additional-reading/images.md
 - docs/additional-reading/node-dependencies-and-npm.md
 - docs/additional-reading/node-server-rendering.md
 - docs/additional-reading/rails-assets-relative-paths.md