react_on_rails 6.1.1.rc.1 → 6.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8c1a4b95d529e2b5d95bd5cd92822138f8a5017c
-  data.tar.gz: c77aeda6b4a99c2be1b02719729be8e49fd53179
+  metadata.gz: e0c71a39501e0eb29676ebb4003e70f64b29a754
+  data.tar.gz: e1891e86f9f814cbf14493a0e36d6cab45309459
 SHA512:
-  metadata.gz: 58c496affefbff52af047529ab85cea488f78bfd325cc2d12ee85fd0106340ff2ab174d82a9c92c8d0e8ceba007c987cd4047222546b9c867f038fefe6cef216
-  data.tar.gz: 774fd6cf92855b04a79e6eea058212e7744677b10c492e083ff169746f4a432d4c38be0bc93d19b3530548450f6eb2d6b49ea465808767c120df14ee861baa38
+  metadata.gz: 10e3d05d3c8ebce907a8c29d337a31961b4e9f66d3b816de2881bdcd0c53bb42212f05f760e153d2c236bb076a4d58d03e7cf355a76cbe847165dc80d388c9da
+  data.tar.gz: 3898da0b35b3014e6294becd7b81853b24d73e84e43a220bb51dc9b5c9497450796d7907699a63aa1aa44b470e6952f72f2b765a2774701733ee026d8ba34615

data/CHANGELOG.md

@@ -3,6 +3,10 @@ All notable changes to this project will be documented in this file. Items under
 
 Contributors: please follow the recommendations outlined at [keepachangelog.com](http://keepachangelog.com/). Please use the existing headings and styling as a guide, and add a link for the version diff at the bottom of the file. Also, please update the `Unreleased` link to compare to the latest release version.
 
+## [6.1.1] 2016-09-09
+##### Fixed
+- React on Rails was incorrectly failing to create symlinks when a file existed in the location for the new symlink. [#491](https://github.com/shakacode/react_on_rails/pull/541) by [robwise ](https://github.com/robwise) and [justin808](https://github.com/justin808).
+
 ## [6.1.0] 2016-08-21
 
 ##### Added
@@ -364,7 +368,8 @@ Best done with Object destructing:
 ##### Fixed
 - Fix several generator related issues.
 
-[Unreleased]: https://github.com/shakacode/react_on_rails/compare/6.1.0...master
+[Unreleased]: https://github.com/shakacode/react_on_rails/compare/6.1.1...master
+[6.1.1]: https://github.com/shakacode/react_on_rails/compare/6.1.0...6.1.1
 [6.1.0]: https://github.com/shakacode/react_on_rails/compare/6.0.5...6.1.0
 [6.0.5]: https://github.com/shakacode/react_on_rails/compare/6.0.4...6.0.5
 [6.0.4]: https://github.com/shakacode/react_on_rails/compare/6.0.3...6.0.4

data/lib/react_on_rails/assets_precompile.rb

@@ -26,18 +26,14 @@ module ReactOnRails
       target_exists = File.exist?(target_path)
       raise SymlinkTargetDoesNotExistException, "Target Path was: #{target_path}" unless target_exists
 
-      # File.exist?(symlink_path) will check the file the sym is pointing to is existing
-      # File.lstat(symlink_path).symlink? confirms that this is a symlink
-      valid_symlink_already_exists = File.exist?(symlink_path) && File.lstat(symlink_path).symlink?
-
-      if valid_symlink_already_exists
+      if symlink_and_points_to_existing_file?(symlink_path)
         puts "React On Rails: Digested version of #{symlink} already exists indicating #{target} did not change."
         return
       end
 
       if file_or_symlink_exists_at_path?(symlink_path)
         puts "React On Rails: Removing existing invalid symlink or file #{symlink_path}"
-        `rm -f "#{symlink_path}"`
+        FileUtils.remove_file(symlink_path, true)
       end
 
       # Might be like:
@@ -120,7 +116,15 @@ module ReactOnRails
 
     private
 
+    def symlink_and_points_to_existing_file?(symlink_path)
+      # File.exist?(symlink_path) will check the file the sym is pointing to is existing
+      # File.lstat(symlink_path).symlink? confirms that this is a symlink
+      File.exist?(symlink_path) && File.lstat(symlink_path).symlink?
+    end
+
     def file_or_symlink_exists_at_path?(path)
+      # We use lstat and not stat, we we don't want to visit the file that the symlink maybe
+      # pointing to. We can't use File.exist?, as that would check the file pointed at by the symlink.
       File.lstat(path)
       true
     rescue

data/lib/react_on_rails/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module ReactOnRails
-  VERSION = "6.1.1.rc.1".freeze
+  VERSION = "6.1.1".freeze
 end

data/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-on-rails",
-  "version": "6.1.1-rc.1",
+  "version": "6.1.1",
   "description": "react-on-rails JavaScript for react_on_rails Ruby gem",
   "main": "node_package/lib/ReactOnRails.js",
   "directories": {

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: react_on_rails
 version: !ruby/object:Gem::Version
-  version: 6.1.1.rc.1
+  version: 6.1.1
 platform: ruby
 authors:
 - Justin Gordon
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-09-05 00:00:00.000000000 Z
+date: 2016-09-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: connection_pool
@@ -455,12 +455,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.1
 signing_key: 
 specification_version: 4
 summary: Rails with react server rendering with webpack.