react_on_rails 17.0.0.rc.0 → 17.0.0.rc.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 02f0fa1befbed99b17f624249398f47b5a1395ed5407079a472ad39218d2cfc1
-  data.tar.gz: f8b4e5a3abf309b98f7b244d1a807acb29096ff7ae1ea115e780eefd35f2d609
+  metadata.gz: 5610a42464b29a2f8066e2a91d342838cdd1f3734c3965864e0a5bd0d18e4c8a
+  data.tar.gz: 551fc429af6eea0798b929d0aece8b417b4646dfed702c1dcd39ae26d52084ad
 SHA512:
-  metadata.gz: c594211d78c05817226dd5d4ff06e7bb4f377b57320cdb824de7a8902ec40d66473b28da64e0f6d2df5b445786a050d1c6b61779af3fea0c1c4793f3955efa63
-  data.tar.gz: e86d35866011de451f725c441539bc7f8400e83d9702a4a3b9058d385e483a926229b4e33e18685636d73700bc7a9a1106246d78174a726327b47b8b0f1645d9
+  metadata.gz: 4b1df35fc94bc088e6a9afe96ca54ec651951149ae82415e55d1db023ef582089fb58f9536db698d0971633678b3d2d70188c0ca355217fd9f6a854ead1f177c
+  data.tar.gz: c1371c43729036f9f9dbb78d68b85be81919a98a16fb8d3d4185b94c0f48c92506404bedb6e1a7a804b52596ae784b4f60487cc4bad8333f0933e38aa005551a

data/.rubocop.yml

@@ -11,6 +11,8 @@ AllCops:
 
   Exclude:
     - 'spec/dummy/bin/*'
+    - 'spec/react_on_rails/dummy-for-generators/**/*'  # Generated fixture contains intentionally invalid Ruby
+    - 'spike/**/*'  # Exploratory spike code outside lib/ — not part of the production surface
 
 Naming/FileName:
   Exclude:

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    react_on_rails (17.0.0.rc.0)
+    react_on_rails (17.0.0.rc.2)
       addressable
       connection_pool
       execjs (~> 2.5)
@@ -207,7 +207,6 @@ GEM
       racc (~> 1.4)
     ostruct (0.6.1)
     package_json (0.2.0)
-    parallel (1.24.0)
     parser (3.3.1.0)
       ast (~> 2.4.1)
       racc
@@ -313,34 +312,6 @@ GEM
     rspec-support (3.13.1)
     rspec_junit_formatter (0.6.0)
       rspec-core (>= 2, < 4, != 2.12.0)
-    rubocop (1.61.0)
-      json (~> 2.3)
-      language_server-protocol (>= 3.17.0)
-      parallel (~> 1.10)
-      parser (>= 3.3.0.2)
-      rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.8, < 3.0)
-      rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.30.0, < 2.0)
-      ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.31.3)
-      parser (>= 3.3.1.0)
-    rubocop-capybara (2.20.0)
-      rubocop (~> 1.41)
-    rubocop-factory_bot (2.25.1)
-      rubocop (~> 1.41)
-    rubocop-performance (1.20.2)
-      rubocop (>= 1.48.1, < 2.0)
-      rubocop-ast (>= 1.30.0, < 2.0)
-    rubocop-rspec (2.29.2)
-      rubocop (~> 1.40)
-      rubocop-capybara (~> 2.17)
-      rubocop-factory_bot (~> 2.22)
-      rubocop-rspec_rails (~> 2.28)
-    rubocop-rspec_rails (2.28.3)
-      rubocop (~> 1.40)
-    ruby-progressbar (1.13.0)
     rubyzip (2.3.2)
     sass-rails (6.0.0)
       sassc-rails (~> 2.1, >= 2.1.1)
@@ -469,9 +440,6 @@ DEPENDENCIES
   rspec-rails
   rspec-retry
   rspec_junit_formatter
-  rubocop (= 1.61.0)
-  rubocop-performance (~> 1.20.0)
-  rubocop-rspec (~> 2.26)
   sass-rails (~> 6.0)
   sdoc
   selenium-webdriver (= 4.9.0)
@@ -487,4 +455,4 @@ DEPENDENCIES
   webdrivers (= 5.3.0)
 
 BUNDLED WITH
-   2.5.9
+  4.0.10

data/Rakefile

@@ -13,7 +13,7 @@ desc "All actions but no examples, good for local developer run."
 task all_but_examples: ["run_rspec:all_but_examples", "lint"]
 
 desc "Prepare for ci, including node_package, dummy app, and generator examples"
-task prepare_for_ci: prepare_for_ci
+task(prepare_for_ci:)
 
 desc "Runs prepare_for_ci and tasks"
 task ci: [:prepare_for_ci, *tasks]

data/lib/generators/react_on_rails/base_generator.rb

@@ -6,11 +6,13 @@ require "erb"
 require_relative "generator_messages"
 require_relative "generator_helper"
 require_relative "js_dependency_manager"
+require_relative "shakapacker_precompile_hook_helper"
 module ReactOnRails
   module Generators
     class BaseGenerator < Rails::Generators::Base
       include GeneratorHelper
       include JsDependencyManager
+      include ShakapackerPrecompileHookHelper
 
       Rails::Generators.hide_namespace(namespace)
       source_root(File.expand_path("templates", __dir__))
@@ -22,11 +24,22 @@ module ReactOnRails
                    desc: "Install Redux package and Redux version of Hello World Example",
                    aliases: "-R"
 
-      # --rspack
+      # --rspack / --no-rspack (Rspack is the default on fresh installs; --no-rspack selects Webpack)
+      # IMPORTANT: do NOT add a `default:` here. The absence of a default is load-bearing — Thor
+      # only includes :rspack in the options hash when the flag is explicitly passed, which is how
+      # GeneratorHelper#using_rspack? tells an explicit choice from "no flag given" (the latter
+      # falls back to rspack_bundler_default). Adding `default: false` would make
+      # options.key?(:rspack) always true and silently break the fresh-install Rspack default.
+      # (Thor's omit-when-no-default behavior verified against Thor 1.5.0; see Gemfile.lock.)
       class_option :rspack,
                    type: :boolean,
-                   default: false,
-                   desc: "Use Rspack instead of Webpack as the bundler"
+                   desc: "Use Rspack (default) as the bundler; pass --no-rspack to use Webpack"
+
+      # --webpack: friendly alias for --no-rspack (reconciled in GeneratorHelper#explicit_bundler_choice).
+      # No `default:` here either — same load-bearing reason as --rspack above.
+      class_option :webpack,
+                   type: :boolean,
+                   desc: "Use Webpack as the bundler (alias for --no-rspack; --no-webpack is equivalent to --rspack)"
 
       # --pro
       class_option :pro,
@@ -96,6 +109,14 @@ module ReactOnRails
         def shakapacker_version_9_or_higher?
           generator.__send__(:shakapacker_version_9_or_higher?)
         end
+
+        def rsc_plugin_class_name
+          generator.__send__(:rsc_plugin_class_name)
+        end
+
+        def rsc_plugin_import_path
+          generator.__send__(:rsc_plugin_import_path)
+        end
       end
 
       REMOVABLE_WEBPACK_FILES = (MANAGED_WEBPACK_FILE_TEMPLATES.keys +
@@ -313,6 +334,18 @@ module ReactOnRails
 
       private
 
+      # Fresh-install context: default to Rspack (when Shakapacker supports it) unless the
+      # app already declares a bundler. See GeneratorHelper#fresh_install_rspack_default.
+      # NOTE: InstallGenerator#rspack_bundler_default is an intentional twin of this override
+      # (both generators are independently CLI-invocable); keep the two in sync.
+      def rspack_bundler_default
+        fresh_install_rspack_default
+      end
+
+      def generated_build_test_command
+        shakapacker_build_command(env: "RAILS_ENV=test NODE_ENV=test", environment: "test")
+      end
+
       def generate_new_app_home_page?
         options.new_app? && new_app_root_route_added?
       end
@@ -347,8 +380,8 @@ module ReactOnRails
                    end
 
         {
-          app_name: app_name,
-          docs_url: docs_url,
+          app_name:,
+          docs_url:,
           examples: home_page_examples,
           file_hints: home_page_file_hints,
           stack_badges: home_page_stack_badges,
@@ -938,8 +971,9 @@ module ReactOnRails
           # current run omits those options; in that case, we preserve the directory.
           # Templates rely on config[:message] plus a small helper subset exposed by
           # TemplateRenderContext (add_documentation_reference, use_pro?, use_rsc?,
-          # shakapacker_version_9_or_higher?). Missing method delegates raise
-          # NoMethodError and are caught below, treating the file as non-removable.
+          # shakapacker_version_9_or_higher?, rsc_plugin_class_name, rsc_plugin_import_path).
+          # Missing method delegates raise NoMethodError and are caught below, treating the
+          # file as non-removable.
           # Missing config hash keys return nil silently, so any new config key
           # required by templates must be added to template_doc_config above.
           # Use TemplateRenderContext#erb_binding to avoid leaking method-local
@@ -984,13 +1018,13 @@ module ReactOnRails
         expected_configs = shakapacker_default_configs
 
         # Check if the content matches any of the known default configurations
-        expected_configs.any? { |config| content_matches_template?(content, config, strip_comments: strip_comments) }
+        expected_configs.any? { |config| content_matches_template?(content, config, strip_comments:) }
       end
 
       def content_matches_template?(content, template, strip_comments: false)
         # Normalize whitespace and compare
-        normalize_config_content(content, strip_comments: strip_comments) ==
-          normalize_config_content(template, strip_comments: strip_comments)
+        normalize_config_content(content, strip_comments:) ==
+          normalize_config_content(template, strip_comments:)
       end
 
       def normalize_config_content(content, strip_comments: false)
@@ -1196,8 +1230,9 @@ module ReactOnRails
 
         content = File.read(shakapacker_config_path)
 
-        # Already has an active (non-commented) precompile_hook configured? Don't overwrite.
-        return if content.match?(/^\s+precompile_hook:\s*['"][^'"]+['"]/)
+        # Don't materialize placeholders when any placeholder section already has
+        # a direct or inherited active precompile_hook.
+        return if active_precompile_hook_configured?(content)
 
         # Replace the commented placeholder with the actual value
         # Shakapacker 9.x default config has: # precompile_hook: ~

data/lib/generators/react_on_rails/demo_page_config.rb

@@ -5,12 +5,12 @@ module ReactOnRails
     module DemoPageConfig # rubocop:disable Metrics/ModuleLength
       def build_hello_world_view_config(component_name:, source_path:, landing_page:, redux:, rsc_demo:)
         {
-          component_name: component_name,
+          component_name:,
           title: redux ? "Redux SSR Demo" : "React SSR Demo",
-          intro: hello_world_intro(redux: redux),
-          highlights: hello_world_highlights(redux: redux),
-          file_hints: hello_world_file_hints(source_path: source_path, redux: redux),
-          quick_links: hello_world_quick_links(landing_page: landing_page, rsc_demo: rsc_demo),
+          intro: hello_world_intro(redux:),
+          highlights: hello_world_highlights(redux:),
+          file_hints: hello_world_file_hints(source_path:, redux:),
+          quick_links: hello_world_quick_links(landing_page:, rsc_demo:),
           learning_links: hello_world_learning_links
         }
       end
@@ -22,7 +22,7 @@ module ReactOnRails
                  "component response while only client islands ship JavaScript to the browser.",
           highlights: hello_server_highlights,
           file_hints: hello_server_file_hints,
-          quick_links: hello_server_quick_links(landing_page: landing_page, redux_demo: redux_demo),
+          quick_links: hello_server_quick_links(landing_page:, redux_demo:),
           learning_links: hello_server_learning_links
         }
       end

data/lib/generators/react_on_rails/generator_helper.rb

@@ -1,8 +1,12 @@
 # frozen_string_literal: true
 
 require "json"
+require_relative "shakapacker_precompile_hook_helper"
 
+# rubocop:disable Metrics/ModuleLength
 module GeneratorHelper
+  include ReactOnRails::Generators::ShakapackerPrecompileHookHelper
+
   def package_json
     # Lazy load package_json gem only when actually needed for dependency management
 
@@ -37,7 +41,7 @@ module GeneratorHelper
       result != false
     rescue StandardError => e
       say_status :warning, "Could not add packages via package_json gem: #{e.message}", :yellow
-      say_status :warning, "Will fall back to direct npm commands.", :yellow
+      say_status :warning, "Will fall back to direct package manager commands.", :yellow
       false
     end
   end
@@ -128,11 +132,57 @@ module GeneratorHelper
   def using_rspack?
     return @using_rspack if defined?(@using_rspack)
 
-    # options.key?(:rspack) is true when the generator declares --rspack (e.g. InstallGenerator),
-    # false when it does not (e.g. RscGenerator, ProGenerator). Using .key? rather than .nil?
-    # check on the value makes the intent explicit and avoids relying on Thor returning nil for
-    # undeclared options.
-    @using_rspack = options.key?(:rspack) ? options[:rspack] : rspack_configured_in_project?
+    # An explicit bundler flag always wins. When none was passed (or the generator doesn't
+    # declare the flags, e.g. RscGenerator/ProGenerator), fall back to the bundler default,
+    # which each generator defines for its own context.
+    explicit = explicit_bundler_choice
+    @using_rspack = explicit.nil? ? rspack_bundler_default : explicit
+  end
+
+  # Resolve the explicit bundler flags into a single choice.
+  #
+  # --rspack selects Rspack; --no-rspack and --webpack select Webpack (--webpack is a friendly
+  # alias for --no-rspack, and the auto-generated --no-webpack mirrors --rspack). Returns true
+  # for Rspack, false for Webpack, or nil when no bundler flag was passed (so the caller falls
+  # back to rspack_bundler_default).
+  #
+  # IMPORTANT: this relies on Thor NOT including a nil-defaulted option in the hash when the flag
+  # is absent — options.key?(:rspack)/(:webpack) is true only when the user passed that flag.
+  # Re-adding `default:` to either class_option would make the key always present and break both
+  # the "no flag given" fallback and the conflict detection here.
+  # (Thor's omit-when-no-default behavior verified against Thor 1.5.0; see Gemfile.lock.)
+  #
+  # Passing contradictory flags (e.g. --rspack --webpack) raises a Thor::Error.
+  def explicit_bundler_choice
+    choices = []
+    choices << options[:rspack] if options.key?(:rspack)
+    # --webpack means "use Webpack" (rspack = false); --no-webpack means "use Rspack".
+    # Name the inverted webpack flag so the rspack-boolean intent reads directly.
+    rspack_via_webpack_flag = !options[:webpack]
+    choices << rspack_via_webpack_flag if options.key?(:webpack)
+    return nil if choices.empty?
+
+    if choices.uniq.length > 1
+      raise Thor::Error,
+            "Conflicting bundler flags: pass either Rspack (--rspack) or Webpack " \
+            "(--webpack / --no-rspack), not both."
+    end
+
+    choices.first
+  end
+
+  # True when the user passed any explicit bundler flag
+  # (--rspack/--no-rspack/--webpack/--no-webpack).
+  def bundler_flag_given?
+    options.key?(:rspack) || options.key?(:webpack)
+  end
+
+  # Bundler to use when no explicit bundler flag was passed.
+  # Default (standalone generators like RscGenerator/ProGenerator): respect the existing
+  # project's shakapacker.yml and never impose a bundler. InstallGenerator/BaseGenerator
+  # override this to default fresh installs to Rspack.
+  def rspack_bundler_default
+    rspack_configured_in_project?
   end
 
   # Remap a config path from config/webpack/ to config/rspack/ when using rspack.
@@ -147,6 +197,26 @@ module GeneratorHelper
     path.sub(%r{\Aconfig/webpack/}, "config/rspack/")
   end
 
+  # RSC client-manifest plugin class name for the active bundler.
+  # Rspack uses the native `RSCRspackPlugin`; webpack uses `RSCWebpackPlugin`.
+  # Both expose the same `{ isServer, clientReferences }` API and emit the same
+  # manifest schema, so only the import path and class name differ.
+  # Shared by the base webpack-config templates and the standalone RSC migration
+  # so both paths scaffold the bundler-correct plugin from one source of truth.
+  #
+  # @return [String] "RSCRspackPlugin" when rspack, "RSCWebpackPlugin" otherwise
+  def rsc_plugin_class_name
+    using_rspack? ? "RSCRspackPlugin" : "RSCWebpackPlugin"
+  end
+
+  # `react-on-rails-rsc` subpath that exports {#rsc_plugin_class_name}.
+  #
+  # @return [String] "react-on-rails-rsc/RspackPlugin" when rspack,
+  #   "react-on-rails-rsc/WebpackPlugin" otherwise
+  def rsc_plugin_import_path
+    using_rspack? ? "react-on-rails-rsc/RspackPlugin" : "react-on-rails-rsc/WebpackPlugin"
+  end
+
   # Detect the installed React version from package.json
   # Uses VERSION_PARTS_REGEX pattern from VersionChecker for consistency
   #
@@ -269,6 +339,24 @@ module GeneratorHelper
     @pro_gem_install_deferred = true
   end
 
+  # The other bundler's plugin class name — the one this project should NOT be using.
+  # Used to detect a config left in a mixed state (e.g. a legacy `RSCWebpackPlugin` surviving
+  # in an rspack project) so diagnostics can say "wrong bundler plugin" rather than "missing".
+  #
+  # @return [String] "RSCWebpackPlugin" when rspack, "RSCRspackPlugin" otherwise
+  def inactive_rsc_plugin_class_name
+    using_rspack? ? "RSCWebpackPlugin" : "RSCRspackPlugin"
+  end
+
+  # Import path for the inactive bundler's plugin — the counterpart to {#rsc_plugin_import_path},
+  # used when migrating a legacy config to the active bundler's plugin.
+  #
+  # @return [String] "react-on-rails-rsc/WebpackPlugin" when rspack,
+  #   "react-on-rails-rsc/RspackPlugin" otherwise
+  def inactive_rsc_plugin_import_path
+    using_rspack? ? "react-on-rails-rsc/WebpackPlugin" : "react-on-rails-rsc/RspackPlugin"
+  end
+
   # NOTE: only the `default:` section is inspected — same assumption as
   # rspack_configured_in_project?. Projects that set `javascript_transpiler`
   # only in per-environment sections (without a `default:` block) will not be
@@ -291,25 +379,6 @@ module GeneratorHelper
     shakapacker_version_9_3_or_higher?
   end
 
-  def parse_shakapacker_yml(path)
-    require "yaml"
-    # Use safe_load_file for security (defense-in-depth, even though this is user's own config)
-    # permitted_classes: [Symbol] allows symbol keys which shakapacker.yml may use
-    # aliases: true allows YAML anchors (&default, *default) commonly used in Rails configs
-    YAML.safe_load_file(path, permitted_classes: [Symbol], aliases: true)
-  rescue ArgumentError
-    # Older Psych versions don't support all parameters - try without aliases
-    begin
-      YAML.safe_load_file(path, permitted_classes: [Symbol])
-    rescue ArgumentError
-      # Very old Psych - fall back to safe_load with File.read
-      YAML.safe_load(File.read(path), permitted_classes: [Symbol]) # rubocop:disable Style/YAMLFileRead
-    end
-  rescue StandardError
-    # If we can't parse the file, return empty config
-    {}
-  end
-
   # Check if Shakapacker 9.3.0 or higher is available
   # This version made SWC the default JavaScript transpiler
   def shakapacker_version_9_3_or_higher?
@@ -330,10 +399,34 @@ module GeneratorHelper
   # `assets_bundler` inside the `default: &default` block, and our generator writes
   # it there too via configure_rspack_in_shakapacker.
   def rspack_configured_in_project?
+    shakapacker_assets_bundler_value == "rspack"
+  end
+
+  # Fresh-install bundler default used by InstallGenerator/BaseGenerator: prefer Rspack
+  # when Shakapacker supports it (Rspack landed in Shakapacker 9.0), but never override an
+  # existing app's explicit assets_bundler choice. On a brand-new install where Shakapacker
+  # isn't loaded yet, shakapacker_version_9_or_higher? optimistically returns true.
+  def fresh_install_rspack_default
+    return rspack_configured_in_project? if project_declares_assets_bundler?
+
+    shakapacker_version_9_or_higher?
+  end
+
+  # True when config/shakapacker.yml exists and its default: section declares an
+  # assets_bundler (i.e., the project has already made an explicit bundler choice).
+  def project_declares_assets_bundler?
+    !shakapacker_assets_bundler_value.nil?
+  end
+
+  # Single source for the config/shakapacker.yml default-section read shared by
+  # rspack_configured_in_project? and project_declares_assets_bundler?. Returns the
+  # assets_bundler value (e.g. "rspack"), or nil when the file is absent or the key is unset.
+  # Only the default: section is inspected (see rspack_configured_in_project? for the rationale).
+  def shakapacker_assets_bundler_value
     shakapacker_yml_path = File.join(destination_root, "config/shakapacker.yml")
-    return false unless File.exist?(shakapacker_yml_path)
+    return nil unless File.exist?(shakapacker_yml_path)
 
-    config = parse_shakapacker_yml(shakapacker_yml_path)
-    config.dig("default", "assets_bundler") == "rspack"
+    parse_shakapacker_yml(shakapacker_yml_path).dig("default", "assets_bundler")
   end
 end
+# rubocop:enable Metrics/ModuleLength

data/lib/generators/react_on_rails/generator_messages/ci_section.rb

@@ -1,9 +1,12 @@
 # frozen_string_literal: true
 
 require "rainbow"
+require_relative "../shakapacker_precompile_hook_helper"
 
 module GeneratorMessages
   module CiSection
+    include ReactOnRails::Generators::ShakapackerPrecompileHookHelper
+
     private
 
     def build_ci_section(app_root: Dir.pwd, ci_workflow_generated: false)
@@ -12,7 +15,7 @@ module GeneratorMessages
       # Read package.json once and reuse for both package-manager detection and the
       # build:test script presence check to avoid a second I/O pass.
       package_json = read_package_json(app_root)
-      package_manager = detect_package_manager(app_root: app_root, package_json: package_json)
+      package_manager = detect_package_manager(app_root:, package_json:)
       ci_status = if ci_workflow_generated
                     "A GitHub Actions workflow has been generated at .github/workflows/ci.yml."
                   else
@@ -25,6 +28,11 @@ module GeneratorMessages
                         else
                           ""
                         end
+      manual_build_command = shakapacker_build_command(
+        env: "RAILS_ENV=test NODE_ENV=test",
+        app_root:,
+        environment: "test"
+      )
 
       <<~CI
 
@@ -35,7 +43,7 @@ module GeneratorMessages
         #{ci_status}
 
         To build bundles manually before tests:
-        #{Rainbow('RAILS_ENV=test NODE_ENV=test bin/shakapacker').cyan}#{build_test_hint}
+        #{Rainbow(manual_build_command).cyan}#{build_test_hint}
       CI
     end
   end

data/lib/generators/react_on_rails/generator_messages/package_manager_detection.rb

@@ -37,8 +37,8 @@ module GeneratorMessages
     # wants detection to fall through directly to lockfile heuristics.
     def detect_package_manager(app_root: Dir.pwd, package_json: PACKAGE_JSON_UNSET)
       detect_package_manager_with_source(
-        app_root: app_root,
-        package_json: package_json
+        app_root:,
+        package_json:
       ).first
     end
 
@@ -52,13 +52,13 @@ module GeneratorMessages
       return [env_package_manager, :env] if supported_package_manager?(env_package_manager)
 
       content = package_json_content(
-        app_root: app_root,
-        package_json: package_json
+        app_root:,
+        package_json:
       )
       pm_from_json = content ? package_manager_name_from_content(content) : nil
       return [pm_from_json, :package_json] if pm_from_json
 
-      pm_from_lockfile = detect_package_manager_from_lockfiles(app_root: app_root)
+      pm_from_lockfile = detect_package_manager_from_lockfiles(app_root:)
       return [pm_from_lockfile, :lockfile] if pm_from_lockfile
 
       ["npm", :default]
@@ -84,8 +84,8 @@ module GeneratorMessages
     # package_json: nil to preserve a cached missing/unreadable read.
     def package_manager_declared?(manager:, app_root: Dir.pwd, package_json: PACKAGE_JSON_UNSET)
       content = package_json_content(
-        app_root: app_root,
-        package_json: package_json
+        app_root:,
+        package_json:
       )
       return false unless content
 
@@ -99,12 +99,12 @@ module GeneratorMessages
     # that's not on disk (e.g. `packageManager: pnpm` without `pnpm-lock.yaml`, which
     # breaks `actions/setup-node`'s cache step).
     def lockfile_for_manager?(package_manager, app_root: Dir.pwd)
-      !lockfile_filename_for(package_manager, app_root: app_root).nil?
+      !lockfile_filename_for(package_manager, app_root:).nil?
     end
 
     def detect_package_manager_from_lockfiles(app_root: Dir.pwd)
       LOCKFILE_CANDIDATES_BY_MANAGER.keys.find do |pm|
-        lockfile_for_manager?(pm, app_root: app_root)
+        lockfile_for_manager?(pm, app_root:)
       end
     end
 

data/lib/generators/react_on_rails/generator_messages/shakapacker_status_section.rb

@@ -7,7 +7,7 @@ module GeneratorMessages
     private
 
     def build_shakapacker_status_section(shakapacker_just_installed: false, app_root: Dir.pwd)
-      version_warning = check_shakapacker_version_warning(app_root: app_root)
+      version_warning = check_shakapacker_version_warning(app_root:)
       if shakapacker_just_installed
         base = <<~SHAKAPACKER
 

data/lib/generators/react_on_rails/generator_messages.rb

@@ -58,13 +58,13 @@ module GeneratorMessages
                                            rsc: false, shakapacker_just_installed: false, landing_page: false,
                                            ci_workflow_generated: false, app_root: Dir.pwd)
       process_manager_section = build_process_manager_section
-      testing_section = build_testing_section(app_root: app_root)
-      ci_section = build_ci_section(app_root: app_root, ci_workflow_generated: ci_workflow_generated)
-      package_manager = detect_package_manager(app_root: app_root)
-      shakapacker_status = build_shakapacker_status_section(shakapacker_just_installed: shakapacker_just_installed,
-                                                            app_root: app_root)
-      render_example = build_render_example(component_name: component_name, route: route, rsc: rsc)
-      render_label = build_render_label(route: route, rsc: rsc)
+      testing_section = build_testing_section(app_root:)
+      ci_section = build_ci_section(app_root:, ci_workflow_generated:)
+      package_manager = detect_package_manager(app_root:)
+      shakapacker_status = build_shakapacker_status_section(shakapacker_just_installed:,
+                                                            app_root:)
+      render_example = build_render_example(component_name:, route:, rsc:)
+      render_label = build_render_label(route:, rsc:)
       normalized_route = route.to_s.sub(%r{\A/+}, "")
       visit_url = if landing_page || normalized_route.empty?
                     "http://localhost:3000"