react_on_rails 16.0.1.rc.2 → 16.0.1.rc.4

data/lib/react_on_rails/configuration.rb

@@ -52,8 +52,13 @@ module ReactOnRails
       # If exceeded, an error will be thrown for server-side rendered components not registered on the client.
       # Set to 0 to disable the timeout and wait indefinitely for component registration.
       component_registry_timeout: DEFAULT_COMPONENT_REGISTRY_TIMEOUT,
-      generated_component_packs_loading_strategy: nil
+      generated_component_packs_loading_strategy: nil,
+      server_bundle_output_path: "ssr-generated",
+      enforce_private_server_bundles: false
     )
+    # TODO: Add automatic detection of server_bundle_output_path from shakapacker.yml
+    # See feature/shakapacker-yml-integration branch for implementation
+    # Requires Shakapacker v8.5.0+ and semantic version checking
   end
 
   class Configuration
@@ -68,7 +73,8 @@ module ReactOnRails
                   :same_bundle_for_client_and_server, :rendering_props_extension,
                   :make_generated_server_bundle_the_entrypoint,
                   :generated_component_packs_loading_strategy, :immediate_hydration, :rsc_bundle_js_file,
-                  :react_client_manifest_file, :react_server_client_manifest_file, :component_registry_timeout
+                  :react_client_manifest_file, :react_server_client_manifest_file, :component_registry_timeout,
+                  :server_bundle_output_path, :enforce_private_server_bundles
 
     # rubocop:disable Metrics/AbcSize
     def initialize(node_modules_location: nil, server_bundle_js_file: nil, prerender: nil,
@@ -85,7 +91,7 @@ module ReactOnRails
                    random_dom_id: nil, server_render_method: nil, rendering_props_extension: nil,
                    components_subdirectory: nil, auto_load_bundle: nil, immediate_hydration: nil,
                    rsc_bundle_js_file: nil, react_client_manifest_file: nil, react_server_client_manifest_file: nil,
-                   component_registry_timeout: nil)
+                   component_registry_timeout: nil, server_bundle_output_path: nil, enforce_private_server_bundles: nil)
       self.node_modules_location = node_modules_location.present? ? node_modules_location : Rails.root
       self.generated_assets_dirs = generated_assets_dirs
       self.generated_assets_dir = generated_assets_dir
@@ -130,6 +136,8 @@ module ReactOnRails
       self.defer_generated_component_packs = defer_generated_component_packs
       self.immediate_hydration = immediate_hydration
       self.generated_component_packs_loading_strategy = generated_component_packs_loading_strategy
+      self.server_bundle_output_path = server_bundle_output_path
+      self.enforce_private_server_bundles = enforce_private_server_bundles
     end
     # rubocop:enable Metrics/AbcSize
 
@@ -139,13 +147,13 @@ module ReactOnRails
       ensure_webpack_generated_files_exists
       configure_generated_assets_dirs_deprecation
       configure_skip_display_none_deprecation
-      ensure_generated_assets_dir_present
       check_server_render_method_is_only_execjs
       error_if_using_packer_and_generated_assets_dir_not_match_public_output_path
       # check_deprecated_settings
       adjust_precompile_task
       check_component_registry_timeout
       validate_generated_component_packs_loading_strategy
+      validate_enforce_private_server_bundles
     end
 
     private
@@ -180,7 +188,7 @@ module ReactOnRails
         1. Use :sync or :defer loading strategy instead of :async
         2. Upgrade to Shakapacker v8.2.0 or above to enable async script loading
       MSG
-      if PackerUtils.shakapacker_version_requirement_met?("8.2.0")
+      if PackerUtils.supports_async_loading?
         self.generated_component_packs_loading_strategy ||= :async
       elsif generated_component_packs_loading_strategy.nil?
         Rails.logger.warn("**WARNING** #{msg}")
@@ -194,15 +202,40 @@ module ReactOnRails
       raise ReactOnRails::Error, "generated_component_packs_loading_strategy must be either :async, :defer, or :sync"
     end
 
+    def validate_enforce_private_server_bundles
+      return unless enforce_private_server_bundles
+
+      # Check if server_bundle_output_path is nil
+      if server_bundle_output_path.nil?
+        raise ReactOnRails::Error, "enforce_private_server_bundles is set to true, but " \
+                                   "server_bundle_output_path is nil. Please set server_bundle_output_path " \
+                                   "to a directory outside of the public directory."
+      end
+
+      # Check if server_bundle_output_path is inside public directory
+      # Skip validation if Rails.root is not available (e.g., in tests)
+      return unless defined?(Rails) && Rails.root
+
+      public_path = Rails.root.join("public").to_s
+      server_output_path = File.expand_path(server_bundle_output_path, Rails.root.to_s)
+
+      return unless server_output_path.start_with?(public_path)
+
+      raise ReactOnRails::Error, "enforce_private_server_bundles is set to true, but " \
+                                 "server_bundle_output_path (#{server_bundle_output_path}) is inside " \
+                                 "the public directory. Please set it to a directory outside of public."
+    end
+
+    def check_minimum_shakapacker_version
+      ReactOnRails::PackerUtils.raise_shakapacker_version_incompatible_for_basic_pack_generation unless
+        ReactOnRails::PackerUtils.supports_basic_pack_generation?
+    end
+
     def check_autobundling_requirements
-      raise_missing_components_subdirectory if auto_load_bundle && !components_subdirectory.present?
-      return unless components_subdirectory.present?
+      raise_missing_components_subdirectory unless components_subdirectory.present?
 
-      ReactOnRails::PackerUtils.raise_shakapacker_not_installed unless ReactOnRails::PackerUtils.using_packer?
       ReactOnRails::PackerUtils.raise_shakapacker_version_incompatible_for_autobundling unless
-        ReactOnRails::PackerUtils.shakapacker_version_requirement_met?(
-          ReactOnRails::PacksGenerator::MINIMUM_SHAKAPACKER_VERSION
-        )
+        ReactOnRails::PackerUtils.supports_autobundling?
       ReactOnRails::PackerUtils.raise_nested_entries_disabled unless ReactOnRails::PackerUtils.nested_entries?
     end
 
@@ -221,8 +254,8 @@ module ReactOnRails
         # We set it very big so that it is not used, and then clean just
         # removes files older than 1 hour.
         versions = 100_000
-        puts "Invoking task #{ReactOnRails::PackerUtils.packer_type}:clean from React on Rails"
-        Rake::Task["#{ReactOnRails::PackerUtils.packer_type}:clean"].invoke(versions)
+        puts "Invoking task shakapacker:clean from React on Rails"
+        Rake::Task["shakapacker:clean"].invoke(versions)
       }
 
       if Rake::Task.task_defined?("assets:precompile")
@@ -237,22 +270,20 @@ module ReactOnRails
     end
 
     def error_if_using_packer_and_generated_assets_dir_not_match_public_output_path
-      return unless ReactOnRails::PackerUtils.using_packer?
-
       return if generated_assets_dir.blank?
 
       packer_public_output_path = ReactOnRails::PackerUtils.packer_public_output_path
 
       if File.expand_path(generated_assets_dir) == packer_public_output_path.to_s
         Rails.logger.warn("You specified generated_assets_dir in `config/initializers/react_on_rails.rb` " \
-                          "with #{ReactOnRails::PackerUtils.packer_type}. " \
+                          "with Shakapacker. " \
                           "Remove this line from your configuration file.")
       else
         msg = <<~MSG
-          Error configuring /config/initializers/react_on_rails.rb: You are using #{ReactOnRails::PackerUtils.packer_type}
+          Error configuring /config/initializers/react_on_rails.rb: You are using Shakapacker
           and your specified value for generated_assets_dir = #{generated_assets_dir}
           that does not match the value for public_output_path specified in
-          #{ReactOnRails::PackerUtils.packer_type}.yml = #{packer_public_output_path}. You should remove the configuration
+          shakapacker.yml = #{packer_public_output_path}. You should remove the configuration
           value for "generated_assets_dir" from your config/initializers/react_on_rails.rb file.
         MSG
         raise ReactOnRails::Error, msg
@@ -271,37 +302,21 @@ module ReactOnRails
       raise ReactOnRails::Error, msg
     end
 
-    def ensure_generated_assets_dir_present
-      return if generated_assets_dir.present? || ReactOnRails::PackerUtils.using_packer?
-
-      self.generated_assets_dir = DEFAULT_GENERATED_ASSETS_DIR
-      Rails.logger.warn "ReactOnRails: Set generated_assets_dir to default: #{DEFAULT_GENERATED_ASSETS_DIR}"
-    end
-
     def configure_generated_assets_dirs_deprecation
       return if generated_assets_dirs.blank?
 
-      if ReactOnRails::PackerUtils.using_packer?
-        packer_public_output_path = ReactOnRails::PackerUtils.packer_public_output_path
-        # rubocop:disable Layout/LineLength
-        packer_name = ReactOnRails::PackerUtils.packer_type&.upcase_first
+      packer_public_output_path = ReactOnRails::PackerUtils.packer_public_output_path
 
-        Rails.logger.warn "Error configuring config/initializers/react_on_rails. Define neither the generated_assets_dirs nor " \
-                          "the generated_assets_dir when using #{packer_name}. This is defined by " \
-                          "public_output_path specified in #{ReactOnRails::PackerUtils.packer_type}.yml = #{packer_public_output_path}."
-        # rubocop:enable Layout/LineLength
-        return
-      end
+      msg = <<~MSG
+        ReactOnRails Configuration Warning: The 'generated_assets_dirs' configuration option is no longer supported.
+        Since Shakapacker is now required, public asset paths are automatically determined from your shakapacker.yml configuration.
+        Please remove 'config.generated_assets_dirs' from your config/initializers/react_on_rails.rb file.
+        Public assets will be loaded from: #{packer_public_output_path}
+        If you need to customize the public output path, configure it in config/shakapacker.yml under 'public_output_path'.
+        Note: Private server bundles are configured separately via server_bundle_output_path.
+      MSG
 
-      Rails.logger.warn "[DEPRECATION] ReactOnRails: Use config.generated_assets_dir rather than " \
-                        "generated_assets_dirs"
-      if generated_assets_dir.blank?
-        self.generated_assets_dir = generated_assets_dirs
-      else
-        Rails.logger.warn "[DEPRECATION] ReactOnRails. You have both generated_assets_dirs and " \
-                          "generated_assets_dir defined. Define ONLY generated_assets_dir if NOT using Shakapacker " \
-                          "and define neither if using Webpacker"
-      end
+      Rails.logger.warn msg
     end
 
     def ensure_webpack_generated_files_exists
@@ -333,17 +348,15 @@ module ReactOnRails
     end
 
     def compile_command_conflict_message
-      packer_name = ReactOnRails::PackerUtils.packer_type.upcase_first
-      packer_type = ReactOnRails::PackerUtils.packer_type
       <<~MSG
 
-        React on Rails and #{packer_name} error in configuration!
+        React on Rails and Shakapacker error in configuration!
         In order to use config/react_on_rails.rb config.build_production_command,
-        you must edit config/#{packer_type}.yml to include this value in the default configuration:
-        '#{packer_type}_precompile: false'
+        you must edit config/shakapacker.yml to include this value in the default configuration:
+        'shakapacker_precompile: false'
 
         Alternatively, remove the config/react_on_rails.rb config.build_production_command and the
-        default bin/#{packer_type} script will be used for assets:precompile.
+        default bin/shakapacker script will be used for assets:precompile.
 
       MSG
     end

data/lib/react_on_rails/json_parse_error.rb

@@ -7,7 +7,12 @@ module ReactOnRails
     def initialize(parse_error:, json:)
       @json = json
       @original_error = parse_error
-      super(parse_error.message)
+      message = <<~MSG
+        #{parse_error.message}
+
+        #{Utils.default_troubleshooting_section}
+      MSG
+      super(message)
     end
 
     def to_honeybadger_context

data/lib/react_on_rails/packer_utils.rb

@@ -1,44 +1,19 @@
 # frozen_string_literal: true
 
+require "shakapacker"
+
 module ReactOnRails
   module PackerUtils
-    def self.using_packer?
-      using_shakapacker_const?
-    end
-
-    def self.using_shakapacker_const?
-      return @using_shakapacker_const if defined?(@using_shakapacker_const)
-
-      @using_shakapacker_const = ReactOnRails::Utils.gem_available?("shakapacker") &&
-                                 shakapacker_version_requirement_met?("8.2.0")
-    end
-
-    def self.packer_type
-      return "shakapacker" if using_shakapacker_const?
-
-      nil
-    end
-
-    def self.packer
-      return nil unless using_packer?
-
-      require "shakapacker"
-      ::Shakapacker
-    end
-
     def self.dev_server_running?
-      return false unless using_packer?
-
-      packer.dev_server.running?
+      Shakapacker.dev_server.running?
     end
 
     def self.dev_server_url
-      "#{packer.dev_server.protocol}://#{packer.dev_server.host_with_port}"
+      "#{Shakapacker.dev_server.protocol}://#{Shakapacker.dev_server.host_with_port}"
     end
 
     def self.shakapacker_version
       return @shakapacker_version if defined?(@shakapacker_version)
-      return nil unless ReactOnRails::Utils.gem_available?("shakapacker")
 
       @shakapacker_version = Gem.loaded_specs["shakapacker"].version.to_s
     end
@@ -53,14 +28,28 @@ module ReactOnRails
     end
 
     def self.shakapacker_version_requirement_met?(required_version)
-      Gem::Version.new(shakapacker_version) >= Gem::Version.new(required_version)
+      @version_checks ||= {}
+      @version_checks[required_version] ||= Gem::Version.new(shakapacker_version) >= Gem::Version.new(required_version)
+    end
+
+    def self.supports_async_loading?
+      shakapacker_version_requirement_met?("8.2.0")
+    end
+
+    def self.supports_basic_pack_generation?
+      shakapacker_version_requirement_met?(ReactOnRails::PacksGenerator::MINIMUM_SHAKAPACKER_VERSION)
+    end
+
+    def self.supports_autobundling?
+      min_version = ReactOnRails::PacksGenerator::MINIMUM_SHAKAPACKER_VERSION_FOR_AUTO_BUNDLING
+      ::Shakapacker.config.respond_to?(:nested_entries?) && shakapacker_version_requirement_met?(min_version)
     end
 
     # This returns either a URL for the webpack-dev-server, non-server bundle or
     # the hashed server bundle if using the same bundle for the client.
     # Otherwise returns a file path.
     def self.bundle_js_uri_from_packer(bundle_name)
-      hashed_bundle_name = packer.manifest.lookup!(bundle_name)
+      hashed_bundle_name = ::Shakapacker.manifest.lookup!(bundle_name)
 
       # Support for hashing the server-bundle and having that built
       # the webpack-dev-server is provided by the config value
@@ -69,7 +58,7 @@ module ReactOnRails
       is_bundle_running_on_server = (bundle_name == ReactOnRails.configuration.server_bundle_js_file) ||
                                     (bundle_name == ReactOnRails.configuration.rsc_bundle_js_file)
 
-      if packer.dev_server.running? && (!is_bundle_running_on_server ||
+      if ::Shakapacker.dev_server.running? && (!is_bundle_running_on_server ||
         ReactOnRails.configuration.same_bundle_for_client_and_server)
         "#{dev_server_url}#{hashed_bundle_name}"
       else
@@ -78,7 +67,7 @@ module ReactOnRails
     end
 
     def self.public_output_uri_path
-      "#{packer.config.public_output_path.relative_path_from(packer.config.public_path)}/"
+      "#{::Shakapacker.config.public_output_path.relative_path_from(::Shakapacker.config.public_path)}/"
     end
 
     # The function doesn't ensure that the asset exists.
@@ -93,42 +82,40 @@ module ReactOnRails
     end
 
     def self.precompile?
-      return ::Shakapacker.config.shakapacker_precompile? if using_shakapacker_const?
-
-      false
+      ::Shakapacker.config.shakapacker_precompile?
     end
 
     def self.packer_source_path
-      packer.config.source_path
+      ::Shakapacker.config.source_path
     end
 
     def self.packer_source_entry_path
-      packer.config.source_entry_path
+      ::Shakapacker.config.source_entry_path
     end
 
     def self.nested_entries?
-      packer.config.nested_entries?
+      ::Shakapacker.config.nested_entries?
     end
 
     def self.packer_public_output_path
-      packer.config.public_output_path.to_s
+      ::Shakapacker.config.public_output_path.to_s
     end
 
     def self.manifest_exists?
-      packer.config.public_manifest_path.exist?
+      ::Shakapacker.config.public_manifest_path.exist?
     end
 
     def self.packer_source_path_explicit?
-      packer.config.send(:data)[:source_path].present?
+      ::Shakapacker.config.send(:data)[:source_path].present?
     end
 
     def self.check_manifest_not_cached
-      return unless using_packer? && packer.config.cache_manifest?
+      return unless ::Shakapacker.config.cache_manifest?
 
       msg = <<-MSG.strip_heredoc
           ERROR: you have enabled cache_manifest in the #{Rails.env} env when using the
           ReactOnRails::TestHelper.configure_rspec_to_compile_assets helper
-          To fix this: edit your config/#{packer_type}.yml file and set cache_manifest to false for test.
+          To fix this: edit your config/shakapacker.yml file and set cache_manifest to false for test.
       MSG
       puts wrap_message(msg)
       exit!
@@ -149,7 +136,7 @@ module ReactOnRails
     def self.raise_nested_entries_disabled
       msg = <<~MSG
         **ERROR** ReactOnRails: `nested_entries` is configured to be disabled in shakapacker. Please update \
-        config/#{packer_type}.yml to enable nested entries. for more information read
+        config/shakapacker.yml to enable nested entries. for more information read
         https://www.shakacode.com/react-on-rails/docs/guides/file-system-based-automated-bundle-generation.md#enable-nested_entries-for-shakapacker
       MSG
 
@@ -158,19 +145,19 @@ module ReactOnRails
 
     def self.raise_shakapacker_version_incompatible_for_autobundling
       msg = <<~MSG
-        **ERROR** ReactOnRails: Please upgrade Shakapacker to version #{ReactOnRails::PacksGenerator::MINIMUM_SHAKAPACKER_VERSION} or \
-        above to use the automated bundle generation feature. The currently installed version is \
-        #{ReactOnRails::PackerUtils.shakapacker_version}.
+        **ERROR** ReactOnRails: Please upgrade ::Shakapacker to version #{ReactOnRails::PacksGenerator::MINIMUM_SHAKAPACKER_VERSION_FOR_AUTO_BUNDLING} or \
+        above to use the automated bundle generation feature (which requires nested_entries support). \
+        The currently installed version is #{ReactOnRails::PackerUtils.shakapacker_version}. \
+        Basic pack generation requires ::Shakapacker #{ReactOnRails::PacksGenerator::MINIMUM_SHAKAPACKER_VERSION} or above.
       MSG
 
       raise ReactOnRails::Error, msg
     end
 
-    def self.raise_shakapacker_not_installed
+    def self.raise_shakapacker_version_incompatible_for_basic_pack_generation
       msg = <<~MSG
-        **ERROR** ReactOnRails: Missing Shakapacker gem. Please upgrade to use Shakapacker \
-        #{ReactOnRails::PacksGenerator::MINIMUM_SHAKAPACKER_VERSION} or above to use the \
-        automated bundle generation feature.
+        **ERROR** ReactOnRails: Please upgrade ::Shakapacker to version #{ReactOnRails::PacksGenerator::MINIMUM_SHAKAPACKER_VERSION} or \
+        above to use basic pack generation features. The currently installed version is #{ReactOnRails::PackerUtils.shakapacker_version}.
       MSG
 
       raise ReactOnRails::Error, msg

data/lib/react_on_rails/packs_generator.rb

@@ -9,6 +9,8 @@ module ReactOnRails
     CONTAINS_CLIENT_OR_SERVER_REGEX = /\.(server|client)($|\.)/
     COMPONENT_EXTENSIONS = /\.(jsx?|tsx?)$/
     MINIMUM_SHAKAPACKER_VERSION = "6.5.1"
+    # Auto-registration requires nested_entries support which was added in 7.0.0
+    MINIMUM_SHAKAPACKER_VERSION_FOR_AUTO_BUNDLING = "7.0.0"
 
     def self.instance
       @instance ||= PacksGenerator.new
@@ -164,6 +166,7 @@ module ReactOnRails
 
     def add_generated_pack_to_server_bundle
       return if ReactOnRails.configuration.make_generated_server_bundle_the_entrypoint
+      return if ReactOnRails.configuration.server_bundle_js_file.blank?
 
       relative_path_to_generated_server_bundle = relative_path(server_bundle_entrypoint,
                                                                generated_server_bundle_file_path)

data/lib/react_on_rails/prerender_error.rb

@@ -83,6 +83,10 @@ module ReactOnRails
         MSG
 
       end
+
+      # Add help and support information
+      message << "\n#{Utils.default_troubleshooting_section}\n"
+
       [backtrace, message]
     end
   end

data/lib/react_on_rails/server_rendering_pool/ruby_embedded_java_script.rb

@@ -77,6 +77,7 @@ module ReactOnRails
             if err.message.include?("ReferenceError: self is not defined")
               msg << "\nError indicates that you may have code-splitting incorrectly enabled.\n"
             end
+            msg << "\n#{Utils.default_troubleshooting_section}\n"
             raise ReactOnRails::Error, msg, err.backtrace
           end
 
@@ -122,7 +123,7 @@ module ReactOnRails
         rescue StandardError => e
           msg = "You specified server rendering JS file: #{server_js_file}, but it cannot be " \
                 "read. You may set the server_bundle_js_file in your configuration to be \"\" to " \
-                "avoid this warning.\nError is: #{e}"
+                "avoid this warning.\nError is: #{e}\n\n#{Utils.default_troubleshooting_section}"
           raise ReactOnRails::Error, msg
         end
 
@@ -149,7 +150,8 @@ module ReactOnRails
             msg = "ERROR when compiling base_js_code! " \
                   "See file #{file_name} to " \
                   "correlate line numbers of error. Error is\n\n#{e.message}" \
-                  "\n\n#{e.backtrace.join("\n")}"
+                  "\n\n#{e.backtrace.join("\n")}" \
+                  "\n\n#{Utils.default_troubleshooting_section}"
             Rails.logger.error(msg)
             trace_js_code_used("Error when compiling JavaScript code for the context.", base_js_code,
                                file_name, force: true)
@@ -227,7 +229,7 @@ module ReactOnRails
           encoding_type = match[:encoding]
           response.body.force_encoding(encoding_type)
         rescue StandardError => e
-          msg = "file_url_to_string #{url} failed\nError is: #{e}"
+          msg = "file_url_to_string #{url} failed\nError is: #{e}\n\n#{Utils.default_troubleshooting_section}"
           raise ReactOnRails::Error, msg
         end
 

data/lib/react_on_rails/system_checker.rb

@@ -618,14 +618,14 @@ module ReactOnRails
           version = shakapacker_match[1].strip
 
           begin
-            # Use proper semantic version comparison
-            version_obj = Gem::Version.new(version)
-            threshold_version = Gem::Version.new("8.2")
+            # Validate version string format
+            Gem::Version.new(version)
 
-            if version_obj >= threshold_version
-              add_success("✅ Shakapacker #{version} (supports React on Rails auto-registration)")
+            if ReactOnRails::PackerUtils.supports_autobundling?
+              add_success("✅ Shakapacker #{version} (supports React on Rails auto-bundling)")
             else
-              add_warning("⚠️  Shakapacker #{version} - Version 8.2+ needed for React on Rails auto-registration")
+              add_warning("⚠️  Shakapacker #{version} - Version 7.0+ with nested_entries support needed " \
+                          "for React on Rails auto-bundling")
             end
           rescue ArgumentError
             # Fallback for invalid version strings

data/lib/react_on_rails/test_helper/webpack_assets_compiler.rb

@@ -16,7 +16,7 @@ module ReactOnRails
 
             React on Rails is aborting your test run
 
-            If you wish to use the config/#{ReactOnRails::PackerUtils.packer_type}.yml compile option for tests
+            If you wish to use the config/shakapacker.yml compile option for tests
             them remove your call to the ReactOnRails test helper.
           MSG
           puts Rainbow(msg).red

data/lib/react_on_rails/test_helper/webpack_assets_status_checker.rb

@@ -31,8 +31,7 @@ module ReactOnRails
       end
 
       def stale_generated_files(files)
-        manifest_needed = ReactOnRails::PackerUtils.using_packer? &&
-                          !ReactOnRails::PackerUtils.manifest_exists?
+        manifest_needed = !ReactOnRails::PackerUtils.manifest_exists?
 
         return ["manifest.json"] if manifest_needed
 

data/lib/react_on_rails/test_helper.rb

@@ -86,10 +86,9 @@ module ReactOnRails
           puts
           @printed_once = true
 
-          if ReactOnRails::PackerUtils.using_packer? &&
-             ReactOnRails::Utils.using_packer_source_path_is_not_defined_and_custom_node_modules?
+          if ReactOnRails::Utils.using_packer_source_path_is_not_defined_and_custom_node_modules?
             msg = <<-MSG.strip_heredoc
-              WARNING: Define config/#{ReactOnRails::PackerUtils.packer_type}.yml to include sourcePath to configure
+              WARNING: Define config/shakapacker.yml to include sourcePath to configure
               the location of your JavaScript source for React on Rails.
               Default location of #{source_path} is used.
             MSG