react_on_rails 12.4.0 → 13.0.0

data/lib/generators/react_on_rails/templates/base/base/config/webpack/webpackConfig.js.tt

@@ -0,0 +1,36 @@
+<%= add_documentation_reference(config[:message], "// https://github.com/shakacode/react_on_rails_tutorial_with_ssr_and_hmr_fast_refresh/blob/master/config/webpack/webpackConfig.js") %>
+
+const clientWebpackConfig = require('./clientWebpackConfig');
+const serverWebpackConfig = require('./serverWebpackConfig');
+
+const webpackConfig = (envSpecific) => {
+  const clientConfig = clientWebpackConfig();
+  const serverConfig = serverWebpackConfig();
+
+  if (envSpecific) {
+    envSpecific(clientConfig, serverConfig);
+  }
+
+  let result;
+  // For HMR, need to separate the the client and server webpack configurations
+  if (process.env.WEBPACK_SERVE || process.env.CLIENT_BUNDLE_ONLY) {
+    // eslint-disable-next-line no-console
+    console.log('[React on Rails] Creating only the client bundles.');
+    result = clientConfig;
+  } else if (process.env.SERVER_BUNDLE_ONLY) {
+    // eslint-disable-next-line no-console
+    console.log('[React on Rails] Creating only the server bundle.');
+    result = serverConfig;
+  } else {
+    // default is the standard client and server build
+    // eslint-disable-next-line no-console
+    console.log('[React on Rails] Creating both client and server bundles.');
+    result = [clientConfig, serverConfig];
+  }
+
+  // To debug, uncomment next line and inspect "result"
+  // debugger
+  return result;
+};
+
+module.exports = webpackConfig;

data/lib/generators/react_on_rails/templates/base/base/config/webpacker.yml

@@ -0,0 +1,62 @@
+# Note: You must restart bin/webpacker-dev-server for changes to take effect
+
+default: &default
+  source_path: app/javascript
+  source_entry_path: packs
+  public_root_path: public
+  public_output_path: packs
+  cache_path: tmp/webpacker
+  webpack_compile_output: true
+
+  # Additional paths webpack should lookup modules
+  # ['app/assets', 'engine/foo/app/assets']
+  additional_paths: []
+
+  # Reload manifest.json on all requests so we reload latest compiled packs
+  cache_manifest: false
+
+development:
+  <<: *default
+  # This is false since we're running `bin/webpacker -w` in Procfile.dev-setic
+  compile: false
+
+  # Reference: https://webpack.js.org/configuration/dev-server/
+  dev_server:
+    https: false
+    host: localhost
+    port: 3035
+    # Hot Module Replacement updates modules while the application is running without a full reload
+    hmr: true
+    client:
+      # Should we show a full-screen overlay in the browser when there are compiler errors or warnings?
+      overlay: true
+      # May also be a string
+      # webSocketURL:
+      #  hostname: "0.0.0.0"
+      #  pathname: "/ws"
+      #  port: 8080
+    compress: true
+    # Note that apps that do not check the host are vulnerable to DNS rebinding attacks
+    allowed_hosts: [ 'localhost' ]
+    pretty: true
+    headers:
+      'Access-Control-Allow-Origin': '*'
+    static:
+      watch:
+        ignored: '**/node_modules/**'
+
+test:
+  <<: *default
+  compile: true
+
+  # Compile test packs to a separate directory
+  public_output_path: packs-test
+
+production:
+  <<: *default
+
+  # Production depends on precompilation of packs prior to booting for performance.
+  compile: false
+
+  # Cache manifest.json for performance
+  cache_manifest: true

data/lib/generators/react_on_rails/templates/redux/base/app/javascript/bundles/HelloWorld/components/HelloWorld.jsx

@@ -1,5 +1,6 @@
 import PropTypes from 'prop-types';
 import React from 'react';
+import style from './HelloWorld.module.css';
 
 const HelloWorld = ({ name, updateName }) => (
   <div>
@@ -9,7 +10,7 @@ const HelloWorld = ({ name, updateName }) => (
     </h3>
     <hr />
     <form>
-      <label htmlFor="name">
+      <label className={style.bright} htmlFor="name">
         Say hello to:
         <input id="name" type="text" value={name} onChange={(e) => updateName(e.target.value)} />
       </label>

data/lib/react_on_rails/configuration.rb

@@ -32,6 +32,7 @@ module ReactOnRails
       # skip_display_none is deprecated
       webpack_generated_files: %w[manifest.json],
       rendering_extension: nil,
+      rendering_props_extension: nil,
       server_render_method: nil,
       build_test_command: "",
       build_production_command: "",
@@ -51,7 +52,7 @@ module ReactOnRails
                   :build_production_command,
                   :i18n_dir, :i18n_yml_dir, :i18n_output_format,
                   :server_render_method, :random_dom_id,
-                  :same_bundle_for_client_and_server
+                  :same_bundle_for_client_and_server, :rendering_props_extension
 
     # rubocop:disable Metrics/AbcSize
     def initialize(node_modules_location: nil, server_bundle_js_file: nil, prerender: nil,
@@ -65,7 +66,7 @@ module ReactOnRails
                    build_production_command: nil,
                    same_bundle_for_client_and_server: nil,
                    i18n_dir: nil, i18n_yml_dir: nil, i18n_output_format: nil,
-                   random_dom_id: nil, server_render_method: nil)
+                   random_dom_id: nil, server_render_method: nil, rendering_props_extension: nil)
       self.node_modules_location = node_modules_location.present? ? node_modules_location : Rails.root
       self.generated_assets_dirs = generated_assets_dirs
       self.generated_assets_dir = generated_assets_dir
@@ -87,6 +88,7 @@ module ReactOnRails
       self.trace = trace.nil? ? Rails.env.development? : trace
       self.raise_on_prerender_error = raise_on_prerender_error
       self.skip_display_none = skip_display_none
+      self.rendering_props_extension = rendering_props_extension
 
       # Server rendering:
       self.server_bundle_js_file = server_bundle_js_file
@@ -111,44 +113,41 @@ module ReactOnRails
       check_i18n_yml_directory_exists
       check_server_render_method_is_only_execjs
       error_if_using_webpacker_and_generated_assets_dir_not_match_public_output_path
-      check_deprecated_settings
+      # check_deprecated_settings
+      adjust_precompile_task
     end
 
     private
 
-    def check_deprecated_settings
-      if build_production_command.present? &&
-         ReactOnRails::WebpackerUtils.webpacker_webpack_production_config_exists?
-        msg = <<~MSG
-          Setting ReactOnRails configuration for `build_production_command` is
-          not necessary if you have config/webpack/production.js. When that file
-          exists, React on Rails DOES NOT modify the standard assets:precompile.
-          If you want React on Rails to modify to the standard assets:precompile
-          to use your config/initializers/react_on_rails.rb config.build_production_command
-          then delete the config/webpack/production.js.
-        MSG
-        Rails.logger.warn(msg)
+    def adjust_precompile_task
+      skip_react_on_rails_precompile = %w[no false n f].include?(ENV["REACT_ON_RAILS_PRECOMPILE"])
+
+      return if skip_react_on_rails_precompile || build_production_command.blank?
+
+      # Ensure that shakacode/shakapacker does not call bin/webpacker if we're providing
+      # the build command.
+      ENV["WEBPACKER_PRECOMPILE"] = "false"
+
+      precompile_tasks = lambda {
+        Rake::Task["react_on_rails:assets:webpack"].invoke
+        puts "Invoking task webpacker:clean from React on Rails"
+
+        # VERSIONS is per the shakacode/shakapacker clean method definition.
+        # We set it very big so that it is not used, and then clean just
+        # removes files older than 1 hour.
+        versions = 100_000
+        Rake::Task["webpacker:clean"].invoke(versions)
+      }
+
+      if Rake::Task.task_defined?("assets:precompile")
+        Rake::Task["assets:precompile"].enhance do
+          precompile_tasks.call
+        end
+      else
+        Rake::Task.define_task("assets:precompile") do
+          precompile_tasks.call
+        end
       end
-      #
-      # msg = <<~MSG
-      #   ReactOnRails configuration for `build_production_command` is removed.
-      #   Move this command into `bin/webpack` converting the script to a shell script.
-      # MSG
-      # raise ReactOnRails::Error, msg
-      # Commenting out until v13 when
-      # https://github.com/rails/webpacker/issues/2640 gets resolved
-      # if node_modules_location.present?
-      #   Rails.logger.warn("ReactOnRails configuration for `node_modules_location` is deprecated. "\
-      #    "Instead, prepend a `cd client` (or whichever location) before your test command.")
-      # end
-      #
-      # return unless build_production_command.present?
-      #
-      # msg = <<~MSG
-      #   ReactOnRails configuration for `build_production_command` is removed.
-      #   Move this command into `bin/webpack` converting the script to a shell script.
-      # MSG
-      # raise ReactOnRails::Error, msg
     end
 
     def error_if_using_webpacker_and_generated_assets_dir_not_match_public_output_path
@@ -160,7 +159,7 @@ module ReactOnRails
 
       if File.expand_path(generated_assets_dir) == webpacker_public_output_path.to_s
         Rails.logger.warn("You specified generated_assets_dir in `config/initializers/react_on_rails.rb` "\
-        "with Webpacker. Remove this line from your configuration file.")
+                          "with Webpacker. Remove this line from your configuration file.")
       else
         msg = <<~MSG
           Error configuring /config/initializers/react_on_rails.rb: You are using webpacker
@@ -222,19 +221,19 @@ module ReactOnRails
       if ReactOnRails::WebpackerUtils.using_webpacker?
         webpacker_public_output_path = ReactOnRails::WebpackerUtils.webpacker_public_output_path
         Rails.logger.warn "Error configuring config/initializers/react_on_rails. Define neither the "\
-        "generated_assets_dirs no the generated_assets_dir when using Webpacker. This is defined by "\
-        "public_output_path specified in webpacker.yml = #{webpacker_public_output_path}."
+                          "generated_assets_dirs no the generated_assets_dir when using Webpacker. This is defined by "\
+                          "public_output_path specified in webpacker.yml = #{webpacker_public_output_path}."
         return
       end
 
       Rails.logger.warn "[DEPRECATION] ReactOnRails: Use config.generated_assets_dir rather than "\
-        "generated_assets_dirs"
+                        "generated_assets_dirs"
       if generated_assets_dir.blank?
         self.generated_assets_dir = generated_assets_dirs
       else
         Rails.logger.warn "[DEPRECATION] ReactOnRails. You have both generated_assets_dirs and "\
-          "generated_assets_dir defined. Define ONLY generated_assets_dir if NOT using Webpacker"\
-          " and define neither if using Webpacker"
+                          "generated_assets_dir defined. Define ONLY generated_assets_dir if NOT using Webpacker"\
+                          " and define neither if using Webpacker"
       end
     end
 

data/lib/react_on_rails/helper.rb

@@ -154,7 +154,7 @@ module ReactOnRails
         @registered_stores_defer_render ||= []
         @registered_stores_defer_render << redux_store_data
         "YOU SHOULD NOT SEE THIS ON YOUR VIEW -- Uses as a code block, like <% redux_store %> "\
-        "and not <%= redux store %>"
+          "and not <%= redux store %>"
       else
         @registered_stores ||= []
         @registered_stores << redux_store_data
@@ -234,9 +234,9 @@ module ReactOnRails
       console_log_script = result["consoleLogScript"]
       raw("#{html}#{render_options.replay_console ? console_log_script : ''}")
     rescue ExecJS::ProgramError => err
-      raise ReactOnRails::PrerenderError, component_name: "N/A (server_render_js called)",
-                                          err: err,
-                                          js_code: js_code
+      raise ReactOnRails::PrerenderError.new(component_name: "N/A (server_render_js called)",
+                                             err: err,
+                                             js_code: js_code)
     end
 
     def json_safe_and_pretty(hash_or_string)
@@ -244,7 +244,7 @@ module ReactOnRails
 
       unless hash_or_string.is_a?(String) || hash_or_string.is_a?(Hash)
         raise ReactOnRails::Error, "#{__method__} only accepts String or Hash as argument "\
-            "(#{hash_or_string.class} given)."
+                                   "(#{hash_or_string.class} given)."
       end
 
       json_value = hash_or_string.is_a?(String) ? hash_or_string : hash_or_string.to_json
@@ -309,6 +309,7 @@ module ReactOnRails
 
       @rails_context.merge(serverSide: server_side)
     end
+
     # rubocop:enable Metrics/AbcSize, Metrics/CyclomaticComplexity
 
     private
@@ -413,7 +414,7 @@ module ReactOnRails
       # Setup the page_loaded_js, which is the same regardless of prerendering or not!
       # The reason is that React is smart about not doing extra work if the server rendering did its job.
       component_specification_tag = content_tag(:script,
-                                                json_safe_and_pretty(render_options.props).html_safe,
+                                                json_safe_and_pretty(render_options.client_props).html_safe,
                                                 type: "application/json",
                                                 class: "js-react-on-rails-component",
                                                 "data-component-name" => render_options.react_component_name,
@@ -483,21 +484,21 @@ module ReactOnRails
         result = ReactOnRails::ServerRenderingPool.server_render_js_with_console_logging(js_code, render_options)
       rescue StandardError => err
         # This error came from the renderer
-        raise ReactOnRails::PrerenderError, component_name: react_component_name,
-                                            # Sanitize as this might be browser logged
-                                            props: sanitized_props_string(props),
-                                            err: err,
-                                            js_code: js_code
+        raise ReactOnRails::PrerenderError.new(component_name: react_component_name,
+                                               # Sanitize as this might be browser logged
+                                               props: sanitized_props_string(props),
+                                               err: err,
+                                               js_code: js_code)
       end
 
       if result["hasErrors"] && render_options.raise_on_prerender_error
         # We caught this exception on our backtrace handler
-        raise ReactOnRails::PrerenderError, component_name: react_component_name,
-                                            # Sanitize as this might be browser logged
-                                            props: sanitized_props_string(props),
-                                            err: nil,
-                                            js_code: js_code,
-                                            console_messages: result["consoleReplayScript"]
+        raise ReactOnRails::PrerenderError.new(component_name: react_component_name,
+                                               # Sanitize as this might be browser logged
+                                               props: sanitized_props_string(props),
+                                               err: nil,
+                                               js_code: js_code,
+                                               console_messages: result["consoleReplayScript"])
 
       end
       result

data/lib/react_on_rails/json_parse_error.rb

@@ -4,7 +4,7 @@ module ReactOnRails
   class JsonParseError < ::ReactOnRails::Error
     attr_reader :json
 
-    def initialize(parse_error, json)
+    def initialize(parse_error:, json:)
       @json = json
       @original_error = parse_error
       super(parse_error.message)

data/lib/react_on_rails/locales/base.rb

@@ -85,9 +85,7 @@ module ReactOnRails
 
       def generate_file(template, path)
         result = ERB.new(template).result()
-        File.open(path, "w") do |f|
-          f.write(result)
-        end
+        File.write(path, result)
       end
 
       def generate_translations

data/lib/react_on_rails/prerender_error.rb

@@ -49,10 +49,13 @@ module ReactOnRails
       message = +"ERROR in SERVER PRERENDERING\n"
       if err
         message << <<~MSG
-          Encountered error: \"#{err}\"
+          Encountered error:
+
+          #{err}
+
         MSG
 
-        backtrace = err.backtrace.join("\n")
+        backtrace = err.backtrace.first(15).join("\n")
       else
         backtrace = nil
       end

data/lib/react_on_rails/react_component/render_options.rb

@@ -27,6 +27,20 @@ module ReactOnRails
         options.fetch(:props) { NO_PROPS }
       end
 
+      def client_props
+        props_extension = ReactOnRails.configuration.rendering_props_extension
+        if props_extension.present?
+          if props_extension.respond_to?(:adjust_props_for_client_side_hydration)
+            return props_extension.adjust_props_for_client_side_hydration(react_component_name,
+                                                                          props.clone)
+          end
+
+          raise ReactOnRails::Error, "ReactOnRails: your rendering_props_extension module is missing the "\
+                                     "required adjust_props_for_client_side_hydration method & can not be used"
+        end
+        props
+      end
+
       def random_dom_id
         retrieve_configuration_value_for(:random_dom_id)
       end

data/lib/react_on_rails/server_rendering_js_code.rb

@@ -18,6 +18,19 @@ module ReactOnRails
         react_component_name: nil,
         render_options: nil
       )
+
+        config_server_bundle_js = ReactOnRails.configuration.server_bundle_js_file
+
+        if render_options.prerender == true && config_server_bundle_js.blank?
+          msg = <<~MSG
+            The `prerender` option to allow Server Side Rendering is marked as true but the ReactOnRails configuration
+            for `server_bundle_js_file` is nil or not present in `config/initializers/react_on_rails.rb`.
+            Set `config.server_bundle_js_file` to your javascript bundle to allow server side rendering.
+            Read more at https://www.shakacode.com/react-on-rails/docs/guides/react-server-rendering/
+          MSG
+          raise ReactOnRails::Error, msg
+        end
+
         js_code_renderer.render(props_string, rails_context, redux_stores, react_component_name, render_options)
       end
 

data/lib/react_on_rails/server_rendering_pool/ruby_embedded_java_script.rb

@@ -47,7 +47,7 @@ module ReactOnRails
         # Note, js_code does not have to be based on React.
         # js_code MUST RETURN json stringify Object
         # Calling code will probably call 'html_safe' on return value before rendering to the view.
-        # rubocop:disable Metrics/CyclomaticComplexity
+        # rubocop:disable Metrics/CyclomaticComplexity, Metrics/AbcSize, Metrics/PerceivedComplexity
         def exec_server_render_js(js_code, render_options, js_evaluator = nil)
           js_evaluator ||= self
           if render_options.trace
@@ -56,12 +56,27 @@ module ReactOnRails
                                "tmp/server-generated-#{@file_index % 10}.js")
             @file_index += 1
           end
-          json_string = js_evaluator.eval_js(js_code, render_options)
+          begin
+            json_string = js_evaluator.eval_js(js_code, render_options)
+          rescue StandardError => err
+            msg = <<~MSG
+              Error evaluating server bundle. Check your webpack configuration.
+              ===============================================================
+              Caught error:
+              #{err.message}
+              ===============================================================
+            MSG
+
+            if err.message.include?("ReferenceError: self is not defined")
+              msg << "\nError indicates that you may have code-splitting incorrectly enabled.\n"
+            end
+            raise ReactOnRails::Error, msg, err.backtrace
+          end
           result = nil
           begin
             result = JSON.parse(json_string)
           rescue JSON::ParserError => e
-            raise ReactOnRails::JsonParseError.new(e, json_string)
+            raise ReactOnRails::JsonParseError.new(parse_error: e, json: json_string)
           end
 
           if render_options.logging_on_server
@@ -76,7 +91,7 @@ module ReactOnRails
           end
           result
         end
-        # rubocop:enable Metrics/CyclomaticComplexity
+        # rubocop:enable Metrics/CyclomaticComplexity, Metrics/AbcSize, Metrics/PerceivedComplexity
 
         def trace_js_code_used(msg, js_code, file_name = "tmp/server-generated.js", force: false)
           return unless ReactOnRails.configuration.trace || force
@@ -133,15 +148,15 @@ module ReactOnRails
             if ReactOnRails.configuration.trace
               Rails.logger.info do
                 "[react_on_rails] Created JavaScript context with file "\
-                "#{ReactOnRails::Utils.server_bundle_js_file_path}"
+                  "#{ReactOnRails::Utils.server_bundle_js_file_path}"
               end
             end
             ExecJS.compile(base_js_code)
           rescue StandardError => e
             msg = "ERROR when compiling base_js_code! "\
-              "See file #{file_name} to "\
-              "correlate line numbers of error. Error is\n\n#{e.message}"\
-              "\n\n#{e.backtrace.join("\n")}"
+                  "See file #{file_name} to "\
+                  "correlate line numbers of error. Error is\n\n#{e.message}"\
+                  "\n\n#{e.backtrace.join("\n")}"
             Rails.logger.error(msg)
             trace_js_code_used("Error when compiling JavaScript code for the context.", base_js_code,
                                file_name, force: true)
@@ -150,7 +165,9 @@ module ReactOnRails
         end
 
         def execjs_timer_polyfills
-          if ReactOnRails::Utils.react_on_rails_pro? && ReactOnRailsPro.configuration.include_execjs_polyfills == false
+          if ReactOnRails::Utils.react_on_rails_pro? &&
+             ReactOnRailsPro.configuration.respond_to?(:include_execjs_polyfills) &&
+             ReactOnRailsPro.configuration.include_execjs_polyfills == false
             return ""
           end
 
@@ -184,7 +201,7 @@ module ReactOnRails
         def undefined_for_exec_js_logging(function_name)
           if ReactOnRails.configuration.trace
             "console.error('[React on Rails Rendering] #{function_name} is not defined for server rendering.');\n"\
-            "  console.error(getStackTrace().join('\\n'));"
+              "  console.error(getStackTrace().join('\\n'));"
           else
             ""
           end

data/lib/react_on_rails/test_helper/webpack_assets_status_checker.rb

@@ -66,10 +66,10 @@ module ReactOnRails
             file_list = make_file_list(make_globs(generated_assets_full_path)).to_ary
             puts "V" * 80
             puts "Please define config.webpack_generated_files (array) so the test helper knows "\
-            "which files are required. If you are using webpacker, you typically need to only "\
-            "include 'manifest.json'."
+                 "which files are required. If you are using webpacker, you typically need to only "\
+                 "include 'manifest.json'."
             puts "Detected the possible following files to check for webpack compilation in "\
-              "#{generated_assets_full_path}"
+                 "#{generated_assets_full_path}"
             puts file_list.join("\n")
             puts "^" * 80
             file_list

data/lib/react_on_rails/test_helper.rb

@@ -72,8 +72,8 @@ module ReactOnRails
         unless @printed_once
           puts
           puts "====> React On Rails: Checking files in "\
-            "#{webpack_assets_status_checker.generated_assets_full_path} for "\
-            "outdated/missing bundles based on source_path #{source_path}"
+               "#{webpack_assets_status_checker.generated_assets_full_path} for "\
+               "outdated/missing bundles based on source_path #{source_path}"
           puts
           @printed_once = true
 

data/lib/react_on_rails/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ReactOnRails
-  VERSION = "12.4.0"
+  VERSION = "13.0.0"
 end

data/lib/react_on_rails/webpacker_utils.rb

@@ -7,13 +7,8 @@ module ReactOnRails
     def self.using_webpacker?
       return @using_webpacker if defined?(@using_webpacker)
 
-      @using_webpacker = ReactOnRails::Utils.gem_available?("webpacker")
-    end
-
-    def self.webpacker_webpack_production_config_exists?
-      webpacker_webpack_config_abs_path = File.join(Rails.root,
-                                                    "config/webpack/production.js")
-      File.exist?(webpacker_webpack_config_abs_path)
+      @using_webpacker = ReactOnRails::Utils.gem_available?("webpacker") ||
+                         ReactOnRails::Utils.gem_available?("shakapacker")
     end
 
     def self.dev_server_running?

data/lib/tasks/assets.rake

@@ -1,51 +1,12 @@
 # frozen_string_literal: true
 
-# Important: The default assets:precompile is modified ONLY if the rails/webpacker webpack config
-# does not exist!
-
-require "active_support"
-
-ENV["RAILS_ENV"] ||= ENV["RACK_ENV"] || "development"
-
-skip_react_on_rails_precompile = %w[no false n f].include?(ENV["REACT_ON_RAILS_PRECOMPILE"])
-
-if !skip_react_on_rails_precompile && !ReactOnRails::WebpackerUtils.webpacker_webpack_production_config_exists?
-  # Ensure that rails/webpacker does not call bin/webpack if we're providing
-  # the build command.
-  ENV["WEBPACKER_PRECOMPILE"] = "false"
-
-  precompile_tasks = lambda {
-    Rake::Task["react_on_rails:assets:webpack"].invoke
-    puts "Invoking task webpacker:clean from React on Rails"
-
-    # VERSIONS is per the rails/webpacker clean method definition.
-    # We set it very big so that it is not used, and then clean just
-    # removes files older than 1 hour.
-    versions = 100_000
-    Rake::Task["webpacker:clean"].invoke(versions)
-  }
-
-  if Rake::Task.task_defined?("assets:precompile")
-    Rake::Task["assets:precompile"].enhance do
-      precompile_tasks.call
-    end
-  else
-    Rake::Task.define_task("assets:precompile") do
-      precompile_tasks.call
-    end
-  end
-end
-
-# Sprockets independent tasks
 # rubocop:disable Metrics/BlockLength
 namespace :react_on_rails do
   namespace :assets do
-    desc <<-DESC.strip_heredoc
-      Compile assets with webpack
-      Uses command defined with ReactOnRails.configuration.build_production_command
-      sh "#{ReactOnRails::Utils.prepend_cd_node_modules_directory('<ReactOnRails.configuration.build_production_command>')}"
-      Note: This command is not automatically added to assets:precompile if the rails/webpacker
-      configuration file config/webpack/production.js exists.
+    desc <<~DESC
+      If config.build_production_command is defined, this command is automatically
+      added to task assets:precompile and the regular webpacker compile will not run.
+      The defined command is either a script or a module with a method `call`.
     DESC
     task webpack: :locale do
       build_production_command = ReactOnRails.configuration.build_production_command
@@ -63,13 +24,10 @@ namespace :react_on_rails do
           exit!(1)
         end
       else
+        # Left in this warning message in case this rake task is run directly
         msg = <<~MSG
           React on Rails is aborting webpack compilation from task react_on_rails:assets:webpack
           because you do not have the `config.build_production_command` defined.
-
-          Note, this task may have run as part of `assets:precompile`. If file
-          config/webpack/production.js does not exist, React on Rails will modify
-          the default `asset:precompile` to run task `react_on_rails:assets:webpack`.
         MSG
         puts Rainbow(msg).red
         exit!(1)

data/lib/tasks/locale.rake

@@ -3,10 +3,9 @@
 require "react_on_rails/locales/base"
 require "react_on_rails/locales/to_js"
 require "react_on_rails/locales/to_json"
-require "active_support"
 
 namespace :react_on_rails do
-  desc <<-DESC.strip_heredoc
+  desc <<~DESC
     Generate i18n javascript files
     This task generates javascript locale files: `translations.js` & `default.js` and places them in
     the "ReactOnRails.configuration.i18n_dir".

data/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-on-rails",
-  "version": "12.4.0",
+  "version": "13.0.0",
   "description": "react-on-rails JavaScript for react_on_rails Ruby gem",
   "main": "node_package/lib/ReactOnRails.js",
   "directories": {