react_on_rails 12.0.0 → 12.0.4

data/rakelib/task_helpers.rb

@@ -17,9 +17,8 @@ module ReactOnRails
     end
 
     # Executes a string or an array of strings in a shell in the given directory
-    def sh_in_dir(dir, shell_commands)
-      shell_commands = [shell_commands] if shell_commands.is_a?(String)
-      shell_commands.each { |shell_command| sh %(cd #{dir} && #{shell_command.strip}) }
+    def sh_in_dir(dir, *shell_commands)
+      shell_commands.flatten.each { |shell_command| sh %(cd #{dir} && #{shell_command.strip}) }
     end
 
     def bundle_install_in(dir)

data/react_on_rails.gemspec

@@ -32,27 +32,13 @@ Gem::Specification.new do |s|
   s.add_dependency "rainbow", "~> 3.0"
   s.add_dependency "webpacker", ">= 4.0"
 
-  s.add_development_dependency "awesome_print"
   s.add_development_dependency "bundler", "~> 2"
-  s.add_development_dependency "coveralls"
   s.add_development_dependency "gem-release"
-  s.add_development_dependency "generator_spec"
-  s.add_development_dependency "listen"
-  s.add_development_dependency "pry"
-  s.add_development_dependency "pry-byebug"
-  s.add_development_dependency "pry-doc"
-  s.add_development_dependency "pry-rescue"
-  s.add_development_dependency "pry-state"
-  s.add_development_dependency "rails", "~> 5.2"
-
-  s.add_development_dependency "rake", "~> 10.0"
-  s.add_development_dependency "rspec"
-  s.add_development_dependency "rubocop", "0.85.0"
-
   s.post_install_message = '
 --------------------------------------------------------------------------------
-Email contact@shakacode.com for access to our slack room and information about our "pro support plan"
-which supports better performance, via caching helpers and our node rendering server.
+Checkout https://www.shakacode.com/react-on-rails-pro for information about
+"React on Rails Pro" which includes one hour a month of support and a gem for
+better performance, via caching helpers, and our node rendering server.
 --------------------------------------------------------------------------------
 '
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: react_on_rails
 version: !ruby/object:Gem::Version
-  version: 12.0.0
+  version: 12.0.4
 platform: ruby
 authors:
 - Justin Gordon
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-07-08 00:00:00.000000000 Z
+date: 2020-11-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -94,20 +94,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '4.0'
-- !ruby/object:Gem::Dependency
-  name: awesome_print
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -122,20 +108,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2'
-- !ruby/object:Gem::Dependency
-  name: coveralls
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: gem-release
   requirement: !ruby/object:Gem::Requirement
@@ -150,160 +122,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: generator_spec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: listen
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: pry
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: pry-byebug
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: pry-doc
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: pry-rescue
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: pry-state
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rails
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '5.2'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '5.2'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '10.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '10.0'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 0.85.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 0.85.0
 description: See README.md
 email:
 - justin@shakacode.com
@@ -318,6 +136,10 @@ files:
 - ".eslintignore"
 - ".eslintrc"
 - ".github/FUNDING.yml"
+- ".github/workflows/lint-js-and-ruby.yml"
+- ".github/workflows/main.yml"
+- ".github/workflows/package-js-tests.yml"
+- ".github/workflows/rspec-package-specs.yml"
 - ".gitignore"
 - ".npmignore"
 - ".prettierignore"
@@ -331,6 +153,7 @@ files:
 - CONTRIBUTING.md
 - Dockerfile_tests
 - Gemfile
+- Gemfile.development_dependencies
 - KUDOS.md
 - LICENSE.md
 - NEWS.md
@@ -346,6 +169,7 @@ files:
 - docs/additional-reading/asset-pipeline.md
 - docs/additional-reading/capistrano-deployment.md
 - docs/additional-reading/convert-rails-5-api-only-app.md
+- docs/additional-reading/converting-from-custom-webpack-config-to-rails-webpacker-config.md
 - docs/additional-reading/credits.md
 - docs/additional-reading/elastic-beanstalk.md
 - docs/additional-reading/foreman-issues.md
@@ -356,13 +180,13 @@ files:
 - docs/additional-reading/react-and-redux.md
 - docs/additional-reading/react-helmet.md
 - docs/additional-reading/react-router.md
+- docs/additional-reading/recommended-project-structure.md
 - docs/additional-reading/server-rendering-tips.md
 - docs/additional-reading/tips.md
 - docs/additional-reading/troubleshooting-when-using-webpacker.md
 - docs/additional-reading/turbolinks.md
 - docs/additional-reading/updating-dependencies.md
 - docs/additional-reading/upgrade-webpacker-v3-to-v4.md
-- docs/additional-reading/webpack-dev-server.md
 - docs/additional-reading/webpack-v1-notes.md
 - docs/additional-reading/webpack.md
 - docs/api/javascript-api.md
@@ -380,7 +204,6 @@ files:
 - docs/basics/migrating-from-react-rails.md
 - docs/basics/minitest-configuration.md
 - docs/basics/react-server-rendering.md
-- docs/basics/recommended-project-structure.md
 - docs/basics/render-functions-and-railscontext.md
 - docs/basics/rspec-configuration.md
 - docs/basics/upgrading-react-on-rails.md
@@ -475,7 +298,6 @@ files:
 - rakelib/run_rspec.rake
 - rakelib/task_helpers.rb
 - react_on_rails.gemspec
-- ruby-lint.yml
 - script/bootstrap
 - script/release
 - script/setup
@@ -490,8 +312,9 @@ metadata: {}
 post_install_message: |2
 
   --------------------------------------------------------------------------------
-  Email contact@shakacode.com for access to our slack room and information about our "pro support plan"
-  which supports better performance, via caching helpers and our node rendering server.
+  Checkout https://www.shakacode.com/react-on-rails-pro for information about
+  "React on Rails Pro" which includes one hour a month of support and a gem for
+  better performance, via caching helpers, and our node rendering server.
   --------------------------------------------------------------------------------
 rdoc_options: []
 require_paths:
@@ -507,8 +330,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.8
-signing_key: 
+rubygems_version: 3.1.4
+signing_key:
 specification_version: 4
 summary: Rails with react server rendering with webpack.
 test_files: []

data/docs/additional-reading/webpack-dev-server.md

@@ -1,15 +0,0 @@
-## Developing with the Webpack Dev Server
-One of the benefits of using webpack is access to [webpack's dev server](https://webpack.github.io/docs/webpack-dev-server.html) and its [hot module replacement](https://webpack.github.io/docs/hot-module-replacement-with-webpack.html) functionality.
-
-The webpack dev server with HMR will apply changes from the code (or styles!) to the browser as soon as you save whatever file you're working on. You won't need to reload the page, and your data will still be there. Start foreman as normal (it boots up the Rails server *and* the webpack HMR dev server at the same time).
-
-  ```bash
-  foreman start -f Procfile.dev
-  ```
-
-Open your browser to [localhost:3000](http://localhost:3000). Whenever you make changes to your JavaScript code in the `client` folder, they will automatically show up in the browser. Hot module replacement is already enabled by default.
-
-Note that **React-related error messages are possibly more helpful when encountered in the dev server** than the Rails server as they do not include noise added by the React on Rails gem.
-
-### Adding Additional Routes for the Dev Server
-As you add more routes to your front-end application, you will need to make the corresponding API for the dev server in `client/server.js`. See our example `server.js` from our [tutorial](https://github.com/shakacode/react-webpack-rails-tutorial/blob/master/client%2Fserver-express.js).

data/docs/basics/recommended-project-structure.md

@@ -1,77 +0,0 @@
-# Recommended Project structure
-
-The React on Rails generator uses the standard `rails/webpacker` convention of this structure:
-
-```yml
-app/javascript:
-  ├── bundles:
-  │   # Logical groups of files that can be used for code splitting
-  │   └── hello-world-bundle.js
-  ├── packs:
-  │   # only webpack entry files here
-  │   └── hello-world-bundle.js
-```
-
-However, you may wish to move all your client side files to a single directory called something like `/client`.
-
-## Steps to convert from the generator defaults to use a `/client` directory structure.
-
-1. Move the directory:
-
-```
-mv app/javascript client
-```
-
-2. Edit your `/config/webpacker.yml` file. Change the `default/source_path`:
-
-```yml
-  source_path: client
-```
-
-## Moving node_modules from `/` to `/client` with a custom webpack setup.
-
-`rails/webpacker` probably doesn't support having your main node_modules directory under `/client`, so only follow these steps if you want to use your own webpack configuration.
-
-1. Move the `/package.json` to `/client/package.json`
-2. Create a `/package.json` that delegates to `/client/package.json`. See the example in [spec/dummy/package.json](../../spec/dummy/package.json).
-3. See the webpack configuration in [spec/dummy/client](../../spec/dummy/client) for a webpack configuration example.
-
-
-## JavaScript Assets
-1. `/client`: All client side JavaScript goes under the `/client` directory. Place all the major domains of the client side app under client.
-1. `/client/app`: All application JavaScript. Note the adherence to the [Airbnb JavaScript Style Guide](https://github.com/airbnb/javascript#naming-conventions) where we name the files to correspond to exported Objects (PascalCase) or exported functions (camelCase). We don't use dashes or snake_case for JavaScript files, except for possibly some config files.
-1. `/client/app/bundles`: Top level of different app domains. Use a name within this directory for you app domains. For example, if you had a domain called `widget-editing`, then you would have: `/client/app/bundles/widget-editing`
-1. `/client/app/lib`: Common code for bundles
-1. Within each bundle directory (or the lib directory), such as a domain named "comments"
-`/client/app/bundles/comments`, use following directory structure, if you're using redux. However, with React hooks, this will probably be a bit different:
-
-  * `/actions`: Redux actions.
-  * `/components`: "dumb" components (no connections to Redux or Ajax). These get props and can render themselves and children.
-  * `/constants`: Constants used by Redux actions and reducers.
-  * `/containers`: "smart" components. These components are bound to Redux.
-  * `/reducers`: Reducers for redux.
-  * `/routes`: Routes for React Router.
-  * `/store`: Store, which might be [configured differently for dev vs. production](https://github.com/reactjs/redux/tree/master/examples/real-world/store).
-  * `/startup`: Component bindings to stores, with registration of components and stores.
-  * `/schemas`: Schemas for AJAX JSON requests and responses, as used by the [Normalizr](https://github.com/gaearon/normalizr) package.
-
-## CSS, Sass, Fonts, and Images
-Should you move your styling assets to Webpack? Or stick with the plain Rails asset pipeline. It depends! You have 2 basic choices:
-
-### Simple Rails Way
-This isn't really any technique, as you keep handling all your styling assets using Rails standard tools, such as using the [sass-rails gem](https://rubygems.org/gems/sass-rails/versions/5.0.4). Basically, Webpack doesn't get involved with styling. Your Rails layouts just doing the styling the standard Rails way.
-
-#### Advantages
-1. Much simpler! There's no changes really from your current processes.
-
-### Using Webpack to Manage Styling Assets
-This technique involves customization of the webpack config files to generate CSS, image, and font assets. 
-
-#### Directory structure
-1. `/client/app/assets`: Assets for CSS for client app.
-1. `/client/app/assets/fonts` and `/client/app/assets/styles`: Globally shared assets for styling. Note, most Sass and image assets will be stored next to the JavaScript files.
-
-#### Advantages
-1. You can use [CSS modules](https://github.com/css-modules/css-modules), which is super compelling once you seen the benefits.
-1. You can do hot reloading of your assets. Thus, you do not have to refresh your web page to see asset change, including changing styles.
-1. You can run your client code on a mocked out express server for super fast prototyping. In other words, your client application can somewhat more easily be move to a different application server.

data/ruby-lint.yml

@@ -1,25 +0,0 @@
-# Not currently using ruby-lint
----
-presenter: syntastic
-
-# Be sure to edit this per your project!
-directories:
-  - app
-  - lib
-  - spec
-
-ignore_paths:
-  - client
-  - node_modules
-  - coverage
-  - examples
-
-analysis_classes:
-  #  - argument_amount
-  - pedantics
-  - shadowing_variables
-  # Too many false positives for these
-  #  - undefined_methods
-  #  - undefined_variables
-  #  - unused_variables
-  - useless_equality_checks