react_on_rails 11.3.0 → 12.0.0.pre.beta.0

data/docs/basics/configuration.md

@@ -59,58 +59,12 @@ ReactOnRails.configure do |config|
 
   # defaults to "" (top level)
   #
-  config.node_modules_location = "client" # Recommended!
+  config.node_modules_location = "client" # If using webpacker you should use "".
 
   # This configures the script to run to build the production assets by webpack. Set this to nil
   # if you don't want react_on_rails building this file for you.
   config.build_production_command = "RAILS_ENV=production bin/webpack"
 
-  ################################################################################
-  ################################################################################
-  # TEST CONFIGURATION OPTIONS
-  # Below options are used with the use of this test helper:
-  # ReactOnRails::TestHelper.configure_rspec_to_compile_assets(config)
-  ################################################################################
-
-  # If you are using this in your spec_helper.rb (or rails_helper.rb):
-  #
-  # ReactOnRails::TestHelper.configure_rspec_to_compile_assets(config)
-  #
-  # with rspec then this controls what yarn command is run
-  # to automatically refresh your webpack assets on every test run.
-  #
-  config.build_test_command = "RAILS_ENV=test bin/webpack"
-
-  # Directory where your generated assets go. All generated assets must go to the same directory.
-  # If you are using webpacker, this value will come from your config/webpacker.yml file. 
-  # This is the default in webpacker.yml:
-  #   public_output_path: packs-test
-  # which means files in /public/packs-test
-  #
-  # Alternately, you may configure this if you are NOT using webpacker. It is relative to your Rails 
-  # root directory. A custom, non-webpacker, config might use something like:
-  #
-  # config.generated_assets_dir = File.join(%w[public webpack], Rails.env)
-  # This setting should not be used if using webpacker. 
-
-  # CONFIGURE YOUR SOURCE FILES 
-  # The test helper needs to know where your JavaScript files exist. The default is configured
-  # by your config/webpacker.yml soure_path:
-  # source_path: client/app/javascript # if using recommended /client directory
-  #
-  # If you are not using webpacker, the `node_modules_location` is assumed to be the location of your source
-  # files.
-
-  # Define the files we need to check for webpack compilation when running tests.
-  # The default is `%w( manifest.json )` as will be sufficient for most webpacker builds.
-  # However, if you are generated a server bundle that is NOT hashed (present in manifest.json),
-  # then include the file in this list like this: 
-  #
-  config.webpack_generated_files = %w( server-bundle.js manifest.json )
-  
-  # You can optionally add values to your rails_context. See example below for RenderingExtension
-  # config.rendering_extension = RenderingExtension
-
   ################################################################################
   ################################################################################
   # SERVER RENDERING OPTIONS
@@ -127,27 +81,35 @@ ReactOnRails.configure do |config|
   # you should include a name that matches your bundle name in your webpack config.
   config.server_bundle_js_file = "server-bundle.js"
 
+  # THE BELOW OPTIONS FOR SERVER-SIDE RENDERING RARELY NEED CHANGING 
+  #
+  # This value only affects server-side rendering when using the webpack-dev-server 
+  # If you are hashing the server bundle and you want to use the same bundle for client and server,
+  # you'd set this to `true` so that React on Rails reads the server bundle from the webpack-dev-server.
+  # Normally, you have different bundles for client and server, thus, the default is false.
+  # Furthermore, if you are not hashing the server bundle (not in the manifest.json), then React on Rails
+  # will only look for the server bundle to be created in the typical file location, typically by
+  # a `webpack --watch` process. 
+  config.same_bundle_for_client_and_server = false
+  
   # If set to true, this forces Rails to reload the server bundle if it is modified
   # Default value is Rails.env.development?
-  #
+  # You probably will never change this.
   config.development_mode = Rails.env.development?
 
-  # For server rendering so that it replays in the browser console.
+  # For server rendering so that the server-side console replays in the browser console.
   # This can be set to false so that server side messages are not displayed in the browser.
-  # Default is true. Be cautious about turning this off.
+  # Default is true. Be cautious about turning this off, as it can make debugging difficult.
   # Default value is true
-  # 
   config.replay_console = true
 
   # Default is true. Logs server rendering messages to Rails.logger.info. If false, you'll only
   # see the server rendering messages in the browser console.
-  #
   config.logging_on_server = true
 
   # Default is true only for development? to raise exception on server if the JS code throws for
   # server rendering. The reason is that the server logs will show the error and force you to fix
   # any server rendering issues immediately during development. 
-  # 
   config.raise_on_prerender_error = Rails.env.development? 
 
   ################################################################################
@@ -181,6 +143,10 @@ ReactOnRails.configure do |config|
   # and installed gems are loaded
   config.i18n_yml_dir = Rails.root.join("config", "locales", "client")
   
+  # Possible output formats are js and json
+  # The default format is json
+  config.i18n_output_format = 'js'
+
   ################################################################################
   ################################################################################
   # CLIENT RENDERING OPTIONS
@@ -189,8 +155,47 @@ ReactOnRails.configure do |config|
   ################################################################################
   # default is false
   config.prerender = false
-end
 
+  # You can optionally add values to your rails_context. This object is passed
+  # every time a component renders.
+  # See example below for an example definition of RenderingExtension
+  #
+  # config.rendering_extension = RenderingExtension
+
+  ################################################################################
+  ################################################################################
+  # TEST CONFIGURATION OPTIONS
+  # Below options are used with the use of this test helper:
+  # ReactOnRails::TestHelper.configure_rspec_to_compile_assets(config)
+  # 
+  # NOTE:
+  # Instead of using this test helper, you may ensure fresh test files using rails/webpacker via:
+  # 1. Have `config/webpacker/test.js` exporting an array of objects to configure both client and server bundles.
+  # 2. Set the compile option to true in config/webpacker.yml for env test
+  ################################################################################
+  
+  # If you are using this in your spec_helper.rb (or rails_helper.rb):
+  #
+  # ReactOnRails::TestHelper.configure_rspec_to_compile_assets(config)
+  #
+  # with rspec then this controls what yarn command is run
+  # to automatically refresh your webpack assets on every test run.
+  #
+  config.build_test_command = "RAILS_ENV=test bin/webpack"
+
+  # CONFIGURE YOUR SOURCE FILES 
+  # The test helper needs to know where your JavaScript files exist. The value is configured
+  # by your config/webpacker.yml source_path:
+  # source_path: client/app/javascript # if using recommended /client directory
+  #
+  # Define the files we need to check for webpack compilation when running tests.
+  # The default is `%w( manifest.json )` as will be sufficient for most webpacker builds.
+  # However, if you are generated a server bundle that is NOT hashed (present in manifest.json),
+  # then include the file in this list like this: 
+  config.webpack_generated_files = %w( server-bundle.js manifest.json )
+  # Note, be sure NOT to include your server-bundle.js if it is hashed, or else React on Rails will
+  # think the server-bundle.js is missing every time for test runs. 
+end
 ```
 
 Example of a RenderingExtension for custom values in the `rails_context`:
@@ -199,7 +204,7 @@ Example of a RenderingExtension for custom values in the `rails_context`:
 module RenderingExtension
 
   # Return a Hash that contains custom values from the view context that will get merged with
-  # the standard rails_context values and passed to all calls to generator functions used by the
+  # the standard rails_context values and passed to all calls to render functions used by the
   # react_component and redux_store view helpers
   def self.custom_context(view_context)
     {
@@ -208,5 +213,3 @@ module RenderingExtension
   end
 end
 ```
-
-

data/docs/basics/deployment.md

@@ -2,5 +2,4 @@
 
 - React on Rails puts the necessary precompile steps automatically in the rake precompile step. You can, however, disable this by setting certain values to nil in the [config/initializers/react_on_rails.rb](./configuration.md).
   - `build_production_command`: Set to nil to turn off the precompilation of the js assets.
-  - `config.symlink_non_digested_assets_regex`: Default is nil, turning off the setup of non-js assets. This should be nil except when when using Sprockets rather than Webpacker. 
-- See the [Heroku Deployment](../additional-reading/heroku-deployment.md) doc for specifics regarding Heroku. The information for Heroku may apply to other deployments.
+- See the [Heroku Deployment](docs/outdated/heroku-deployment.md) doc for specifics regarding Heroku. The information for Heroku may apply to other deployments.

data/docs/basics/i18n.md

@@ -1,23 +1,10 @@
-# How to add I18n
+# I18n
 
 Here's a summary of adding the I18n functionality.
 
-You can refer to [react-webpack-rails-tutorial](https://github.com/shakacode/react-webpack-rails-tutorial) and [PR #340](https://github.com/shakacode/react-webpack-rails-tutorial/pull/340), [commmited](https://github.com/shakacode/react-webpack-rails-tutorial/commit/ef369ed9d922aea5116ca7e50208169fd7831389) for a complete example.
+1. Add `config.i18n_dir` in `config/initializers/react_on_rails.rb`
 
-1. Add `react-intl` & `intl` to `client/package.json`, and remember to `bundle && yarn install`.
-
-  ```js
-  "dependencies": {
-    ...
-    "intl": "^1.2.5",
-    "react-intl": "^2.1.5",
-    ...
-  }
-  ```
-
-2. Add `config.i18n_dir` in `config/initializers/react_on_rails.rb`
-
-  `react-intl` requires locale files in json format. React on Rails will generate `translations.js` & `default.js` automatically after you configured your `config.i18n_dir` in `config/initializers/react_on_rails.rb`.
+  React on Rails will generate `translations.json` & `default.json` automatically (see #3) after you configured your `config.i18n_dir` in `config/initializers/react_on_rails.rb`.
 
   ```ruby
   # Replace the following line to the location where you keep translation.js & default.js.
@@ -31,16 +18,49 @@ You can refer to [react-webpack-rails-tutorial](https://github.com/shakacode/rea
   config.i18n_yml_dir = Rails.root.join("PATH_TO", "YOUR_YAML_I18N_FOLDER")
   ```
 
-  `translations.js`: All your locales in json format.
-  `default.js`: Default settings in json format.
+  `translations.json`: All your locales in json format.
+  `default.json`: Default settings in json format.
 
-3. Add `translations.js` and `default.js` to your `.gitignore` and `.eslintignore`.
+2. Add `translations.json` and `default.json` to your `.gitignore`.
+
+3. Javascript locale files must be generated before `yarn build`.
+
+  Once you setup `config.i18n_dir` as in the previous step, react_on_rails will automatically do this for testing (if using the `ReactOnRails::TestHelper.configure_rspec_to_compile_assets` and for production deployments if using the [default precompile rake hook](docs/outdated/heroku-deployment.md). 
+  
+  For development, you should adjust your startup scripts (Procfiles) so that they run **`bundle exec rake react_on_rails:locale`** before running any webpack watch process (`yarn run build:development`). 
+  
+  You may need to configure your CI to  run **`bundle exec rake react_on_rails:locale`** before any webpack process if you are not using the React on Rails test helper. 
+  
+  Note, if you are try to lint before running tests, and you are depending on the test helper to build your locales, your linting will fail because the translations won't be built yet. 
+  
+  The fix is either to 
+  1) run the rake task to build the translations before running the lint command or 
+  2) to run the tests first.
+
+# Generate locales with react-intl support
+
+By default the locales generated in json format. If you need to generate files in the prior way
+with `react-intl` supported via js files:
 
-4. Javascript locale files must be generated before `yarn build`.
+1. Specify i18n output format in `react_on_rails.rb`:
+  ```rb
+    config.i18n_output_format = 'js'
+  ```
+
+2. Add `react-intl` & `intl` to `client/package.json`, and remember to `bundle && yarn install`.
+
+  ```js
+  "dependencies": {
+    ...
+    "intl": "^1.2.5",
+    "react-intl": "^2.1.5",
+    ...
+  }
+  ```
 
-  Once you setup `config.i18n_dir` as in the previous step, react_on_rails will automatically do this for testing (if using the `ReactOnRails::TestHelper.configure_rspec_to_compile_assets` and for production deployments if using the [default precompile rake hook](../additional-reading/heroku-deployment.md). For development, you should adjust your startup scripts (Procfiles) so that they run **`bundle exec rake react_on_rails:locale`** before running any webpack watch process (`yarn run build:development`). You may need to configure your CI to  run **`bundle exec rake react_on_rails:locale`** before any webpack process if you are not using the React on Rails test helper. Note, if you are try to lint before running tests, and you are depending on the test helper to build your locales, your linting will fail because the translations won't be built yet. The fix is either to 1) run the rake task to build the translations before running the lint command or 2) to run the tests first.
+3. Add `translations.js` and `default.js` to your `.gitignore` and `.eslintignore`.
 
-5. In React, you need to initialize `react-intl`, and set parameters for it.
+4. In React, you need to initialize `react-intl`, and set parameters for it.
 
   ```js
   ...
@@ -74,4 +94,6 @@ You can refer to [react-webpack-rails-tutorial](https://github.com/shakacode/rea
   
   # Notes
   
+  * See why using JSON could be better compare to JS if amount of data is hure [ https://v8.dev/blog/cost-of-javascript-2019#json]( https://v8.dev/blog/cost-of-javascript-2019#json).
   * See [Support for Rails' i18n pluralization #1000](https://github.com/shakacode/react_on_rails/issues/1000) for a discussion of issues around pluralization.
+  * [Outdated] You can refer to [react-webpack-rails-tutorial](https://github.com/shakacode/react-webpack-rails-tutorial) and [PR #340](https://github.com/shakacode/react-webpack-rails-tutorial/pull/340), [commmited](https://github.com/shakacode/react-webpack-rails-tutorial/commit/ef369ed9d922aea5116ca7e50208169fd7831389) for a complete example.

data/docs/basics/installation-into-an-existing-rails-app.md

@@ -11,7 +11,7 @@
    gem "webpacker", "~> 3" # Newer versions might be supported
    ```
 
-2. Run the following 2 commands to install Webpacker with React. Note, f you are using an older version of Rails than 5.1, you'll need to install webpacker with React per the instructions [here](https://github.com/rails/webpacker).
+2. Run the following 2 commands to install Webpacker with React. Note, if you are using an older version of Rails than 5.1, you'll need to install webpacker with React per the instructions [here](https://github.com/rails/webpacker).
 
 
    ```bash
@@ -45,7 +45,7 @@
 
 ## Installation
 
-See the [Installation Overview](../misc-pending/manual-installation-overview.md) for a concise set summary of what's in a React on Rails installation.
+See the [Installation Overview](docs/outdated/manual-installation-overview.md) for a concise set summary of what's in a React on Rails installation.
 
 
 ## NPM

data/docs/basics/react-server-rendering.md

@@ -10,7 +10,7 @@ During the Rails rendering of HTML per a browser request, the Rails server will
 
 The default JavaScript interpretter is [ExecJS](https://github.com/rails/execjs). If you want to maximize the perfomance of your server rendering, then you want to use React on Rails Pro which uses NodeJS to do the server rendering. See the [docs for React on Rails Pro](https://github.com/shakacode/react_on_rails/wiki).
 
-See [this note](./how-react-on-rails-works.md#client-side-rendering-vs-server-side-rendering)
+See [this note](docs/outdated/how-react-on-rails-works.md#client-side-rendering-vs-server-side-rendering)
 
 
 ## How do you do Server Rendering with React on Rails?

data/docs/basics/{generator-functions-and-railscontext.md → render-functions-and-railscontext.md}

@@ -1,45 +1,80 @@
-# Generator Functions and Rails Context 
+# Render-Functions and the Rails Context 
 
-## Generator Functions
+## Render-Functions
 
-When you use a "generator function" to create react components (or renderedHtml on the server), or you used shared redux stores, you get two params passed to your function that creates a React component:
+When you use a render-function to create react components (or renderedHtml on the server), or you
+used shared redux stores, you get two params passed to your function that creates a React component:
 
 1. `props`: Props that you pass in the view helper of either `react_component` or `redux_store`
-2. `railsContext`: Rails contextual information, such as the current pathname. You can customize this in your config file. **Note**: The `railsContext` is not related to the concept of a ["context" for React components](https://facebook.github.io/react/docs/context.html#how-to-use-context).
+2. `railsContext`: Rails contextual information, such as the current pathname. You can customize
+   this in your config file. **Note**: The `railsContext` is not related to the concept of a
+   ["context" for React components](https://facebook.github.io/react/docs/context.html#how-to-use-context).
 
-This parameters (`props` and `railsContext`) will be the same regardless of either client or server side rendering, except for the key `serverSide` based on whether or not you are server rendering.
+These parameters (`props` and `railsContext`) will be the same regardless of either client or server
+side rendering, except for the key `serverSide` based on whether or not you are server rendering.
 
-While you could manually configure your Rails code to pass the "`railsContext` information" with the rest of your "props", the `railsContext` is a convenience because it's passed consistently to all invocations of generator functions.
+While you could manually configure your Rails code to pass the "`railsContext` information" with
+the rest of your "props", the `railsContext` is a convenience because it's passed consistently to
+all invocations of render functions.
 
-For example, suppose you create a "generator function" called MyAppComponent.
+For example, suppose you create a "render-function" called MyAppComponent.
 
 ```js
 import React from 'react';
 const MyAppComponent = (props, railsContext) => (
-  <div>
-    <p>props are: {JSON.stringify(props)}</p>
-    <p>railsContext is: {JSON.stringify(railsContext)}
-    </p>
-  </div>
+  // NOTE: need to wrap in a function so this is proper React function component that can use
+  // hooks
+ 
+  // the props get passed again, but we ignore since we use a closure
+  // or should we
+  () =>
+      <div>
+        <p>props are: {JSON.stringify(props)}</p>
+        <p>railsContext is: {JSON.stringify(railsContext)}
+        </p>
+      </div>
 );
 export default MyAppComponent;
 ```
 
+------------------------------
+
+_This would be alternate API where you have to call React.createElement and the React on Rails code doesn't do that._
+
+```js
+import React from 'react';
+const MyAppComponent = (props, railsContext) => (
+  // NOTE: need to wrap in a function so this is proper React function component that can use
+  // hooks
+  React.createElement(
+    () =>
+      <div>
+        <p>props are: {JSON.stringify(props)}</p>
+        <p>railsContext is: {JSON.stringify(railsContext)}
+        </p>
+      </div>,
+  props)
+);
+export default MyAppComponent;
+```
+
+------------------------------------
+
 *Note: you will get a React browser console warning if you try to serverRender this since the value of `serverSide` will be different for server rendering.*
 
-So if you register your generator function `MyAppComponent`, it will get called like:
+So if you register your render-function `MyAppComponent`, it will get called like:
 
 ```js
 reactComponent = MyAppComponent(props, railsContext);
 ```
 
-and, similarly, any redux store always initialized with 2 parameters:
+and, similarly, any redux store is always initialized with 2 parameters:
 
 ```js
 reduxStore = MyReduxStore(props, railsContext);
 ```
 
-Note: you never make these calls. React on Rails makes these calls when it does either client or server rendering. You will define functions that take these 2 params and return a React component or a Redux Store. Naturally, you do not have to use second parameter of the railsContext if you do not need it.
+Note: you never make these calls. React on Rails makes these calls when it does either client or server rendering. You will define functions that take these 2 params and return a React component or a Redux Store. Naturally, you do not have to use second parameter of the railsContext if you do not need it. If you don't take a second parameter, then you're probably defining a React function component and you will simply return a React Element, often just JSX.
 
 (Note: see below [section](#multiple-react-components-on-a-page-with-one-store) on how to setup redux stores that allow multiple components to talk to the same store.)
 
@@ -76,7 +111,7 @@ Plus, you can add your customizations to this. See "rendering extension" below.
 
 ## Rails Context
 
-The `railsContext` is a second param passed to your generator functions for React components. This is in addition to the props that are passed from the `react_component` Rails helper. For example:
+The `railsContext` is a second param passed to your render-functions for React components. This is in addition to the props that are passed from the `react_component` Rails helper. For example:
 
 ERB view file: 
 
@@ -91,7 +126,8 @@ This is what your HelloWorld.js file might contain. The railsContext is always a
 import React from 'react';
 
 export default (props, railsContext) => {
-  return (
+  // Note, wrap in a function so this is React function component
+  return () => (
     <div>
       Your locale is {railsContext.i18nLocale}.<br/>
       Hello, {props.name}!
@@ -100,15 +136,17 @@ export default (props, railsContext) => {
 };
 ``` 
 
-## Why is the railsContext is only passed to generator functions?
+## Why is the railsContext only passed to render-functions?
 
-There's no reason that the railsContext would ever get passed to your React component unless the value is explicitly put into the props used for rendering. If you create a react component, rather than a generator function, for use by React on Rails, then you get whatever props are passed in from the view helper, which **does not include the Rails Context**. It's trivial to wrap your component in a "generator function" to return a new component that takes both:
+There's no reason that the railsContext would ever get passed to your React component unless the value is explicitly put into the props used for rendering. If you create a react component, rather than a render-function, for use by React on Rails, then you get whatever props are passed in from the view helper, which **does not include the Rails Context**. It's trivial to wrap your component in a "render-function" to return a new component that takes both:
 
 ```js
 import React from 'react';
 import AppComponent from './AppComponent';
 const AppComponentWithRailsContext = (props, railsContext) => (
-  <AppComponent {...{...props, railsContext}}/>
+  // Create a React Function Component so you can
+  // use the React Hooks API in this React Function Component
+  () => <AppComponent {...{...props, railsContext}}/>
 )
 export default AppComponentWithRailsContext;
 ```
@@ -153,7 +191,7 @@ See [spec/dummy/config/initializers/react_on_rails.rb](https://github.com/shakac
 module RenderingExtension
 
   # Return a Hash that contains custom values from the view context that will get merged with
-  # the standard rails_context values and passed to all calls to generator functions used by the
+  # the standard rails_context values and passed to all calls to render-functions used by the
   # react_component and redux_store view helpers
   def self.custom_context(view_context)
     {

data/docs/basics/upgrading-react-on-rails.md

@@ -5,6 +5,54 @@ If you would like help in migrating between React on Rails versions or help with
 
 We specialize in helping companies to quickly and efficiently move from versions before 9 to current. The older versions use the Rails asset pipeline to package client assets. The current and recommended way is to use Webpack 4 for asset preparation. You may also need help migrating from the `rails/webpacker`'s Webpack configuration to a better setup ready for Server Side Rendering.
 
+## Upgrading to v13
+* Make sure that you are on a relatively more recent version of rails and webpacker.
+* Updated API for ReactOnRails.register.
+
+In order to solve the issues regarding React Hooks compatibility, the number of parameters
+for functions is used to determine if you have a render function that will get invoked to
+return a React component, or you are registering a React component defined by a function.
+
+Registered Objects are of the following types:
+
+##### Correct
+Either of these will work:
+1. Take **2 params** and return **a React function or class component**. A function component is a function
+   that takes zero or one params and returns a React Element, like JSX.
+    ```js
+    export default (props, _railsContext) => () => <Component {...props} />;
+    ```
+
+2. Take only zero or one params and you return a React Element, often JSX.
+    ```js
+    export default (props) => <Component {...props} />;
+    ```
+##### Broken, as this function takes two params and it returns a React Element from a JSX Literal
+```js
+export default (props, _railsContext) => <Component {...props} />;
+```
+
+If you make this mistake, you'll get this warning
+`Warning: React.createElement: type is invalid -- expected a string (for built-in components) or a class/function (for composite components) but got: <Fragment />. Did you accidentally export a JSX literal instead of a component?`
+
+And this error:
+`react-dom.development.js:23965 Uncaught Error: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: object.`
+
+In this example, you need to wrap the `<Component {...props} />` in a function call like this which
+results in the return value being a React function component.
+
+```js
+export default (props, _railsContext) => () => <Component {...props} />;
+```
+
+If you have a pure component, taking one or zero parameters, and you have an unnecessary function
+wrapper such that you're returning a function rather than a React Element, then:
+
+1. You won't see anything render.
+2. You will see this warning in development mode: `Warning: Functions are not valid as a React child. This may happen if you return a Component instead of <Component /> from render. Or maybe you meant to call this function rather than return it.`
+
+---------
+
 ## Upgrading rails/webpacker from v3 to v4
 ### Custom Webpack build file
 The default value for `extract_css` is **false** in `config/webpack.yml`. Custom webpack builds should set this value to true or else no CSS link tags are generated. You have a custom webpack build if you are not using [rails/webpacker](https://github.com/rails/webpacker to setup your Webpack configuration.
@@ -42,8 +90,8 @@ Reason for doing this: This enables your webpack bundles to bypass the Rails ass
 ##### ...while keeping your `client` directory
 *   `.gitignore`: add `/public/webpack/*`
 *   `Gemfile`: bump `react_on_rails` and add `webpacker`
-*   layout views: anything bundled by webpack will need to be requested by a `javascript_pack_tag` or `stylesheet_pack_tag`. 
-  * Search your codebase for javascript_include_tag. Use the 
+*   layout views: anything bundled by webpack will need to be requested by a `javascript_pack_tag` or `stylesheet_pack_tag`.
+  * Search your codebase for javascript_include_tag. Use the
 *   `config/initializers/assets.rb`: we no longer need to modify `Rails.application.config.assets.paths` or append anything to `Rails.application.config.assets.precompile`.
 *   `config/initializers/react_on_rails.rb`:
     *   Delete `config.generated_assets_dir`. Webpacker's config now supplies this information