react_on_rails 11.0.5 → 13.4.0

data/.github/workflows/main.yml

@@ -0,0 +1,183 @@
+name: Main test
+
+on: [push, pull_request]
+
+jobs:
+  build-dummy-app-webpack-test-bundles:
+    strategy:
+      matrix:
+        ruby: [2.7]
+        node: [14]
+    runs-on: ubuntu-22.04
+    steps:
+    - uses: actions/checkout@v2
+    - name: Setup Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby }}
+        bundler: 2.4.17
+    # libyaml-dev is needed for psych v5
+    # this gem depends on sdoc which depends on rdoc which depends on psych
+    - name: Fix dependency for libyaml-dev
+      run: sudo apt install libyaml-dev
+    - name: Setup Node
+      uses: actions/setup-node@v2-beta
+      with:
+        node-version: ${{ matrix.node }}
+    - name: Print system information
+      run: |
+        echo "Linux release: "; cat /etc/issue
+        echo "Current user: "; whoami
+        echo "Current directory: "; pwd
+        echo "Ruby version: "; ruby -v
+        echo "Node version: "; node -v
+        echo "Yarn version: "; yarn --version
+        echo "Bundler version: "; bundle --version
+    - name: Save root node_modules to cache
+      uses: actions/cache@v3
+      with:
+        path: node_modules
+        key: v5-package-node-modules-cache-${{ hashFiles('yarn.lock') }}
+    - name: Install Node modules with Yarn for renderer package
+      run: |
+        yarn install --no-progress --no-emoji
+        yarn run eslint -v
+        sudo yarn global add yalc
+    - name: yalc publish for react-on-rails
+      run: yalc publish
+    - name: Save spec/dummy/node_modules to cache
+      uses: actions/cache@v3
+      with:
+        path: spec/dummy/node_modules
+        key: v5-dummy-app-node-modules-cache-${{ hashFiles('spec/dummy/yarn.lock') }}
+    - name: yalc add react-on-rails
+      run: cd spec/dummy && yalc add react-on-rails
+    - name: Install Node modules with Yarn for dummy app
+      run: cd spec/dummy && yarn install --no-progress --no-emoji
+    - name: Save dummy app ruby gems to cache
+      uses: actions/cache@v3
+      with:
+        path: spec/dummy/vendor/bundle
+        key: v5-dummy-app-gem-cache-${{ hashFiles('spec/dummy/Gemfile.lock') }}
+    - name: Install Ruby Gems for dummy app
+      run: cd spec/dummy && bundle lock --add-platform 'x86_64-linux' && bundle check --path=vendor/bundle || bundle _2.4.17_ install --path=vendor/bundle --jobs=4 --retry=3
+    - name: generate file system-based packs
+      run: cd spec/dummy && RAILS_ENV=test bundle exec rake react_on_rails:generate_packs
+    - name: Build test bundles for dummy app
+      run: cd spec/dummy && yarn run build:test
+    - id: get-sha
+      run: echo "::set-output name=sha::$(git rev-parse HEAD)"
+    - name: Save test webpack bundles to cache (for build number checksum used by rspec job)
+      uses: actions/cache/save@v3
+      with:
+        path: spec/dummy/public/webpack
+        key: v5-dummy-app-webpack-bundle-${{ steps.get-sha.outputs.sha }}
+
+  main:
+    needs: build-dummy-app-webpack-test-bundles
+    strategy:
+      matrix:
+        ruby: [2.7]
+        node: [14]
+        rake_task: ['run_rspec:all_but_examples', 'run_rspec:examples']
+    runs-on: ubuntu-22.04
+    steps:
+    - uses: actions/checkout@v2
+    - name: Setup Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby }}
+        bundler: 2.4.17
+    - name: Setup Node
+      uses: actions/setup-node@v2-beta
+      with:
+        node-version: ${{ matrix.node }}
+    - name: Print system information
+      run: |
+        echo "Linux release: "; cat /etc/issue
+        echo "Current user: "; whoami
+        echo "Current directory: "; pwd
+        echo "Ruby version: "; ruby -v
+        echo "Node version: "; node -v
+        echo "Yarn version: "; yarn --version
+        echo "Bundler version: "; bundle --version
+    - name: Save root node_modules to cache
+      uses: actions/cache@v3
+      with:
+        path: node_modules
+        key: v5-package-node-modules-cache-${{ hashFiles('yarn.lock') }}
+    - name: Save root ruby gems to cache
+      uses: actions/cache@v3
+      with:
+        path: vendor/bundle
+        key: v5-package-app-gem-cache-${{ hashFiles('react_on_rails.gemspec') }}
+    - name: Save dummy app ruby gems to cache
+      uses: actions/cache@v3
+      with:
+        path: spec/dummy/vendor/bundle
+        key: v5-dummy-app-gem-cache-${{ hashFiles('spec/dummy/Gemfile.lock') }}
+    - name: Save spec/dummy/node_modules to cache
+      uses: actions/cache@v3
+      with:
+        path: spec/dummy/node_modules
+        key: v5-dummy-app-node-modules-cache-${{ hashFiles('spec/dummy/yarn.lock') }}
+    - id: get-sha
+      run: echo "::set-output name=sha::$(git rev-parse HEAD)"
+    - name: Save test webpack bundles to cache (for build number checksum used by rspec job)
+      uses: actions/cache@v3
+      with:
+        path: spec/dummy/public/webpack
+        key: v5-dummy-app-webpack-bundle-${{ steps.get-sha.outputs.sha }}
+    - name: Install Node modules with Yarn for renderer package
+      run: |
+        yarn install --no-progress --no-emoji
+        yarn run eslint -v
+        sudo yarn global add yalc
+    - name: yalc publish for react-on-rails
+      run: yalc publish
+    - name: yalc add react-on-rails
+      run: cd spec/dummy && yalc add react-on-rails
+    - name: Install Ruby Gems for package
+      run:  bundle lock --add-platform 'x86_64-linux' && bundle check --path=vendor/bundle || bundle install --path=vendor/bundle --jobs=4 --retry=3
+    - name: Install Ruby Gems for dummy app
+      run: cd spec/dummy && bundle lock --add-platform 'x86_64-linux' && bundle check --path=vendor/bundle || bundle _2.4.17_ install --path=vendor/bundle --jobs=4 --retry=3
+    - name: Ensure minimum required Chrome version
+      run: |
+        echo -e "Already installed $(google-chrome --version)\n"
+        MINIMUM_REQUIRED_CHROME_VERSION=75
+        INSTALLED_CHROME_MAJOR_VERSION="$(google-chrome --version | tr ' .' '\t' | cut -f3)"
+        if [[ $INSTALLED_CHROME_MAJOR_VERSION < $MINIMUM_REQUIRED_CHROME_VERSION ]]; then
+          wget -q -O - https://dl.google.com/linux/linux_signing_key.pub | sudo apt-key add -
+          sudo sh -c 'echo "deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main" >> /etc/apt/sources.list.d/google.list'
+          sudo apt-get update
+          sudo apt-get install google-chrome-stable
+          echo -e "\nInstalled $(google-chrome --version)"
+        fi
+    - name: Install yalc globally
+      run: sudo yarn global add yalc
+    - name: Increase the amount of inotify watchers
+      run: echo fs.inotify.max_user_watches=524288 | sudo tee -a /etc/sysctl.conf && sudo sysctl -p
+    - name: generate file system-based packs
+      run: cd spec/dummy && RAILS_ENV=test bundle exec rake react_on_rails:generate_packs
+    - name: Main CI
+      run: bundle exec rake ${{ matrix.rake_task }}
+    - name: Store test results
+      uses: actions/upload-artifact@v2
+      with:
+        name: main-rspec
+        path: ~/rspec
+    - name: Store artifacts
+      uses: actions/upload-artifact@v2
+      with:
+        name: dummy-app-capybara
+        path: spec/dummy/tmp/capybara
+    - name: Store artifacts
+      uses: actions/upload-artifact@v2
+      with:
+        name: dummy-app-test-log
+        path: spec/dummy/log/test.log
+    - name: Store artifacts
+      uses: actions/upload-artifact@v2
+      with:
+        name: dummy-app-yarn-log
+        path: spec/dummy/yarn-error.log

data/.github/workflows/package-js-tests.yml

@@ -0,0 +1,35 @@
+name: JS unit tests for Renderer package
+
+on: [push, pull_request]
+
+jobs:
+  build:
+    strategy:
+      matrix:
+        node: [12, 14]
+    runs-on: ubuntu-22.04
+    steps:
+    - uses: actions/checkout@v2
+    - name: Setup Node
+      uses: actions/setup-node@v2-beta
+      with:
+        node-version: ${{ matrix.node }}
+    - name: Print system information
+      run: |
+        echo "Linux release: "; cat /etc/issue
+        echo "Current user: "; whoami
+        echo "Current directory: "; pwd
+        echo "Node version: "; node -v
+        echo "Yarn version: "; yarn --version
+    - name: Save root node_modules to cache
+      uses: actions/cache@v2
+      with:
+        path: node_modules
+        key: v5-package-node-modules-cache-${{ hashFiles('yarn.lock') }}
+    - name: Install Node modules with Yarn for renderer package
+      run: |
+        yarn install --no-progress --no-emoji
+        yarn run eslint -v
+        sudo yarn global add yalc
+    - name: Run JS unit tests for Renderer package
+      run: yarn test

data/.github/workflows/rspec-package-specs.yml

@@ -0,0 +1,46 @@
+name: Rspec test for gem
+
+on: [push, pull_request]
+
+jobs:
+  build:
+    strategy:
+      matrix:
+        ruby: [2.7]
+        node: [14]
+    runs-on: ubuntu-22.04
+    steps:
+    - uses: actions/checkout@v2
+    - name: Setup Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby }}
+        bundler: 2.4.17
+    - name: Print system information
+      run: |
+        echo "Linux release: "; cat /etc/issue
+        echo "Current user: "; whoami
+        echo "Current directory: "; pwd
+        echo "Ruby version: "; ruby -v
+        echo "Node version: "; node -v
+        echo "Yarn version: "; yarn --version
+        echo "Bundler version: "; bundle --version
+    - name: Save root ruby gems to cache
+      uses: actions/cache@v2
+      with:
+        path: vendor/bundle
+        key: v5-package-app-gem-cache-${{ hashFiles('react_on_rails.gemspec') }}
+    - name: Install Ruby Gems for package
+      run: bundle check --path=vendor/bundle || bundle install --path=vendor/bundle --jobs=4 --retry=3
+    - name: Run rspec tests
+      run: bundle exec rspec spec/react_on_rails
+    - name: Store test results
+      uses: actions/upload-artifact@v2
+      with:
+        name: main-rspec
+        path: ~/rspec
+    - name: Store artifacts
+      uses: actions/upload-artifact@v2
+      with:
+        name: main-test-log
+        path: log/test.log

data/.gitignore

@@ -1,7 +1,6 @@
 /.bundle/
 /.yardoc
 /Gemfile.lock
-/Gemfile.rails32.lock
 /_yardoc/
 /coverage/
 /doc/
@@ -12,9 +11,6 @@
 /vendor/
 
 /spec/examples.txt
-/spec/dummy/client/node_modules
-/spec/dummy/public/webpack/
-/spec/dummy/coverage/
 /spec/react_on_rails/dummy-for-generators/
 
 # RVM
@@ -32,3 +28,6 @@ npm-debug.*
 /gen-examples
 
 .DS_Store
+
+.yalc
+yalc.lock

data/.prettierignore

@@ -0,0 +1,14 @@
+node_modules/
+package.json
+tmp/
+coverage/
+**/app/assets/webpack/
+gen-examples/examples/*
+node_package/lib/*
+spec/react_on_rails/dummy-for-generators/app/javascript/bundles/HelloWorld/*
+bundle/
+spec/dummy/lib/bs/**
+spec/dummy/public
+**/.yalc/**
+**/generated/**
+*.bs.js

data/.prettierrc

@@ -0,0 +1,20 @@
+printWidth: 110
+tabWidth: 2
+useTabs: false
+semi: true
+singleQuote: true
+trailingComma: all
+bracketSpacing: true
+jsxBracketSameLine: false
+parser: flow
+
+overrides:
+- files: "*.@(css|scss)"
+  options:
+    parser: css
+    singleQuote: false
+    printWidth: 120
+- files: "*.@(json)"
+  options:
+    parser: json
+    printWidth: 100

data/.rubocop.yml

@@ -1,50 +1,44 @@
 # This is the configuration used to check the rubocop source code.
 # Check out: https://github.com/bbatsov/rubocop
+require:
+  - rubocop-performance
+  - rubocop-rspec
 
 AllCops:
+  NewCops: enable
   DisplayCopNames: true
-  TargetRubyVersion: 2.1
+  TargetRubyVersion: 2.5
 
   Include:
     - '**/Rakefile'
     - '**/config.ru'
+    - 'Gemfile'
+    - '**/*.rb'
+    - '**/*.rake'
 
   Exclude:
-    - 'vendor/**/*'
-    - 'spec/fixtures/**/*'
-    - 'node_modules/**/.*'
-    - 'node_modules/**/*'
+  <% `git status --ignored --porcelain`.lines.grep(/^!! /).each do |path| %>
+    - <%= path.sub(/^!! /, '') %>
+  <% end %>
+    - '**/*.js'
+    - '**/node_modules/**/*'
+    - '**/public/**/*'
+    - '**/tmp/**/*'
     - 'coverage/**/*'
-    - 'db/**/*'
-    - 'db/schema.rb'
-    - 'db/seeds.rb'
-    - 'client/node_modules/**/*.*'
-    - 'client/node_modules/**/.*'
-    - 'bin/**/*'
-    - !ruby/regexp /old_and_unused\.rb$/
-    - 'spec/react_on_rails/dummy-for-generators/**/*'
-    - 'spec/dummy/Procfile.*'
-    - 'spec/dummy/bin/**/*'
-    - 'spec/dummy/client/node_modules/**/*'
-    - 'spec/dummy/client/node_modules/**/.*'
-    - 'spec/dummy_no_webpacker/Procfile.*'
-    - 'spec/dummy_no_webpacker/bin/**/*'
-    - 'spec/dummy_no_webpacker/client/node_modules/**/*'
-    - 'spec/dummy_no_webpacker/client/node_modules/**/.*'
-    - 'gen-examples/examples/**/.*'
     - 'gen-examples/examples/**/*'
+    - 'node_modules/**/*'
+    - 'spec/dummy/bin/*'
+    - 'spec/fixtures/**/*'
+    - 'spec/react_on_rails/dummy-for-generators/**/*'
+    - 'tmp/**/*'
+    - 'vendor/**/*'
 
 Naming/FileName:
   Exclude:
-    - 'Gemfile'
-    - 'spec/dummy/Gemfile'
-    - 'spec/dummy_no_webpacker/Gemfile'
-
-# Turn off until we require 2.3 ruby
-Style/SafeNavigation:
-  Enabled: false
+    - '**/Gemfile'
+    - '**/Rakefile'
 
-Metrics/LineLength:
+Layout/LineLength:
   Max: 120
 
 Style/StringLiterals:
@@ -53,11 +47,20 @@ Style/StringLiterals:
 Style/Documentation:
   Enabled: false
 
+Style/HashEachMethods:
+  Enabled: true
+
+Style/HashTransformKeys:
+  Enabled: true
+
+Style/HashTransformValues:
+  Enabled: true
+
 Lint/AssignmentInCondition:
   Exclude:
     - 'spec/dummy/bin/spring'
 
-Lint/HandleExceptions:
+Lint/SuppressedException:
   Exclude:
     - 'spec/dummy/bin/rails'
     - 'spec/dummy/bin/rake'
@@ -84,9 +87,48 @@ Metrics/MethodLength:
 Metrics/ModuleLength:
   Max: 180
 
+Naming/RescuedExceptionsVariableName:
+  Enabled: false
+
+RSpec/AnyInstance:
+  Exclude:
+    - 'spec/react_on_rails/git_utils_spec.rb'
+    - 'spec/react_on_rails/locales_to_js_spec.rb'
+    - 'spec/react_on_rails/binstubs/dev_spec.rb'
+    - 'spec/react_on_rails/binstubs/dev_static_spec.rb'
+
+RSpec/DescribeClass:
+  Enabled: false
+
+RSpec/ExampleLength:
+  Enabled: false
+
+RSpec/MessageSpies:
+  Enabled: false
+
+RSpec/NestedGroups:
+  Max: 4
+
+RSpec/BeforeAfterAll:
+  Exclude:
+    - 'spec/react_on_rails/generators/dev_tests_generator_spec.rb'
+    - 'spec/react_on_rails/generators/install_generator_spec.rb'
+    - 'spec/react_on_rails/binstubs/dev_spec.rb'
+    - 'spec/react_on_rails/binstubs/dev_static_spec.rb'
+
+RSpec/MessageChain:
+  Enabled: false
+
+RSpec/MultipleExpectations:
+  Enabled: false
+
+RSpec/MultipleDescribes:
+  Exclude:
+    - 'spec/dummy/spec/system/integration_spec.rb'
+
+RSpec/MultipleMemoizedHelpers:
+  Max: 12
+
 Style/GlobalVars:
   Exclude:
     - 'spec/dummy/config/environments/development.rb'
-
-Style/FrozenStringLiteralComment:
-  EnforcedStyle: when_needed

data/.travis.yml

@@ -3,11 +3,10 @@ sudo: required
 language: ruby
 
 rvm:
-  # Rails 5 requires 2.2
-  - 2.3.1
-  - 2.4.1
-  - 2.5.0
-  - 2.2.6
+  - 2.5.3
+  - 2.6.5
+  - 2.7.0
+
 services:
   - docker
 
@@ -19,7 +18,6 @@ cache:
 
 gemfile:
   - spec/dummy/Gemfile
-  - spec/dummy_no_webpacker/Gemfile.rails32
 
 env:
   global:
@@ -36,14 +34,20 @@ before_install:
   - "/sbin/start-stop-daemon --start --quiet --pidfile /tmp/custom_xvfb_99.pid --make-pidfile --background --exec /usr/bin/Xvfb -- :99 -ac -screen scn 1600x1200x16"
 
 install:
-  - travis_retry gem install bundler
-  - travis_retry nvm install 9.11.1
+  - travis_retry gem install bundler -v '>2'
+  - travis_retry nvm install 14
   - node -v
-  - travis_retry npm i -g yarn@0.27.5
-  - travis_retry yarn global add babel-cli
-  - travis_retry bundle install
+  - travis_retry npm i -g yarn
+  - travis_retry yarn global add yalc
+  - travis_retry yalc add react-on-rails
   - travis_retry yarn
+  - travis_retry bundle install
   - travis_retry yarn run build
+  - travis_retry yalc publish
+  - cd spec/dummy
+  - travis_retry yalc add react-on-rails
+  - travis_retry yarn
+  - cd ../..
   - bundle exec rake prepare_for_ci
 
 before_script:
@@ -52,17 +56,6 @@ before_script:
 script:
   - bundle exec rake
 
-matrix:
-  exclude:
-    - gemfile: spec/dummy_no_webpacker/Gemfile.rails32
-      rvm: 2.3.1
-    - gemfile: spec/dummy_no_webpacker/Gemfile.rails32
-      rvm: 2.4.1
-    - gemfile: spec/dummy_no_webpacker/Gemfile.rails32
-      rvm: 2.5.0
-    - gemfile: spec/dummy/Gemfile
-      rvm: 2.2.6
-
 notifications:
   slack:
     secure: LfcUk4AJ4vAxWwRIyw4tFh8QNbYefMwfG/oLfsN3CdRMWMOtCOHR1GGsRhAOlfVVJ/FvHqVqWj5gK7z7CaO5Uvl7rD3/zJ8QzExKx/iH9yWj55iIPuKLzwFNnBwRpFW/cqyU2lFPPRxGD50BUn3c+qybkuSqtKZ6qtTowwqlxLa5iyM3N95aZp7MEIKCP7cPcnHfLbJyP8wBpotp/rtw62eXM2HIRJJwgjcp+n+My7VFR9DnBXNFf6R91aZHM4U4cHHDbu15HFtH8honVrzK1JQdyqMNHga+j04dFuaS7z9Q369/hsELMOBp/227+Pz7ZRfWZFK4UASguOvyeX7RmGTRpTuWLm1XJeUzfsPZVROecaSVQBve+U7F12yKqilt97QlvRXn2EGyBILqvxtFNNR4S9kgAf72/6EFgiM1TKq7i9zy6lVOnagU2+7amq7UeopX1uoFsUfNKMR7YbgV1WjF0IK95UP0b0/7ZOJlPYgi5zzkQi129qAFWSMmxGk+ZpsttHh/tjJtvAh0A3mHq/zb5w4ub/MbSyZqeDUNgGj72QArOWUFSAStQT1ybsVLeDoKPgOvVq7OV1D64rpcHjBXcqOCit8tDZ+TqkFhcYJo2cITSaqE4zJXn+4F5s7So5O8CyfKYQq+kFJCooYGmfgTUckJpGl7eIvKmL4TN9Q=