react_on_rails 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5fde8cbadfff66bb7793dbc144644d60d46d4803
-  data.tar.gz: 29f6b282949c98382a6821d7b56a987ede72f80c
+  metadata.gz: 3cafbd0b068b4be809103e6f043761aa5ca9dff1
+  data.tar.gz: 4466dd647b9846dc792d8e3926a6819caf40f989
 SHA512:
-  metadata.gz: 41b6e18bc73f593867cf322feb405d8c1eb77ccf2063860aac2d519cefc8994708cf838b783fca3b8056cb509bc2e1253d4a7da30874d193271d978d3724b110
-  data.tar.gz: 179393aadd9f9d2b1431eb7b21cc436f9e036fe504b25901dd0a69002725032f12daaedaee0e64f3ae05c2d04ef3a412bc05a0ba8b8d72c20aa5f735407eecb8
+  metadata.gz: 827b09823116f3d03ddf43d2343f2cfa45aa18793011d4174ec3517c4777c49a331c35b4f4d6533e8b73040d9a18befa3f452a33e973925c08d3abf3e6c9b568
+  data.tar.gz: d529ec20ac5c921231b64b0fe06201a78ff7671c2c27197ee3b93f735b5cccf810262550027f760135d776d0c4d8ba04066ca6a382a949ea5b1eeb61fd447e9e

data/README.md

@@ -54,7 +54,7 @@ In the following screenshot you can see the actual HTML rendered for a side-by-s
   rails generate react_on_rails:install
   ```
 
-3. NPM install:
+3. NPM install. Make sure you are on a recent version of node, preferably using nvm.
 
   ```bash
   npm install

data/docs/linters.md

@@ -1,8 +1,25 @@
 # Linters
-The React on Rails generator automatically adds linters and their recommended accompanying configurations to your project (to disable this behavior, include the `--skip-linters` option when running the generator). Those linters that are written in Ruby have been added to your Gemfile, and those that run in Node have been add to your `package.json` under `devDependencies`.
+The React on Rails generator can add linters and their recommended accompanying configurations to your project (to disable this behavior, include the `--linters` option when running the generator). Those linters that are written in Ruby have been added to your Gemfile, and those that run in Node have been add to your `package.json` under `devDependencies`.
 
 To run the linters (runs both Ruby and Node linters):
 
 ```bash
 rake lint
 ```
+
+Run this command to see all the linters available
+
+```bash
+rake -T lint
+```
+
+**Here's the list:**
+```bash
+rake lint               # Runs all linters
+rake lint:eslint        # eslint
+rake lint:js            # JS Linting
+rake lint:jscs          # jscs
+rake lint:rubocop[fix]  # Run Rubocop lint in shell
+rake lint:ruby          # Run ruby-lint as shell
+rake lint:scss          # See docs for task 'scss_lint'
+```

data/lib/generators/react_on_rails/install_generator.rb

@@ -28,11 +28,11 @@ module ReactOnRails
                    default: false,
                    desc: "Configure for server-side rendering of webpack JavaScript",
                    aliases: "-S"
-      # --skip-linters
-      class_option :skip_linters,
+      # --linters
+      class_option :linters,
                    type: :boolean,
                    default: false,
-                   desc: "Don't install linter files",
+                   desc: "Install linter files",
                    aliases: "-L"
 
       def run_generators
@@ -41,7 +41,7 @@ module ReactOnRails
         invoke "react_on_rails:base"
         invoke "react_on_rails:react_no_redux" unless options.redux?
         invoke "react_on_rails:react_with_redux" if options.redux?
-        invoke "react_on_rails:linters" unless options.skip_linters?
+        invoke "react_on_rails:linters" if options.linters?
         invoke "react_on_rails:bootstrap"
         invoke "react_on_rails:heroku_deployment"
       end

data/lib/generators/react_on_rails/templates/base/base/config/initializers/react_on_rails.rb

@@ -12,7 +12,7 @@ ReactOnRails.configure do |config|
   # seconds
   config.server_renderer_timeout = 20
   # If set to true, this forces Rails to reload the server bundle if it is modified
-  config.reload_server_js_every_request = Rails.env.development?
+  config.development_mode = Rails.env.development?
   # For server rendering. This can be set to false so that server side messages are discarded.
   # Default is true. Be cautious about turning this off.
   config.replay_console = true

data/lib/generators/react_on_rails/templates/linters/client/.eslintrc

@@ -14,4 +14,4 @@ rules:
   indent: [1, 2, { SwitchCase: 1, VariableDeclarator: 2 }]
   react/sort-comp: 0
   react/jsx-quotes: 1
-  id-length: [2, {"exceptions": ["e", "i"]}]
+  id-length: [2, {"exceptions": ["e", "i", "_"]}]

data/lib/generators/react_on_rails/templates/no_redux/base/client/package.json.tt

@@ -29,7 +29,7 @@
     "build:client": "NODE_ENV=production webpack --config webpack.client.rails.config.js",
     "build:server": "NODE_ENV=production webpack --config webpack.server.rails.config.js",
     "build:dev:client": "webpack -w --config webpack.client.rails.config.js",
-    "build:dev:server": "webpack -w --config webpack.server.rails.config.js",<%- unless options.skip_linters? %>
+    "build:dev:server": "webpack -w --config webpack.server.rails.config.js",<%- if options.linters? %>
    "lint": "npm run eslint && npm run jscs",
     "eslint": "eslint --ext .js,.jsx .",
     "jscs": "jscs --verbose ."<%- end %>
@@ -51,19 +51,19 @@
     "sleep": "^3.0.0",
     "webpack": "^1.12.2"
   },
-  "devDependencies": {<%- unless options.skip_linters? %>
+  "devDependencies": {<%- if options.linters? %>
     "babel-eslint": "^4.1.3",
     <%- end %>"babel-plugin-react-transform": "^1.1.1",
     "bootstrap-sass": "^3.3.5",
     "bootstrap-sass-loader": "^1.0.9",
-    "css-loader": "^0.19.0",<%- unless options.skip_linters? %>
+    "css-loader": "^0.19.0",<%- if options.linters? %>
     "eslint": "^1.6.0",
     "eslint-config-airbnb": "0.1.0",
     "eslint-plugin-react": "^3.5.1",<%- end %>
     "esprima-fb": "^15001.1001.0-dev-harmony-fb",
     "express": "^4.13.3",
     "file-loader": "^0.8.4",
-    "jade": "^1.11.0",<%- unless options.skip_linters? %>
+    "jade": "^1.11.0",<%- if options.linters? %>
     "jscs": "^2.3.0",
     <%- end %>"node-sass": "^3.3.3",
     "react-transform-hmr": "^1.0.1",

data/lib/generators/react_on_rails/templates/redux/base/client/package.json.tt

@@ -29,7 +29,7 @@
     "build:client": "NODE_ENV=production webpack --config webpack.client.rails.config.js",
     "build:server": "NODE_ENV=production webpack --config webpack.server.rails.config.js",
     "build:dev:client": "webpack -w --config webpack.client.rails.config.js",
-    "build:dev:server": "webpack -w --config webpack.server.rails.config.js",<%- unless options.skip_linters? %>
+    "build:dev:server": "webpack -w --config webpack.server.rails.config.js",<%- if options.linters? %>
     "lint": "npm run eslint && npm run jscs",
     "eslint": "eslint --ext .js,.jsx .",
     "jscs": "jscs --verbose ."<%- end %>
@@ -58,19 +58,19 @@
     "sleep": "^3.0.0",
     "webpack": "^1.12.2"
   },
-  "devDependencies": {<%- unless options.skip_linters? %>
+  "devDependencies": {<%- if options.linters? %>
     "babel-eslint": "^4.1.3",<%- end %>
     "babel-plugin-react-transform": "^1.1.1",
     "bootstrap-sass": "^3.3.5",
     "bootstrap-sass-loader": "^1.0.9",
-    "css-loader": "^0.19.0",<%- unless options.skip_linters? %>
+    "css-loader": "^0.19.0",<%- if options.linters? %>
     "eslint": "^1.6.0",
     "eslint-config-airbnb": "0.1.0",
     "eslint-plugin-react": "^3.5.1",<%- end %>
     "esprima-fb": "^15001.1001.0-dev-harmony-fb",
     "express": "^4.13.3",
     "file-loader": "^0.8.4",
-    "jade": "^1.11.0",<%- unless options.skip_linters? %>
+    "jade": "^1.11.0",<%- if options.linters? %>
     "jscs": "^2.3.0",<%- end %>
     "node-sass": "^3.3.3",
     "react-transform-hmr": "^1.0.1",

data/lib/react_on_rails/version.rb

@@ -1,3 +1,3 @@
 module ReactOnRails
-  VERSION = "1.0.0"
+  VERSION = "1.0.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: react_on_rails
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Justin Gordon
@@ -242,7 +242,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Rails with react server rendering with webpack.