react-manifest-rails 0.2.33 → 0.3.0

data/lib/react_manifest/version.rb

@@ -1,3 +1,3 @@
 module ReactManifest
-  VERSION = "0.2.33".freeze
+  VERSION = "0.3.0".freeze
 end

data/lib/react_manifest.rb

@@ -14,6 +14,7 @@ require "react_manifest/application_analyzer"
 require "react_manifest/application_migrator"
 require "react_manifest/layout_patcher"
 require "react_manifest/sprockets_manifest_patcher"
+require "react_manifest/gitignore_patcher"
 require "react_manifest/watcher"
 require "react_manifest/reporter"
 require "react_manifest/view_helpers"
@@ -55,10 +56,7 @@ module ReactManifest
       bundles << shared if shared
 
       # 2. always_include bundles (e.g. ux_main)
-      config.always_include.each do |b|
-        resolved = resolve_bundle_reference(config, b)
-        bundles << resolved if resolved && !bundles.include?(resolved)
-      end
+      append_always_include(config, bundles)
 
       # 3. Controller-specific bundle
       # Try fully-namespaced first: admin/users → ux_admin_users
@@ -74,6 +72,18 @@ module ReactManifest
       bundles
     end
 
+    # Ensure the manifest dir is gitignored (and .keep present). Honors
+    # config.manage_gitignore. Returns true if it appended the .gitignore entry.
+    # Best-effort: a filesystem error is logged and swallowed (never breaks boot).
+    def reconcile_gitignore!(config = configuration)
+      return false unless config.manage_gitignore?
+
+      GitignorePatcher.new(config).reconcile!
+    rescue StandardError => e
+      Rails.logger&.warn("[ReactManifest] gitignore reconcile skipped: #{e.message}")
+      false
+    end
+
     # Resolve a controller bundle from a React component symbol.
     #
     # This is primarily used to support react-rails `react_component` calls,
@@ -102,6 +112,12 @@ module ReactManifest
       shared = resolve_bundle_reference(config, config.shared_bundle)
       bundles << shared if shared
 
+      # always_include bundles are delivered on every page. react_component does
+      # NOT go through resolve_bundles, so it must emit them here too — this is
+      # what makes always_include symbols available without inlining them into
+      # controller manifests (which would double-declare, see Generator).
+      append_always_include(config, bundles)
+
       root = resolve_bundle_reference(config, root_bundle)
       bundles << root if root && !bundles.include?(root)
 
@@ -142,6 +158,15 @@ module ReactManifest
 
     private
 
+    # Append each configured always_include bundle (deduped) to +bundles+.
+    def append_always_include(config, bundles)
+      config.always_include.each do |b|
+        resolved = resolve_bundle_reference(config, b)
+        bundles << resolved if resolved && !bundles.include?(resolved)
+      end
+      bundles
+    end
+
     def component_bundle_map(config)
       component_maps(config)[:symbol_to_bundle]
     end
@@ -163,13 +188,16 @@ module ReactManifest
         bundle_name = ctrl[:bundle_name]
         files = js_files_in_controller(ctrl[:path], config)
         bundle_files[bundle_name].concat(files)
+        isolated = config.isolated_app_dirs.include?(ctrl[:name])
 
         files.each do |file_path|
           extract_defined_symbols(file_path).each do |symbol|
             next unless symbol.match?(/\A[A-Z][A-Za-z0-9_]*\z/)
 
             # Keep first writer to ensure deterministic behavior if a symbol is duplicated.
-            symbol_to_bundle[symbol] ||= bundle_name
+            # Isolated dirs never register into the shared symbol index (see
+            # Generator#build_controller_context for the full rationale).
+            symbol_to_bundle[symbol] ||= bundle_name unless isolated
             bundle_own_symbols[bundle_name] << symbol
           end
         end
@@ -211,14 +239,14 @@ module ReactManifest
 
     def extract_defined_symbols(file_path)
       content = File.read(file_path, encoding: "utf-8")
-      SymbolExtractor.extract_definitions(content)
+      SymbolExtractor.extract_definitions(content, file_path: file_path)
     rescue Errno::ENOENT, Errno::EACCES, Encoding::InvalidByteSequenceError
       []
     end
 
     def extract_used_component_symbols(file_path)
       content = File.read(file_path, encoding: "utf-8")
-      SymbolExtractor.extract_usages(content)
+      SymbolExtractor.extract_usages(content, file_path: file_path)
     rescue Errno::ENOENT, Errno::EACCES, Encoding::InvalidByteSequenceError
       []
     end

data/tasks/react_manifest.rake

@@ -80,6 +80,22 @@ namespace :react_manifest do
       puts "   ✓ #{written} written, #{unchanged} unchanged"
     end
 
+    # 6. Ensure generated manifests are gitignored
+    puts "\n6) Gitignoring generated manifests..."
+    if config.manage_gitignore?
+      patcher = ReactManifest::GitignorePatcher.new(config)
+      result  = patcher.patch!
+      if result.appended
+        puts "   ✓ added #{patcher.pattern} to .gitignore"
+        puts "   → one-time cleanup for previously-committed manifests:"
+        puts "     git rm --cached #{File.dirname(patcher.pattern)}/*.js"
+      else
+        puts "   ✓ #{patcher.pattern} already ignored"
+      end
+    else
+      puts "   (skipped — config.manage_gitignore is false)"
+    end
+
     # Done
     puts "\n=== Setup #{'(dry-run) ' if config.dry_run?}complete ==="
     puts "Start your Rails server — react_bundle_tag will serve the right JS per controller." unless config.dry_run?
@@ -130,6 +146,14 @@ namespace :react_manifest do
     scan_result    = scanner.scan(classification)
     dep_map        = ReactManifest::DependencyMap.new(scan_result)
     dep_map.print_report
+
+    reasons = ReactManifest::Generator.new(config).promotion_reasons
+    unless reasons.empty?
+      puts "\nPromotions (app/ components emitted into #{config.shared_bundle}):"
+      reasons.sort.each do |req, bundles|
+        puts "  #{req}  <- used by: #{bundles.sort.join(', ')}"
+      end
+    end
   end
 
   desc "Analyze application*.js files — show what migrate_application would change"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: react-manifest-rails
 version: !ruby/object:Gem::Version
-  version: 0.2.33
+  version: 0.3.0
 platform: ruby
 authors:
 - Oliver Noonan
@@ -119,6 +119,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: mini_racer
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: |
   react-manifest-rails automatically generates per-controller Sprockets manifest
   files for Rails applications using react-rails + Sprockets. It eliminates the
@@ -137,9 +151,11 @@ files:
 - lib/react_manifest.rb
 - lib/react_manifest/application_analyzer.rb
 - lib/react_manifest/application_migrator.rb
+- lib/react_manifest/ast_extractor.rb
 - lib/react_manifest/configuration.rb
 - lib/react_manifest/dependency_map.rb
 - lib/react_manifest/generator.rb
+- lib/react_manifest/gitignore_patcher.rb
 - lib/react_manifest/layout_patcher.rb
 - lib/react_manifest/logging.rb
 - lib/react_manifest/path_utils.rb
@@ -149,6 +165,11 @@ files:
 - lib/react_manifest/sprockets_manifest_patcher.rb
 - lib/react_manifest/symbol_extractor.rb
 - lib/react_manifest/tree_classifier.rb
+- lib/react_manifest/vendor/ast_extractor.js
+- lib/react_manifest/vendor/build/README.md
+- lib/react_manifest/vendor/build/entry.js
+- lib/react_manifest/vendor/build/package-lock.json
+- lib/react_manifest/vendor/build/package.json
 - lib/react_manifest/version.rb
 - lib/react_manifest/view_helpers.rb
 - lib/react_manifest/watcher.rb