react-manifest-rails 0.2.31 → 0.2.33

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fc0a4a583ea6c0b488c1fc9e4c0af46dec90e4ecdd6b93cd7eae48267ffdbfaa
-  data.tar.gz: 1a00e3b56139db55d5c473e22bc35cd43e2fc1dcb3ee50700602344c09d0c4db
+  metadata.gz: 03532c58c1ba02316a423460c591adf2b8caa7d6366ff89abfc5c344d1e3a8fc
+  data.tar.gz: 3ab9a668ad0196bec652c804535307f788a7b6a9abea8418bb3c206d6f6ddba6
 SHA512:
-  metadata.gz: b6db17954b9a91e080c0074ce203d322af67ba58d887be9ae4a1ada51add9fe3d36f7fc256b1587c274c2315c9324caa7576421c19740a6aeab40fa85f3f5606
-  data.tar.gz: 49dc6ae440709098ace838c583f492a516fa5abd0b1b332525cd3803ed3787ed656cd23871b53ad8cb91908a4c0d62e0f9d96b8394180fe950da8ee405068d6c
+  metadata.gz: 6ff77f4444719e08a35032a2b07bc2d6e0621d49a5db73e2b77880bbddd0172f8c3f2aea1b38b3ce40ff7feaad8d59a141fa7edabe0ce8430091f89656904a42
+  data.tar.gz: d683a77dbcb098e2f5b08c74b1b36dac9d53e56587bf6ec7e958b5f0af25701d98fb9f70a305ceeff2ee0e2656bb81112fddf60cb61f33f21029bf6b445b8291

data/CHANGELOG.md

@@ -7,6 +7,19 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.2.33] - 2026-07-01
+
+### Fixed
+- `resolve_bundle_for_component`/`resolve_bundles_for_component(_direct)` (used by the `react_component` view helper) now pick up new controllers and components added while a development server is still running. Their `component_maps` cache is keyed only on config values, not on what's on disk, so once anything primed the cache (any earlier `react_component` call in the process), a controller dir or component added afterward was invisible until the process restarted — `react_component` would silently render with no bundle injected. The file watcher now invalidates this cache on every file change, the same way it already invalidates the scanner's per-file symbol cache.
+
+## [0.2.32] - 2026-07-01
+
+### Added
+- Generation now removes AUTO-GENERATED manifests whose `ux/app/<controller>/` directory no longer exists (renamed or deleted). Previously these were left behind indefinitely, still `//= require`-ing source files that no longer existed — a landmine for `assets:precompile`. Pinned (non-AUTO-GENERATED) files are never touched, and dry-run mode only logs what would be removed.
+
+### Changed
+- `config.stdout_logging` now defaults to `false`. `Rails.logger` always receives ReactManifest's status lines regardless of this flag; `stdout_logging` only controls an *additional* direct print to the terminal. Many development setups already have `Rails.logger` broadcast to stdout (`RAILS_LOG_TO_STDOUT`, Docker, `bin/dev`/Foreman), so the previous default of `true` printed every "File change detected" / "N manifest(s) written" line twice. Set `config.stdout_logging = true` explicitly if your `Rails.logger` does not already surface output in your terminal.
+
 ## [0.2.31] - 2026-07-01
 
 ### Fixed

data/README.md

@@ -108,6 +108,8 @@ Files carry an `AUTO-GENERATED` header. Any file without it is never overwritten
 
 Writes are atomic (temp file + rename) and idempotent (SHA-256 comparison skips unchanged files).
 
+If a `ux/app/<controller>/` directory is renamed or deleted, its manifest is removed automatically on the next generation (dev file watcher, boot, or `rails react_manifest:generate`) — pinned files are never removed this way.
+
 ## Asset Compilation & Minification
 
 The generated files are standard Sprockets manifests — `//= require` directives only. Sprockets processes them identically to `application.js`:
@@ -133,7 +135,7 @@ ReactManifest.configure do |config|
   config.size_threshold_kb = 500           # warn if a bundle exceeds this
   config.dry_run          = false          # never write; only print what would change
   config.verbose          = false          # extra diagnostic detail
-  config.stdout_logging   = true           # print status lines to terminal
+  config.stdout_logging   = false          # also print status lines directly to stdout (see note below)
 end
 ```
 
@@ -144,6 +146,7 @@ end
 - **`dry_run`**: also honoured by `DRY_RUN=1` environment variable at runtime.
 - **`extensions`**: add `ts` and `tsx` to enable TypeScript source detection.
 - **`external_roots` / `external_providers`**: do not point these at files already inside shared `ux/` dirs (`components/`, `hooks/`, `lib/`, etc.). The generator now skips those overlaps to prevent duplicate declarations in browser runtime.
+- **`stdout_logging`**: `Rails.logger` always receives status lines regardless of this flag. Turn this on only if your `Rails.logger` does *not* already print to your terminal in development — if it does (common with `RAILS_LOG_TO_STDOUT`, Docker, or `bin/dev`/Foreman setups), enabling this prints every line twice.
 
 ## Commands
 

data/lib/react_manifest/configuration.rb

@@ -50,8 +50,13 @@ module ReactManifest
     # Extra diagnostic logging (summary lines and richer error context).
     attr_accessor :verbose
 
-    # Emit ReactManifest status lines to stdout in development.
-    # Independent from Rails.logger output.
+    # Also print ReactManifest status lines directly to stdout, in addition
+    # to Rails.logger (which always receives them regardless of this flag).
+    # Off by default: many development setups already have Rails.logger
+    # broadcast to the terminal (RAILS_LOG_TO_STDOUT, Docker/Foreman, etc.),
+    # and enabling this on top of that prints every line twice. Turn it on
+    # only if your Rails.logger does NOT already surface output in your
+    # terminal and you want a guaranteed visible line per event.
     attr_accessor :stdout_logging
 
     # Explicit symbol-to-require-path mapping for external globals.
@@ -88,7 +93,7 @@ module ReactManifest
       @extensions        = %w[js jsx]
       @dry_run           = false
       @verbose           = false
-      @stdout_logging    = true
+      @stdout_logging    = false
       @external_providers = {}
       @external_roots     = []
     end

data/lib/react_manifest/generator.rb

@@ -12,7 +12,8 @@ module ReactManifest
   # Returns an array of result hashes:
   #   [{path: "/abs/path/ux_shared.js", status: :written}, ...]
   #
-  # Possible +status+ values: +:written+, +:unchanged+, +:skipped_pinned+, +:dry_run+.
+  # Possible +status+ values: +:written+, +:unchanged+, +:skipped_pinned+, +:dry_run+,
+  # +:removed_orphan+.
   #
   # Generates:
   #   ux_shared.js   — requires all files from shared dirs (components/, hooks/, lib/, etc.)
@@ -22,6 +23,9 @@ module ReactManifest
   # (skips write if content unchanged). Writes are atomic (temp-file + rename)
   # to avoid partial reads from concurrent processes.
   #
+  # Manifests whose ux/app/<controller> dir no longer exists are removed
+  # automatically (pinned files are never removed this way).
+  #
   # Never touches application.js, application_dev.js, or files in exclude_paths.
   # rubocop:disable Metrics/ClassLength
   class Generator
@@ -58,6 +62,12 @@ module ReactManifest
       # Phase 2: write — each write is atomic (tmp + rename).
       results = manifests.map { |m| write_manifest(m[:filename], m[:content]) }
 
+      # Phase 3: remove manifests left behind by a controller dir that no
+      # longer exists (renamed/deleted ux/app/<controller>). Never touches
+      # pinned (non-AUTO-GENERATED) files.
+      expected_filenames = manifests.map { |m| m[:filename] }
+      results.concat(remove_orphaned_manifests(expected_filenames))
+
       print_summary(results) if @config.verbose?
       results
     end
@@ -322,6 +332,25 @@ module ReactManifest
       end
     end
 
+    # Remove AUTO-GENERATED manifests that no longer correspond to any
+    # current shared/controller bundle (e.g. a ux/app/<controller> dir was
+    # deleted or renamed). Skips pinned files and, in dry-run mode, only
+    # logs what would be removed.
+    def remove_orphaned_manifests(expected_filenames)
+      Dir.glob(File.join(@config.abs_manifest_dir, "ux_*.js")).filter_map do |file|
+        next if expected_filenames.include?(File.basename(file))
+        next unless auto_generated?(file)
+
+        if @config.dry_run?
+          log_info "DRY-RUN: would remove orphaned manifest #{file}"
+          { path: file, status: :dry_run }
+        else
+          File.delete(file)
+          { path: file, status: :removed_orphan }
+        end
+      end
+    end
+
     # ----------------------------------------------------------- helpers
 
     def header_lines
@@ -433,7 +462,8 @@ module ReactManifest
       counts = results.group_by { |r| r[:status] }.transform_values(&:count)
       log_info "Generated: #{counts[:written] || 0} written, " \
                "#{counts[:unchanged] || 0} unchanged, " \
-               "#{counts[:skipped_pinned] || 0} skipped (not auto-generated)"
+               "#{counts[:skipped_pinned] || 0} skipped (not auto-generated), " \
+               "#{counts[:removed_orphan] || 0} orphaned removed"
     end
   end
   # rubocop:enable Metrics/ClassLength

data/lib/react_manifest/version.rb

@@ -1,3 +1,3 @@
 module ReactManifest
-  VERSION = "0.2.31".freeze
+  VERSION = "0.2.33".freeze
 end

data/lib/react_manifest/watcher.rb

@@ -91,6 +91,7 @@ module ReactManifest
         end
 
         (modified + added + removed).each { |f| Scanner.invalidate(f) }
+        ReactManifest.invalidate_component_maps!
         schedule_regeneration(config)
       end
 

data/lib/react_manifest.rb

@@ -35,6 +35,15 @@ module ReactManifest
       Scanner.clear_cache!
     end
 
+    # Drop the cached component-symbol -> bundle map used by
+    # resolve_bundle_for_component / resolve_bundles_for_component(_direct).
+    # Unlike reset!, this does NOT touch the current Configuration — safe to
+    # call whenever ux/ files change (e.g. from the file watcher) so newly
+    # added controllers/components are picked up without losing app config.
+    def invalidate_component_maps!
+      @component_maps_cache = nil
+    end
+
     # Returns the ordered list of bundle logical names for a given controller.
     # Used by the react_bundle_tag view helper.
     def resolve_bundles(ctrl_name)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: react-manifest-rails
 version: !ruby/object:Gem::Version
-  version: 0.2.31
+  version: 0.2.33
 platform: ruby
 authors:
 - Oliver Noonan