react-manifest-rails 0.2.30 → 0.2.32

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1331513cb5939f583960098fa86106a9901a0b3ef126b64f5ac9ae545a51f930
-  data.tar.gz: f89ef2eff49327f1e4a4a3aed0657167d5dacabd0bae3735a1a4744c0ca45332
+  metadata.gz: cfebc711293e26ed0feb2d97ba630782e2d2de8592d4e0d4b3392c54ecda6f5a
+  data.tar.gz: 4501274e0565b053dbdf110f87a747e631811e8a5b4d9b248e76e28a6b4a54ea
 SHA512:
-  metadata.gz: 6fe469fdebbd0bb563f46c59e01c3931fbcf67485e8d0141cd9628f95969912716f42622454055f758c98e0a4e9482183f79a4a1c025c9e8a9b86a6690dd8f0c
-  data.tar.gz: 36fcaa4b86a562227966018d98355894526ada5f6744427749938dd64b21ed6e5cd4f390c08c309f4500201f220647fe868a7f223ede977fbbafc15960d5ed51
+  metadata.gz: 358aa7190d5e0f146b1a9fce2065b41890a23bd8b9b6c42855c895905bf8af6567bb6fec372f8b2bd2363cfd7c68b5a5cd7a535fe8632474be60e5bd8d91b5fa
+  data.tar.gz: bb655465c8ce7a9eb63ad3dde98cbb6f354a1d1eaef8efd948a4b11dc0657ef673c943fb2ca8549e0fb672f7c7abec8f9b4c3e312a77c26bdb870ea4807622b5

data/CHANGELOG.md

@@ -7,6 +7,23 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.2.32] - 2026-07-01
+
+### Added
+- Generation now removes AUTO-GENERATED manifests whose `ux/app/<controller>/` directory no longer exists (renamed or deleted). Previously these were left behind indefinitely, still `//= require`-ing source files that no longer existed — a landmine for `assets:precompile`. Pinned (non-AUTO-GENERATED) files are never touched, and dry-run mode only logs what would be removed.
+
+### Changed
+- `config.stdout_logging` now defaults to `false`. `Rails.logger` always receives ReactManifest's status lines regardless of this flag; `stdout_logging` only controls an *additional* direct print to the terminal. Many development setups already have `Rails.logger` broadcast to stdout (`RAILS_LOG_TO_STDOUT`, Docker, `bin/dev`/Foreman), so the previous default of `true` printed every "File change detected" / "N manifest(s) written" line twice. Set `config.stdout_logging = true` explicitly if your `Rails.logger` does not already surface output in your terminal.
+
+## [0.2.31] - 2026-07-01
+
+### Fixed
+- Controller manifests no longer pull in an unrelated bundle's files just because a component name collides (e.g. a generic `Show` component defined in two different `ux/app/*` dirs). A bundle now always satisfies a symbol from its own files first, instead of attributing it to whichever bundle happened to define that name first.
+- `react_component` no longer silently stops auto-injecting a component's bundle for the rest of the request after `react_bundle_tag` has rendered once. Previously, calling `react_component` for a component in an unrelated bundle (not the current controller's own bundle, e.g. from a haml/erb view mixing controller-based and component-based rendering) would render with no script tag at all if `react_bundle_tag` had already run earlier in the same request.
+
+### Removed
+- The gem version is no longer embedded in the `AUTO-GENERATED` manifest header. Previously every manifest's content digest changed on every gem upgrade, forcing a full regeneration of all `ux_*.js` files for no functional reason.
+
 ## [0.2.28] - 2026-05-11
 
 ### Fixed

data/README.md

@@ -108,6 +108,8 @@ Files carry an `AUTO-GENERATED` header. Any file without it is never overwritten
 
 Writes are atomic (temp file + rename) and idempotent (SHA-256 comparison skips unchanged files).
 
+If a `ux/app/<controller>/` directory is renamed or deleted, its manifest is removed automatically on the next generation (dev file watcher, boot, or `rails react_manifest:generate`) — pinned files are never removed this way.
+
 ## Asset Compilation & Minification
 
 The generated files are standard Sprockets manifests — `//= require` directives only. Sprockets processes them identically to `application.js`:
@@ -133,7 +135,7 @@ ReactManifest.configure do |config|
   config.size_threshold_kb = 500           # warn if a bundle exceeds this
   config.dry_run          = false          # never write; only print what would change
   config.verbose          = false          # extra diagnostic detail
-  config.stdout_logging   = true           # print status lines to terminal
+  config.stdout_logging   = false          # also print status lines directly to stdout (see note below)
 end
 ```
 
@@ -144,6 +146,7 @@ end
 - **`dry_run`**: also honoured by `DRY_RUN=1` environment variable at runtime.
 - **`extensions`**: add `ts` and `tsx` to enable TypeScript source detection.
 - **`external_roots` / `external_providers`**: do not point these at files already inside shared `ux/` dirs (`components/`, `hooks/`, `lib/`, etc.). The generator now skips those overlaps to prevent duplicate declarations in browser runtime.
+- **`stdout_logging`**: `Rails.logger` always receives status lines regardless of this flag. Turn this on only if your `Rails.logger` does *not* already print to your terminal in development — if it does (common with `RAILS_LOG_TO_STDOUT`, Docker, or `bin/dev`/Foreman setups), enabling this prints every line twice.
 
 ## Commands
 

data/lib/react_manifest/configuration.rb

@@ -50,8 +50,13 @@ module ReactManifest
     # Extra diagnostic logging (summary lines and richer error context).
     attr_accessor :verbose
 
-    # Emit ReactManifest status lines to stdout in development.
-    # Independent from Rails.logger output.
+    # Also print ReactManifest status lines directly to stdout, in addition
+    # to Rails.logger (which always receives them regardless of this flag).
+    # Off by default: many development setups already have Rails.logger
+    # broadcast to the terminal (RAILS_LOG_TO_STDOUT, Docker/Foreman, etc.),
+    # and enabling this on top of that prints every line twice. Turn it on
+    # only if your Rails.logger does NOT already surface output in your
+    # terminal and you want a guaranteed visible line per event.
     attr_accessor :stdout_logging
 
     # Explicit symbol-to-require-path mapping for external globals.
@@ -88,7 +93,7 @@ module ReactManifest
       @extensions        = %w[js jsx]
       @dry_run           = false
       @verbose           = false
-      @stdout_logging    = true
+      @stdout_logging    = false
       @external_providers = {}
       @external_roots     = []
     end

data/lib/react_manifest/generator.rb

@@ -12,7 +12,8 @@ module ReactManifest
   # Returns an array of result hashes:
   #   [{path: "/abs/path/ux_shared.js", status: :written}, ...]
   #
-  # Possible +status+ values: +:written+, +:unchanged+, +:skipped_pinned+, +:dry_run+.
+  # Possible +status+ values: +:written+, +:unchanged+, +:skipped_pinned+, +:dry_run+,
+  # +:removed_orphan+.
   #
   # Generates:
   #   ux_shared.js   — requires all files from shared dirs (components/, hooks/, lib/, etc.)
@@ -22,6 +23,9 @@ module ReactManifest
   # (skips write if content unchanged). Writes are atomic (temp-file + rename)
   # to avoid partial reads from concurrent processes.
   #
+  # Manifests whose ux/app/<controller> dir no longer exists are removed
+  # automatically (pinned files are never removed this way).
+  #
   # Never touches application.js, application_dev.js, or files in exclude_paths.
   # rubocop:disable Metrics/ClassLength
   class Generator
@@ -30,7 +34,6 @@ module ReactManifest
 
     HEADER = <<~JS.freeze
       // AUTO-GENERATED — DO NOT EDIT
-      // react-manifest-rails %<version>s
       // Run `rails react_manifest:generate` to regenerate.
     JS
 
@@ -59,6 +62,12 @@ module ReactManifest
       # Phase 2: write — each write is atomic (tmp + rename).
       results = manifests.map { |m| write_manifest(m[:filename], m[:content]) }
 
+      # Phase 3: remove manifests left behind by a controller dir that no
+      # longer exists (renamed/deleted ux/app/<controller>). Never touches
+      # pinned (non-AUTO-GENERATED) files.
+      expected_filenames = manifests.map { |m| m[:filename] }
+      results.concat(remove_orphaned_manifests(expected_filenames))
+
       print_summary(results) if @config.verbose?
       results
     end
@@ -130,6 +139,7 @@ module ReactManifest
     def build_controller_context(controller_dirs)
       bundle_files = {}
       symbol_to_bundle = {}
+      bundle_own_symbols = Hash.new { |h, k| h[k] = Set.new }
       external_symbol_to_require = {}
       dependencies = Hash.new { |h, k| h[k] = Set.new }
       external_requires = Hash.new { |h, k| h[k] = Set.new }
@@ -145,6 +155,7 @@ module ReactManifest
             next unless sym.match?(/\A[A-Z][A-Za-z0-9_]*\z/)
 
             symbol_to_bundle[sym] ||= bundle_name
+            bundle_own_symbols[bundle_name] << sym
           end
         end
       end
@@ -170,8 +181,16 @@ module ReactManifest
 
       # Compute per-bundle cross-app and external dependencies
       bundle_files.each do |bundle_name, files|
+        own_symbols = bundle_own_symbols[bundle_name]
+
         files.each do |file_path|
           extract_used_component_symbols(file_path).each do |sym|
+            # A symbol the bundle defines itself (in any of its own files) is
+            # always satisfied locally — never attribute it to another bundle
+            # or an external provider just because that symbol name happens
+            # to collide with something defined elsewhere.
+            next if own_symbols.include?(sym)
+
             dep_bundle = symbol_to_bundle[sym]
             dependencies[bundle_name] << dep_bundle if dep_bundle && dep_bundle != bundle_name
 
@@ -313,13 +332,29 @@ module ReactManifest
       end
     end
 
+    # Remove AUTO-GENERATED manifests that no longer correspond to any
+    # current shared/controller bundle (e.g. a ux/app/<controller> dir was
+    # deleted or renamed). Skips pinned files and, in dry-run mode, only
+    # logs what would be removed.
+    def remove_orphaned_manifests(expected_filenames)
+      Dir.glob(File.join(@config.abs_manifest_dir, "ux_*.js")).filter_map do |file|
+        next if expected_filenames.include?(File.basename(file))
+        next unless auto_generated?(file)
+
+        if @config.dry_run?
+          log_info "DRY-RUN: would remove orphaned manifest #{file}"
+          { path: file, status: :dry_run }
+        else
+          File.delete(file)
+          { path: file, status: :removed_orphan }
+        end
+      end
+    end
+
     # ----------------------------------------------------------- helpers
 
     def header_lines
-      [
-        format(HEADER, version: ReactManifest::VERSION),
-        ""
-      ].flatten
+      [HEADER, ""]
     end
 
     def js_files_in(dir)
@@ -427,7 +462,8 @@ module ReactManifest
       counts = results.group_by { |r| r[:status] }.transform_values(&:count)
       log_info "Generated: #{counts[:written] || 0} written, " \
                "#{counts[:unchanged] || 0} unchanged, " \
-               "#{counts[:skipped_pinned] || 0} skipped (not auto-generated)"
+               "#{counts[:skipped_pinned] || 0} skipped (not auto-generated), " \
+               "#{counts[:removed_orphan] || 0} orphaned removed"
     end
   end
   # rubocop:enable Metrics/ClassLength

data/lib/react_manifest/version.rb

@@ -1,3 +1,3 @@
 module ReactManifest
-  VERSION = "0.2.30".freeze
+  VERSION = "0.2.32".freeze
 end

data/lib/react_manifest/view_helpers.rb

@@ -26,7 +26,6 @@ module ReactManifest
       return "".html_safe if fresh_bundles.empty?
 
       fresh_bundles.each { |b| emitted << b }
-      mark_bundle_tag_rendered
 
       asset_names = fresh_bundles.map { |bundle| "#{bundle}.js" }
       javascript_include_tag(*asset_names, extname: false, **html_options)
@@ -38,7 +37,6 @@ module ReactManifest
     # This avoids strict dependence on controller_path -> bundle naming alignment.
     def react_component(*args, **kwargs, &block)
       html = super
-      return html if bundle_tag_rendered?
 
       component_name = args.first
       bundles = ReactManifest.resolve_bundles_for_component_direct(component_name)
@@ -78,17 +76,5 @@ module ReactManifest
         @emitted_bundles ||= []
       end
     end
-
-    def mark_bundle_tag_rendered
-      return unless respond_to?(:request, true) && request
-
-      request.env["react_manifest.bundle_tag_rendered"] = true
-    end
-
-    def bundle_tag_rendered?
-      return false unless respond_to?(:request, true) && request
-
-      request.env["react_manifest.bundle_tag_rendered"] == true
-    end
   end
 end

data/lib/react_manifest.rb

@@ -146,6 +146,7 @@ module ReactManifest
 
       controller_dirs = TreeClassifier.new(config).classify.controller_dirs
       symbol_to_bundle = {}
+      bundle_own_symbols = Hash.new { |h, k| h[k] = Set.new }
       bundle_files = Hash.new { |h, k| h[k] = [] }
       bundle_dependencies = Hash.new { |h, k| h[k] = Set.new }
 
@@ -160,13 +161,21 @@ module ReactManifest
 
             # Keep first writer to ensure deterministic behavior if a symbol is duplicated.
             symbol_to_bundle[symbol] ||= bundle_name
+            bundle_own_symbols[bundle_name] << symbol
           end
         end
       end
 
       bundle_files.each do |bundle_name, files|
+        own_symbols = bundle_own_symbols[bundle_name]
+
         files.each do |file_path|
           extract_used_component_symbols(file_path).each do |symbol|
+            # A symbol the bundle defines itself is always satisfied locally —
+            # never attribute it to another bundle just because that symbol
+            # name happens to collide with something defined elsewhere.
+            next if own_symbols.include?(symbol)
+
             dep_bundle = symbol_to_bundle[symbol]
             next unless dep_bundle && dep_bundle != bundle_name
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: react-manifest-rails
 version: !ruby/object:Gem::Version
-  version: 0.2.30
+  version: 0.2.32
 platform: ruby
 authors:
 - Oliver Noonan
@@ -160,7 +160,7 @@ licenses:
 metadata:
   homepage_uri: https://github.com/olivernoonan/react-manifest-rails
   source_code_uri: https://github.com/olivernoonan/react-manifest-rails
-  changelog_uri: https://github.com/olivernoonan/react-manifest-rails/blob/main/CHANGELOG.md
+  changelog_uri: https://github.com/olivernoonan/react-manifest-rails/blob/master/CHANGELOG.md
   bug_tracker_uri: https://github.com/olivernoonan/react-manifest-rails/issues
   rubygems_mfa_required: 'true'
 rdoc_options: []