react-manifest-rails 0.2.19 → 0.2.21

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d392f2b6bf13451773d9e12b51a3b1cf1048c407058cb60cbdb2db48cfa79acc
-  data.tar.gz: ff2acfbd5ddc4b0b1e048fea664211ed62d04890fcdbcb555324f4ce3bbfa0bd
+  metadata.gz: a68f022a75a440c68e741e931c5453e6c96c126380356757825a984de94e2143
+  data.tar.gz: 52d20e65e685a1b82d833ee650677c91a6fc5faa9e7b32c1075d85a2e6f53fa7
 SHA512:
-  metadata.gz: 2df51348498e3778af7048c4a7d3090d1223ab0683e4bac4a0443dff6ad2b4ec47eca9bb50a492b35a012cb5ce126521839540a58171cddd67651c0da50e56e8
-  data.tar.gz: b7f9300e03f28a274b33f62c3500add16249aa0e4d52607d6c359527ca36c3f53ba00d69d840021c954ec87bcf7b6aa36682122349ada050f0f74e7d11a481a0
+  metadata.gz: bfd3abb4dde7e8d661df2623b42345a6f5a191f6b119ce25d8913ab094261ea76592ea435709a9fd80d320703673deb073b4df2a8de90a2fb76d6cf43532272b
+  data.tar.gz: cef2fd10f820ebf0a1583772fa7236e34f5c5d2744e076f682111d374cf220c265b2625d02a6f88d0274baaaa8e215eb55cfec353e528d85ac82327ef466dc6f

data/CHANGELOG.md

@@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [Unreleased]
+
+### Fixed
+- `react_component` now emits only `ux_shared` plus the direct owning bundle for the requested component symbol, instead of also emitting transitive controller manifests as separate script tags. This prevents unnecessary network requests for additional `ux_*.js` manifests while preserving dependency loading through generated manifest `require` directives.
+- Generator now skips `external_roots` and `external_providers` entries that resolve to files already included in `ux_shared`, preventing duplicate runtime declarations from overlapping shared/external includes.
+- View helper bundle deduplication now canonicalizes bundle names (e.g. `ux_shared` vs `ux_manifests/ux_shared`) to avoid re-emitting equivalent script tags.
+
 ## [0.2.10] - 2026-04-16
 
 ### Fixed

data/README.md

@@ -84,7 +84,9 @@ In development:
 Generation is **directory-based** — deterministic and conservative by design.
 
 - `ux_shared.js`: every file from directories outside `ux/app/` (i.e. `components/`, `hooks/`, `lib/`, etc.)
-- `ux_<controller>.js`: `ux_shared` + every file under `ux/app/<controller>/`
+- `ux_<controller>.js`: every file under `ux/app/<controller>/`, plus transitive controller dependencies inferred from component usage across `ux/app/*`
+
+`ux_shared.js` is loaded as a separate script by `react_bundle_tag` and `react_component` helpers. It is intentionally not inlined into every `ux_<controller>.js` manifest to avoid duplicating shared code across controller bundles.
 
 Namespace fallback for nested controllers: `admin/reports/summary` tries `ux_admin_reports_summary`, then `ux_admin_reports`, then `ux_admin`, then `ux_summary`. The most specific match wins.
 
@@ -141,6 +143,7 @@ end
 - **`exclude_paths`**: excludes files whose path contains any listed segment. Not based on `application.js`.
 - **`dry_run`**: also honoured by `DRY_RUN=1` environment variable at runtime.
 - **`extensions`**: add `ts` and `tsx` to enable TypeScript source detection.
+- **`external_roots` / `external_providers`**: do not point these at files already inside shared `ux/` dirs (`components/`, `hooks/`, `lib/`, etc.). The generator now skips those overlaps to prevent duplicate declarations in browser runtime.
 
 ## Commands
 
@@ -168,6 +171,22 @@ bundle exec rails react_manifest:watch
 bundle exec rails react_manifest:clean
 ```
 
+## Releasing
+
+The publish workflow runs on tag pushes (`v*`), not on branch pushes.
+
+1. Bump `ReactManifest::VERSION` in `lib/react_manifest/version.rb`.
+2. Run `bundle install` to refresh the local path spec version in `Gemfile.lock`.
+3. Commit and push to `main`/`master`.
+4. Create and push a matching annotated tag:
+
+```bash
+git tag -a vX.Y.Z -m "Release vX.Y.Z"
+git push origin vX.Y.Z
+```
+
+This tag push triggers `.github/workflows/release.yml`, which runs tests, creates a GitHub Release, and publishes to RubyGems.
+
 ## Troubleshooting
 
 ### `AssetNotPrecompiledError` for `ux_*.js`

data/lib/react_manifest/generator.rb

@@ -42,7 +42,7 @@ module ReactManifest
     # written and others stale/missing.
     def run!
       classification = @classifier.classify
-      controller_context = build_controller_context(classification.controller_dirs)
+      controller_context = build_controller_context(classification.controller_dirs, classification.shared_dirs)
 
       # Phase 1: build all content in memory — no I/O.
       manifests = []
@@ -99,12 +99,13 @@ module ReactManifest
       { filename: "#{ctrl[:bundle_name]}.js", content: "#{lines.join("\n")}\n" }
     end
 
-    def build_controller_context(controller_dirs)
+    def build_controller_context(controller_dirs, shared_dirs)
       bundle_files = {}
       symbol_to_bundle = {}
       external_symbol_to_require = {}
       dependencies = Hash.new { |h, k| h[k] = Set.new }
       external_requires = Hash.new { |h, k| h[k] = Set.new }
+      shared_require_paths = shared_require_path_set(shared_dirs)
 
       # Index controller-defined symbols for cross-app detection
       controller_dirs.each do |ctrl|
@@ -126,6 +127,11 @@ module ReactManifest
         abs_root = abs_external_root(root_path)
         external_js_files_in(abs_root).each do |file_path|
           req_path = relative_require_path(file_path)
+          if shared_require_paths.include?(normalize_require_path(req_path))
+            warn "[ReactManifest] Skipping external_roots file already provided by shared bundle: #{req_path}"
+            next
+          end
+
           extract_defined_symbols(file_path).each do |sym|
             external_symbol_to_require[sym] ||= req_path
           end
@@ -134,6 +140,12 @@ module ReactManifest
 
       # Explicit external_providers win over scanned roots on symbol conflicts
       @config.external_providers.each do |sym, req_path|
+        if shared_require_paths.include?(normalize_require_path(req_path))
+          warn "[ReactManifest] Skipping external provider '#{sym}' because it is already " \
+               "provided by shared bundle: #{req_path}"
+          next
+        end
+
         external_symbol_to_require[sym] = req_path
       end
 
@@ -348,6 +360,18 @@ module ReactManifest
       Rails.root.join(path).to_s
     end
 
+    def shared_require_path_set(shared_dirs)
+      shared_dirs.each_with_object(Set.new) do |shared_dir, paths|
+        js_files_in(shared_dir[:path]).each do |file_path|
+          paths << normalize_require_path(relative_require_path(file_path))
+        end
+      end
+    end
+
+    def normalize_require_path(path)
+      path.to_s.sub(/\.js\.jsx$/, "").sub(/\.jsx$/, "").sub(/\.js$/, "")
+    end
+
     def auto_generated?(path)
       # Avoid TOCTOU: don't check existence separately — just attempt the read
       # and treat a missing/unreadable file as not auto-generated.

data/lib/react_manifest/version.rb

@@ -1,3 +1,3 @@
 module ReactManifest
-  VERSION = "0.2.19".freeze
+  VERSION = "0.2.21".freeze
 end

data/lib/react_manifest/view_helpers.rb

@@ -23,7 +23,7 @@ module ReactManifest
 
       # Record emitted bundles so react_component doesn't re-emit them.
       emitted = (@_react_manifest_emitted_bundles ||= [])
-      bundles.each { |b| emitted << b unless emitted.include?(b) }
+      bundles.each { |b| emitted << b unless emitted_bundle?(emitted, b) }
 
       asset_names = bundles.map { |bundle| "#{bundle}.js" }
       javascript_include_tag(*asset_names, extname: false, **html_options)
@@ -37,13 +37,13 @@ module ReactManifest
       html = super
 
       component_name = args.first
-      bundles = ReactManifest.resolve_bundles_for_component(component_name)
+      bundles = ReactManifest.resolve_bundles_for_component_direct(component_name)
       return html if bundles.empty?
 
       emitted = (@_react_manifest_emitted_bundles ||= [])
 
       new_tags = bundles.filter_map do |bundle|
-        next if emitted.include?(bundle)
+        next if emitted_bundle?(emitted, bundle)
 
         emitted << bundle
         javascript_include_tag("#{bundle}.js", extname: false)
@@ -53,5 +53,16 @@ module ReactManifest
 
       safe_join(new_tags + [html])
     end
+
+    private
+
+    def emitted_bundle?(emitted, bundle)
+      canonical = canonical_bundle_name(bundle)
+      emitted.any? { |existing| canonical_bundle_name(existing) == canonical }
+    end
+
+    def canonical_bundle_name(bundle)
+      bundle.to_s.split("/").last
+    end
   end
 end

data/lib/react_manifest.rb

@@ -15,6 +15,7 @@ require "react_manifest/watcher"
 require "react_manifest/reporter"
 require "react_manifest/view_helpers"
 
+# rubocop:disable Metrics/ModuleLength
 module ReactManifest
   class << self
     def configuration
@@ -65,7 +66,32 @@ module ReactManifest
     # where the requested component name is known and may not align 1:1 with
     # controller_path-derived bundle names.
     def resolve_bundle_for_component(component_name)
-      resolve_bundles_for_component(component_name).last
+      resolve_bundles_for_component_direct(component_name).last
+    end
+
+    # Resolve the direct bundle list needed for a React component symbol.
+    # Returns shared first (if present), then the component's owning bundle.
+    #
+    # Unlike resolve_bundles_for_component, this does not include transitive
+    # controller dependencies because generated controller manifests already
+    # inline those files via Sprockets require directives.
+    def resolve_bundles_for_component_direct(component_name)
+      name = component_name.to_s
+      return [] if name.empty?
+
+      config = configuration
+      maps = component_maps(config)
+      root_bundle = maps[:symbol_to_bundle][name]
+      return [] unless root_bundle
+
+      bundles = []
+      shared = resolve_bundle_reference(config, config.shared_bundle)
+      bundles << shared if shared
+
+      root = resolve_bundle_reference(config, root_bundle)
+      bundles << root if root && !bundles.include?(root)
+
+      bundles
     end
 
     # Resolve all controller bundles needed for a React component symbol.
@@ -220,3 +246,4 @@ module ReactManifest
     end
   end
 end
+# rubocop:enable Metrics/ModuleLength

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: react-manifest-rails
 version: !ruby/object:Gem::Version
-  version: 0.2.19
+  version: 0.2.21
 platform: ruby
 authors:
 - Oliver Noonan