react-manifest-rails 0.2.18 → 0.2.20

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d200b72fea50e032cb2b8d812482ae6c65550029e129455d0ef7b81ff14b1077
-  data.tar.gz: 4a22e1b28aef9c55e8a081b7874bc70104cd4dabec4a236f168b909bd2bebeb8
+  metadata.gz: 573c8f1d4441a029cdc192ceef3e3e140702e55a17fc367e195243752f3970d6
+  data.tar.gz: d02437b64aeee8fb45879b9b5d1f740e4eea85b42023ac8fadb84c3c6c491e97
 SHA512:
-  metadata.gz: 7e065d309bd9ad9e3f8ebeb25dbb22b6cea11771d27283efafd85fe9f16d5ee186753118906fa38f20e86441e334540bb332e2aea31c48e4d537ecf3f1748fe0
-  data.tar.gz: 6d094eb1f61e1f3b67929b64fb1a7c99e0fa9e9386db1dcaabcb010f9a88b143508af4e4ffc36870cee4c7fc175460bf6d29ba9c2bbd07b60a35a06708621cb6
+  metadata.gz: f4aaf9bc43e9cc067c47790eb98061a0af8ad58efaa61c7c9a663749ca1d3e5cb464881987ca9ee31e015c820578780857cf5b15c9fae2a5d2b7bd0e0ce3038c
+  data.tar.gz: 34273febe66a2821de77756baad5be6e3193234746db4f0ded7ba80d180ba1ce3d0d7a7c01e67456060ae743d5cab2723914ec5e163f1eaefb885f3504177569

data/CHANGELOG.md

@@ -5,6 +5,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [Unreleased]
+
+### Fixed
+- `react_component` now emits only `ux_shared` plus the direct owning bundle for the requested component symbol, instead of also emitting transitive controller manifests as separate script tags. This prevents unnecessary network requests for additional `ux_*.js` manifests while preserving dependency loading through generated manifest `require` directives.
+
 ## [0.2.10] - 2026-04-16
 
 ### Fixed

data/lib/react_manifest/version.rb

@@ -1,3 +1,3 @@
 module ReactManifest
-  VERSION = "0.2.18".freeze
+  VERSION = "0.2.20".freeze
 end

data/lib/react_manifest/view_helpers.rb

@@ -37,7 +37,7 @@ module ReactManifest
       html = super
 
       component_name = args.first
-      bundles = ReactManifest.resolve_bundles_for_component(component_name)
+      bundles = ReactManifest.resolve_bundles_for_component_direct(component_name)
       return html if bundles.empty?
 
       emitted = (@_react_manifest_emitted_bundles ||= [])

data/lib/react_manifest.rb

@@ -15,6 +15,7 @@ require "react_manifest/watcher"
 require "react_manifest/reporter"
 require "react_manifest/view_helpers"
 
+# rubocop:disable Metrics/ModuleLength
 module ReactManifest
   class << self
     def configuration
@@ -65,7 +66,32 @@ module ReactManifest
     # where the requested component name is known and may not align 1:1 with
     # controller_path-derived bundle names.
     def resolve_bundle_for_component(component_name)
-      resolve_bundles_for_component(component_name).last
+      resolve_bundles_for_component_direct(component_name).last
+    end
+
+    # Resolve the direct bundle list needed for a React component symbol.
+    # Returns shared first (if present), then the component's owning bundle.
+    #
+    # Unlike resolve_bundles_for_component, this does not include transitive
+    # controller dependencies because generated controller manifests already
+    # inline those files via Sprockets require directives.
+    def resolve_bundles_for_component_direct(component_name)
+      name = component_name.to_s
+      return [] if name.empty?
+
+      config = configuration
+      maps = component_maps(config)
+      root_bundle = maps[:symbol_to_bundle][name]
+      return [] unless root_bundle
+
+      bundles = []
+      shared = resolve_bundle_reference(config, config.shared_bundle)
+      bundles << shared if shared
+
+      root = resolve_bundle_reference(config, root_bundle)
+      bundles << root if root && !bundles.include?(root)
+
+      bundles
     end
 
     # Resolve all controller bundles needed for a React component symbol.
@@ -186,10 +212,16 @@ module ReactManifest
     end
 
     def resolve_bundle_reference(config, bundle_name)
+      subdir = config.normalized_manifest_subdir
       manifest_path = File.join(config.abs_manifest_dir, "#{bundle_name}.js")
-      return bundle_name if File.exist?(manifest_path)
+      if File.exist?(manifest_path)
+        # Return the full Sprockets logical path so javascript_include_tag resolves
+        # correctly: files in ux_manifests/ have logical path ux_manifests/<name>.
+        return subdir.empty? ? bundle_name : "#{subdir}/#{bundle_name}"
+      end
 
-      # Backward compatibility for apps still holding legacy manifests in output_dir root.
+      # Backward compatibility: apps that wrote manifests directly to output_dir root
+      # before manifest_subdir was introduced keep working with bare bundle names.
       legacy_path = File.join(config.abs_output_dir, "#{bundle_name}.js")
       return bundle_name if File.exist?(legacy_path)
 
@@ -214,3 +246,4 @@ module ReactManifest
     end
   end
 end
+# rubocop:enable Metrics/ModuleLength

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: react-manifest-rails
 version: !ruby/object:Gem::Version
-  version: 0.2.18
+  version: 0.2.20
 platform: ruby
 authors:
 - Oliver Noonan