rdux 0.4.1 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0eef143c3400a105457f40a8a9c4923ac3ceda1f55368d7bc2a8de146b9bf18d
-  data.tar.gz: 3fd1831ee4745709a83d3046bc923fbaba15f6c00c219dc768efcc6c7d6c4c3c
+  metadata.gz: 4d8b2deb7d13b8061c8996ccb5389ee374f7822aeb9973e50c7723688caf1c1d
+  data.tar.gz: 4d5fd29c0b67e4c3d01a326b2b34e7e7ee8a5599485b2ea76c48cfd445147ad6
 SHA512:
-  metadata.gz: 45d228402c630f1470c1bca298ece96eb39c1de62d6368890ac9959d6c331f77ee48703bcbf56b684b30f22214665789d8bbbada18b691f9e01a18e058cd0fba
-  data.tar.gz: c518e31ce369986564bdc735602480499dfbecf0f4c90f7e873a3e73b016c14cf2e9367e954d99e4e05a56c6f1a17f70c592ceebbd39d7fa82ed077695f94cf4
+  metadata.gz: a27f19dba3623c4e9da1f0c802d3d62f44a5d9a20a75fc7af1ac14a597e9f203b2237ada8930ca22c10e626e756d77b601041e820668485ec3c25b325c744f40
+  data.tar.gz: e5603781b011cd5fd8e215083be8165c3665a5071b7a148d91cfd247e6e0be3875d5289ed89f5ec593b4e26aece21f2e7b05f19d5334ccb569c8c574272e2838

data/app/models/rdux/action.rb

@@ -4,6 +4,8 @@ module Rdux
   class Action < ApplicationRecord
     include Actionable
 
+    attr_accessor :up_payload_unsanitized
+
     belongs_to :rdux_failed_action, optional: true, class_name: 'Rdux::FailedAction'
     belongs_to :rdux_action, optional: true, class_name: 'Rdux::Action'
     has_many :rdux_actions, class_name: 'Rdux::Action', foreign_key: 'rdux_action_id'
@@ -14,14 +16,14 @@ module Rdux
     scope :down, -> { where.not(down_at: nil) }
 
     def call(opts = {})
-      perform_action(:call, up_payload, opts)
+      perform_action(:call, up_payload_unsanitized || up_payload, opts)
     end
 
     def up(opts = {})
-      return false if up_payload_sanitized
+      return false if up_payload_sanitized && up_payload_unsanitized.nil?
       return false unless down_at.nil?
 
-      perform_action(:up, up_payload, opts)
+      perform_action(:up, up_payload_unsanitized || up_payload, opts)
     end
 
     def down
@@ -42,13 +44,13 @@ module Rdux
     def can_down?
       q = self.class.where('created_at > ?', created_at)
               .where(down_at: nil)
-              .where('id != ?', rdux_action_id.to_i)
+              .where('rdux_action_id IS NULL OR rdux_action_id != ?', id)
       q = q.where(stream_hash: stream_hash) unless stream_hash.nil?
       !q.count.positive?
     end
 
     def action_performer(meth)
-      name_const = name.to_s.classify.constantize
+      name_const = name.to_s.constantize
       return name_const if name_const.respond_to?(meth)
       return unless name_const.is_a?(Class)
 
@@ -57,13 +59,13 @@ module Rdux
     end
 
     def perform_action(meth, payload, opts)
-      responder = action_performer(meth)
-      return if responder.nil?
+      performer = action_performer(meth)
+      return if performer.nil?
 
       if opts.any?
-        responder.public_send(meth, payload, opts)
+        performer.public_send(meth, payload, opts)
       else
-        responder.public_send(meth, payload)
+        performer.public_send(meth, payload)
       end
     end
 

data/lib/rdux/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Rdux
-  VERSION = '0.4.1'
+  VERSION = '0.5.0'
 end

data/lib/rdux.rb

@@ -9,58 +9,49 @@ module Rdux
   class << self
     def dispatch(action_name, payload, opts = {}, meta: nil)
       (opts[:ars] || {}).each { |k, v| payload["#{k}_id"] = v.id }
-      action = Action.new(name: action_name, up_payload: payload, meta: meta)
-      call_call_meth_on_action(action, opts)
+      action = Action.create!(name: action_name, up_payload: payload, meta: meta)
+      sanitize(action)
+      call_call_or_up_on_action(action, opts)
     end
 
     alias perform dispatch
 
     private
 
-    def call_call_meth_on_action(action, opts)
+    def call_call_or_up_on_action(action, opts)
       res = action.call(opts)
-      return call_up_meth_on_action(action, opts) if res.nil?
-
-      unless res.down_payload.nil?
-        res.resp = res.down_payload.deep_stringify_keys
+      if res
+        res.resp ||= res.down_payload
         res.down_payload = nil
+      else
+        res = action.up(opts)
       end
       assign_and_persist(res, action)
     end
 
-    def call_up_meth_on_action(action, opts)
-      res = action.up(opts)
-      res.down_payload&.deep_stringify_keys!
-      action.down_payload = res.down_payload
-      assign_and_persist(res, action)
-    end
-
     def assign_and_persist(res, action)
+      action.down_payload = res.down_payload&.deep_stringify_keys!
       if res.ok
         assign_and_persist_for_ok(res, action)
       elsif res.save_failed?
         assign_and_persist_for_failed(res, action)
+      else
+        action.destroy
       end
-      res.action ||= action
       res
     end
 
-    def assign_and_persist_common(res, action)
-      sanitize(action)
-      action.up_result = res.up_result
-    end
-
     def assign_and_persist_for_ok(res, action)
-      assign_and_persist_common(res, action)
+      action.up_result = res.up_result
+      res.action = action.tap(&:save!)
       res.nested&.each { |nested_res| action.rdux_actions << nested_res.action }
-      action.save!
     end
 
     def assign_and_persist_for_failed(res, action)
-      assign_and_persist_common(res, action)
-      action.up_result ||= res.resp
+      action.up_result = res.up_result
       res.action = action.to_failed_action.tap(&:save!)
-      assign_nested_responses_to_failed_action(res.action, res.nested) unless res.nested.nil?
+      action.destroy
+      assign_nested_responses_to_failed_action(res.action, res.nested) if res.nested
     end
 
     def assign_nested_responses_to_failed_action(failed_action, nested)
@@ -76,6 +67,7 @@ module Rdux
     def sanitize(action)
       up_payload_sanitized = Sanitize.call(action.up_payload)
       action.up_payload_sanitized = action.up_payload != up_payload_sanitized
+      action.up_payload_unsanitized = action.up_payload if action.up_payload_sanitized
       action.up_payload = up_payload_sanitized
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rdux
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.5.0
 platform: ruby
 authors:
 - Zbigniew Humeniuk
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-08-29 00:00:00.000000000 Z
+date: 2023-12-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -131,7 +131,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.18
+rubygems_version: 3.4.21
 signing_key:
 specification_version: 4
 summary: Rdux adds a new layer to Rails apps - actions.