rds-rotate-db-snapshots 0.5.1 → 0.5.2

data/lib/rds_rotate_db_snapshots/options_parser/options.rb

@@ -0,0 +1,80 @@
+class RdsRotateDbSnapshots
+  class OptionsParser
+    module Options
+      def split_tag(hash, value)
+        value.split(',').each do |pair|
+          tag, value = pair.split('=', 2)
+          raise InvalidArgument, "invalid tag=value format" if value.nil?
+
+          hash[tag] = value
+        end
+      end
+
+      def banner_opts(opt)
+        opt.banner = "Usage: #{script_name} [options] <db_indentifier>\nUsage: #{script_name} " \
+                     "--by-tags <tag=value,...> [other options]"
+        opt.separator ""
+      end
+
+      def aws_opts(opt)
+        opt.on("--aws-access-key ACCESS_KEY", "AWS Access Key") do |v|
+          @options[:aws_access_key] = v
+        end
+
+        opt.on("--aws-secret-access-key SECRET_KEY", "AWS Secret Access Key") do |v|
+          @options[:aws_secret_access_key] = v
+        end
+
+        opt.on("--aws-region REGION", "AWS Region") do |v|
+          @options[:aws_region] = v
+        end
+
+        opt.on("--aws-session-token SESSION_TOKEN", "AWS session token") do |v|
+          @options[:aws_session_token] = v
+        end
+      end
+
+      def not_supported_opts(opt)
+        opt.on("--by-tags TAG=VALUE,TAG=VALUE",
+               "Instead of rotating specific snapshots, rotate over all the snapshots having the intersection of all " \
+               "given TAG=VALUE pairs.") do |_v|
+          @options[:by_tags] = {}
+          raise NotImplementedError,
+                'Hey! It\'s not implemented in RDS yet. Who knows, maybe they will add Tagging in RDS later.'
+          # split_tag(@options[:by_tags], v)
+        end
+      end
+
+      def snapshot_create_opts(opt)
+        opt.on("--create-snapshot STRING", "Use this option if you want to create a snapshot") do |v|
+          @options[:create_snapshot] = v
+        end
+      end
+
+      def time_period_opts(opt)
+        @time_periods.keys.sort { |a, b| @time_periods[a][:seconds] <=> @time_periods[b][:seconds] }.each do |period|
+          opt.on("--keep-#{period} NUMBER", Integer, "Number of #{period} snapshots to keep") do |v|
+            @time_periods[period][:keep] = v
+          end
+        end
+
+        opt.on("--keep-last", "Keep the most recent snapshot, regardless of time-based policy") do |_v|
+          @options[:keep_last] = true
+        end
+      end
+
+      def extra_opts(opt)
+        opt.on("--pattern STRING", "Snapshots without this string in the description will be ignored") do |v|
+          @options[:pattern] = v
+        end
+        opt.on("--backoff-limit LIMIT",
+               "Backoff and retry when hitting RDS Error exceptions no more than this many times. Default is 15") do |v|
+          @options[:backoff_limit] = v
+        end
+        opt.on("--dry-run", "Shows what would happen without doing anything") do |_v|
+          @options[:dry_run] = true
+        end
+      end
+    end
+  end
+end

data/lib/rds_rotate_db_snapshots/options_parser.rb

@@ -1,31 +1,33 @@
 require 'optparse'
-
+require_relative 'options_parser/options'
 class RdsRotateDbSnapshots
   class OptionsParser
     class NotImplementedError < StandardError; end
     class InvalidArgument < StandardError; end
 
+    include RdsRotateDbSnapshots::OptionsParser::Options
+
     attr_reader :options, :script_name, :time_periods
 
     def initialize(script_name: nil, cli: false)
       @script_name = script_name
       @options = {
-        :aws_access_key => ENV["AWS_ACCESS_KEY_ID"],
-        :aws_secret_access_key => ENV["AWS_SECRET_ACCESS_KEY"],
-        :aws_session_token => ENV["AWS_SESSION_TOKEN"],
-        :aws_region => ENV["AWS_REGION"],
-        :pattern => nil,
-        :by_tags => nil,
-        :dry_run => false,
-        :backoff_limit => 15,
-        :create_snapshot => nil
+        aws_access_key: ENV.fetch("AWS_ACCESS_KEY_ID", nil),
+        aws_secret_access_key: ENV.fetch("AWS_SECRET_ACCESS_KEY", nil),
+        aws_session_token: ENV.fetch("AWS_SESSION_TOKEN", nil),
+        aws_region: ENV.fetch("AWS_REGION", nil),
+        pattern: nil,
+        by_tags: nil,
+        dry_run: false,
+        backoff_limit: 15,
+        create_snapshot: nil
       }
       @time_periods = {
-        :hourly  => { :seconds => 60 * 60, :format => '%Y-%m-%d-%H', :keep => 0, :keeping => {} },
-        :daily   => { :seconds => 24 * 60 * 60, :format => '%Y-%m-%d', :keep => 0, :keeping => {} },
-        :weekly  => { :seconds => 7 * 24 * 60 * 60, :format => '%Y-%W', :keep => 0, :keeping => {} },
-        :monthly => { :seconds => 30 * 24 * 60 * 60, :format => '%Y-%m', :keep => 0, :keeping => {} },
-        :yearly  => { :seconds => 12 * 30 * 24 * 60 * 60, :format => '%Y', :keep => 0, :keeping => {} },
+        hourly: { seconds: 60 * 60, format: '%Y-%m-%d-%H', keep: 0, keeping: {} },
+        daily: { seconds: 24 * 60 * 60, format: '%Y-%m-%d', keep: 0, keeping: {} },
+        weekly: { seconds: 7 * 24 * 60 * 60, format: '%Y-%W', keep: 0, keeping: {} },
+        monthly: { seconds: 30 * 24 * 60 * 60, format: '%Y-%m', keep: 0, keeping: {} },
+        yearly: { seconds: 12 * 30 * 24 * 60 * 60, format: '%Y', keep: 0, keeping: {} }
       }
       @cli = cli
       init_cli_parser if cli?
@@ -44,66 +46,12 @@ class RdsRotateDbSnapshots
 
     def init_cli_parser
       @parser ||= OptionParser.new do |o|
-        o.banner = "Usage: #{script_name} [options] <db_indentifier>\nUsage: #{script_name} --by-tags <tag=value,...> [other options]"
-        o.separator ""
-      
-        o.on("--aws-access-key ACCESS_KEY", "AWS Access Key") do |v|
-          @options[:aws_access_key] = v
-        end
-      
-        o.on("--aws-secret-access-key SECRET_KEY", "AWS Secret Access Key") do |v|
-          @options[:aws_secret_access_key] = v
-        end
-      
-        o.on("--aws-region REGION", "AWS Region") do |v|
-          @options[:aws_region] = v
-        end
-      
-        o.on("--aws-session-token SESSION_TOKEN", "AWS session token") do |v|
-          @options[:aws_session_token] = v
-        end
-      
-        o.on("--pattern STRING", "Snapshots without this string in the description will be ignored") do |v|
-          @options[:pattern] = v
-        end
-      
-        o.on("--by-tags TAG=VALUE,TAG=VALUE", "Instead of rotating specific snapshots, rotate over all the snapshots having the intersection of all given TAG=VALUE pairs.") do |v|
-          @options[:by_tags] = {}
-          raise NotImplementedError, 'Hey! It\'s not implemented in RDS yet. Who knows, maybe they will add Tagging in RDS later.'
-          split_tag(@options[:by_tags],v)
-        end
-      
-        o.on("--backoff-limit LIMIT", "Backoff and retry when hitting RDS Error exceptions no more than this many times. Default is 15") do |v|
-          @options[:backoff_limit] = v
-        end
-      
-        o.on("--create-snapshot STRING", "Use this option if you want to create a snapshot") do |v|
-          @options[:create_snapshot] = v
-        end
-      
-        @time_periods.keys.sort { |a, b| @time_periods[a][:seconds] <=> @time_periods[b][:seconds] }.each do |period|
-          o.on("--keep-#{period} NUMBER", Integer, "Number of #{period} snapshots to keep") do |v|
-            @time_periods[period][:keep] = v
-          end
-        end
-      
-        o.on("--keep-last", "Keep the most recent snapshot, regardless of time-based policy") do |v|
-          @options[:keep_last] = true
-        end
-      
-        o.on("--dry-run", "Shows what would happen without doing anything") do |v|
-          @options[:dry_run] = true
-        end
-      end
-    end
-
-    def split_tag(hash,v)
-      v.split(',').each do |pair|
-        tag, value = pair.split('=',2)
-        if value.nil?
-          raise InvalidArgument, "invalid tag=value format"
-        end
-        hash[tag] = value
+        banner_opts o
+        aws_opts o
+        snapshot_create_opts o
+        time_period_opts o
+        extra_opts o
+        not_supported_opts o
       end
     end
   end

data/lib/rds_rotate_db_snapshots.rb

@@ -9,6 +9,7 @@ class RdsRotateDbSnapshots
   include RdsRotateDbSnapshots::Actions
 
   attr_reader :options
+
   with_backoff :get_db_snapshots, :create_snapshot, :rotate_em
 
   def initialize(script_name: nil, cli: false, options: {})
@@ -22,7 +23,7 @@ class RdsRotateDbSnapshots
   def rds_client
     @rds_client ||= RdsRotateDbSnapshots::RdsClient.new(@options)
   end
-  alias_method :client, :rds_client
+  alias client rds_client
 
   def reset_backoff
     @backoff_counter = 0
@@ -43,14 +44,14 @@ class RdsRotateDbSnapshots
   end
 
   def backoff
-    @backoff_counter = @backoff_counter + 1
-  
+    @backoff_counter += 1
+
     # TODO: re-work
-    if options && options[:backoff_limit] > 0 && options[:backoff_limit] < @backoff_counter
+    if options && options[:backoff_limit].positive? && options[:backoff_limit] < @backoff_counter
       puts "Too many backoff attempts. Sorry it didn't work out."
       exit 2
     end
-  
+
     naptime = rand(60) * @backoff_counter
     puts "Backing off for #{naptime} seconds..."
     sleep naptime

data/rds-rotate-db-snapshots.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Juwelier::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: rds-rotate-db-snapshots 0.5.1 ruby lib
+# stub: rds-rotate-db-snapshots 0.5.2 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "rds-rotate-db-snapshots".freeze
-  s.version = "0.5.1"
+  s.version = "0.5.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]
   s.authors = ["Siarhei Kavaliou".freeze]
-  s.date = "2023-01-10"
+  s.date = "2023-01-11"
   s.description = "Provides a simple way to rotate RDS DB snapshots with configurable retention periods.".freeze
   s.email = "kovserg@gmail.com".freeze
   s.executables = ["rds-rotate-db-snapshots".freeze]
@@ -25,6 +25,8 @@ Gem::Specification.new do |s|
     ".github/workflows/ci.yml",
     ".github/workflows/codeql.yml",
     ".rspec",
+    ".rubocop.yml",
+    ".rubocop_todo.yml",
     "Gemfile",
     "LICENSE.txt",
     "README.md",
@@ -35,6 +37,7 @@ Gem::Specification.new do |s|
     "lib/rds_rotate_db_snapshots/action_wrappers.rb",
     "lib/rds_rotate_db_snapshots/actions.rb",
     "lib/rds_rotate_db_snapshots/options_parser.rb",
+    "lib/rds_rotate_db_snapshots/options_parser/options.rb",
     "lib/rds_rotate_db_snapshots/rds_client.rb",
     "rds-rotate-db-snapshots.gemspec",
     "spec/helper.rb",
@@ -46,25 +49,17 @@ Gem::Specification.new do |s|
   ]
   s.homepage = "http://github.com/serg-kovalev/rds-rotate-db-snapshots".freeze
   s.licenses = ["MIT".freeze]
-  s.rubygems_version = "3.3.7".freeze
+  s.rubygems_version = "3.4.1".freeze
   s.summary = "Amazon RDS DB snapshot rotator".freeze
 
-  if s.respond_to? :specification_version then
-    s.specification_version = 4
-  end
+  s.specification_version = 4
 
-  if s.respond_to? :add_runtime_dependency then
-    s.add_runtime_dependency(%q<aws-sdk-rds>.freeze, ["~> 1"])
-    s.add_runtime_dependency(%q<rake>.freeze, [">= 0"])
-    s.add_development_dependency(%q<juwelier>.freeze, [">= 0"])
-    s.add_development_dependency(%q<pry>.freeze, [">= 0"])
-    s.add_development_dependency(%q<pry-byebug>.freeze, [">= 0"])
-  else
-    s.add_dependency(%q<aws-sdk-rds>.freeze, ["~> 1"])
-    s.add_dependency(%q<rake>.freeze, [">= 0"])
-    s.add_dependency(%q<juwelier>.freeze, [">= 0"])
-    s.add_dependency(%q<pry>.freeze, [">= 0"])
-    s.add_dependency(%q<pry-byebug>.freeze, [">= 0"])
-  end
+  s.add_runtime_dependency(%q<aws-sdk-rds>.freeze, ["~> 1"])
+  s.add_development_dependency(%q<rake>.freeze, [">= 0"])
+  s.add_development_dependency(%q<juwelier>.freeze, [">= 0"])
+  s.add_development_dependency(%q<pry>.freeze, [">= 0"])
+  s.add_development_dependency(%q<pry-byebug>.freeze, [">= 0"])
+  s.add_development_dependency(%q<rubocop>.freeze, [">= 0"])
+  s.add_development_dependency(%q<rubocop-rspec>.freeze, [">= 0"])
 end
 

data/spec/helper.rb

@@ -27,7 +27,7 @@ require "diff/lcs" # You need diff/lcs installed to run specs.
 # require 'stringio'
 require "webmock/rspec"
 
-WebMock.disable_net_connect!(:allow => "coveralls.io")
+WebMock.disable_net_connect!(allow: "coveralls.io")
 
 $0 = "rds_rotate_db_snapshots"
 ARGV.clear

data/spec/lib/rds_rotate_db_snapshots/action_wrappers_spec.rb

@@ -15,7 +15,7 @@ class TestClass
   end
 
   def backoff
-    @backoff_counter = @backoff_counter + 1
+    @backoff_counter += 1
 
     raise StandardError, 'gave up' if @options[:backoff_limit] > 0 && @options[:backoff_limit] < @backoff_counter
   end
@@ -33,13 +33,13 @@ describe RdsRotateDbSnapshots::ActionWrappers do
       allow(subject).to receive(:test_method).and_raise(Aws::RDS::Errors::ExpiredToken.new(nil, 'token expired'))
       expect(subject).not_to receive(:reset_backoff)
       expect(subject).not_to receive(:backoff)
-      expect{subject.test_method}.to raise_error(Aws::RDS::Errors::ExpiredToken)
+      expect { subject.test_method }.to raise_error(Aws::RDS::Errors::ExpiredToken)
     end
 
     it "retries if the exception raised is Aws::RDS::Errors::ServiceError" do
       expect(subject).to receive(:backoff).exactly(6).and_call_original
 
-      expect{ subject.test_method }.to raise_error(StandardError, 'gave up')
+      expect { subject.test_method }.to raise_error(StandardError, 'gave up')
     end
   end
 end

data/spec/lib/rds_rotate_db_snapshots/actions_spec.rb

@@ -1,42 +1,105 @@
 require 'helper'
+class Test
+  include RdsRotateDbSnapshots::Actions
+
+  attr_reader :options
+
+  def initialize(script_name: nil, options: {})
+    @script_name = script_name
+    @options = options
+    @backoff_counter = 0
+  end
+
+  def rds_client
+    @rds_client ||= RdsRotateDbSnapshots::RdsClient.new(@options)
+  end
+  alias client rds_client
+
+  def reset_backoff
+    @backoff_counter = 0
+  end
+
+  def time_periods
+    @options[:time_periods]
+  end
+
+  private
+
+  def backoff
+    @backoff_counter += 1
+  end
+end
 
-RSpec.shared_examples 'rds_rotate_db_snapshots actions' do
-  let(:rds_client) { instance_double(RdsRotateDbSnapshots::RdsClient) }
-  let(:client) { rds_client }
+describe RdsRotateDbSnapshots::Actions do
+  let(:test_class) { Test.new(script_name: 'test', options: options) }
+  let(:client) { double("client") }
+  let(:time_periods) do
+    {
+      hourly: { seconds: 60 * 60, format: '%Y-%m-%d-%H', keep: 0, keeping: {} },
+      daily: { seconds: 24 * 60 * 60, format: '%Y-%m-%d', keep: 1, keeping: {} },
+      weekly: { seconds: 7 * 24 * 60 * 60, format: '%Y-%W', keep: 0, keeping: {} },
+      monthly: { seconds: 30 * 24 * 60 * 60, format: '%Y-%m', keep: 0, keeping: {} }
+    }
+  end
   let(:options) do
-    { 
+    {
       aws_access_key: 'ACCESS_KEY',
       aws_secret_access_key: 'SECRET_KEY',
       aws_region: 'REGION',
       pattern: 'test',
-      dry_run: true,
-      backoff_limit: 15
+      dry_run: false,
+      backoff_limit: 15,
+      time_periods: time_periods
     }
   end
   let(:rds_snapshots) do
     [
-      { snapshot_create_time: Time.now, db_instance_identifier: 'test_db', db_snapshot_identifier: 'test_snapshot' }
+      { snapshot_create_time: Time.now - (24 * 3600), db_instance_identifier: 'test_db',
+        db_snapshot_identifier: 'test_snapshot' },
+      { snapshot_create_time: Time.now, db_instance_identifier: 'test_db', db_snapshot_identifier: 'test_snapshot2' }
     ]
   end
 
   before do
-    allow(subject).to receive(:client).and_return(rds_client)
-    allow(rds_client).to receive(:describe_db_snapshots).and_return(rds_snapshots)
-    allow(rds_client).to receive(:create_db_snapshot)
-    allow(rds_client).to receive(:delete_db_snapshot)
+    allow(client).to receive(:describe_db_snapshots).and_return(rds_snapshots)
+    allow(test_class).to receive(:client).and_return(client)
   end
 
   describe "#rotate_em" do
     it "deletes the snapshots that are not part of the specified time periods" do
-      expect(rds_client).to receive(:delete_db_snapshot)
-      subject.rotate_em(rds_snapshots)
+      expect(client).to receive(:delete_db_snapshot)
+      test_class.rotate_em(rds_snapshots)
+    end
+
+    context 'when the snapshot is not matched with pattern' do
+      let(:rds_snapshots) do
+        [
+          { snapshot_create_time: Time.now - (49 * 3600), db_instance_identifier: 'test_db',
+            db_snapshot_identifier: 'other_snapshot' },
+          { snapshot_create_time: Time.now - (48 * 3600), db_instance_identifier: 'test_db',
+            db_snapshot_identifier: 'test_snapshot' },
+          { snapshot_create_time: Time.now, db_instance_identifier: 'test_db',
+            db_snapshot_identifier: 'test_snapshot2' }
+        ]
+      end
+
+      it "deletes the snapshots that are matched with pattern" do
+        expect(client).to receive(:delete_db_snapshot).with(db_snapshot_identifier: 'test_snapshot')
+        test_class.rotate_em(rds_snapshots)
+      end
     end
   end
 
   describe "#create_snapshot" do
     it "creates a snapshot with the specified name" do
-      expect(rds_client).to receive(:create_db_snapshot)
-      subject.create_snapshot('test', ['test_db'])
+      expect(client).to receive(:create_db_snapshot)
+      test_class.create_snapshot('test', ['test_db'])
+    end
+
+    context "when snaphost name is invalid" do
+      it "raises an error SystemExit" do
+        expect { test_class.create_snapshot('$#', ['test_db']) }.to raise_error(SystemExit)
+      end
     end
   end
 
@@ -45,52 +108,9 @@ RSpec.shared_examples 'rds_rotate_db_snapshots actions' do
 
     it "returns the list of snapshots from the client" do
       allow(snapshots).to receive(:[]).with(:marker).and_return(nil)
-      expect(rds_client).to receive(:describe_db_snapshots).and_return(snapshots)
-      snapshots = subject.get_db_snapshots(options)
+      expect(client).to receive(:describe_db_snapshots).and_return(snapshots)
+      snapshots = test_class.get_db_snapshots(options)
       expect(snapshots).to eq(rds_snapshots)
     end
   end
-
-end
-
-class Test
-  include RdsRotateDbSnapshots::Actions
-
-  attr_reader :options
-
-  def initialize(script_name: nil, cli: false, options: {})
-    @script_name = script_name
-    @options = options
-    @cli = cli
-    parse_options if cli?
-    @backoff_counter = 0
-  end
-
-  def reset_backoff
-    @backoff_counter = 0
-  end
-
-  def time_periods
-    @options[:time_periods] || {}
-  end
-
-  private
-
-  def cli?
-    !!@cli
-  end
-
-  def parse_options
-    @options = RdsRotateDbSnapshots::OptionsParser.new(script_name: @script_name, cli: @cli).parse!
-  end
-
-  def backoff
-    @backoff_counter = @backoff_counter + 1
-  end
-end
-
-describe RdsRotateDbSnapshots::Actions do
-  subject { Test.new }
-
-  it_behaves_like 'rds_rotate_db_snapshots actions'
 end

data/spec/lib/rds_rotate_db_snapshots/options_parser_spec.rb

@@ -1,19 +1,16 @@
 require 'helper'
 
 describe RdsRotateDbSnapshots::OptionsParser do
+  subject { described_class.new(script_name: script_name, cli: true).parse! }
+
   let(:script_name) { "rds_rotate_snapshots.rb" }
-  subject { RdsRotateDbSnapshots::OptionsParser.new(script_name: script_name, cli: true).parse! }
 
   describe "#parse!" do
     before { ARGV.clear }
-  
+
     it "parses options correctly" do
-      ARGV.concat(["--aws-access-key", "ACCESS_KEY",
-                   "--aws-secret-access-key", "SECRET_KEY",
-                   "--aws-region", "REGION",
-                   "--pattern", "PATTERN",
-                   "--backoff-limit", "20",
-                   "--create-snapshot", "snapshot"])
+      ARGV.push("--aws-access-key", "ACCESS_KEY", "--aws-secret-access-key", "SECRET_KEY", "--aws-region", "REGION",
+                "--pattern", "PATTERN", "--backoff-limit", "20", "--create-snapshot", "snapshot")
       options = subject
 
       expect(options[:aws_access_key]).to eq("ACCESS_KEY")
@@ -25,7 +22,7 @@ describe RdsRotateDbSnapshots::OptionsParser do
     end
 
     it "raises NotImplementedError when by-tags option is passed and it is not implemented" do
-      ARGV.concat(["--by-tags", "tag=value,tag2=value"])
+      ARGV.push("--by-tags", "tag=value,tag2=value")
 
       expect { subject }.to raise_error(RdsRotateDbSnapshots::OptionsParser::NotImplementedError)
     end

data/spec/lib/rds_rotate_db_snapshots/rds_client_spec.rb

@@ -1,17 +1,19 @@
 require 'helper'
 
 describe RdsRotateDbSnapshots::RdsClient do
-  let(:options) { {
-    :aws_access_key => "ACCESS_KEY",
-    :aws_secret_access_key => "SECRET_KEY",
-    :aws_session_token => "SESSION_TOKEN",
-    :aws_region => "REGION"
-  } }
-  let(:rds_client) { RdsRotateDbSnapshots::RdsClient.new(options) }
+  let(:options) do
+    {
+    aws_access_key: "ACCESS_KEY",
+    aws_secret_access_key: "SECRET_KEY",
+    aws_session_token: "SESSION_TOKEN",
+    aws_region: "REGION"
+  }
+  end
+  let(:rds_client) { described_class.new(options) }
 
   it 'configures the client with the correct credentials and region' do
-    expect(rds_client.instance_variable_get(:@client).config.credentials).
-      to have_attributes(access_key_id: "ACCESS_KEY", secret_access_key: "SECRET_KEY", session_token: "SESSION_TOKEN")
+    expect(rds_client.instance_variable_get(:@client).config.credentials)
+      .to have_attributes(access_key_id: "ACCESS_KEY", secret_access_key: "SECRET_KEY", session_token: "SESSION_TOKEN")
     expect(rds_client.instance_variable_get(:@client).config.region).to eq("REGION")
   end
 

data/spec/lib/rds_rotate_db_snapshots_spec.rb

@@ -5,6 +5,7 @@ describe RdsRotateDbSnapshots do
 
   let(:script_name) { "test" }
   let(:cli) { true }
+
   before do
     allow(Aws::RDS::Client).to receive(:new)
   end
@@ -43,11 +44,11 @@ describe RdsRotateDbSnapshots do
   describe "#time_periods" do
     it "returns time periods" do
       expect(subject.time_periods).to eq(
-        :daily=>{:format=>"%Y-%m-%d", :keep=>0, :keeping=>{}, :seconds=>86400},
-        :hourly => {:format=>"%Y-%m-%d-%H", :keep=>0, :keeping=>{}, :seconds=>3600},
-        :monthly => {:format=>"%Y-%m", :keep=>0, :keeping=>{}, :seconds=>2592000},
-        :weekly => {:format=>"%Y-%W", :keep=>0, :keeping=>{}, :seconds=>604800},
-        :yearly=>{:format=>"%Y", :keep=>0, :keeping=>{}, :seconds=>31104000}
+        daily: { format: "%Y-%m-%d", keep: 0, keeping: {}, seconds: 86_400 },
+        hourly: { format: "%Y-%m-%d-%H", keep: 0, keeping: {}, seconds: 3600 },
+        monthly: { format: "%Y-%m", keep: 0, keeping: {}, seconds: 2_592_000 },
+        weekly: { format: "%Y-%W", keep: 0, keeping: {}, seconds: 604_800 },
+        yearly: { format: "%Y", keep: 0, keeping: {}, seconds: 31_104_000 }
       )
     end
   end