rdm 0.2.0 → 0.3.0

data/spec/rdm/gen/package_spec.rb

@@ -1,40 +1,24 @@
 require "spec_helper"
 
 describe Rdm::Gen::Package do
-  before :all do
-    Rdm::Gen::Package.disable_logger!
-  end
-  include SetupHelper
-
-  def generate_package!
-    Rdm::Gen::Package.generate(
-      current_dir: project_dir,
-      package_name: "some",
-      package_relative_path: "domain/some",
-      skip_tests: false
-    )
-  end
+  include ExampleProjectHelper
 
-  def ensure_exists(file)
-    expect(File.exists?(file)).to be true
-  end
-
-  def ensure_content(file, content)
-    expect(File.read(file)).to match(content)
-  end
+  subject { described_class }
+  
+  before { initialize_example_project }
+  after  { reset_example_project }
 
   context "sample package" do
-    before :all do
-      fresh_project
-      generate_package!
-    end
+    it "has generated correct files" do
+      FileUtils.rm_rf(File.join(example_project_path, '.rdm'))
 
-    after :all do
-      clean_tmp
-    end
+      subject.generate(
+        current_path: example_project_path,
+        package_name: "some",
+        local_path:   "domain/some",
+      )
 
-    it "has generated correct files" do
-      FileUtils.cd(project_dir) do
+      FileUtils.cd(example_project_path) do
         ensure_exists("domain/some/Package.rb")
         ensure_exists("domain/some/package/some.rb")
         ensure_exists("domain/some/package/some/")
@@ -42,46 +26,81 @@ describe Rdm::Gen::Package do
         ensure_exists("domain/some/spec/spec_helper.rb")
         ensure_exists("domain/some/.rspec")
         ensure_exists("domain/some/.gitignore")
-        ensure_content("domain/some/package/some.rb", "module Some\n\nend\n")
       end
     end
 
-    it "has added new entry to Rdm.packages" do
-      FileUtils.cd(project_dir) do
-        ensure_content("Rdm.packages", "package 'domain/some'")
+    it "takes template from '.rdm' directory primarily" do
+      File.open(File.join(example_project_path, '.rdm/templates/package/Package.rb'), 'w') do |f|
+        f.write('# modified file for .rdm tempalates directory')
+      end
+
+      subject.generate(
+        current_path: example_project_path,
+        package_name: "some",
+        local_path:   "domain/some",
+      )
+
+      FileUtils.cd(example_project_path) do
+        ensure_content("domain/some/Package.rb", "# modified file for .rdm tempalates directory")
+        expect(Dir['domain/some/'].size).to eq(1)
       end
     end
 
-    it "has logged useful output" do
-      Rdm::Gen::Package.enable_logger!
-      expect {
-        fresh_project
-        generate_package!
-      }.to output(Regexp.new("Generated: domain/some/Package.rb")).to_stdout
-      Rdm::Gen::Package.disable_logger!
+    it "has added new entry to Rdm.packages" do
+      subject.generate(
+        current_path: example_project_path,
+        package_name: "some",
+        local_path:   "domain/some",
+      )
+
+      FileUtils.cd(example_project_path) do
+        ensure_content("Rdm.packages", "package 'domain/some'")
+      end
     end
   end
 
   context "prevents double execution" do
-    after :all do
-      clean_tmp
-    end
-
     it "raises on second package generation" do
-      fresh_project
-      generate_package!
+      subject.generate(
+        current_path: example_project_path,
+        package_name: "some",
+        local_path:   "domain/some",
+      )
+
       expect {
-        generate_package!
+        subject.generate(
+          current_path: example_project_path,
+          package_name: "some",
+          local_path:   "domain/some",
+        )
       }.to raise_error(Rdm::Errors::PackageDirExists)
     end
 
     it "raises on second package generation, if Rdm.packages includes the package (and folder does not exist)" do
-      fresh_project
-      generate_package!
-      FileUtils.rm_rf(File.join(project_dir, "domain/some"))
+      subject.generate(
+        current_path: example_project_path,
+        package_name: "some",
+        local_path:   "domain/some",
+      )
       expect {
-        generate_package!
+        subject.generate(
+          current_path: example_project_path,
+          package_name: "some",
+          local_path:   "some",
+        )
       }.to raise_error(Rdm::Errors::PackageExists)
     end
+
+
+    it "add package record to Rdm.packages file" do
+      subject.generate(
+        package_name: "database",
+        current_path: example_project_path,
+        local_path:   "infrastructure/database"
+      )
+      expect(
+        Rdm::SourceParser.read_and_init_source(rdm_source_file).packages.keys
+      ).to include('database')
+    end
   end
 end

data/spec/rdm/git/diff_manager_spec.rb

@@ -0,0 +1,81 @@
+require "spec_helper"
+
+describe Rdm::Git::DiffManager do
+  include GitCommandsHelper
+  subject { described_class }
+
+  describe "::get_diffs" do
+    before :each do
+      @git_example_path = File.join("/tmp", 'git_example')
+      FileUtils.mkdir_p(File.join(@git_example_path, 'files'))
+
+      File.open(File.join(@git_example_path, 'files/file_to_modify.rb'), 'w') { |f| f.write('I will be modified') }
+      File.open(File.join(@git_example_path, 'file_to_delete.rb'), 'w') { |f| f.write('I will be deleted') }
+    end
+
+    context "contains all modified files if present" do
+      before do
+        git_initialize_repository(@git_example_path)
+        git_commit_changes(@git_example_path)
+
+        @new_filename = File.join(@git_example_path, 'new_file.rb')
+        File.open(@new_filename, 'w') { |f| f.write('I am new file') }
+
+        @modified_filename = File.join(@git_example_path, 'file_to_modify.rb')
+        File.open(@modified_filename, 'a') { |f| f.write('I am modified now!') }
+
+        @deleted_filename = File.join(@git_example_path, 'file_to_delete.rb')
+        FileUtils.rm(@deleted_filename)
+
+        @nested_file = File.join(@git_example_path, 'files/nested_file.rb')
+        File.open(@nested_file, 'w') { |f| f.write("I'm nested file!") }
+
+        %x( cd #{@git_example_path} && git init && git add . )
+      end
+
+      it "shows new files" do
+        expect(subject.run(path: @git_example_path, revision: 'HEAD')).to include(@new_filename)
+      end
+
+      it "shows edited files" do
+        expect(subject.run(path: @git_example_path, revision: 'HEAD')).to include(@modified_filename)
+      end
+
+      it "shows deleted files" do
+        expect(subject.run(path: @git_example_path, revision: 'HEAD')).to include(@deleted_filename)
+      end
+
+      it "shows files with folder structure" do
+        expect(subject.run(path: @git_example_path, revision: 'HEAD')).to include(@nested_file)
+      end
+
+      it "returns array" do
+        expect(subject.run(path: @git_example_path, revision: 'HEAD')).to be_a(Array)
+        expect(subject.run(path: @git_example_path, revision: 'HEAD').size).to eq(4)
+      end
+    end
+
+    context "does't contain any modified files if not present" do
+      before do
+        git_initialize_repository(@git_example_path)
+        git_commit_changes(@git_example_path)
+      end
+
+      it "returns empty array of modified files" do
+        expect(subject.run(path: @git_example_path, revision: 'HEAD')).to eq([])
+      end
+    end
+
+    context "if git repository was not initialized" do
+      it "raises Rdm::Errors::GitRepositoryNotInitialized" do
+        expect{
+          subject.run(path: @git_example_path, revision: 'HEAD')
+        }.to raise_error(Rdm::Errors::GitRepositoryNotInitialized)
+      end
+    end
+
+    after :each do
+      FileUtils.rm_r(@git_example_path)
+    end
+  end
+end

data/spec/rdm/git/repository_locator_spec.rb

@@ -0,0 +1,31 @@
+require "spec_helper"
+
+describe Rdm::Git::RepositoryLocator do
+  include GitCommandsHelper
+  include ExampleProjectHelper
+
+  subject { described_class }
+
+  context "::locate" do
+    before { initialize_example_project }
+    after  { reset_example_project }
+
+    it "returns root of git repository if initialized for existing path" do
+      %x( cd #{example_project_path} && git init )
+
+      expect(subject.locate(File.join(example_project_path, "application"))).to eq(example_project_path)
+    end
+
+    it "returns root of git repository if initialized for non existing path" do
+      %x( cd #{example_project_path} && git init )
+
+      expect(subject.locate(File.join(example_project_path, "non_existing_path"))).to eq(example_project_path)
+    end
+
+    it "raises error Rdm::Errors::GitRepositoryNotInitialized if not initialized" do
+      expect{
+        subject.locate(File.join(example_project_path, "application"))
+      }
+    end
+  end
+end

data/spec/rdm/handlers/dependencies_handler_spec.rb

@@ -0,0 +1,84 @@
+require 'spec_helper'
+
+describe Rdm::Handlers::DependenciesHandler do
+  include ExampleProjectHelper
+
+  subject { described_class }
+
+  before { initialize_example_project }
+  after  { reset_example_project }
+
+  context ":show_names" do
+    it "returns array of dependencies names" do
+      expect(
+        subject.show_names(
+          package_name: 'web',
+          project_path: example_project_path
+        )
+      ).to match(["core", "repository", "web"])
+    end
+  end
+
+  context ":show_packages" do
+    let(:result) {
+      subject.show_packages(
+        package_name: 'web',
+        project_path: example_project_path
+      )
+    }
+    it "returns array with proper size" do
+      expect(result.count).to eq(3)
+    end
+
+    it "returns array with proper size" do
+      expect(result.first).to be_a Rdm::Package
+    end
+  end
+
+  context ":format_for_draw" do
+    context "for simple case" do
+      let(:result) {
+        subject.draw(
+          package_name: 'web',
+          project_path: example_project_path
+        )
+      }
+      it "returns hash structure of dependencies" do
+        expect(result).to match(
+          [
+            "web", 
+            "└── core",
+            "    └── repository"
+          ]
+        )
+      end
+    end
+
+    context "for cycle dependencies" do
+      before do
+        core_package_file = File.join(example_project_path, "domain/core", Rdm::PACKAGE_FILENAME)
+        Rdm::Utils::FileUtils.change_file(core_package_file) do |line|
+          line.include?('import "repository"') ? '  import "web"' : line
+        end
+      end
+
+      let(:result) {
+        subject.draw(
+          package_name: 'web',
+          project_path: example_project_path
+        )
+      }
+
+      it "use one at time" do
+        expect(result).to match(
+          [
+            "web", 
+            "└── core", 
+            "    └── web", 
+            "        └── ..." 
+          ]
+        )
+      end
+    end
+  end
+end

data/spec/rdm/handlers/diff_package_handler_spec.rb

@@ -0,0 +1,78 @@
+require "spec_helper"
+
+describe Rdm::Handlers::DiffPackageHandler do
+  include ExampleProjectHelper
+  include GitCommandsHelper
+
+  subject { described_class }
+
+  context "::handle" do    
+    before { initialize_example_project }
+    after  { reset_example_project }
+
+    context "when git changes present" do
+      context "for package without dependencies" do
+        before do
+          git_initialize_repository(example_project_path)
+          git_commit_changes(example_project_path)
+
+          File.open(File.join(example_project_path, 'server/package/new_server.rb'), 'w') { |f| f.write '' }
+
+          git_index_changes(example_project_path)
+        end
+
+        it "returns only modified packages" do
+          expect(subject.handle(path: example_project_path, revision: 'HEAD')).to match(["server"])
+        end
+      end
+
+      context "for package with dependencies" do
+        before do
+          git_initialize_repository(example_project_path)
+          git_commit_changes(example_project_path)
+
+          File.open(File.join(example_project_path, 'domain/core/package/core/new_service.rb'), 'w') do |f| 
+            f.write <<~EOF
+              class Core::NewService
+              end
+            EOF
+          end
+        end
+
+        it "returns array of modified and dependend packages for indexed changes" do
+          git_index_changes(example_project_path)
+          
+          expect(subject.handle(path: example_project_path, revision: 'HEAD')).to match(["core", "server", "web"].sort)
+        end
+      end
+
+      context "for file without package" do
+        before do
+          git_initialize_repository(example_project_path)
+          git_commit_changes(example_project_path)
+
+          File.open(File.join(example_project_path, 'domain/missing_package_class.rb'), 'w') do |f|
+            f.write <<~EOF
+              class MissingPackageClass
+              end
+            EOF
+          end
+        end
+
+        it "returns empty array" do
+          git_index_changes(example_project_path)
+
+          expect(subject.handle(path: example_project_path, revision: 'HEAD')).to eq([])
+        end
+      end
+    end
+
+    context "when git repository is not initialized" do
+      it "raises Rdm::Errors::GitRepositoryNotInitialized error" do
+        expect{
+          subject.handle(path: example_project_path, revision: 'HEAD')
+        }.to raise_error(Rdm::Errors::GitRepositoryNotInitialized)
+      end
+    end
+  end
+end

data/spec/rdm/handlers/template_handler_spec.rb

@@ -0,0 +1,94 @@
+require 'spec_helper'
+
+describe Rdm::Handlers::TemplateHandler do
+  include ExampleProjectHelper
+
+  subject { Rdm::Handlers::TemplateHandler }
+
+  let(:template_name)     { 'repository' }
+  let(:local_path)        { 'domain/infrastructure' }
+  let(:created_abs_path)  { File.join(example_project_path, local_path) }
+  let(:stdout)            { SpecLogger.new }
+
+  before { initialize_example_project } 
+  after  { reset_example_project }
+
+  describe "::generate" do
+    context "for existing template" do
+      it "creates all files from template to destination folder" do
+        subject.generate(
+          template_name:    template_name, 
+          local_path:       local_path,
+          current_path:     example_project_path,
+          locals:           {
+            name: 'users'
+          }
+        )
+
+        ensure_exists(File.join(created_abs_path, 'dao/users_dao.rb'))
+        ensure_exists(File.join(created_abs_path, 'mapper/users_mapper.rb'))
+        ensure_exists(File.join(created_abs_path, 'repository/users_repository.rb'))
+      end
+
+      it "creates files with proper content" do
+        subject.generate(
+          template_name:    template_name, 
+          local_path:       local_path,
+          current_path:     example_project_path,
+          locals:           {
+            name: 'users'
+          }
+        )
+
+        ensure_content(
+          File.join(created_abs_path, 'dao/users_dao.rb'), 
+          "require 'users_repository'\n\nclass Users\nend"
+        )
+      end
+
+      it "skips erb files" do
+        subject.generate(
+          template_name:    template_name, 
+          local_path:       local_path,
+          current_path:     example_project_path,
+          locals:           {
+            name: 'users'
+          }
+        )
+
+        ensure_content(
+          File.join(created_abs_path, 'views/users.html.erb'), 
+          "class <%=name%>\nend"
+        )
+      end
+
+      context "asks for undefined variables" do
+        before do
+          subject.generate(
+            template_name:    template_name, 
+            local_path:       local_path,
+            current_path:     example_project_path,
+            locals:           {},
+            stdout:           stdout,
+            stdin:            SpecLogger.new(stdin: "order\n")
+          )
+        end
+        
+        it "output ask variable text" do
+          expect(stdout.output).to match([
+            "Undefined variables were found:", 
+            "  1. name", "Type value for 'name': "
+          ])
+        end
+        
+        it "creates file with correct variable" do
+            ensure_content(
+            File.join(created_abs_path, 'dao/order_dao.rb'), 
+            "require 'order_repository'\n\nclass Order\nend"
+          )
+        end
+
+      end
+    end
+  end
+end