rdkafka 0.19.0 → 0.20.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0fd23bfe1b2c4372cd42937cd388c5ff893b4ff448613bff8a74f8fd6c1ecc7f
-  data.tar.gz: 8085175e03eed6d02ca929691ec039bf4cb0cba2a470d9021d80b5d7de6774e2
+  metadata.gz: 1be38bd2e19d5ef4a8ddbe9a884ab1659448e240975d3aff8805529206ed7764
+  data.tar.gz: 4e5c9662def495ceccdb05fd29594568286b980c2a3c57f9cc405fec955913d5
 SHA512:
-  metadata.gz: b2332ee34165297680322124ebe0f4e5ea2dacdeab94a7d0a43a4d199d6c6d000a59d96cf752def7530e0233616ee1286ea432f20f877128170a0298385770d5
-  data.tar.gz: 980cf6f95573f3947d0f9b5a916aaea8d397f6ac59065b6a657fc4505f89f1d13155462879154c9192dd5c495bc1f51aefd99af5d944db470f455bf1ded8853f
+  metadata.gz: d6305b9bc8baf478da702f92678b39089ba10f987b8dee0c71d0be9b2799f3060d1f11893428cee0471b331f640627252888e5fe3be06849712b87e7bc2452a4
+  data.tar.gz: 351fc0bf7dcedc63075bb62b765d7db846979146dcb49b7494eb102bf2630799d4a5da76a02b08499a3061e1efbddaab6c965b22feeb50832f5a09f33bcd9801

data/.github/workflows/ci.yml

@@ -22,12 +22,12 @@ jobs:
       fail-fast: false
       matrix:
         ruby:
-          - '3.4.0-preview1'
+          - '3.4'
           - '3.3'
           - '3.2'
           - '3.1'
         include:
-          - ruby: '3.3'
+          - ruby: '3.4'
             coverage: 'true'
     steps:
       - uses: actions/checkout@v4
@@ -54,3 +54,30 @@ jobs:
           cd ext && bundle exec rake
           cd ..
           bundle exec rspec
+
+
+  macos_build:
+    timeout-minutes: 30
+    runs-on: macos-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby:
+          - '3.4'
+          - '3.3'
+          - '3.2'
+          - '3.1'
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{matrix.ruby}}
+          bundler-cache: false
+
+      - name: Build rdkafka-ruby
+        run: |
+          set -e
+          bundle install --path vendor/bundle
+          cd ext && bundle exec rake

data/.ruby-version

@@ -1 +1 @@
-3.3.5
+3.4.1

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Rdkafka Changelog
 
+## 0.20.0 (2025-01-07)
+- **[Breaking]** Deprecate and remove `#each_batch` due to data consistency concerns.
+- [Enhancement] Bump librdkafka to `2.6.1`
+- [Enhancement] Expose `rd_kafka_global_init` to mitigate macos forking issues.
+- [Enhancement] Avoid clobbering LDFLAGS and CPPFLAGS if in a nix prepared environment (secobarbital).
+- [Patch] Retire no longer needed cooperative-sticky patch.
+
 ## 0.19.0 (2024-10-01)
 - **[Breaking]** Drop Ruby 3.0 support
 - [Enhancement] Update `librdkafka` to `2.5.3`

data/README.md

@@ -163,6 +163,7 @@ bundle exec rake produce_messages
 
 | rdkafka-ruby | librdkafka | patches |
 |-|-|-|
+| 0.20.0 (2025-01-07) | 2.6.1 (2024-11-18) | yes |
 | 0.19.0 (2024-10-01) | 2.5.3 (2024-09-02) | yes |
 | 0.18.0 (2024-09-02) | 2.5.0 (2024-06-10) | yes |
 | 0.17.0 (2024-08-03) | 2.4.0 (2024-05-07) | no  |

data/dist/patches/rdkafka_global_init.patch

@@ -0,0 +1,15 @@
+# This patch is released under the 2-clause BSD license, same as librdkafka
+#
+--- librdkafka_2.5.3/src/rdkafka.h
++++ librdkafka_2.5.3/src/rdkafka.h
+@@ -1101,6 +1101,10 @@ rd_kafka_topic_partition_t *rd_kafka_topic_partition_list_find(
+     const char *topic,
+     int32_t partition);
+ 
++/**
++ * @brief Allows for the global init of rdkafka when required in the Ruby process.
++ */
++RD_EXPORT void rd_kafka_global_init(void);
+ 
+ /**
+  * @brief Sort list using comparator \p cmp.

data/docker-compose.yml

@@ -1,9 +1,7 @@
-version: '2'
-
 services:
   kafka:
     container_name: kafka
-    image: confluentinc/cp-kafka:7.7.1
+    image: confluentinc/cp-kafka:7.8.0
 
     ports:
       - 9092:9092

data/ext/Rakefile

@@ -16,17 +16,17 @@ task :default => :clean do
     require "mini_portile2"
     recipe = MiniPortile.new("librdkafka", Rdkafka::LIBRDKAFKA_VERSION)
 
-    # Use default homebrew openssl if we're on mac and the directory exists
-    # and each of flags is not empty
-    if recipe.host&.include?("darwin") && system("which brew &> /dev/null") && Dir.exist?("#{homebrew_prefix = %x(brew --prefix openssl).strip}")
-      ENV["CPPFLAGS"] = "-I#{homebrew_prefix}/include" unless ENV["CPPFLAGS"]
-      ENV["LDFLAGS"] = "-L#{homebrew_prefix}/lib" unless ENV["LDFLAGS"]
+    # Use default homebrew openssl if we're on mac and the directory exists, is not using nix-prepared libraries
+    # and each of flags is not already set
+    if recipe.host&.include?("darwin") && system("which brew &> /dev/null") && Dir.exist?("#{homebrew_prefix = %x(brew --prefix openssl).strip}") && ENV.key?("NIX_LDFLAGS")
+      ENV["CPPFLAGS"] = "-I#{homebrew_prefix}/include" unless ENV.key?("CPPFLAGS")
+      ENV["LDFLAGS"] = "-L#{homebrew_prefix}/lib" unless ENV.key?("LDFLAGS")
     end
 
     releases = File.expand_path(File.join(File.dirname(__FILE__), '../dist'))
 
     recipe.files << {
-      :url => "file://#{releases}/librdkafka_#{Rdkafka::LIBRDKAFKA_VERSION}.tar.gz",
+      :url => "file://#{releases}/librdkafka-#{Rdkafka::LIBRDKAFKA_VERSION}.tar.gz",
       :sha256 => Rdkafka::LIBRDKAFKA_SOURCE_SHA256
     }
     recipe.configure_options = ["--host=#{recipe.host}"]

data/lib/rdkafka/bindings.rb

@@ -30,6 +30,11 @@ module Rdkafka
       layout :value, :size_t
     end
 
+    # This function comes from our patch on top of librdkafka. It allows os to load all the
+    # librdkafka components without initializing the client
+    # @see https://github.com/confluentinc/librdkafka/issues/4590
+    attach_function :rd_kafka_global_init, [], :void
+
     # Polling
 
     attach_function :rd_kafka_flush, [:pointer, :int], :int, blocking: true

data/lib/rdkafka/consumer.rb

@@ -609,87 +609,23 @@ module Rdkafka
       end
     end
 
-    # Poll for new messages and yield them in batches that may contain
-    # messages from more than one partition.
-    #
-    # Rather than yield each message immediately as soon as it is received,
-    # each_batch will attempt to wait for as long as `timeout_ms` in order
-    # to create a batch of up to but no more than `max_items` in size.
-    #
-    # Said differently, if more than `max_items` are available within
-    # `timeout_ms`, then `each_batch` will yield early with `max_items` in the
-    # array, but if `timeout_ms` passes by with fewer messages arriving, it
-    # will yield an array of fewer messages, quite possibly zero.
-    #
-    # In order to prevent wrongly auto committing many messages at once across
-    # possibly many partitions, callers must explicitly indicate which messages
-    # have been successfully processed as some consumed messages may not have
-    # been yielded yet. To do this, the caller should set
-    # `enable.auto.offset.store` to false and pass processed messages to
-    # {store_offset}. It is also possible, though more complex, to set
-    # 'enable.auto.commit' to false and then pass a manually assembled
-    # TopicPartitionList to {commit}.
-    #
-    # As with `each`, iteration will end when the consumer is closed.
-    #
-    # Exception behavior is more complicated than with `each`, in that if
-    # :yield_on_error is true, and an exception is raised during the
-    # poll, and messages have already been received, they will be yielded to
-    # the caller before the exception is allowed to propagate.
-    #
-    # If you are setting either auto.commit or auto.offset.store to false in
-    # the consumer configuration, then you should let yield_on_error keep its
-    # default value of false because you are guaranteed to see these messages
-    # again. However, if both auto.commit and auto.offset.store are set to
-    # true, you should set yield_on_error to true so you can process messages
-    # that you may or may not see again.
-    #
-    # @param max_items [Integer] Maximum size of the yielded array of messages
-    # @param bytes_threshold [Integer] Threshold number of total message bytes in the yielded array of messages
-    # @param timeout_ms [Integer] max time to wait for up to max_items
-    #
-    # @yieldparam messages [Array] An array of received Message
-    # @yieldparam pending_exception [Exception] normally nil, or an exception
-    #
-    # @yield [messages, pending_exception]
-    # which will be propagated after processing of the partial batch is complete.
-    #
-    # @return [nil]
-    #
-    # @raise [RdkafkaError] When polling fails
+    # Deprecated. Please read the error message for more details.
     def each_batch(max_items: 100, bytes_threshold: Float::INFINITY, timeout_ms: 250, yield_on_error: false, &block)
-      closed_consumer_check(__method__)
-      slice = []
-      bytes = 0
-      end_time = monotonic_now + timeout_ms / 1000.0
-      loop do
-        break if closed?
-        max_wait = end_time - monotonic_now
-        max_wait_ms = if max_wait <= 0
-                        0  # should not block, but may retrieve a message
-                      else
-                        (max_wait * 1000).floor
-                      end
-        message = nil
-        begin
-          message = poll max_wait_ms
-        rescue Rdkafka::RdkafkaError => error
-          raise unless yield_on_error
-          raise if slice.empty?
-          yield slice.dup, error
-          raise
-        end
-        if message
-          slice << message
-          bytes += message.payload.bytesize if message.payload
-        end
-        if slice.size == max_items || bytes >= bytes_threshold || monotonic_now >= end_time - 0.001
-          yield slice.dup, nil
-          slice.clear
-          bytes = 0
-          end_time = monotonic_now + timeout_ms / 1000.0
-        end
-      end
+      raise NotImplementedError, <<~ERROR
+        `each_batch` has been removed due to data consistency concerns.
+
+        This method was removed because it did not properly handle partition reassignments,
+        which could lead to processing messages from partitions that were no longer owned
+        by this consumer, resulting in duplicate message processing and data inconsistencies.
+
+        Recommended alternatives:
+
+        1. Implement your own batching logic using rebalance callbacks to properly handle
+           partition revocations and ensure message processing correctness.
+
+        2. Use a high-level batching library that supports proper partition reassignment
+           handling out of the box (such as the Karafka framework).
+      ERROR
     end
 
     # Returns pointer to the consumer group metadata. It is used only in the context of

data/lib/rdkafka/version.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Rdkafka
-  VERSION = "0.19.0"
-  LIBRDKAFKA_VERSION = "2.5.3"
-  LIBRDKAFKA_SOURCE_SHA256 = "eaa1213fdddf9c43e28834d9a832d9dd732377d35121e42f875966305f52b8ff"
+  VERSION = "0.20.0"
+  LIBRDKAFKA_VERSION = "2.6.1"
+  LIBRDKAFKA_SOURCE_SHA256 = "0ddf205ad8d36af0bc72a2fec20639ea02e1d583e353163bf7f4683d949e901b"
 end

data/lib/rdkafka.rb

@@ -49,3 +49,5 @@ require "rdkafka/producer/delivery_report"
 # Main Rdkafka namespace of this gem
 module Rdkafka
 end
+
+Rdkafka::Bindings.rd_kafka_global_init

data/spec/rdkafka/consumer/topic_partition_list_spec.rb

@@ -114,12 +114,18 @@ describe Rdkafka::Consumer::TopicPartitionList do
   end
 
   describe "#to_s" do
+    let(:expected) do
+      if RUBY_VERSION >= '3.4.0'
+        "<TopicPartitionList: {\"topic1\" => [<Partition 0>, <Partition 1>]}>"
+      else
+        "<TopicPartitionList: {\"topic1\"=>[<Partition 0>, <Partition 1>]}>"
+      end
+    end
+
     it "should return a human readable representation" do
       list = Rdkafka::Consumer::TopicPartitionList.new
       list.add_topic("topic1", [0, 1])
 
-      expected = "<TopicPartitionList: {\"topic1\"=>[<Partition 0>, <Partition 1>]}>"
-
       expect(list.to_s).to eq expected
     end
   end

data/spec/rdkafka/consumer_spec.rb

@@ -921,236 +921,10 @@ describe Rdkafka::Consumer do
   end
 
   describe "#each_batch" do
-    let(:message_payload) { 'a' * 10 }
-
-    before do
-      @topic = SecureRandom.base64(10).tr('+=/', '')
-    end
-
-    after do
-      @topic = nil
-    end
-
-    def topic_name
-      @topic
-    end
-
-    def produce_n(n)
-      handles = []
-      n.times do |i|
-        handles << producer.produce(
-          topic:     topic_name,
-          payload:   i % 10 == 0 ? nil : Time.new.to_f.to_s,
-          key:       i.to_s,
-          partition: 0
-        )
-      end
-      handles.each(&:wait)
-    end
-
-    def new_message
-      instance_double("Rdkafka::Consumer::Message").tap do |message|
-        allow(message).to receive(:payload).and_return(message_payload)
-      end
-    end
-
-    it "retrieves messages produced into a topic" do
-      # This is the only each_batch test that actually produces real messages
-      # into a topic in the real kafka of the container.
-      #
-      # The other tests stub 'poll' which makes them faster and more reliable,
-      # but it makes sense to keep a single test with a fully integrated flow.
-      # This will help to catch breaking changes in the behavior of 'poll',
-      # libdrkafka, or Kafka.
-      #
-      # This is, in effect, an integration test and the subsequent specs are
-      # unit tests.
-      admin = rdkafka_config.admin
-      create_topic_handle = admin.create_topic(topic_name, 1, 1)
-      create_topic_handle.wait(max_wait_timeout: 15.0)
-      consumer.subscribe(topic_name)
-      produce_n 42
-      all_yields = []
-      consumer.each_batch(max_items: 10) do |batch|
-        all_yields << batch
-        break if all_yields.flatten.size >= 42
-      end
-      expect(all_yields.flatten.first).to be_a Rdkafka::Consumer::Message
-      expect(all_yields.flatten.size).to eq 42
-      expect(all_yields.size).to be > 4
-      expect(all_yields.flatten.map(&:key)).to eq (0..41).map { |x| x.to_s }
-      admin.close
-    end
-
-    it "should batch poll results and yield arrays of messages" do
-      consumer.subscribe(topic_name)
-      all_yields = []
-      expect(consumer)
-        .to receive(:poll)
-        .exactly(10).times
-        .and_return(new_message)
-      consumer.each_batch(max_items: 10) do |batch|
-        all_yields << batch
-        break if all_yields.flatten.size >= 10
-      end
-      expect(all_yields.first).to be_instance_of(Array)
-      expect(all_yields.flatten.size).to eq 10
-      non_empty_yields = all_yields.reject { |batch| batch.empty? }
-      expect(non_empty_yields.size).to be < 10
-    end
-
-    it "should yield a partial batch if the timeout is hit with some messages" do
-      consumer.subscribe(topic_name)
-      poll_count = 0
-      expect(consumer)
-        .to receive(:poll)
-        .at_least(3).times do
-        poll_count = poll_count + 1
-        if poll_count > 2
-          sleep 0.1
-          nil
-        else
-          new_message
-        end
-      end
-      all_yields = []
-      consumer.each_batch(max_items: 10) do |batch|
-        all_yields << batch
-        break if all_yields.flatten.size >= 2
-      end
-      expect(all_yields.flatten.size).to eq 2
-    end
-
-    it "should yield [] if nothing is received before the timeout" do
-      admin = rdkafka_config.admin
-      create_topic_handle = admin.create_topic(topic_name, 1, 1)
-      create_topic_handle.wait(max_wait_timeout: 15.0)
-      consumer.subscribe(topic_name)
-      consumer.each_batch do |batch|
-        expect(batch).to eq([])
-        break
-      end
-      admin.close
-    end
-
-    it "should yield batchs of max_items in size if messages are already fetched" do
-      yielded_batches = []
-      expect(consumer)
-        .to receive(:poll)
-        .with(anything)
-        .exactly(20).times
-        .and_return(new_message)
-
-      consumer.each_batch(max_items: 10, timeout_ms: 500) do |batch|
-        yielded_batches << batch
-        break if yielded_batches.flatten.size >= 20
-        break if yielded_batches.size >= 20 # so failure doesn't hang
-      end
-      expect(yielded_batches.size).to eq 2
-      expect(yielded_batches.map(&:size)).to eq 2.times.map { 10 }
-    end
-
-    it "should yield batchs as soon as bytes_threshold is hit" do
-      yielded_batches = []
-      expect(consumer)
-        .to receive(:poll)
-        .with(anything)
-        .exactly(20).times
-        .and_return(new_message)
-
-      consumer.each_batch(bytes_threshold: message_payload.size * 4, timeout_ms: 500) do |batch|
-        yielded_batches << batch
-        break if yielded_batches.flatten.size >= 20
-        break if yielded_batches.size >= 20 # so failure doesn't hang
-      end
-      expect(yielded_batches.size).to eq 5
-      expect(yielded_batches.map(&:size)).to eq 5.times.map { 4 }
-    end
-
-    context "error raised from poll and yield_on_error is true" do
-      it "should yield buffered exceptions on rebalance, then break" do
-        config = rdkafka_consumer_config(
-          {
-            :"enable.auto.commit" => false,
-            :"enable.auto.offset.store" => false
-          }
-        )
-        consumer = config.consumer
-        consumer.subscribe(topic_name)
-        batches_yielded = []
-        exceptions_yielded = []
-        each_batch_iterations = 0
-        poll_count = 0
-        expect(consumer)
-          .to receive(:poll)
-          .with(anything)
-          .exactly(3).times
-          .and_wrap_original do |method, *args|
-              poll_count = poll_count + 1
-              if poll_count == 3
-                raise Rdkafka::RdkafkaError.new(27,
-                    "partitions ... too ... heavy ... must ... rebalance")
-              else
-                new_message
-              end
-          end
-        expect {
-          consumer.each_batch(max_items: 30, yield_on_error: true) do |batch, pending_error|
-            batches_yielded << batch
-            exceptions_yielded << pending_error
-            each_batch_iterations = each_batch_iterations + 1
-          end
-        }.to raise_error(Rdkafka::RdkafkaError)
-        expect(poll_count).to eq 3
-        expect(each_batch_iterations).to eq 1
-        expect(batches_yielded.size).to eq 1
-        expect(batches_yielded.first.size).to eq 2
-        expect(exceptions_yielded.flatten.size).to eq 1
-        expect(exceptions_yielded.flatten.first).to be_instance_of(Rdkafka::RdkafkaError)
-        consumer.close
-      end
-    end
-
-    context "error raised from poll and yield_on_error is false" do
-      it "should yield buffered exceptions on rebalance, then break" do
-        config = rdkafka_consumer_config(
-          {
-            :"enable.auto.commit" => false,
-            :"enable.auto.offset.store" => false
-          }
-        )
-        consumer = config.consumer
-        consumer.subscribe(topic_name)
-        batches_yielded = []
-        exceptions_yielded = []
-        each_batch_iterations = 0
-        poll_count = 0
-        expect(consumer)
-          .to receive(:poll)
-          .with(anything)
-          .exactly(3).times
-          .and_wrap_original do |method, *args|
-              poll_count = poll_count + 1
-              if poll_count == 3
-                raise Rdkafka::RdkafkaError.new(27,
-                    "partitions ... too ... heavy ... must ... rebalance")
-              else
-                new_message
-              end
-          end
-        expect {
-          consumer.each_batch(max_items: 30, yield_on_error: false) do |batch, pending_error|
-            batches_yielded << batch
-            exceptions_yielded << pending_error
-            each_batch_iterations = each_batch_iterations + 1
-          end
-        }.to raise_error(Rdkafka::RdkafkaError)
-        expect(poll_count).to eq 3
-        expect(each_batch_iterations).to eq 0
-        expect(batches_yielded.size).to eq 0
-        expect(exceptions_yielded.size).to eq 0
-        consumer.close
-      end
+    it 'expect to raise an error' do
+      expect do
+        consumer.each_batch {}
+      end.to raise_error(NotImplementedError)
     end
   end
 
@@ -1317,7 +1091,6 @@ describe Rdkafka::Consumer do
     {
         :subscribe               => [ nil ],
         :unsubscribe             => nil,
-        :each_batch              => nil,
         :pause                   => [ nil ],
         :resume                  => [ nil ],
         :subscription            => nil,

metadata

@@ -1,12 +1,11 @@
 --- !ruby/object:Gem::Specification
 name: rdkafka
 version: !ruby/object:Gem::Version
-  version: 0.19.0
+  version: 0.20.0
 platform: ruby
 authors:
 - Thijs Cadier
 - Maciej Mensfeld
-autorequire: 
 bindir: bin
 cert_chain:
 - |
@@ -36,7 +35,7 @@ cert_chain:
   i9zWxov0mr44TWegTVeypcWGd/0nxu1+QHVNHJrpqlPBRvwQsUm7fwmRInGpcaB8
   ap8wNYvryYzrzvzUxIVFBVM5PacgkFqRmolCa8I7tdKQN+R1
   -----END CERTIFICATE-----
-date: 2024-10-01 00:00:00.000000000 Z
+date: 2025-01-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ffi
@@ -186,8 +185,8 @@ files:
 - README.md
 - Rakefile
 - certs/cert.pem
-- dist/librdkafka_2.5.3.tar.gz
-- dist/patches/rdkafka_sticky_assignor.c.patch
+- dist/librdkafka-2.6.1.tar.gz
+- dist/patches/rdkafka_global_init.patch
 - docker-compose.yml
 - ext/README.md
 - ext/Rakefile
@@ -261,7 +260,6 @@ files:
 - spec/rdkafka/producer/delivery_report_spec.rb
 - spec/rdkafka/producer_spec.rb
 - spec/spec_helper.rb
-homepage: 
 licenses:
 - MIT
 metadata:
@@ -272,7 +270,6 @@ metadata:
   source_code_uri: https://github.com/karafka/rdkafka-ruby
   documentation_uri: https://github.com/karafka/rdkafka-ruby/blob/main/README.md
   rubygems_mfa_required: 'true'
-post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -287,8 +284,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.16
-signing_key: 
+rubygems_version: 3.6.2
 specification_version: 4
 summary: The rdkafka gem is a modern Kafka client library for Ruby based on librdkafka.
   It wraps the production-ready C client using the ffi gem and targets Kafka 1.0+

data/dist/patches/rdkafka_sticky_assignor.c.patch

@@ -1,26 +0,0 @@
-# This patch is released under the 2-clause BSD license, same as librdkafka
-# Fixes: https://github.com/confluentinc/librdkafka/issues/4783
-#
---- librdkafka_2.5.3/src/rdkafka_sticky_assignor.c	2024-07-08 09:47:43.000000000 +0200
-+++ librdkafka_2.5.3/src/rdkafka_sticky_assignor.c	2024-07-30 09:44:38.529759640 +0200
-@@ -769,7 +769,7 @@
-         const rd_kafka_topic_partition_list_t *partitions;
-         const char *consumer;
-         const rd_map_elem_t *elem;
--        int i;
-+        int i, j;
- 
-         /* The assignment is balanced if minimum and maximum numbers of
-          * partitions assigned to consumers differ by at most one. */
-@@ -836,9 +836,9 @@
- 
-                 /* Otherwise make sure it can't get any more partitions */
- 
--                for (i = 0; i < potentialTopicPartitions->cnt; i++) {
-+                for (j = 0; j < potentialTopicPartitions->cnt; j++) {
-                         const rd_kafka_topic_partition_t *partition =
--                            &potentialTopicPartitions->elems[i];
-+                            &potentialTopicPartitions->elems[j];
-                         const char *otherConsumer;
-                         int otherConsumerPartitionCount;
-