rdf-ldp 0.7.0 → 0.8.0

data/lib/rdf/ldp/indirect_container.rb

@@ -1,23 +1,26 @@
 module RDF::LDP
   ##
-  # An extension of `RDF::LDP::DirectContainer` implementing indirect 
-  # containment. Adds the concept of an inserted content relation to the 
+  # An extension of `RDF::LDP::DirectContainer` implementing indirect
+  # containment. Adds the concept of an inserted content relation to the
   # features of the direct container.
   #
   # Clients MUST provide exactly one `ldp:insertedContentRelation` statement in
-  # each Indirect Container. If no `#inserted_content_relation` is given by the 
+  # each Indirect Container. If no `#inserted_content_relation` is given by the
   # client, we default to `ldp:MemberSubject`. If more than one is present,
   #
-  # Attempts to POST resources without the appropriate content relation (or 
-  # with more than one) to an Indirect Container will fail with `Not 
+  # Attempts to POST resources without the appropriate content relation (or
+  # with more than one) to an Indirect Container will fail with `Not
   # Acceptable`. LDP-NR's cannot be added since indirect membership is not well
   # defined for them, per _LDP 5.5.1.2_.
   #
-  # @see http://www.w3.org/TR/ldp/#h-ldpic-indirectmbr for an explanation if 
+  # @see http://www.w3.org/TR/ldp/#h-ldpic-indirectmbr for an explanation if
   #   indirect membership and limitiations surrounding LDP-NRs.
   # @see http://www.w3.org/TR/ldp/#dfn-linked-data-platform-indirect-container
   #   definition of LDP Indirect Container
   class IndirectContainer < DirectContainer
+    INSERTED_CONTENT_REL_URI = RDF::Vocab::LDP.insertedContentRelation.freeze
+    MEMBER_SUBJECT_URI       = RDF::Vocab::LDP.MemberSubject.freeze
+
     def self.to_uri
       RDF::Vocab::LDP.IndirectContainer
     end
@@ -31,16 +34,17 @@ module RDF::LDP
     ##
     # Creates and inserts default relation triples if none are given.
     #
-    # @see DirectContainer#create for information about the behavior and 
+    # @see DirectContainer#create for information about the behavior and
     #   transactionality of this method.
-    def create(input, content_type, &block)
+    def create(input, content_type)
       super
 
       graph.transaction(mutable: true) do |tx|
-        tx.insert RDF::Statement(subject_uri, 
-                                 RDF::Vocab::LDP.insertedContentRelation, 
-                                 RDF::Vocab::LDP.MemberSubject) if
-          inserted_content_statements.empty?
+        if inserted_content_statements.empty?
+          tx.insert RDF::Statement(subject_uri,
+                                   INSERTED_CONTENT_REL_URI,
+                                   MEMBER_SUBJECT_URI)
+        end
       end
 
       self
@@ -48,13 +52,13 @@ module RDF::LDP
 
     ##
     # Gives the inserted content relation for the indirect container. If none is
-    # present in the container state, we add `ldp:MemberSubject`, effectively 
+    # present in the container state, we add `ldp:MemberSubject`, effectively
     # treating this LDP-IC as an LDP-DC.
     #
     # @return [RDF::URI] the inserted content relation; either a predicate term
     #   or `ldp:MemberSubject`
     #
-    # @raise [RDF::LDP::NotAcceptable] if multiple inserted content relations 
+    # @raise [RDF::LDP::NotAcceptable] if multiple inserted content relations
     #   exist.
     #
     # @see http://www.w3.org/TR/ldp/#dfn-membership-triples
@@ -62,36 +66,36 @@ module RDF::LDP
       statements = inserted_content_statements
       return statements.first.object if statements.count == 1
 
-      raise NotAcceptable.new('An LDP-IC MUST have exactly ' \
-                              'one inserted content relation triple; found ' \
-                              "#{statements.count}.")
+      raise(NotAcceptable, 'An LDP-IC MUST have exactly ' \
+                           'one inserted content relation triple; found ' \
+                           "#{statements.count}.")
     end
 
     private
 
     def inserted_content_statements
-      graph.query([subject_uri, RDF::Vocab::LDP.insertedContentRelation, nil])
-        .statements
+      graph.query([subject_uri, INSERTED_CONTENT_REL_URI, nil])
+           .statements
     end
-    
-    def process_membership_resource(resource, &block)
+
+    def process_membership_resource(resource)
       resource = member_derived_uri(resource)
-      super(resource, &block)
+      super
     end
-    
+
     def member_derived_uri(resource)
       predicate = inserted_content_relation
-      return resource.to_uri if predicate == RDF::Vocab::LDP.MemberSubject
+      return resource.to_uri if predicate == MEMBER_SUBJECT_URI
 
-      raise NotAcceptable.new("#{resource.to_uri} is an LDP-NR; cannot add " \
-                              'it to an IndirectContainer with a content ' \
-                              'relation.') if resource.non_rdf_source?
+      raise(NotAcceptable, "#{resource.to_uri} is an LDP-NR; cannot add " \
+                           'it to an IndirectContainer with a content '   \
+                           'relation.') if resource.non_rdf_source?
 
       statements = resource.graph.query([resource.subject_uri, predicate, :o])
       return statements.first.object if statements.count == 1
 
-      raise NotAcceptable.new("#{statements.count} inserted content" \
-                              "#{predicate} found on #{resource.to_uri}")
+      raise(NotAcceptable, "#{statements.count} inserted content" \
+                           "#{predicate} found on #{resource.to_uri}")
     end
   end
 end

data/lib/rdf/ldp/non_rdf_source.rb

@@ -1,31 +1,47 @@
+require 'rdf/ldp/storage_adapters/file_storage_adapter'
+
 module RDF::LDP
   ##
   # A NonRDFSource describes a `Resource` whose response body is a format other
-  # than an RDF serialization. The persistent state of the resource, as 
-  # represented by the body, is persisted to an IO stream provided by a 
+  # than an RDF serialization. The persistent state of the resource, as
+  # represented by the body, is persisted to an IO stream provided by a
   # `RDF::LDP::NonRDFSource::StorageAdapter` given by `#storage`.
   #
   # In addition to the properties stored by the `RDF::LDP::Resource#metagraph`,
-  # `NonRDFSource`s also store a content type (format). 
+  # `NonRDFSource`s also store a content type (format).
   #
-  # When a `NonRDFSource` is created, it also creates an `RDFSource` which 
+  # When a `NonRDFSource` is created, it also creates an `RDFSource` which
   # describes it. This resource is created at the URI in `#description_uri`,
-  # the resource itself is returned by `#description`. 
+  # the resource itself is returned by `#description`.
   #
   # @see RDF::LDP::Resource
   # @see http://www.w3.org/TR/ldp/#dfn-linked-data-platform-non-rdf-source for
   #   a definition of NonRDFSource in LDP
   class NonRDFSource < Resource
+    attr_reader :storage
+
+    # Use the default filesystem-based storage adapter
+    DEFAULT_ADAPTER = RDF::LDP::NonRDFSource::FileStorageAdapter
+
     # Use DC elements format
-    FORMAT_TERM = RDF::Vocab::DC11.format
-    DESCRIBED_BY_TERM = RDF::URI('http://www.w3.org/2007/05/powder-s#describedby')
-    
+    FORMAT_TERM = RDF::Vocab::DC11.format.freeze
+
+    ##
+    # @param [storage_adapter] a class implementing the StorageAdapter interface
+    #
+    # @see RDF::LDP::Resource#initialize
+    def initialize(subject_uri, data = RDF::Repository.new, storage_adapter = DEFAULT_ADAPTER)
+      data ||= RDF::Repository.new # allows explict `nil` pass
+      @storage = storage_adapter.new(self)
+      super(subject_uri, data)
+    end
+
     ##
-    # @return [RDF::URI] uri with lexical representation 
+    # @return [RDF::URI] uri with lexical representation
     #   'http://www.w3.org/ns/ldp#NonRDFSource'
     #
     # @see http://www.w3.org/TR/ldp/#dfn-linked-data-platform-non-rdf-source
-    def self.to_uri 
+    def self.to_uri
       RDF::Vocab::LDP.NonRDFSource
     end
 
@@ -36,7 +52,7 @@ module RDF::LDP
     end
 
     ##
-    # @param [IO, File] input  input (usually from a Rack env's 
+    # @param [IO, File] input  input (usually from a Rack env's
     #   `rack.input` key) that will be read into the NonRDFSource
     # @param [#to_s] c_type  a MIME content_type used as a content type
     #   for the created NonRDFSource
@@ -52,7 +68,7 @@ module RDF::LDP
       self.content_type = c_type
 
       RDFSource.new(description_uri, @data)
-        .create(StringIO.new, 'application/n-triples')
+               .create(StringIO.new, 'application/n-triples')
 
       self
     end
@@ -67,13 +83,13 @@ module RDF::LDP
     end
 
     ##
-    # Deletes the LDP-NR contents from the storage medium and marks the 
+    # Deletes the LDP-NR contents from the storage medium and marks the
     # resource as destroyed.
     #
     # @see RDF::LDP::Resource#destroy
     def destroy
-      storage.delete
       super
+      storage.delete
     end
 
     ##
@@ -90,49 +106,43 @@ module RDF::LDP
       subject_uri / '.well-known' / 'desc'
     end
 
-    ##
-    # @return [StorageAdapter] the storage adapter for this LDP-NR
-    def storage
-      @storage_adapter ||= StorageAdapter.new(self)
-    end
-    
     ##
     # Sets the MIME type for the resource in `metagraph`.
     #
     # @param [String] a string representing the content type for this LDP-NR.
     #   This SHOULD be a regisered MIME type.
     #
-    # @return [StorageAdapter] the content type 
+    # @return [StorageAdapter] the content type
     def content_type=(content_type)
       metagraph.delete([subject_uri, FORMAT_TERM])
-      metagraph << 
-        RDF::Statement(subject_uri, RDF::Vocab::DC11.format, content_type)
+      metagraph <<
+        RDF::Statement(subject_uri, FORMAT_TERM, content_type)
     end
-    
+
     ##
-    # @return [StorageAdapter] this resource's content type 
+    # @return [StorageAdapter] this resource's content type
     def content_type
       format_triple = metagraph.first([subject_uri, FORMAT_TERM, :format])
       format_triple.nil? ? nil : format_triple.object.object
     end
 
     ##
-    # @return [#each] the response body. This is normally the StorageAdapter's 
+    # @return [#each] the response body. This is normally the StorageAdapter's
     #   IO object in read and binary mode.
-    # 
+    #
     # @raise [RDF::LDP::RequestError] when the request fails
     def to_response
       (exists? && !destroyed?) ? storage.io : []
     end
 
-    private 
+    private
 
     ##
     # Process & generate response for PUT requsets.
-    def put(status, headers, env)
-      raise PreconditionFailed.new('Etag invalid') if 
-        env.has_key?('HTTP_IF_MATCH') && !match?(env['HTTP_IF_MATCH'])
-      
+    def put(_status, headers, env)
+      raise(PreconditionFailed, 'Etag invalid') if
+        env.key?('HTTP_IF_MATCH') && !match?(env['HTTP_IF_MATCH'])
+
       if exists?
         update(env['rack.input'], env['CONTENT_TYPE'])
         headers = update_headers(headers)
@@ -153,104 +163,5 @@ module RDF::LDP
     def link_headers
       super << "<#{description_uri}>;rel=\"describedBy\""
     end
-
-    ##
-    # StorageAdapters bundle the logic for mapping a `NonRDFSource` to a 
-    # specific IO stream. Implementations must conform to a minimal interface:
-    #
-    #  - `#initailize` must accept a `resource` parameter. The input should be 
-    #     a `NonRDFSource` (LDP-NR).
-    #  - `#io` must yield and return a IO object in binary mode that represents 
-    #    the current state of the LDP-NR.
-    #    - If a block is passed to `#io`, the implementation MUST allow return a
-    #      writable IO object and that anything written to the stream while 
-    #      yielding is synced with the source in a thread-safe manner.
-    #    - Clients not passing a block to `#io` SHOULD call `#close` on the 
-    #      object after reading it. 
-    #    - If the `#io` object responds to `#to_path` it MUST give the location
-    #      of a file whose contents are identical the IO object's. This supports
-    #      Rack's response body interface.
-    #  - `#delete` remove the contents from the corresponding storage. This MAY
-    #      be a no-op if is undesirable or impossible to delete the contents 
-    #      from the storage medium.
-    #
-    # @see http://www.rubydoc.info/github/rack/rack/master/file/SPEC#The_Body 
-    #   for details about `#to_path` in Rack response bodies.
-    #
-    # @example reading from a `StorageAdapter`
-    #   storage = StorageAdapter.new(an_nr_source)
-    #   storage.io.read # => [string contents of `an_nr_source`]
-    #
-    # @example writing to a `StorageAdapter`
-    #   storage = StorageAdapter.new(an_nr_source)
-    #   storage.io { |io| io.write('moomin') }
-    #
-    # Beyond this interface, implementations are permitted to behave as desired.
-    # They may, for instance, reject undesirable content or alter the graph (or 
-    # metagraph) of the resource. They should throw appropriate `RDF::LDP` 
-    # errors when failing to allow the middleware to handle response codes and 
-    # messages.
-    #
-    # The base storage adapter class provides a simple File storage 
-    # implementation.
-    #
-    # @todo check thread saftey on write for base implementation 
-    class StorageAdapter
-      STORAGE_PATH = '.storage'.freeze
-
-      ##
-      # Initializes the storage adapter.
-      #
-      # @param [NonRDFSource] resource
-      def initialize(resource)
-        @resource = resource
-      end
-      
-      ##
-      # Gives an IO object which represents the current state of @resource.
-      # Opens the file for read-write (mode: r+), if it already exists; 
-      # otherwise, creates the file and opens it for read-write (mode: w+).
-      #
-      # @yield [IO] yields a read-writable object conforming to the Ruby IO 
-      #   interface for storage. The IO object will be closed when the block 
-      #   ends.
-      #
-      # @return [IO] an object conforming to the Ruby IO interface
-      def io(&block)
-        FileUtils.mkdir_p(path_dir) unless Dir.exists?(path_dir)
-        FileUtils.touch(path) unless file_exists?
-
-        File.open(path, 'r+b', &block)
-      end
-      
-      ##
-      # @return [Boolean] 1 if the file has been deleted, otherwise false
-      def delete
-        return false unless File.exists?(path)
-        File.delete(path) 
-      end
-
-      private 
-
-      ##
-      # @return [Boolean]
-      def file_exists?
-        File.exists?(path)
-      end
-
-      ##
-      # Build the path to the file on disk.
-      # @return [String]
-      def path
-        File.join(STORAGE_PATH, @resource.subject_uri.path)
-      end
-
-      ##
-      # Build the path to the file's directory on disk
-      # @return [String]
-      def path_dir
-        File.split(path).first
-      end
-    end
   end
 end

data/lib/rdf/ldp/rdf_source.rb

@@ -3,39 +3,38 @@ require 'ld/patch'
 
 module RDF::LDP
   ##
-  # The base class for all directly usable LDP Resources that *are not* 
+  # The base class for all directly usable LDP Resources that *are not*
   # `NonRDFSources`. RDFSources are implemented as a resource with:
   #
   #   - a `#graph` representing the "entire persistent state"
   #   - a `#metagraph` containing internal properties of the RDFSource
   #
-  # Repository implementations must be able to reconstruct both `#graph` and 
+  # Repository implementations must be able to reconstruct both `#graph` and
   # `#metagraph` accurately and separately (e.g., by saving them as distinct
   # named graphs).
-  # 
-  # The implementations of `#create` and `#update` in `RDF::LDP::Resource` are 
-  # overloaded to handle the edits to `#graph` within the same transaction as 
-  # the base `#metagraph` updates. `#to_response` is overloaded to return an 
+  #
+  # The implementations of `#create` and `#update` in `RDF::LDP::Resource` are
+  # overloaded to handle the edits to `#graph` within the same transaction as
+  # the base `#metagraph` updates. `#to_response` is overloaded to return an
   # unnamed `RDF::Graph`, to be transformed into an HTTP Body by
   # `Rack::LDP::ContentNegotiation`.
   #
-  # @note the contents of `#metagraph`'s are *not* the same as 
-  # LDP-server-managed triples. `#metagraph` contains internal properties of the
-  # RDFSource which are necessary for the server's management purposes, but MAY
-  # be absent from (or in conflict with) the representation of its state in 
-  # `#graph`.
-  # 
-  # @see http://www.w3.org/TR/ldp/#dfn-linked-data-platform-rdf-source definition 
-  #   of ldp:RDFSource in the LDP specification
+  # @note the contents of `#metagraph`'s are *not* the same as
+  #   LDP-server-managed triples. `#metagraph` contains internal properties of 
+  #   the RDFSource which are necessary for the server's management purposes, 
+  #   but MAY be absent from (or in conflict with) the representation of its 
+  #   state in `#graph`.
+  #
+  # @see http://www.w3.org/TR/ldp/#dfn-linked-data-platform-rdf-source 
+  #   Definition of ldp:RDFSource in the LDP specification
   class RDFSource < Resource
-
     class << self
       ##
-      # @return [RDF::URI] uri with lexical representation 
+      # @return [RDF::URI] uri with lexical representation
       #   'http://www.w3.org/ns/ldp#RDFSource'
       #
       # @see http://www.w3.org/TR/ldp/#dfn-linked-data-platform-rdf-source
-      def to_uri 
+      def to_uri
         RDF::Vocab::LDP.RDFSource
       end
     end
@@ -50,7 +49,7 @@ module RDF::LDP
     end
 
     ##
-    # @return [RDF::Graph] a graph representing the current persistent state of 
+    # @return [RDF::Graph] a graph representing the current persistent state of
     #   the resource.
     def graph
       @graph ||= RDF::Graph.new(graph_name: @subject_uri, data: @data)
@@ -61,37 +60,39 @@ module RDF::LDP
     #
     # @example
     #   repository = RDF::Repository.new
+    #   content = StringIO.new('<http://ex.org/1> <http://ex.org/p> "moomin" .')
+    #
     #   ldprs = RDF::LDP::RDFSource.new('http://example.org/moomin', repository)
-    #   ldprs.create('<http://ex.org/1> <http://ex.org/prop> "moomin" .', 'text/turtle')
+    #   ldprs.create(content, 'text/turtle')
     #
-    # @param [IO, File, #to_s] input  input (usually from a Rack env's 
+    # @param [IO, File] input  input (usually from a Rack env's
     #   `rack.input` key) used to determine the Resource's initial state.
     # @param [#to_s] content_type  a MIME content_type used to read the graph.
     #
-    # @yield gives an in-progress transaction (changeset) to collect changes to 
-    #   graph, metagraph and other resources' (e.g. containers) graphs. 
-    # @yieldparam tx [RDF::Transaction] a transaction targeting `#graph` as the 
+    # @yield gives an in-progress transaction (changeset) to collect changes to
+    #   graph, metagraph and other resources' (e.g. containers) graphs.
+    # @yieldparam tx [RDF::Transaction] a transaction targeting `#graph` as the
     #   default graph name
     #
     # @example altering changes before execution with block syntax
-    #   content = '<http://ex.org/1> <http://ex.org/prop> "moomin" .'
+    #   content = '<http://ex.org/1> <http://ex.org/p> "moomin" .'
     #
-    #   ldprs.create(content, 'text/turtle') do |tx|
+    #   ldprs.create(StringIO.new(content), 'text/turtle') do |tx|
     #     tx.insert([RDF::URI('s'), RDF::URI('p'), 'custom'])
     #     tx.insert([RDF::URI('s'), RDF::URI('p'), 'custom', RDF::URI('g')])
     #   end
     #
     # @example validating changes before execution with block syntax
-    #   content = '<http://ex.org/1> <http://ex.org/prop> "moomin" .'
+    #   content = '<http://ex.org/1> <http://ex.org/p> "moomin" .'
     #
-    #   ldprs.create(content, 'text/turtle') do |tx|
+    #   ldprs.create(StringIO.new(content), 'text/turtle') do |tx|
     #     raise "cannot delete triples on create!" unless tx.deletes.empty?
     #   end
     #
-    # @raise [RDF::LDP::RequestError] 
-    # @raise [RDF::LDP::UnsupportedMediaType] if no reader can be found for the 
+    # @raise [RDF::LDP::RequestError]
+    # @raise [RDF::LDP::UnsupportedMediaType] if no reader can be found for the
     #   graph
-    # @raise [RDF::LDP::BadRequest] if the identified reader can't parse the 
+    # @raise [RDF::LDP::BadRequest] if the identified reader can't parse the
     #   graph
     # @raise [RDF::LDP::Conflict] if the RDFSource already exists
     #
@@ -104,35 +105,36 @@ module RDF::LDP
     end
 
     ##
-    # Updates the resource. Replaces the contents of `graph` with the parsed 
+    # Updates the resource. Replaces the contents of `graph` with the parsed
     # input.
     #
-    # @param [IO, File, #to_s] input  input (usually from a Rack env's 
+    # @param [IO, File] input  input (usually from a Rack env's
     #   `rack.input` key) used to determine the Resource's new state.
     # @param [#to_s] content_type  a MIME content_type used to interpret the
     #   input.
     #
-    # @yield gives an in-progress transaction (changeset) to collect changes to 
-    #   graph, metagraph and other resources' (e.g. containers) graphs. 
-    # @yieldparam tx [RDF::Transaction] a transaction targeting `#graph` as the 
+    # @yield gives an in-progress transaction (changeset) to collect changes to
+    #   graph, metagraph and other resources' (e.g. containers) graphs.
+    # @yieldparam tx [RDF::Transaction] a transaction targeting `#graph` as the
     #   default graph name
     #
     # @example altering changes before execution with block syntax
     #   content = '<http://ex.org/1> <http://ex.org/prop> "moomin" .'
     #
-    #   ldprs.update(content, 'text/turtle') do |tx|
+    #   ldprs.update(StringIO.new(content), 'text/turtle') do |tx|
     #     tx.insert([RDF::URI('s'), RDF::URI('p'), 'custom'])
     #     tx.insert([RDF::URI('s'), RDF::URI('p'), 'custom', RDF::URI('g')])
     #   end
     #
-    # @raise [RDF::LDP::RequestError] 
-    # @raise [RDF::LDP::UnsupportedMediaType] if no reader can be found for the 
+    # @raise [RDF::LDP::RequestError]
+    # @raise [RDF::LDP::UnsupportedMediaType] if no reader can be found for the
     #   graph
     #
     # @return [RDF::LDP::Resource] self
     def update(input, content_type, &block)
       super do |transaction|
-        transaction.delete(RDF::Statement(nil, nil, nil, graph_name: subject_uri))
+        transaction
+          .delete(RDF::Statement(nil, nil, nil, graph_name: subject_uri))
         transaction.insert parse_graph(input, content_type)
         yield transaction if block_given?
       end
@@ -143,7 +145,7 @@ module RDF::LDP
     #
     # @see RDF::LDP::Resource#destroy
     def destroy(&block)
-      super do |tx| 
+      super do |tx|
         tx.delete(RDF::Statement(nil, nil, nil, graph_name: subject_uri))
       end
     end
@@ -155,7 +157,7 @@ module RDF::LDP
     end
 
     ##
-    # Returns the graph representing this resource's state, without the graph 
+    # Returns the graph representing this resource's state, without the graph
     # context.
     def to_response
       RDF::Graph.new << graph
@@ -168,10 +170,10 @@ module RDF::LDP
     #
     # @note patch is currently not transactional.
     #
-    # @raise [RDF::LDP::UnsupportedMediaType] when a media type other than 
+    # @raise [RDF::LDP::UnsupportedMediaType] when a media type other than
     #   LDPatch is used
     # @raise [RDF::LDP::BadRequest] when an invalid document is given
-    def patch(status, headers, env)
+    def patch(_status, headers, env)
       check_precondition!(env)
       method = patch_types[env['CONTENT_TYPE']]
 
@@ -181,7 +183,7 @@ module RDF::LDP
       set_last_modified
       [200, update_headers(headers), self]
     end
-   
+
     ##
     # @return [Hash<String,Symbol>] a hash mapping supported PATCH content types
     #   to the method used to process the PATCH request
@@ -189,8 +191,8 @@ module RDF::LDP
       { 'text/ldpatch'              => :ld_patch,
         'application/sparql-update' => :sparql_update }
     end
-   
-    def ld_patch(input, graph, &block)
+
+    def ld_patch(input, graph)
       LD::Patch.parse(input.read).execute(graph)
     rescue LD::Patch::Error => e
       raise BadRequest, e.message
@@ -204,7 +206,7 @@ module RDF::LDP
 
     ##
     # Process & generate response for PUT requsets.
-    def put(status, headers, env)
+    def put(_status, headers, env)
       check_precondition!(env)
 
       if exists?
@@ -221,35 +223,35 @@ module RDF::LDP
     # @param [Hash<String, String>] env  a rack env
     # @raise [RDF::LDP::PreconditionFailed]
     def check_precondition!(env)
-      raise PreconditionFailed.new('Etag invalid') if 
-        env.has_key?('HTTP_IF_MATCH') && !match?(env['HTTP_IF_MATCH'])
+      raise(PreconditionFailed, 'Etag invalid') if
+        env.key?('HTTP_IF_MATCH') && !match?(env['HTTP_IF_MATCH'])
     end
 
     ##
     # Finds an {RDF::Reader} appropriate for the given content_type and attempts
     # to parse the graph string.
     #
-    # @param [IO, File, String] input  a (Rack) input stream IO object or String
-    #   to parse
+    # @param [IO, File] input  a (Rack) input stream IO object to parse
+    #
     # @param [#to_s] content_type  the content type for the reader
     #
     # @return [RDF::Enumerable] the statements in the resulting graph
     #
     # @raise [RDF::LDP::UnsupportedMediaType] if no appropriate reader is found
     #
-    # @see http://www.rubydoc.info/github/rack/rack/file/SPEC#The_Input_Stream 
-    #   for documentation on input streams in the Rack SPEC
+    # @see http://www.rubydoc.info/github/rack/rack/file/SPEC#The_Input_Stream
+    #   Documentation on input streams in the Rack SPEC
     def parse_graph(input, content_type)
       reader = RDF::Reader.for(content_type: content_type.to_s)
       raise(RDF::LDP::UnsupportedMediaType, content_type) if reader.nil?
 
       begin
         input.rewind
-        RDF::Graph.new(graph_name: subject_uri, data: RDF::Repository.new) << 
+        RDF::Graph.new(graph_name: subject_uri, data: RDF::Repository.new) <<
           reader.new(input.read, base_uri: subject_uri, validate: true)
       rescue RDF::ReaderError => e
         raise RDF::LDP::BadRequest, e.message
-      end  
+      end
     end
   end
 end