rddd 0.3.0 → 0.3.1

data/examples/remoting/app/Gemfile

@@ -1,4 +1,4 @@
 source 'https://rubygems.org'
 
 gem 'sinatra'
-gem 'rddd', :path => "~/development/rddd"
+gem 'rddd', :path => "../../../"

data/examples/remoting/app/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ~/development/rddd
   specs:
-    rddd (0.2.4)
+    rddd (0.3.0)
       curb
 
 GEM

data/examples/remoting/remote/Gemfile

@@ -2,4 +2,4 @@ source 'https://rubygems.org'
 
 gem 'sinatra'
 gem 'sinatra-contrib'
-gem 'rddd', :path => "~/development/rddd"
+gem 'rddd', :path => "../../../"

data/examples/remoting/remote/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ~/development/rddd
   specs:
-    rddd (0.2.4)
+    rddd (0.3.0)
       curb
 
 GEM

data/examples/remoting/remote/app.rb

@@ -9,7 +9,7 @@ require 'rddd/services/service_bus'
 require 'services/list_service'
 
 Rddd.configure do |config|
-  config.service_creator = lambda do |name|
+  config.service_factory_strategy = lambda do |name|
     class_name = "#{name.to_s.camel_case}Service"
     puts class_name
     Object.const_get(class_name.to_sym)

data/lib/rddd/configuration.rb

@@ -8,9 +8,9 @@ module Rddd
   class Configuration
     include Singleton
 
-    attr_accessor :service_creator, 
-      :repository_creator, 
-      :caching_strategy, 
+    attr_accessor :service_factory_strategy, 
+      :repository_creator,
+      :caching_strategy,
       :remote_services
   end
 end

data/lib/rddd/services/remote_service.rb

@@ -1,6 +1,7 @@
 require 'json'
 require 'curl'
 require 'rddd/services/service'
+require 'rddd/services/transports/factory'
 
 module Rddd
   module Services
@@ -37,24 +38,23 @@ module Rddd
     # for any change in your client or services code base.
     #
     class RemoteService < Service
-      def initialize(url, attributes = {})
+      def initialize(transport, service_name, attributes)
         super(attributes)
 
-        @url = url
+        @transport = transport
+        @service_name = service_name
       end
 
       def execute
-        JSON.parse(Curl.post(@url, JSON.unparse(@attributes)) do |http|
-          http.headers['Content-Type'] = 'application/json' 
-        end.body_str)
+        @transport.call(@service_name, @attributes)
       end
 
-      def self.build(namespace, service_name, attributes)
-        remote = Configuration.instance.remote_services.find do |item|
-          item[:namespace] == namespace
-        end
-
-        RemoteService.new("#{remote[:endpoint]}#{service_name}", attributes)
+      def self.build(namespace, service_name, attributes = {})
+        RemoteService.new(
+          Transports::Factory.build(namespace), 
+          service_name, 
+          attributes
+        )
       end
     end
   end

data/lib/rddd/services/service_factory.rb

@@ -3,17 +3,17 @@ require 'rddd/configuration'
 module Rddd
   module Services
     class ServiceFactory
-      CreatorNotGiven = Class.new(RuntimeError)
+      StrategyNotGiven = Class.new(RuntimeError)
 
       InvalidService = Class.new(RuntimeError)
 
       def self.build(name, attributes)
-        creator = Configuration.instance.service_creator
+        strategy = Configuration.instance.service_factory_strategy
 
-        raise CreatorNotGiven unless creator
+        raise StrategyNotGiven unless strategy
 
         begin
-          creator.call(name).new(attributes)
+          strategy.call(name).new(attributes)
         rescue
           raise Rddd::Services::ServiceFactory::InvalidService
         end

data/lib/rddd/services/transports/factory.rb

@@ -0,0 +1,22 @@
+require 'json'
+require 'curl'
+require 'rddd/services/service'
+require 'rddd/services/transports/http_json'
+
+module Rddd
+  module Services
+    module Transports
+      class Factory
+        def self.build(namespace)
+          remote = Configuration.instance.remote_services.find do |remote|
+            remote[:namespace] == namespace
+          end
+
+          Transports::HttpJson.new(
+            :endpoint => remote[:endpoint]
+          )
+        end
+      end
+    end
+  end
+end

data/lib/rddd/services/transports/http_json.rb

@@ -0,0 +1,17 @@
+module Rddd
+  module Services
+    module Transports
+      class HttpJson
+        def initialize(attributes)
+          @endpoint = attributes[:endpoint]
+        end
+
+        def call(service_name, attributes)
+          JSON.parse(Curl.post("#{@endpoint}#{service_name}", JSON.unparse(attributes)) do |http|
+            http.headers['Content-Type'] = 'application/json' 
+          end.body_str)
+        end
+      end
+    end
+  end
+end

data/lib/rddd/version.rb

@@ -1,3 +1,3 @@
 module Rddd
-  VERSION = "0.3.0"
+  VERSION = "0.3.1"
 end

data/spec/integration_spec.rb

@@ -43,7 +43,7 @@ describe 'CreateProject' do
     Rddd.configure do |config|
       config.repository_creator = repository_creator
 
-      config.service_creator = lambda do |name|
+      config.service_factory_strategy = lambda do |name|
         class_name = "#{name.to_s.camel_case}Service"
         Object.const_get(class_name.to_sym)
       end

data/spec/lib/services/remote_service_spec.rb

@@ -6,32 +6,36 @@ module Rddd
     describe RemoteService do
       let(:attributes) { {:foo => 'bar'} }
 
-      let(:url) { 'http://remote.dev/' }
+      let(:endpoint) { 'http://remote.dev/' }
 
-      describe '#initialize' do
-        subject { RemoteService.new(url, attributes) }
+      let(:namespace) { 'namespace' }
 
-        it 'should store attributes' do
-          subject.instance_variable_get(:@attributes).should == attributes
-        end
-      end  
+      let(:service_name) { :service_name }
+
+      before do
+        Configuration.instance.remote_services = [
+          {:namespace => namespace, :endpoint => endpoint}
+        ]
+      end
 
       describe '#valid?' do
-        subject { RemoteService.new(url).valid? }
+        subject { RemoteService.build(namespace, service_name).valid? }
 
         it { should be_true }
       end
 
       describe '#execute' do
-        subject { RemoteService.new(url, attributes).execute }
+        subject { RemoteService.build(namespace, service_name, attributes).execute }
 
-        let(:curl) { stub('curl', :body_str => '{"foo": "bar"}', :headers => [])}
+        let(:result) { {"foo" => "bar"} }
 
-        it 'should raise not implemented' do
-          Curl.expects(:post).with(url, JSON.unparse(attributes)).yields(curl).returns(curl)
-          curl.headers.expects(:[]=).with('Content-Type', 'application/json')
+        let(:transport) { stub('transport') }
 
-          subject.should == {'foo' => 'bar'}
+        it 'should raise not implemented' do
+          Transports::HttpJson.expects(:new).with(:endpoint => endpoint).returns(transport)
+          transport.expects(:call).with(service_name, attributes).returns(result)
+          
+          subject.should == result
         end
       end
     end

data/spec/lib/services/service_factory_spec.rb

@@ -6,7 +6,7 @@ module Rddd
     describe ServiceFactory do
       let(:attributes) { stub('attributes') }
 
-      let(:service_creator) do
+      let(:service_factory_strategy) do
         lambda do |name|
           class_name = "#{name.to_s.camel_case}Service"
           Services.const_get(class_name.to_sym)
@@ -22,13 +22,13 @@ module Rddd
       end
 
       describe '.build' do
-        context 'configuration service_creator given' do
+        context 'configuration service_factory_strategy given' do
           before do
-            Rddd.configure { |config| config.service_creator = service_creator }
+            Rddd.configure { |config| config.service_factory_strategy = service_factory_strategy }
           end
 
           after do
-            Rddd.configure { |config| config.service_creator = nil }
+            Rddd.configure { |config| config.service_factory_strategy = nil }
           end
 
           it 'should call the appropriate service' do
@@ -40,19 +40,19 @@ module Rddd
 
         context 'not existing service' do
           before do
-            Rddd.configure { |config| config.service_creator = service_creator }
+            Rddd.configure { |config| config.service_factory_strategy = service_factory_strategy }
           end
 
           after do
-            Rddd.configure { |config| config.service_creator = nil }
+            Rddd.configure { |config| config.service_factory_strategy = nil }
           end
 
           it { expect { ServiceFactory.build(:foo, attributes) }.to raise_exception ServiceFactory::InvalidService }
         end
 
-        context 'configuration service_creator not given' do
+        context 'configuration service_factory_strategy not given' do
           it 'should raise exception' do
-            expect { Rddd::Services::ServiceFactory.build(:create_project, attributes) }.to raise_exception Rddd::Services::ServiceFactory::CreatorNotGiven
+            expect { Rddd::Services::ServiceFactory.build(:create_project, attributes) }.to raise_exception Rddd::Services::ServiceFactory::StrategyNotGiven
           end
         end
       end

data/spec/lib/services/transports/http_json_spec.rb

@@ -0,0 +1,42 @@
+require 'spec_helper'
+require 'rddd/services/transports/http_json'
+
+module Rddd
+  module Services
+    module Transports
+      describe HttpJson do
+        let(:transport_attributes) do
+          {
+            :endpoint => 'http://remote.dev/'
+          }
+        end
+
+        let(:transport) { HttpJson.new(transport_attributes) }
+
+        describe '#call' do
+          subject { transport.call(service_name, attributes) }
+
+          let(:service_name) { :service_name }
+
+          let(:attributes) { {'foo' => 'bar'} }
+
+          let(:result) { {'foo' => 'bar'} }
+
+          let(:curl) { stub('curl', :body_str => '{"foo": "bar"}', :headers => [])}
+
+          before do
+            Curl.expects(:post) \
+            .with('http://remote.dev/service_name', JSON.unparse(attributes)) \
+            .yields(curl) \
+            .returns(curl)
+
+            curl.headers.expects(:[]=).with('Content-Type', 'application/json')
+          end
+
+
+          it { should == result }
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rddd
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-01-19 00:00:00.000000000 Z
+date: 2013-01-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: curb
@@ -74,6 +74,8 @@ files:
 - lib/rddd/services/service.rb
 - lib/rddd/services/service_bus.rb
 - lib/rddd/services/service_factory.rb
+- lib/rddd/services/transports/factory.rb
+- lib/rddd/services/transports/http_json.rb
 - lib/rddd/version.rb
 - rddd.gemspec
 - spec/integration_spec.rb
@@ -90,6 +92,7 @@ files:
 - spec/lib/services/service_bus_spec.rb
 - spec/lib/services/service_factory_spec.rb
 - spec/lib/services/service_spec.rb
+- spec/lib/services/transports/http_json_spec.rb
 - spec/spec_helper.rb
 homepage: http://blog.ngneers.com
 licenses: []
@@ -132,5 +135,6 @@ test_files:
 - spec/lib/services/service_bus_spec.rb
 - spec/lib/services/service_factory_spec.rb
 - spec/lib/services/service_spec.rb
+- spec/lib/services/transports/http_json_spec.rb
 - spec/spec_helper.rb
 has_rdoc: