rddd 0.1.7 → 0.2.0

data/lib/rddd/authorization/rule.rb

@@ -11,8 +11,8 @@ module Rddd
       #
       # Initialize.
       #
-      # @param {Symbol} Action to apply rule to.
-      # @param {Block} Block to be evaluated during authorization.
+      # @param [Symbol] Action to apply rule to.
+      # @param [Block] Block to be evaluated during authorization.
       #
       def initialize(action, &block)
         # Block should take two arguments - user and params.
@@ -26,6 +26,7 @@ module Rddd
       # Is the Rule for given action?
       #
       # @param {Symbol} Action to be matched.
+      # @private
       #
       def is_for?(action)
         @action == action

data/lib/rddd/configuration.rb

@@ -8,14 +8,14 @@ module Rddd
   class Configuration
     include Singleton
 
-    attr_writer :service_creator, :repositories_namespace
+    attr_writer :service_creator, :repository_creator
 
     def service_creator
       @service_creator
     end
 
-    def repositories_namespace
-      @repositories_namespace || Object
+    def repository_creator
+      @repository_creator
     end
   end
 end

data/lib/rddd/repository.rb

@@ -2,4 +2,15 @@
 # Repository base class.
 #
 class Rddd::Repository
+  def create(subject)
+    raise NotImplementedError
+  end
+
+  def update(subject)
+    raise NotImplementedError
+  end
+
+  def delete(subject)
+    raise NotImplementedError
+  end
 end

data/lib/rddd/repository_factory.rb

@@ -6,12 +6,15 @@ module Rddd
   end
 
   class RepositoryFactory
+    CreatorNotGiven = Class.new(RuntimeError)
+
     def self.build(clazz)
-      repository_name = "#{clazz.name.split('::').last}Repository"
-      ns = Configuration.instance.repositories_namespace
+      creator = Configuration.instance.repository_creator
+
+      raise CreatorNotGiven unless creator
 
       begin
-        repository = ns.const_get(repository_name)
+        repository = creator.call(clazz)
       rescue
         raise NotExistingRepository unless repository
       end

data/lib/rddd/service.rb

@@ -4,19 +4,27 @@
 # cooperation of multiple entities, in a given order defined by use case.
 #
 # Service takes a list of attributes, which are necessary to execute the given
-# use case. At the end nothing is returned, so service represent the command to
-# the domain, but doesn't return any data back.
+# use case. You shouldn't need to create Service directly. Instead use ServiceBus.
 #
-class Rddd::Service
-  def initialize(attributes = {})
-    @attributes = attributes
-  end
+# Its good practice to leave your service return-less. Although if you *really* need
+# something back from the service for other usage, be sure you return just data in
+# form of DTO (Hash, Array of Hashes), but no Entities and AggregateRoot or other
+# domain objects, so you dont leak business out.
+#
+# Remember dummy data goes in, dummy data goes out.
+#
+module Rddd
+  class Service
+    def initialize(attributes = {})
+      @attributes = attributes
+    end
 
-  def valid?
-    true
-  end
+    def valid?
+      true
+    end
 
-  def execute
-    raise NotImplementedError  
+    def execute
+      raise NotImplementedError  
+    end
   end
 end

data/lib/rddd/service_bus.rb

@@ -1,8 +1,6 @@
 require 'rddd/service_factory'
 
 module Rddd
-  class InvalidService < RuntimeError; end
-
   #
   # Service bus is the central entry point for execution of service within the
   # domain layer. Unless you have a very good reason, services should not be
@@ -36,15 +34,16 @@ module Rddd
     #
     # Execute the given service.
     #
-    # @param {Symbol} Service to be executed.
-    # @param {Hash} Attributes to be passed to the service call.
-    # @param {Block} Optional error callback block.
+    # @param [Symbol] service to be executed.
+    # @param [Hash] attributes to be passed to the service call.
+    # @param [Block] optional error callback block.
     #
     def execute_service(service_name, attributes = {})
-      raise InvalidService unless service = build_service(service_name, attributes)
+      service = build_service(service_name, attributes)
 
       unless service.valid?
-        yield(service.errors) and return if block_given?
+        yield(service.errors) if block_given?
+        return
       end
 
       service.execute

data/lib/rddd/service_factory.rb

@@ -2,14 +2,20 @@ require 'rddd/configuration'
 
 module Rddd
   class ServiceFactory
-    ServiceCreatorNotGiven = Class.new(RuntimeError)
+    CreatorNotGiven = Class.new(RuntimeError)
+
+    InvalidService = Class.new(RuntimeError)
 
     def self.build(name, attributes)
       creator = Configuration.instance.service_creator
 
-      raise ServiceCreatorNotGiven unless creator
+      raise CreatorNotGiven unless creator
 
-      creator.call(name).new(attributes)
+      begin
+        creator.call(name).new(attributes)
+      rescue
+        raise Rddd::ServiceFactory::InvalidService
+      end
     end
   end
 end

data/lib/rddd/version.rb

@@ -1,3 +1,3 @@
 module Rddd
-  VERSION = "0.1.7"
+  VERSION = "0.2.0"
 end

data/spec/integration_spec.rb

@@ -32,16 +32,36 @@ class ProjectsController
 end
 
 describe 'CreateProject' do
-  it 'should call project save' do
+  let(:repository_creator) do
+    lambda do |name|
+      class_name = "#{name.to_s.camel_case}Repository"
+      Object.const_get(class_name.to_sym)
+    end
+  end
+
+  before do
     Rddd.configure do |config|
+      config.repository_creator = repository_creator
+
       config.service_creator = lambda do |name|
         class_name = "#{name.to_s.camel_case}Service"
         Object.const_get(class_name.to_sym)
       end
     end
-
+  end
+  
+  it 'should call project save' do
     ProjectRepository.any_instance.expects(:create)
 
     ProjectsController.new.create(:id => 1, :name => 'Rddd')
-  end  
+  end
+end
+
+describe 'NotExistingService' do
+  it 'should raise' do
+    controller = Object.new
+    controller.extend Rddd::ServiceBus
+
+    expect { controller.execute_service(:foo) }.to raise_exception Rddd::ServiceFactory::InvalidService
+  end
 end

data/spec/lib/repository_factory_spec.rb

@@ -1,34 +1,46 @@
 require 'spec_helper'
-require 'rddd/entity'
 require 'rddd/repository_factory'
 
 describe Rddd::RepositoryFactory do
-  describe '.build' do
-    subject { Rddd::RepositoryFactory.build(Rddd::Entity) }
+  let(:project) { stub('project', :name => 'Foo', :class => stub(:name => 'Foo')) }
 
-    context 'with existing repository' do
-      before do
-        Rddd.const_set(:Repositories, Module.new)
-        Rddd::Repositories.const_set(:EntityRepository, Class.new)
+  let(:repository_creator) do
+    lambda do |clazz|
+      class_name = "#{clazz.name.to_s.camel_case}Repository"
+      Rddd::Repositories.const_get(class_name.to_sym)
+    end
+  end
 
-        Rddd.configure { |config| config.repositories_namespace = Rddd::Repositories }
+  before do
+    Rddd.const_set(:Repositories, Module.new)
+    Rddd::Repositories.const_set(:FooRepository, Class.new)
+  end
+
+  after do
+    Rddd::Repositories.class_eval { remove_const(:FooRepository) }
+    Rddd.class_eval { remove_const(:Repositories) }
+  end
+
+  describe '.build' do
+    context 'configuration repository_creator given' do
+      before do
+        Rddd.configure { |config| config.repository_creator = repository_creator }
       end
-      
-      after do
-        Rddd::Repositories.class_eval {remove_const(:EntityRepository)}
-        Rddd.class_eval {remove_const(:Repositories)}
 
-        Rddd.configure { |config| config.repositories_namespace = Object }
+      after do
+        Rddd.configure { |config| config.repository_creator = nil }
       end
 
-      it 'should return instance of repository' do
-        should be_kind_of Rddd::Repositories::EntityRepository
+      it 'should call the appropriate service' do
+        Rddd::Repositories::FooRepository.expects(:new)
+
+        Rddd::RepositoryFactory.build(project.class)
       end
     end
 
-    context 'with not existing repository' do
-      it 'should raise NotExistingRepository' do
-        lambda { subject }.should raise_exception Rddd::NotExistingRepository
+    context 'configuration repository_creator not given' do
+      it 'should raise exception' do
+        expect { Rddd::RepositoryFactory.build(project.class) }.to raise_exception Rddd::RepositoryFactory::CreatorNotGiven
       end
     end
   end

data/spec/lib/repository_spec.rb

@@ -2,4 +2,25 @@ require 'spec_helper'
 require 'rddd/repository'
 
 describe Rddd::Repository do
+  let(:repository) { Rddd::Repository.new }
+
+  let(:aggregate_root) { stub('aggregate_root') }
+
+  describe '#create' do
+    subject { repository.create(aggregate_root) }
+
+    it { expect { subject }.to raise_exception NotImplementedError }
+  end
+
+  describe '#update' do
+    subject { repository.update(aggregate_root) }
+
+    it { expect { subject }.to raise_exception NotImplementedError }
+  end
+
+  describe '#delete' do
+    subject { repository.delete(aggregate_root) }
+
+    it { expect { subject }.to raise_exception NotImplementedError }
+  end
 end

data/spec/lib/service_bus_spec.rb

@@ -22,15 +22,6 @@ describe Rddd::ServiceBus do
       end
     end
 
-    context 'not-existing service' do
-      it do
-        Rddd::ServiceFactory.expects(:build).with(:foo, attributes).returns(nil)
-        service.expects(:execute).never
-
-        lambda { subject }.should raise_exception Rddd::InvalidService
-      end
-    end
-
     context 'not valid call to service' do
       context 'without block' do
         before { service.stubs(:valid?).returns(false) }

data/spec/lib/service_factory_spec.rb

@@ -38,9 +38,21 @@ describe Rddd::ServiceFactory do
       end
     end
 
+    context 'not existing service' do
+      before do
+        Rddd.configure { |config| config.service_creator = service_creator }
+      end
+
+      after do
+        Rddd.configure { |config| config.service_creator = nil }
+      end
+
+      it { expect { Rddd::ServiceFactory.build(:foo, attributes) }.to raise_exception Rddd::ServiceFactory::InvalidService }
+    end
+
     context 'configuration service_creator not given' do
       it 'should raise exception' do
-        expect { Rddd::ServiceFactory.build(:create_project, attributes) }.to raise_exception Rddd::ServiceFactory::ServiceCreatorNotGiven
+        expect { Rddd::ServiceFactory.build(:create_project, attributes) }.to raise_exception Rddd::ServiceFactory::CreatorNotGiven
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rddd
 version: !ruby/object:Gem::Version
-  version: 0.1.7
+  version: 0.2.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-12-16 00:00:00.000000000 Z
+date: 2012-12-18 00:00:00.000000000 Z
 dependencies: []
 description: Ruby DDD framework
 email:
@@ -18,6 +18,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- .DS_Store
 - .gitignore
 - .rspec
 - .rvmrc
@@ -96,3 +97,4 @@ test_files:
 - spec/lib/service_factory_spec.rb
 - spec/lib/service_spec.rb
 - spec/spec_helper.rb
+has_rdoc: