rcurtain 0.0.6 → 0.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c0d1c0160c429935d3c5914e8c57a6b6805e3ccf
-  data.tar.gz: d84a09c17059baf9415911910cb94ff6b66e5e15
+  metadata.gz: 8436c1d1dcc6db394c86cb23f35bcc81a751a733
+  data.tar.gz: d1dab0bfc9583de833028b1f1d68d6825084fe81
 SHA512:
-  metadata.gz: e9f0581952fa609e43d3af905752976677cc2783a5cf1c1c5f42a03f6d3f6635d1c4720943daa686c46e4de520ba85f08ffad307c277838fa58b6f4e99d4b207
-  data.tar.gz: 5e763482a914a03bcffa5c321ec97399033a44486f8c2ad8f26e4dfae69f32efbe0fdf4e2d982104a856659bb9082009fc200741b3986c6d3aba70316bbbf39e
+  metadata.gz: f6800bc06b564ec03b2ce45017de7dc90153354431e4c4cbbd58e9002e54798b22f74ea13ae353a32cb48c8ee1180ca1e331c62f5868c6066f049713fe5a179b
+  data.tar.gz: c7f45e084617cf7402e4792e7ea7ade49cce134ce735edd520f88e4be4871e8b9584e08873afe766a43f5aeb3305f39544119609ce949fc3ffc2474377b7446f

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rcurtain (0.0.4)
+    rcurtain (0.0.6)
       hiredis
       redis (~> 3.2)
 
@@ -9,8 +9,10 @@ GEM
   remote: https://rubygems.org/
   specs:
     diff-lcs (1.2.5)
+    fakeredis (0.7.0)
+      redis (>= 3.2, < 5.0)
     hiredis (0.6.1)
-    redis (3.3.3)
+    redis (3.3.5)
     rspec (3.4.0)
       rspec-core (~> 3.4.0)
       rspec-expectations (~> 3.4.0)
@@ -29,8 +31,9 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
+  fakeredis
   rcurtain!
   rspec
 
 BUNDLED WITH
-   1.12.3
+   1.16.0

data/lib/rcurtain/curtain.rb

@@ -10,12 +10,8 @@ module Rcurtain
       @redis = Redis.new(:url => Rcurtain.configuration.url)
     end
 
-    def opened? (feature, users = [])
-      feat = get_feature(feature)
-
-      return (compare_percentage?(feat.percentage)) || (users.any? { |user| feat.users.include?(user)}) unless users.empty?
-
-      compare_percentage?(feat.percentage)
+    def opened?(feature, users = [])
+      compare_percentage?(percentage(feature)) || users_enabled?(feature, users)
     rescue Redis::CannotConnectError
       return Rcurtain.configuration.default_response
     end
@@ -23,7 +19,7 @@ module Rcurtain
     def get_users(feature)
       get_feature(feature).users
     rescue Redis::CannotConnectError
-        Rcurtain.configuration.default_response    
+        Rcurtain.configuration.default_response
     end
 
     private
@@ -35,10 +31,22 @@ module Rcurtain
         return Feature.new(name, percentage, users)
       end
 
+      def users_enabled?(feature_name, users = [])
+        return false if invalid_users?(users)
+        users.all? { |user| redis.sismember("feature:#{feature_name}:users", user) }
+      end
+
+      def invalid_users?(users)
+        users.nil? || users.empty?
+      end
+
+      def percentage(feature_name)
+        redis.get("feature:#{feature_name}:percentage") || 0
+      end
+
       def compare_percentage? (percentage)
         rnd = Random.new
         rnd.rand(1..100) <= percentage.to_f
       end
-
   end
 end

data/rcurtain.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name        = 'rcurtain'
-  s.version     = '0.0.6'
+  s.version     = '0.0.7'
   s.date        = '2017-07-03'
   s.summary     = "RCurtain"
   s.description = "Open the curtain and see if your feature is enabled"
@@ -15,5 +15,6 @@ Gem::Specification.new do |s|
 
   s.add_runtime_dependency "hiredis"
   s.add_runtime_dependency "redis", "~>3.2"
+  s.add_development_dependency 'fakeredis'
   s.add_development_dependency "rspec"
 end

data/spec/lib/curtain_spec.rb

@@ -1,4 +1,5 @@
 require "spec_helper"
+require 'fakeredis/rspec'
 
 describe Rcurtain do
 
@@ -15,7 +16,7 @@ describe Rcurtain do
     context "when 100%" do
       before do
         allow_any_instance_of(Redis).to receive(:get).and_return(100)
-        allow_any_instance_of(Redis).to receive(:smembers).and_return(nil)
+        allow_any_instance_of(Redis).to receive(:sismember).and_return(false)
       end
 
       it { expect(rcurtain.opened? "feature").to be true }
@@ -24,7 +25,7 @@ describe Rcurtain do
     context "when user exists" do
       before do
         allow_any_instance_of(Redis).to receive(:get).and_return(0)
-        allow_any_instance_of(Redis).to receive(:smembers).and_return(['MPA-123'])
+        allow_any_instance_of(Redis).to receive(:sismember).and_return(true)
       end
 
       it { expect(rcurtain.opened?("feature", ['MPA-123'])).to be true }
@@ -77,4 +78,4 @@ describe Rcurtain do
     it { expect(rcurtain.get_users("feature")).to eq ['123', '321']}
   end
 
-end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rcurtain
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.0.7
 platform: ruby
 authors:
 - Danillo Souza
@@ -40,6 +40,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.2'
+- !ruby/object:Gem::Dependency
+  name: fakeredis
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -70,6 +84,7 @@ files:
 - lib/rcurtain/configuration.rb
 - lib/rcurtain/curtain.rb
 - lib/rcurtain/feature.rb
+- rcurtain-0.0.6.gem
 - rcurtain.gemspec
 - spec/lib/configuration_spec.rb
 - spec/lib/curtain_spec.rb
@@ -94,7 +109,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.6.14
 signing_key: 
 specification_version: 4
 summary: RCurtain