rc_rails 2.1.0

data/spec/controllers/comments_controller_spec.rb

@@ -0,0 +1,380 @@
+require 'spec_helper'
+
+module CommentsSpecHelper
+  def setup_mocks
+    @forum = mock('Forum')
+    @forum_posts = mock('Assoc: forum_posts')
+    @forum.stub!(:posts).and_return(@forum_posts)
+    @forum.stub!(:to_param).and_return("3")
+    
+    @post = mock('Post')
+    @post_comments = mock('Assoc: post_comments')
+    @post.stub!(:comments).and_return(@post_comments)
+    @post.stub!(:to_param).and_return("2")
+        
+    Forum.stub!(:find).and_return(@forum)
+    @forum_posts.stub!(:find).and_return(@post)
+  end
+end
+
+describe CommentsController do
+  describe "Routing shortcuts for Comments (forums/3/posts/2/comments/1) should map" do
+    include CommentsSpecHelper
+  
+    before(:each) do
+      setup_mocks
+      @comment = mock('Comment')
+      @comment.stub!(:to_param).and_return("1")
+      @post_comments.stub!(:find).and_return(@comment)
+      get :show, :forum_id => "3", :post_id => "2", :id => "1"
+    end
+  
+    it "resources_path to /forums/3/posts/2/comments" do
+      controller.resources_path.should == '/forums/3/posts/2/comments'
+    end
+
+    it "resource_path to /forums/3/posts/2/comments/1" do
+      controller.resource_path.should == '/forums/3/posts/2/comments/1'
+    end
+  
+    it "resource_path(9) to /forums/3/posts/2/comments/9" do
+      controller.resource_path(9).should == '/forums/3/posts/2/comments/9'
+    end
+
+    it "edit_resource_path to /forums/3/posts/2/comments/1/edit" do
+      controller.edit_resource_path.should == '/forums/3/posts/2/comments/1/edit'
+    end
+  
+    it "edit_resource_path(9) to /forums/3/posts/2/comments/9/edit" do
+      controller.edit_resource_path(9).should == '/forums/3/posts/2/comments/9/edit'
+    end
+  
+    it "new_resource_path to /forums/3/posts/2/comments/new" do
+      controller.new_resource_path.should == '/forums/3/posts/2/comments/new'
+    end
+  
+    it "resource_tags_path to /forums/3/posts/2/comments/1/tags" do
+      controller.resource_tags_path.should == "/forums/3/posts/2/comments/1/tags"
+    end
+
+    it "resource_tags_path(9) to /forums/3/posts/2/comments/9/tags" do
+      controller.resource_tags_path(9).should == "/forums/3/posts/2/comments/9/tags" 
+    end
+  
+    it "resource_tag_path(5) to /forums/3/posts/2/comments/1/tags/5" do
+      controller.resource_tag_path(5).should == "/forums/3/posts/2/comments/1/tags/5"
+    end
+  
+    it "resource_tag_path(9,5) to /forums/3/posts/2/comments/9/tags/5" do
+      controller.resource_tag_path(9,5).should == "/forums/3/posts/2/comments/9/tags/5"
+    end
+  end
+
+  describe "resource_service in CommentsController" do
+  
+    before(:each) do
+      @forum          = Forum.create
+      @post           = Post.create :forum_id => @forum.id
+      @comment        = Comment.create :post_id => @post.id, :user => User.create
+      @other_post     = Post.create :forum_id => @forum.id
+      @other_comment  = Comment.create :post_id => @other_post.id
+    
+      get :index, :forum_id => @forum.id, :post_id => @post.id
+      @resource_service = controller.send :resource_service
+    end
+  
+    it "should build new comment with @post foreign key with new" do
+      resource = @resource_service.new
+      resource.should be_kind_of(Comment)
+      resource.post_id.should == @post.id
+    end
+  
+    it "should find @comment with find(@comment.id)" do
+      resource = @resource_service.find(@comment.id)
+      resource.should == @comment
+    end
+  
+    it "should raise RecordNotFound with find(@other_post.id)" do
+      lambda{ @resource_service.find(@other_comment.id) }.should raise_error(ActiveRecord::RecordNotFound)
+    end
+
+    it "should find only comments belonging to @post with find(:all)" do
+      resources = @resource_service.find(:all)
+      resources.should be == Comment.find(:all, :conditions => "post_id = #{@post.id}")
+    end
+  end
+
+  describe "Requesting /forums/3/posts/2/comments (testing the before filters)" do
+    include CommentsSpecHelper
+  
+    before(:each) do
+      setup_mocks
+      @comments = mock('Comments')
+      @post_comments.stub!(:all).and_return(@comments)
+    end
+  
+    def do_get
+      get :index, :forum_id => '3', :post_id => '2'
+    end
+    
+    it "should find the forum" do
+      Forum.should_receive(:find).with('3').and_return(@forum)
+      do_get
+    end
+  
+    it "should assign the found forum for the view" do
+      do_get
+      assigns[:forum].should == @forum
+    end
+  
+    it "should find the post" do
+      @forum.should_receive(:posts).and_return(@forum_posts)
+      @forum_posts.should_receive(:find).with('2').and_return(@post)
+      do_get
+    end
+  
+    it "should assign the found post for the view" do
+      do_get
+      assigns[:post].should == @post
+    end
+  
+    it "should assign the post_comments association as the comments resource_service" do
+      @post.should_receive(:comments).and_return(@post_comments)
+      do_get
+      @controller.resource_service.should == @post_comments
+    end
+  end
+
+  describe "Requesting /forums/3/posts/2/comments using GET" do
+    include CommentsSpecHelper
+
+    before(:each) do
+      setup_mocks
+      @comments = mock('Comments')
+      @post_comments.stub!(:all).and_return(@comments)
+    end
+  
+    def do_get
+      get :index, :forum_id => '3', :post_id => '2'
+    end
+  
+    it "should be successful" do
+      do_get
+      response.should be_success
+    end
+
+    it "should render index.rhtml" do
+      do_get
+      response.should render_template(:index)
+    end
+  
+    it "should find comments in post" do
+      @post_comments.should_receive(:all).and_return(@comments)
+      do_get
+    end
+  
+    it "should assign the found comments for the view" do
+      do_get
+      assigns[:comments].should == @comments
+    end
+  end
+
+  describe "Requesting /forums/3/posts/3/comments/1 using GET" do
+    include CommentsSpecHelper
+
+    before(:each) do
+      setup_mocks
+      @comment = mock('a post')
+      @post_comments.stub!(:find).and_return(@comment)
+    end
+  
+    def do_get
+      get :show, :id => "1", :forum_id => '3', :post_id => '2'
+    end
+
+    it "should be successful" do
+      do_get
+      response.should be_success
+    end
+  
+    it "should render show.rhtml" do
+      do_get
+      response.should render_template(:show)
+    end
+  
+    it "should find the comment requested" do
+      @post_comments.should_receive(:find).with("1").and_return(@comment)
+      do_get
+    end
+  
+    it "should assign the found comment for the view" do
+      do_get
+      assigns[:comment].should == @comment
+    end
+  end
+
+  describe "Requesting /forums/3/posts/3/comments/new using GET" do
+    include CommentsSpecHelper
+
+    before(:each) do
+      setup_mocks
+      @comment = mock('new Comment')
+      @post_comments.stub!(:build).and_return(@comment)
+    end
+  
+    def do_get
+      get :new, :forum_id => '3', :post_id => '2'
+    end
+
+    it "should be successful" do
+      do_get
+      response.should be_success
+    end
+  
+    it "should render new.rhtml" do
+      do_get
+      response.should render_template(:new)
+    end
+  
+    it "should build a new comment" do
+      @post_comments.should_receive(:build).and_return(@comment)
+      do_get
+    end
+  
+    it "should not save the new comment" do
+      @comment.should_not_receive(:save)
+      do_get
+    end
+  
+    it "should assign the new comment for the view" do
+      do_get
+      assigns[:post].should == @post
+    end
+  end
+
+  describe "Requesting /forums/3/posts/3/comments/1/edit using GET" do
+    include CommentsSpecHelper
+
+    before(:each) do
+      setup_mocks
+      @comment = mock('Comment')
+      @post_comments.stub!(:find).and_return(@comment)
+    end
+ 
+    def do_get
+      get :edit, :id => "1", :forum_id => '3', :post_id => '2'
+    end
+
+    it "should be successful" do
+      do_get
+      response.should be_success
+    end
+  
+    it "should render edit.rhtml" do
+      do_get
+      response.should render_template(:edit)
+    end
+  
+    it "should find the comment requested" do
+      @post_comments.should_receive(:find).with("1").and_return(@comment)
+      do_get
+    end
+  
+    it "should assign the found comment for the view" do
+      do_get
+      assigns(:comment).should == @comment
+    end
+  end
+
+  describe "Requesting /forums/3/posts/3/comments using POST" do
+    include CommentsSpecHelper
+
+    before(:each) do
+      setup_mocks
+      @comment = mock('Comment')
+      @comment.stub!(:save).and_return(true)
+      @comment.stub!(:to_param).and_return("1")
+      @post_comments.stub!(:build).and_return(@comment)
+    end
+  
+    def do_post
+      post :create, :comment => {:name => 'Comment'}, :forum_id => '3', :post_id => '2'
+    end
+  
+    it "should build a new comment" do
+      @post_comments.should_receive(:build).with({'name' => 'Comment'}).and_return(@comment)
+      do_post
+    end
+
+    it "should redirect to the new comment" do
+      do_post
+      response.should be_redirect
+      response.redirect_url.should == "http://test.host/forums/3/posts/2/comments/1"
+    end
+  end
+
+  describe "Requesting /forums/3/posts/3/comments/1 using PUT" do
+    include CommentsSpecHelper
+
+    before(:each) do
+      setup_mocks
+      @comment = mock('Comment').as_null_object
+      @comment.stub!(:to_param).and_return("1")
+      @post_comments.stub!(:find).and_return(@comment)
+    end
+  
+    def do_update
+      put :update, :id => "1", :forum_id => '3', :post_id => '2'
+    end
+  
+    it "should find the comment requested" do
+      @post_comments.should_receive(:find).with("1").and_return(@comment)
+      do_update
+    end
+
+    it "should update the found comment" do
+      @comment.should_receive(:update_attributes).and_return(true)
+      do_update
+    end
+
+    it "should assign the found comment for the view" do
+      do_update
+      assigns(:comment).should == @comment
+    end
+
+    it "should redirect to the comment" do
+      do_update
+      response.should be_redirect
+      response.redirect_url.should == "http://test.host/forums/3/posts/2/comments/1"
+    end
+  end
+
+
+  describe "Requesting /forums/3/posts/3/comments/1 using DELETE" do
+    include CommentsSpecHelper
+
+    before(:each) do
+      setup_mocks
+      @comment = mock('Comment', :id => '1').as_null_object
+      @post_comments.stub!(:find).and_return(@comment)
+      @post_comments.stub!(:destroy)
+    end
+  
+    def do_delete
+      delete :destroy, :id => "1", :forum_id => '3', :post_id => '2'
+    end
+
+    it "should find and destroy the comment requested" do
+      @post_comments.should_receive(:find).with("1").and_return(@comment)
+      @post_comments.should_receive(:destroy).with("1")
+      do_delete
+      assigns['comment'].should == @comment
+    end
+  
+    it "should redirect to the comments list" do
+      do_delete
+      response.should be_redirect
+      response.redirect_url.should == "http://test.host/forums/3/posts/2/comments"
+    end
+  end
+end

data/spec/controllers/comments_controller_with_models_spec.rb

@@ -0,0 +1,202 @@
+require 'spec_helper'
+
+describe CommentsController, "without stubs" do
+  before do
+    @user = User.create!
+    @forum = Forum.create!
+    @post = Post.create! :forum => @forum
+    @comment = Comment.create! :user => @user, :post => @post
+  end
+  
+  describe "responding to GET index" do
+    def do_get
+      get :index, :forum_id => @forum.id, :post_id => @post.id
+    end
+    
+    it "should expose all comments as @comments" do
+      do_get
+      assigns[:comments].should == [@comment]
+    end
+
+    describe "with mime type of xml" do
+      it "should render all comments as xml" do
+        request.env["HTTP_ACCEPT"] = "application/xml"
+        do_get
+        response.body.should == [@comment].to_xml
+      end
+    end
+  end
+
+  describe "responding to GET show" do
+    def do_get
+      get :show, :id => @comment.id, :forum_id => @forum.id, :post_id => @post.id
+    end
+    
+    it "should expose the requested comment as @comment" do
+      do_get
+      assigns[:comment].should == @comment
+    end
+    
+    describe "with mime type of xml" do
+      it "should render the requested comment as xml" do
+        request.env["HTTP_ACCEPT"] = "application/xml"
+        do_get
+        response.body.should == @comment.to_xml
+      end
+    end
+  end
+
+  describe "responding to GET new" do
+    def do_get
+      get :new, :forum_id => @forum.id, :post_id => @post.id
+    end
+  
+    it "should expose a new comment as @comment" do
+      do_get
+      assigns[:comment].should be_new_record
+      assigns[:comment].post.should == @post
+    end
+  end
+
+  describe "responding to GET edit" do
+    def do_get
+      get :edit, :id => @comment.id, :forum_id => @forum.id, :post_id => @post.id
+    end
+    
+    it "should expose the requested comment as @comment" do
+      do_get
+      assigns[:comment].should == @comment
+    end
+  end
+
+  describe "responding to POST create" do
+    describe "with valid params" do
+      def do_post
+        post :create, :forum_id => @forum.id, :post_id => @post.id, :comment => {:user_id => @user.id}
+      end
+      
+      it "should create a comment" do
+        lambda { do_post }.should change(Comment, :count).by(1)
+      end
+      
+      it "should expose the newly created comment as @comment" do
+        do_post
+        assigns(:comment).should == Comment.find(:first, :order => 'id DESC')
+      end
+
+      it "should be resource_saved?" do
+        do_post
+        @controller.should be_resource_saved
+      end
+      
+      it "should redirect to the created comment" do
+        do_post
+        response.should redirect_to(forum_post_comment_url(@forum, @post, Comment.find(:first, :order => 'id DESC')))
+      end
+    end
+    
+    describe "with invalid params" do
+      def do_post
+        post :create, :forum_id => @forum.id, :post_id => @post.id, :comment => {:user_id => ''}
+      end
+
+      it "should not create a comment" do
+        lambda { do_post }.should_not change(Comment, :count)
+      end
+ 
+      it "should expose a newly created but unsaved comment as @comment" do
+        do_post
+        assigns(:comment).should be_new_record
+        assigns(:comment).post.should == @post
+      end
+
+      it "should not be resource_saved?" do
+        do_post
+        @controller.should_not be_resource_saved
+      end
+
+      it "should re-render the 'new' template" do
+        do_post
+        response.should render_template('new')
+      end
+    end
+  end
+
+  describe "responding to PUT udpate" do
+    describe "with valid params" do
+      before do
+        @new_user = User.create!
+      end
+      
+      def do_put
+        put :update, :id => @comment.id, :forum_id => @forum.id, :post_id => @post.id, :comment => {:user_id => @new_user.id}
+      end
+
+      it "should update the requested comment" do
+        do_put
+        Comment.find(@comment.id).user_id.should == @new_user.id
+      end
+
+      it "should not contain errors on comment" do
+        do_put
+        @comment.errors.should be_empty
+      end
+      
+      it "should be resource_saved?" do
+        do_put
+        @controller.should be_resource_saved
+      end
+      
+      it "should expose the requested comment as @comment" do
+        do_put
+        assigns[:comment].should == @comment
+      end
+
+      it "should redirect to the comment" do
+        do_put
+        response.should redirect_to(forum_post_comment_url(@forum, @post, @comment))
+      end
+    end
+    
+    describe "with invalid params" do
+      def do_put
+        put :update, :id => @comment.id, :forum_id => @forum.id, :post_id => @post.id, :comment => {:user_id => ''}
+      end
+
+      it "should fail to update the requested comment" do
+        do_put
+        Comment.find(@comment.id).user_id.should == @user.id 
+      end
+
+      it "should not be resource_saved?" do
+        do_put
+        @controller.should_not be_resource_saved
+      end
+      
+      it "should expose the requested comment as @comment" do
+        do_put
+        assigns[:comment].should == @comment
+      end
+
+      it "should re-render the 'edit' template" do
+        do_put
+        response.should render_template('edit')
+      end
+    end
+  end
+
+  describe "responding to DELETE destroy" do
+    def do_delete
+      delete :destroy, :id => @comment.id, :forum_id => @forum.id, :post_id => @post.id
+    end
+    
+    it "should delete the requested comment" do
+      lambda { do_delete }.should change(Comment, :count).by(-1)
+    end
+
+    it "should redirect to the comments list" do
+      do_delete
+      response.should redirect_to(forum_post_comments_url(@forum, @post))
+    end
+  end
+end