rbtc_arbitrage 1.4.6 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 62369ae5921161c77cf12861468a5a030c341501
-  data.tar.gz: 455e70c7cef5c338ad71b61fde1f83748b7afbd2
+  metadata.gz: 835177735b2d220e4b1ef228124f49b09fa9ad45
+  data.tar.gz: 0418bcfd189c5e7f8d693cc550c449e7efa200bf
 SHA512:
-  metadata.gz: 6b4fc22945496444b7fcb510bb5f8e3b22ac1c35f14c35d384cffd72d9c700a7ffe5e80b776ba114522a8c2beaff0120275f26a7f28947372479e02ac29433f7
-  data.tar.gz: fc36f51cac71e6e4ed8ff34d566d8ba884c57e5dc4ba436f942ba790da274bc9b279918a232cbe157b33a83ab6fc41ffd8817937d27538bfeb74eb48cf012601
+  metadata.gz: a28ac69bfc9ae19adc1c2ad6fb2a7e265be0ca83aea5880291ed77aed2493b35d4aff366bd5ad3276520a216a150fa06e246c85a82787d0d8958c6af399b4578
+  data.tar.gz: 86a46a9bc74c016967f81b1478bf220b91f19b7a612e222785289ef66306c0ae8859ba3bbcf2a34e48935ab945fd130bbcf21f3109b189bbd6164fb48da44724

data/.gitmodules

@@ -0,0 +1,3 @@
+[submodule "bitstamp"]
+	path = bitstamp
+	url = https://github.com/kojnapp/bitstamp.git

data/Gemfile

@@ -2,17 +2,20 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in rbtc_arbitrage.gemspec
 gemspec
-gem 'rspec'
-gem "activemodel", ">= 3.1"
-gem "activesupport", ">= 3.1"
-gem 'guard'
-gem 'ruby_gntp'
-# gem 'awesome_print'
-gem 'guard-rspec'
-gem 'simplecov'
-gem 'coveralls', require: false
-gem "webmock"
-gem 'vcr'
-gem 'codeclimate-test-reporter'
-gem 'hashie'
-gem 'sinatra'
+group :development do
+  gem 'rspec'
+  gem "activemodel", ">= 3.1"
+  gem "activesupport", ">= 3.1"
+  gem 'guard'
+  gem 'ruby_gntp'
+  # gem 'awesome_print'
+  gem 'guard-rspec'
+  gem 'simplecov'
+  gem 'coveralls', require: false
+  gem "webmock"
+  gem 'vcr'
+  gem 'codeclimate-test-reporter'
+  gem 'hashie'
+  gem 'sinatra'
+end
+gem 'bitstamp', path: '../bitstamp'

data/Gemfile.lock

@@ -1,37 +1,38 @@
 PATH
   remote: .
   specs:
-    rbtc_arbitrage (1.4.6)
+    rbtc_arbitrage (2.0.0)
       activemodel (>= 3.1)
       activesupport (>= 3.1)
-      bitstamp
-      bitstamp
       btce (= 0.2.4)
       coinbase (= 1.2.6)
       faraday (= 0.8.8)
-      mtgox
       pony
       thor
 
+PATH
+  remote: ../bitstamp
+  specs:
+    bitstamp (0.4.0)
+      activemodel (>= 3.1)
+      activesupport (>= 3.1)
+      curb (> 0.8.1)
+      ruby-hmac (= 0.4.0)
+
 GEM
   remote: https://rubygems.org/
   specs:
-    activemodel (4.0.2)
-      activesupport (= 4.0.2)
+    activemodel (4.0.4)
+      activesupport (= 4.0.4)
       builder (~> 3.1.0)
-    activesupport (4.0.2)
-      i18n (~> 0.6, >= 0.6.4)
+    activesupport (4.0.4)
+      i18n (~> 0.6, >= 0.6.9)
       minitest (~> 4.2)
       multi_json (~> 1.3)
       thread_safe (~> 0.1)
       tzinfo (~> 0.3.37)
     addressable (2.3.5)
-    atomic (1.1.14)
-    bitstamp (0.3.0)
-      activemodel (>= 3.1)
-      activesupport (>= 3.1)
-      curb (> 0.8.1)
-      ruby-hmac (= 0.4.0)
+    atomic (1.1.16)
     btce (0.2.4)
       monkey-patch
     builder (3.1.4)
@@ -70,7 +71,7 @@ GEM
       guard (>= 2.1.1)
       rspec (~> 3.0.0.beta, >= 2.14, < 4.0)
     hashie (2.0.5)
-    httparty (0.12.0)
+    httparty (0.13.0)
       json (~> 1.8)
       multi_xml (>= 0.5.2)
     i18n (0.6.9)
@@ -89,16 +90,13 @@ GEM
     minitest (4.7.5)
     money (5.1.1)
       i18n (~> 0.6.0)
-    monkey-patch (0.0.14)
+    monkey-patch (0.0.16)
       activesupport
-    mtgox (1.1.0)
-      faraday (~> 0.8, < 0.10)
-      json (~> 1.7, >= 1.7.7)
-    multi_json (1.8.2)
+    multi_json (1.9.2)
     multi_xml (0.5.5)
     multipart-post (1.2.0)
-    polyglot (0.3.3)
-    pony (1.6.2)
+    polyglot (0.3.4)
+    pony (1.8)
       mail (>= 2.0)
     pry (0.9.12.4)
       coderay (~> 1.0)
@@ -141,15 +139,14 @@ GEM
     term-ansicolor (1.2.2)
       tins (~> 0.8)
     thor (0.18.1)
-    thread_safe (0.1.3)
-      atomic
+    thread_safe (0.3.1)
+      atomic (>= 1.1.7, < 2)
     tilt (1.4.1)
     timers (1.1.0)
     tins (0.13.1)
-    treetop (1.4.15)
-      polyglot
-      polyglot (>= 0.3.1)
-    tzinfo (0.3.38)
+    treetop (1.5.3)
+      polyglot (~> 0.3)
+    tzinfo (0.3.39)
     vcr (2.8.0)
     webmock (1.16.1)
       addressable (>= 2.2.7)
@@ -161,6 +158,7 @@ PLATFORMS
 DEPENDENCIES
   activemodel (>= 3.1)
   activesupport (>= 3.1)
+  bitstamp!
   bundler (~> 1.3)
   codeclimate-test-reporter
   coveralls

data/lib/rbtc_arbitrage.rb

@@ -1,7 +1,7 @@
+require 'bundler'
+Bundler.require(:default)
 require 'thor'
-require 'mtgox'
 require_relative 'rbtc_arbitrage/campbx.rb'
-require 'bitstamp'
 require 'btce'
 require 'coinbase'
 require 'pony'

data/lib/rbtc_arbitrage/cli.rb

@@ -7,7 +7,7 @@ module RbtcArbitrage
     option :volume, type: :numeric, default: 0.01, desc: "The amount of bitcoins to trade per transaction."
     option :verbose, type: :boolean, default: true, desc: "Whether you wish to log information."
     option :buyer, type: :string, default: "bitstamp"
-    option :seller, type: :string, default: "mtgox"
+    option :seller, type: :string, default: "campbx"
     option :repeat, type: :numeric, default: nil
     option :notify, type: :boolean, default: false
     def trade

data/lib/rbtc_arbitrage/trader.rb

@@ -22,7 +22,7 @@ module RbtcArbitrage
       set_key opts, :notify, false
       exchange = opts[:buyer] || :bitstamp
       @buy_client = client_for_exchange(exchange)
-      exchange = opts[:seller] || :mtgox
+      exchange = opts[:seller] || :campbx
       @sell_client = client_for_exchange(exchange)
       self
     end
@@ -94,7 +94,13 @@ module RbtcArbitrage
       logger.info "#{higher_ex}: $#{seller[:price].round(2)}"
       logger.info "buying #{@options[:volume]} btc from #{lower_ex} for $#{@paid.round(2)}"
       logger.info "selling #{@options[:volume]} btc on #{higher_ex} for $#{@received.round(2)}"
-      logger.info "profit: $#{(@received - @paid).round(2)} (#{@percent.round(2)}%)"
+
+      profit_msg = "profit: $#{(@received - @paid).round(2)} (#{@percent.round(2)}%)"
+      if cutoff = @options[:cutoff]
+        profit_msg << " is #{@percent < cutoff ? 'below' : 'above'} cutoff"
+        profit_msg << " of #{cutoff}%."
+      end
+      logger.info profit_msg
     end
 
     def get_balance

data/lib/rbtc_arbitrage/version.rb

@@ -1,3 +1,3 @@
 module RbtcArbitrage
-  VERSION = "1.4.6"
+  VERSION = "2.0.0"
 end

data/rbtc_arbitrage.gemspec

@@ -21,14 +21,12 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"
 
-  spec.add_dependency "mtgox"
   spec.add_dependency "faraday", "0.8.8"
-  spec.add_dependency "bitstamp"
+  # spec.add_dependency "bitstamp"
   spec.add_dependency "activemodel", ">= 3.1"
   spec.add_dependency "activesupport", ">= 3.1"
   spec.add_dependency "thor"
   spec.add_dependency "btce", '0.2.4'
-  spec.add_dependency "bitstamp"
   spec.add_dependency "coinbase", '1.2.6'
   spec.add_dependency "pony"
 end

data/spec/clients/bitstamp_client_spec.rb

@@ -44,8 +44,8 @@ describe RbtcArbitrage::Clients::BitstampClient do
   end
 
   describe "#transfer" do
-    it "calls Bitstamp correctly" do
-      sell_client = RbtcArbitrage::Clients::MtGoxClient.new
+    it "calls Bitstamp correctly", :vcr do
+      sell_client = RbtcArbitrage::Clients::CampbxClient.new
       Bitstamp.should_receive(:transfer).with(0.01, sell_client.address)
       client.transfer sell_client
     end

data/spec/rbtc_arbitrage_spec.rb

@@ -4,7 +4,7 @@ describe RbtcArbitrage do
   describe ".clients" do
     it "includes clients" do
       clients = RbtcArbitrage.clients
-      clients.should include(RbtcArbitrage::Clients::MtGoxClient)
+      clients.should include(RbtcArbitrage::Clients::CampbxClient)
       clients.should include(RbtcArbitrage::Clients::BitstampClient)
     end
   end

data/spec/spec_helper.rb

@@ -13,7 +13,7 @@ SimpleCov.start do
 end
 
 require 'bundler'
-Bundler.require
+Bundler.require(:default, :development)
 
 VCR.configure do |c|
   c.cassette_library_dir = 'spec/support/cassettes'

data/spec/support/cassettes/RbtcArbitrage_Clients_BitstampClient/_transfer/calls_Bitstamp_correctly.yml

@@ -0,0 +1,48 @@
+---
+http_interactions:
+- request:
+    method: post
+    uri: https://campbx.com/api/getbtcaddr.php
+    headers:
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - '*/*'
+      User-Agent:
+      - Ruby
+      Content-Type:
+      - application/x-www-form-urlencoded
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Server:
+      - cloudflare-nginx
+      Date:
+      - Sun, 23 Mar 2014 03:35:04 GMT
+      Content-Type:
+      - application/json
+      Transfer-Encoding:
+      - chunked
+      Connection:
+      - keep-alive
+      Set-Cookie:
+      - __cfduid=d690eee91be78c2c7e475be75dadde6551395545704073; expires=Mon, 23-Dec-2019
+        23:50:00 GMT; path=/; domain=.campbx.com; HttpOnly
+      X-Frame-Options:
+      - SAMEORIGIN
+      Cache-Control:
+      - no-cache, must-revalidate, max-age=3600
+      Vary:
+      - Accept-Encoding
+      Expires:
+      - Sun, 23 Mar 2014 04:34:58 GMT
+      Cf-Ray:
+      - 10f793aa06040657-SJC
+    body:
+      encoding: UTF-8
+      string: "\r\n{\"Success\":\"16rQQYMTTKb9cnnSX3xYkN4hcKXoYcYURi\",\"Expiry\":3802802}"
+    http_version:
+  recorded_at: Sun, 23 Mar 2014 03:35:04 GMT
+recorded_with: VCR 2.8.0

data/spec/support/cassettes/RbtcArbitrage_Trader/_execute_trade/should_raise_SecurityError_if_not_live.yml

@@ -2,45 +2,50 @@
 http_interactions:
 - request:
     method: get
-    uri: https://data.mtgox.com/api/1/BTCUSD/ticker
+    uri: https://campbx.com/api/xticker.php
     body:
       encoding: US-ASCII
       string: ''
     headers:
-      Accept:
-      - application/json
-      User-Agent:
-      - mtgox gem 1.1.0
       Accept-Encoding:
       - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - '*/*'
+      User-Agent:
+      - Ruby
   response:
     status:
       code: 200
       message: OK
     headers:
       Server:
-      - nginx/1.4.4
-      Content-Type:
-      - application/json; charset=utf-8
-      X-Powered-By:
-      - PHP/5.5.4
-      Access-Control-Allow-Origin:
-      - '*'
-      Content-Length:
-      - '1377'
-      Cache-Control:
-      - public, max-age=23
-      Expires:
-      - Fri, 13 Dec 2013 23:46:23 GMT
+      - cloudflare-nginx
       Date:
-      - Fri, 13 Dec 2013 23:46:00 GMT
+      - Sun, 23 Mar 2014 03:30:11 GMT
+      Content-Type:
+      - application/json
+      Transfer-Encoding:
+      - chunked
       Connection:
       - keep-alive
+      Set-Cookie:
+      - __cfduid=d5959036b6f71a1846c956b349605ab471395545410818; expires=Mon, 23-Dec-2019
+        23:50:00 GMT; path=/; domain=.campbx.com; HttpOnly
+      X-Frame-Options:
+      - SAMEORIGIN
+      Cache-Control:
+      - no-cache, must-revalidate, max-age=3600
+      Vary:
+      - Accept-Encoding
+      Expires:
+      - Sun, 23 Mar 2014 04:30:05 GMT
+      Cf-Ray:
+      - 10f78c819b1e012b-SJC
     body:
       encoding: UTF-8
-      string: '{"result":"success","return":{"high":{"value":"990.00000","value_int":"99000000","display":"$990.00","display_short":"$990.00","currency":"USD"},"low":{"value":"882.15864","value_int":"88215864","display":"$882.16","display_short":"$882.16","currency":"USD"},"avg":{"value":"929.35648","value_int":"92935648","display":"$929.36","display_short":"$929.36","currency":"USD"},"vwap":{"value":"930.71887","value_int":"93071887","display":"$930.72","display_short":"$930.72","currency":"USD"},"vol":{"value":"16658.49512372","value_int":"1665849512372","display":"16,658.50\u00a0BTC","display_short":"16,658.50\u00a0BTC","currency":"BTC"},"last_local":{"value":"933.00000","value_int":"93300000","display":"$933.00","display_short":"$933.00","currency":"USD"},"last_orig":{"value":"933.00000","value_int":"93300000","display":"$933.00","display_short":"$933.00","currency":"USD"},"last_all":{"value":"933.00000","value_int":"93300000","display":"$933.00","display_short":"$933.00","currency":"USD"},"last":{"value":"933.00000","value_int":"93300000","display":"$933.00","display_short":"$933.00","currency":"USD"},"buy":{"value":"923.01500","value_int":"92301500","display":"$923.02","display_short":"$923.02","currency":"USD"},"sell":{"value":"932.99500","value_int":"93299500","display":"$933.00","display_short":"$933.00","currency":"USD"},"item":"BTC","now":"1386978350330653"}}'
+      string: '{"Last Trade":"582.01","Best Bid":"598.00","Best Ask":"599.99"}'
     http_version: 
-  recorded_at: Fri, 13 Dec 2013 23:45:59 GMT
+  recorded_at: Sun, 23 Mar 2014 03:30:11 GMT
 - request:
     method: get
     uri: https://www.bitstamp.net/api/ticker/
@@ -53,41 +58,34 @@ http_interactions:
       code: 200
       message: OK
     headers:
-      Date:
-      - Fri, 13 Dec 2013 23:46:01 GMT
-      Server:
-      - Apache
-      Content-Language:
-      - en
-      Expires:
-      - Fri, 13 Dec 2013 23:46:01 GMT
-      Vary:
-      - Accept-Language
-      Cache-Control:
-      - max-age=0
+      Etag:
+      - '"120627-a0-4f53dbbb126b1"'
       Last-Modified:
-      - Fri, 13 Dec 2013 23:46:01 GMT
-      Connection:
-      - close
-      Transfer-Encoding:
-      - chunked
+      - Sun, 23 Mar 2014 03:29:57 GMT
+      Content-Length:
+      - '160'
       Content-Type:
       - application/json
+      Cache-Control:
+      - max-age=10, public
+      Expires:
+      - Sun, 23 Mar 2014 03:30:21 GMT
+      Date:
+      - Sun, 23 Mar 2014 03:30:11 GMT
       Set-Cookie:
-      - incap_ses_124_99025=1AGJPcUZxAWETOnVAYq4ATmcq1IAAAAAsPOre1PyXZcqEJH1uY4Qfg==;
+      - incap_ses_209_99025=/Pt0LzC6viGfdmvjkIXmAkNVLlMAAAAAaFpHwp3YsMhz5noifqhXyg==;
         path=/; Domain=.bitstamp.net
-      - nlbi_99025=/DSMfH+W5Ew2ED96Itob8gAAAAAGzFr9JBde9Z+4ZeBXJbWF; path=/; Domain=.bitstamp.net
-      - visid_incap_99025=QgG3duHHS6OybwUjvo9t3Ticq1IAAAAAQUIPAAAAAABm3P8tzeXhQXHryTzg9Y1Y;
-        expires=Sun, 13 Dec 2015 10:19:32 GMT; path=/; Domain=.bitstamp.net
+      - visid_incap_99025=2EcA4uXSRZ+SzOE2AsWMxENVLlMAAAAAQUIPAAAAAADDQabegou/a5tQLDR/2oR9;
+        expires=Mon, 21 Mar 2016 09:10:12 GMT; path=/; Domain=.bitstamp.net
       X-Iinfo:
-      - 5-187947047-187947137 NNNY CT(197 197 0) RT(1386978360501 172) q(0 0 4 0)
-        r(4 6) U6
+      - 10-57915944-0 0CNN RT(1395545410761 287) q(0 -1 -1 0) r(0 -1)
       X-Cdn:
       - Incapsula
     body:
       encoding: ASCII-8BIT
-      string: '{"high": "920.42", "last": "883.00", "timestamp": "1386978349", "bid":
-        "879.36", "volume": "14666.53257818", "low": "850.00", "ask": "883.00"}'
+      string: '{"high": "571.70", "last": "565.14", "timestamp": "1395545393", "bid":
+        "563.11", "vwap": "556.51", "volume": "13035.98901950", "low": "541.00", "ask":
+        "567.39"}'
     http_version: 
-  recorded_at: Fri, 13 Dec 2013 23:46:00 GMT
-recorded_with: VCR 2.7.0
+  recorded_at: Sun, 23 Mar 2014 03:30:11 GMT
+recorded_with: VCR 2.8.0