rbtc_arbitrage 0.1.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: 8b73f2bb929386db4483f985d6e4ad1e1e630c0f
-  data.tar.gz: 09877353240e3fad0adaa5a14f7a9d9b15951f76
-!binary "U0hBNTEy":
-  metadata.gz: 3ea1ba33fd9e0cefc968e9af9c4a96b71af16d0ae2d8a8952b9928ba065f83f5f489576e902b20c2b55e2658f446b089fadf16d558e7a3574e52e0dc0d20d422
-  data.tar.gz: 3267b9bf783cec825d6564b86910ee67715ab5c6aeca56d1fb3d9a90afe1d0a0e17c7f54659495a36f2188e4c92bd67220d1e1c95267533c7e17efc582810cc2
+SHA1:
+  metadata.gz: 085039358b729bed53c64ff11885c145b9a90686
+  data.tar.gz: 841862abfc69c37d33ed1225727f19a5fe2be36c
+SHA512:
+  metadata.gz: 4523e93e04eff256b8e811f20c1abe832d156e05bf965cf6053989bb772e55d91f7563d647bff86f0d2ef0b3dabf690ee9408c40d00e80b9bbde2b2266ae852e
+  data.tar.gz: eaf1b7274b62f349c57141f82826fba5dea50394b13f26a6d59c3be79b20e30688ea4fce917077cf1e171f7980be2297b9043138ae8a3c9c2d90d9b226d8b369

data/.rspec

@@ -1,2 +1,2 @@
 --color
---format progress
+--format d

data/.travis.yml

@@ -1,5 +1,15 @@
 language: ruby
 rvm:
-  - 2.0.0
-  - 1.9.3
-  - 1.9.2
+- 2.1.0
+- 2.0.0
+- 1.9.3
+- ruby-head
+env:
+  global:
+  - secure: FdoR9cSL5JzSiGRgmrEGCx55VdP7QU6jt2vzeJyc+2Ho67UXxJuXWgFdwojs6X85O3in8YfSOInBLGXXsD8a3mBuvhsAaMmDLbhFKfEExsc9bnpTj3k95UMGRO3pGNkk1tfj/ohsLFs+yL4r/mFZ5pOoxWW0uhYuRPA+Jk39hZg=
+  - secure: k8OmNupst65nssbCEYLnUdJdYvwnW6YUqcBCNOLcxXKRWcABf2RGmfI/T/iyO0uzzF6e9Ms3C9eZixfIXw4BVTY7DajKHicjvUMPMzzAwAqpK9fb2+mHUmNuksl8wjLvZB4j3TkAAxMECjpPQ2TvY1NRj375STUICC1Ahk9V6CU=
+  - secure: DTjDDBK+lKN6unPF1WOj8a/IIEcty4hkqeP2brilboAyKczxxuDkWcEY7q4mr1whzSQqnWgZgKH2my7mJwWm+J8DMW4bkD5se6eQtmHB/lXkIkIUxHdHT1KM5o+8MqMnb8PX7gquudeIGwNfI2yXa8Nh33y/fVCiKsMDg25Z8Es=
+  - secure: VDB+4rlwVZHOVDQanlAp/QD6owxd5RtiOCUC1H/NudyFqAeXUrn57FC8IN4f4s5Mk7mW9M7F7VYF2l4egjfVYszjq3OlUaWb5uMS7LSVl7I4rNaCM+pPA4vi7rlt6F0LqZoDJzNX7Md1SwIQjCBracRbpV3ZKL8GHh5yS3Ojk38=
+  - secure: ksmMGyDkwmIUkJIHzdrAld+GN2KEm9l8dtxZikoP7B9zRymhnPhImDfZHbByFV0DIZmNiUMFvNLIIpgznjpFdpcEjCbLQnfniKTscMyQZ1pvOesCyaPnSHBENRDsADFCG/TMeP5VXtUUL2k/eNIzHU0cVJT8JaEMdihPDy+mrO8=
+  - secure: I3rS8d84BoCsZo9c/PcY6F/GDThVu/rPKMjTUGHkbtWXVD8E809JxaWavu/+EesyUhn8dDGwMRUc+4d6gtk+QeQVOyLkkPIaCII4puJEHqdyJpqrJlsZbXaGO/JJ6mx2y0I6wDryKeLhZqVn6VdxycF+7OTqYdCFGV+o49wirIU=
+  - secure: kih2LqMwQDZErJFU4hslPZcAdtYwQIYyzxnkObIWtIQpLAVQNssbISLBe5ogWNXi8FyiEktAH5Yy0orjTp2ynmrA6rE6NU/vD3oBDeeI7CCd+13weeIW+uReyixuI5zn6zzJLHdxn+rUwowfdYrt9vF54uEjKCVL32pbLZjdavk=

data/Gemfile

@@ -5,3 +5,13 @@ gemspec
 gem 'rspec'
 gem "activemodel", ">= 3.1"
 gem "activesupport", ">= 3.1"
+gem 'guard'
+gem 'ruby_gntp'
+# gem 'awesome_print'
+gem 'guard-rspec'
+gem 'simplecov'
+gem 'coveralls', require: false
+gem "webmock"
+gem 'vcr'
+gem 'codeclimate-test-reporter'
+gem 'hashie'

data/Guardfile

@@ -0,0 +1,8 @@
+guard 'rspec' do
+  watch(%r{^spec/.+_spec\.rb$})
+  watch(%r{^lib/rbtc_arbitrage/(.+)\.rb$}) { |m| "spec/#{m[1]}_spec.rb" }
+  watch('spec/spec_helper.rb')             { 'spec' }
+  watch(%r{^spec/clients/.+_spec\.rb$})
+  watch(%r{^lib/rbtc_arbitrage/clients/(.+)\.rb$}) { |m| "spec/clients/#{m[1]}_spec.rb" }
+end
+

data/README.md

@@ -1,6 +1,20 @@
 # RbtcArbitrage
 
-A Ruby gem for automating arbitrage between the MtGox and Bitstamp bitcoin exchanges.
+A Ruby gem for executing arbitrage between the MtGox and Bitstamp bitcoin exchanges.
+
+## Meta
+
+[Explanation of bitcoin arbitrage](http://hankstoever.com/posts/13-Everything-you-need-to-know-about-Bitcoin-arbitrage)
+
+[Why I open sourced a bitcoin arbitrate bot](http://hankstoever.com/posts/2-Why-I-open-sourced-a-bitcoin-arbitrage-bot)
+
+I'm also creating a course on [creating your own bitcoin arbitrage bot](https://www.uludum.org/funds/2) 
+
+Donations accepted: **16BMcqf93eEpb2aWgMkJCSQQH85WzrpbdZ**
+
+[![Build Status](https://travis-ci.org/hstove/rbtc_arbitrage.png?branch=master)](https://travis-ci.org/hstove/rbtc_arbitrage)
+[![Coverage Status](https://coveralls.io/repos/hstove/rbtc_arbitrage/badge.png)](https://coveralls.io/r/hstove/rbtc_arbitrage)
+[![Code Climate](https://codeclimate.com/github/hstove/rbtc_arbitrage.png)](https://codeclimate.com/github/hstove/rbtc_arbitrage)
 
 ## Installation
 
@@ -21,17 +35,21 @@ After installing the gem, simply run `rbtc` in the command line.
 	2. BITSTAMP_KEY
 	2. BITSTAMP_SECRET
 	3. BITSTAMP_ADDRESS
-	
+	4. BITSTAMP_CLIENT_ID
+
 - **Cutoff**: the minimum profit percentage required to execute a trade. Defaults to **%2.00**.
 - **Volume**: The amount of bitcoins to trade per transaction. Defaults to **0.01** (the minimum transaction size).
+- **Buyer**: The exchange you'd like to buy bitcoins from during arbitrage. `"mtgox"` or `"bitstamp"`. Default is `bitstamp`
+- **Seller**: The exchange you'd like to sell bitcoins from during arbitrage. `"mtgox"` or `"bitstamp"`. Default is `bitstamp`
 
 #### Examples
 
 	$ rbtc --live --cutoff 4
 	$ rbtc --cutoff 0.5
 	$ rbtc --cutoff 3 --volume 0.05
+	$ rbtc --seller bitstamp --buyer mtgox
 	$ rbtc
-	
+
 The output will look like this:
 
 	07/08/2013 at 10:41AM
@@ -42,6 +60,14 @@ The output will look like this:
 	selling 0.01 btc on MtGox for $0.76
 	profit: $0.02 (2.77%)
 
+## Changelog
+
+### 2.0.0
+
+- full refactor
+- 100% test coverage
+- Modularized exchange-specific code to allow for easier extension.
+- CLI `buyer` and `seller` option.
 
 ## Contributing
 
@@ -52,3 +78,15 @@ The output will look like this:
 3. Commit your changes (`git commit -am 'Add some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)
 5. Create new Pull Request
+
+## Adding an exchange
+
+Right now there is support for only MtGox and Bitstamp, but adding support for other exchanges is dead simple. First, you'll need to create a new `client` in `lib/rbtc_arbitrage/clients`. Follow the example from the [mtgox client](https://github.com/hstove/rbtc_arbitrage/blob/master/lib/rbtc_arbitrage/clients/mtgox_client.rb). You'll need to provide custom implementations of the following methods:
+
+- `validate_env`
+- `balance`
+- `price`
+- `trade`
+- `exchange`
+
+Make sure that the methods accept the same arguments and return similar objects. At the same time, make sure you copy the [mtgox_cient_spec](https://github.com/hstove/rbtc_arbitrage/blob/master/spec/clients/mtgox_client_spec.rb) and change it to test your client.

data/btce-api-key.yml

@@ -0,0 +1,2 @@
+key: #{ENV['BTCE_KEY']}
+secret: #{ENV['BTCE_SECRET']}

data/lib/rbtc_arbitrage/campbx.rb

@@ -0,0 +1,98 @@
+## Ruby module for working with CampBX API
+## May 2013
+## based on glenbot's python work @ https://github.com/glenbot/campbx/
+
+require 'json'
+require 'net/http'
+require 'uri'
+
+module CampBX
+  API_BASE = 'https://campbx.com/api/'
+
+  # { method_name => [ url, auth?, [ parameters ] ] }
+  # See: https://campbx.com/api.php for specifics.
+  # Each method returns a Hash with JSON data from the API.
+  # Some parameters are optional.
+  CALLS = {
+    'xdepth' => [ 'xdepth', FALSE, [] ],
+    'xticker' => [ 'xticker', FALSE, [] ],
+    'my_funds' => ['myfunds', TRUE, [] ],
+    'my_orders' => ['myorders', TRUE, [] ],
+    'my_margins' => ['mymargins', TRUE, [] ],
+    'send_instant' => ['sendinstant', TRUE, [ 'CBXCode', 'BTCAmt' ] ],
+    'get_btc_address' => ['getbtcaddr', TRUE, [] ],
+    'send_btc' => ['sendbtc', TRUE, [ 'BTCTo', 'BTCAmt' ] ],
+#   'dwolla' => [ nil, TRUE, [] ], # Coming Soon (TM)
+    'trade_cancel' => ['tradecancel', TRUE, [ 'Type', 'OrderID' ] ],
+    'trade_enter' => ['tradeenter', TRUE, [ 'TradeMode', 'Quantity', 'Price' ] ],
+    'trade_advanced' => ['tradeadv', TRUE, [ 'TradeMode', 'Price', 'Quantity', 'FillType', 'DarkPool', 'Expiry' ] ],
+#   'margin_buy' => [ nil, TRUE, [] ], # Coming Soon (TM)
+#   'short_sell' => [ nil, TRUE, [] ], # Coming Soon (TM)
+  }
+
+
+  class API
+    # CampBX API rate limiting probably per IP address (not account)
+    # which is why we don't limit per instance
+    @@last = Time.new(0)
+    @username  = nil
+    @password  = nil
+
+    def initialize( username=nil, password=nil )
+      @username = username
+      @password = password
+
+      # Build meta-methods for each API call
+      CALLS.each do |name|
+        define_singleton_method name[0], lambda { |*args|
+          data = CALLS[name[0]]
+          api_request( [data[0], data[1]], Hash[data[2].zip( args )] )
+        }
+      end
+    end
+
+    def api_request( info, post_data={} )
+      url, auth = info
+      uri = URI.parse(API_BASE + url + '.php')
+      http = Net::HTTP.new(uri.host, uri.port)
+      http.use_ssl=TRUE
+      # CampBX advises latency can be >4 minutes when markets are volatile
+      http.read_timeout = 300
+      res = nil
+
+      request = Net::HTTP::Get.new(uri.request_uri)
+      if auth then
+        post_data.merge!({
+          'user' => @username,
+          'pass' => @password,
+        })
+        request = Net::HTTP::Post.new(uri.request_uri)
+        request.set_form_data( post_data )
+      end
+
+      # debug # need to test w/valid credentials
+      #puts "Sending request to #{uri}"
+      #puts "Post Data: #{post_data}"
+
+      # CampBX API: max 1 request per 500ms
+      delta = Time.now - @@last
+      #puts delta*1000
+      if delta*1000 <= 500 then
+        #puts "sleeping! for #{0.5 - delta}"
+        sleep(0.5 - delta)
+      end
+
+      res = http.request(request)
+      @@last = Time.now # Update time after request returns
+
+      if res.message == 'OK' then # HTTP OK
+        JSON.parse( res.body )
+      else # HTTP ERROR
+        warn "HTTP Error: + #{res.code}"
+      end
+
+    end
+
+  end
+
+end

data/lib/rbtc_arbitrage/cli.rb

@@ -6,11 +6,13 @@ module RbtcArbitrage
     option :cutoff, type: :numeric, default: 2, desc: "The minimum profit level required to execute a trade."
     option :volume, type: :numeric, default: 0.01, desc: "The amount of bitcoins to trade per transaction."
     option :verbose, type: :boolean, default: true, desc: "Whether you wish to log information."
+    option :buyer, type: :string, default: "bitstamp"
+    option :seller, type: :string, default: "mtgox"
     def trade
       RbtcArbitrage::Trader.new(options).trade
     end
 
     default_task :trade
-    
+
   end
 end

data/lib/rbtc_arbitrage/client.rb

@@ -0,0 +1,45 @@
+module RbtcArbitrage
+  module Client
+    attr_accessor :options
+    attr_writer :balance
+
+    def initialize config={}
+      @options = config
+      @options = {}
+      set_key config, :volume, 0.01
+      set_key config, :cutoff, 2
+      set_key config, :logger, Logger.new(STDOUT)
+      set_key config, :verbose, true
+      set_key config, :live, false
+      self
+    end
+
+    def validate_keys
+      ["KEY", "SECRET", "ADDRESS"].each do |suffix|
+        prefix = exchange.to_s.upcase
+        key = "#{prefix}_#{suffix}"
+        if ENV[key].blank?
+          raise ArgumentError, "Exiting because missing required ENV variable $#{key}."
+        end
+      end
+    end
+
+    def buy
+      trade :buy
+    end
+
+    def sell
+      trade :sell
+    end
+
+    def address
+      ENV["#{exchange.to_s.upcase}_ADDRESS"]
+    end
+
+    private
+
+    def set_key config, key, default
+      @options[key] = config.has_key?(key) ? config[key] : default
+    end
+  end
+end

data/lib/rbtc_arbitrage/clients/bitstamp_client.rb

@@ -0,0 +1,52 @@
+module RbtcArbitrage
+  module Clients
+    class BitstampClient
+      include RbtcArbitrage::Client
+
+      def balance
+        return @balance if @balance
+        balances = Bitstamp.balance
+        @balance = [balances[0].to_f, balances[1].to_f]
+      end
+
+      def validate_env
+        validate_keys
+        Bitstamp.setup do |config|
+          config.client_id = ENV["BITSTAMP_CLIENT_ID"]
+          config.key = ENV["BITSTAMP_KEY"]
+          config.secret = ENV["BITSTAMP_SECRET"]
+        end
+      end
+
+      def exchange
+        :bitstamp
+      end
+
+      def price action
+        return @price if @price
+        action = {
+          buy: :ask,
+          sell: :bid,
+        }[action]
+        @price = Bitstamp.ticker.send(action).to_f
+      end
+
+      def trade action
+        price(action) unless @price #memoize
+        multiple = {
+          buy: 1,
+          sell: -1,
+        }[action]
+        bitstamp_options = {
+          price: (@price + 0.001 * multiple),
+          amount: @options[:volume],
+        }
+        Bitstamp.orders.send(action, bitstamp_options)
+      end
+
+      def transfer other_client
+        Bitstamp.transfer(@options[:volume], other_client.address)
+      end
+    end
+  end
+end

data/lib/rbtc_arbitrage/clients/mtgox_client.rb

@@ -0,0 +1,45 @@
+module RbtcArbitrage
+  module Clients
+    class MtGoxClient
+      include RbtcArbitrage::Client
+
+      def balance
+        return @balance if @balance
+        balances = MtGox.balance
+        @balance = [balances[0].amount.to_f, balances[1].amount.to_f]
+      end
+
+      def validate_env
+        validate_keys
+        MtGox.configure do |config|
+          config.key = ENV["MTGOX_KEY"]
+          config.secret = ENV["MTGOX_SECRET"]
+        end
+      end
+
+      def exchange
+        :mtgox
+      end
+
+      # `action` is :buy or :sell
+      def price action
+        return @price if @price
+        action = {
+          buy: :sell,
+          sell: :buy,
+        }[action]
+        @price = MtGox.ticker.send(action)
+      end
+
+      # `action` is :buy or :sell
+      def trade action
+        action = "#{action.to_s}!".to_sym
+        MtGox.send(action, @options[:volume], :market)
+      end
+
+      def transfer other_client
+        MtGox.withdraw! @options[:volume], other_client.address
+      end
+    end
+  end
+end

data/lib/rbtc_arbitrage/trader.rb

@@ -1,23 +1,34 @@
 module RbtcArbitrage
   class Trader
-    attr_accessor :stamp, :mtgox, :paid, :received, :options, :percent, :amount_to_buy
-
-    def initialize options={}
-      @stamp   = {}
-      @mtgox   = {}
-      @options = options
-      @options[:volume] ||= 0.01
-      @options[:cutoff] ||= 2
+    attr_reader :buy_client, :sell_client, :received
+    attr_accessor :buyer, :seller, :options
 
+    def initialize config={}
+      @buyer   = {}
+      @seller  = {}
+      @options = {}
+      set_key config, :volume, 0.01
+      set_key config, :cutoff, 2
+      set_key config, :logger, Logger.new(STDOUT)
+      set_key config, :verbose, true
+      set_key config, :live, false
+      exchange = config[:buyer] || :bitstamp
+      @buy_client = client_for_exchange(exchange)
+      exchange = config[:seller] || :mtgox
+      @sell_client = client_for_exchange(exchange)
       self
     end
 
+    def set_key config, key, default
+      @options[key] = config.has_key?(key) ? config[key] : default
+    end
+
     def trade
       fetch_prices
       log_info if options[:verbose]
 
-      if options[:cutoff] > percent
-        raise SecurityError, "Exiting because real profit (#{percent.round(2)}%) is less than cutoff (#{options[:cutoff].round(2)}%)"
+      if options[:cutoff] > @percent && options[:live]
+        raise SecurityError, "Exiting because real profit (#{@percent.round(2)}%) is less than cutoff (#{options[:cutoff].round(2)}%)"
       end
 
       execute_trade if options[:live]
@@ -26,82 +37,67 @@ module RbtcArbitrage
     end
 
     def execute_trade
+      fetch_prices unless @paid
       validate_env
-      get_balance
       raise SecurityError, "--live flag is false. Not executing trade." unless options[:live]
-      if options[:verbose]
-        puts "Balances:"
-        puts "stamp usd: $#{stamp[:usd].round(2)} btc: #{stamp[:usd].round(2)}"
-        puts "mtgox usd: $#{mtgox[:usd].round(2)} btc: #{mtgox[:usd].round(2)}"
-      end
-      if stamp[:price] < mtgox[:price]
-        if paid > stamp[:usd] || amount_to_buy > mtgox[:btc]
+      get_balance
+      if @percent > @options[:cutoff]
+        if @paid > buyer[:usd] || @options[:volume] > seller[:btc]
           raise SecurityError, "Not enough funds. Exiting."
         else
-          puts "Trading live!" if options[:verbose]
-          Bitstamp.orders.buy amount_to_buy, stamp[:price] + 0.001
-          MtGox.sell! amount_to_buy, :market
-          Bitstamp.transfer amount_to_buy, ENV['MTGOX_ADDRESS']
+          logger.info "Trading live!" if options[:verbose]
+          @buy_client.buy
+          @sell_client.sell
+          @buy_client.transfer @sell_client
         end
       else
-        if paid > mtgox[:usd] || amount_to_buy > stamp[:btc]
-          raise SecurityError, "Not enough funds. Exiting."
-        else
-          puts "Trading live!" if options[:verbose]
-          MtGox.buy! amount_to_buy, :market
-          Bitstamp.orders.sell amount_to_buy, stamp[:price] - 0.001
-          MtGox.withdraw amount_to_buy, ENV['BITSTAMP_ADDRESS']
-        end
+        logger.info "Not trading live because cutoff is higher than profit." if @options[:verbose]
       end
     end
 
     def fetch_prices
-      @amount_to_buy = options[:volume]
-      stamp[:price] = Bitstamp.ticker.ask.to_f
-      mtgox[:price] = MtGox.ticker.buy
-      prices = [stamp[:price], mtgox[:price]]
-      @paid = prices.min * 1.005 * amount_to_buy
-      @received = prices.max * 0.994 * amount_to_buy
-      @percent = ((received/paid - 1) * 100).round(2)
+      logger.info "Fetching exchange rates" if @options[:verbose]
+      buyer[:price] = @buy_client.price(:buy)
+      seller[:price] = @sell_client.price(:sell)
+      prices = [buyer[:price], seller[:price]]
+      @paid = prices.min * 1.005 * @options[:volume]
+      @received = prices.max * 0.994 * @options[:volume]
+      @percent = ((received/@paid - 1) * 100).round(2)
     end
 
     def log_info
-      puts "Bitstamp: $#{stamp[:price].round(2)}"
-      puts "MtGox: $#{mtgox[:price].round(2)}"
-      lower_ex, higher_ex = stamp[:price] < mtgox[:price] ? %w{Bitstamp, MtGox} : %w{MtGox, Bitstamp}
-      puts "buying #{amount_to_buy} btc from #{lower_ex} for $#{paid.round(2)}"
-      puts "selling #{amount_to_buy} btc on #{higher_ex} for $#{received.round(2)}"
-      puts "profit: $#{(received - paid).round(2)} (#{percent.round(2)}%)"
+      lower_ex = @buy_client.exchange.to_s.capitalize
+      higher_ex = @sell_client.exchange.to_s.capitalize
+      logger.info "#{lower_ex}: $#{buyer[:price].round(2)}"
+      logger.info "#{higher_ex}: $#{seller[:price].round(2)}"
+      logger.info "buying #{@options[:volume]} btc from #{lower_ex} for $#{@paid.round(2)}"
+      logger.info "selling #{@options[:volume]} btc on #{higher_ex} for $#{@received.round(2)}"
+      logger.info "profit: $#{(@received - @paid).round(2)} (#{@percent.round(2)}%)"
     end
 
-    def validate_env
-      ["KEY", "SECRET", "ADDRESS"].each do |suffix|
-        ["MTGOX", "BITSTAMP"].each do |prefix|
-          key = "#{prefix}_#{suffix}"
-          if ENV[key].blank?
-            raise ArgumentError, "Exiting because missing required ENV variable $#{key}."
-          end
-        end
-      end
+    def get_balance
+      @seller[:btc], @seller[:usd] = @sell_client.balance
+      @buyer[:btc], @buyer[:usd] = @buy_client.balance
+    end
 
-      MtGox.configure do |config|
-        config.key = ENV["MTGOX_KEY"]
-        config.secret = ENV["MTGOX_SECRET"]
-      end
+    def logger
+      @options[:logger]
+    end
 
-      Bitstamp.setup do |config|
-        config.key = ENV["BITSTAMP_KEY"]
-        config.secret = ENV["BITSTAMP_SECRET"]
+    def validate_env
+      [@sell_client, @buy_client].each do |client|
+        client.validate_env
       end
     end
 
-    def get_balance
-      balances = MtGox.balance
-      @mtgox[:btc] = balances[0].amount.to_f
-      @mtgox[:usd] = balances[1].amount.to_f
-      balances = Bitstamp.balance if options[:live]
-      @stamp[:usd] = balances["usd_available"].to_f
-      @stamp[:btc] = balances["btc_available"].to_f
+    def client_for_exchange market
+      market = market.to_sym unless market.is_a?(Symbol)
+      clazz = RbtcArbitrage::Clients.constants.find do |c|
+        clazz = RbtcArbitrage::Clients.const_get(c)
+        clazz.new.exchange == market
+      end
+      clazz = RbtcArbitrage::Clients.const_get(clazz)
+      clazz.new @options
     end
   end
 end

data/lib/rbtc_arbitrage/version.rb

@@ -1,3 +1,3 @@
 module RbtcArbitrage
-  VERSION = "0.1.0"
+  VERSION = "1.0.0"
 end

data/lib/rbtc_arbitrage.rb

@@ -1,7 +1,9 @@
 require 'thor'
 require 'mtgox'
+require_relative 'rbtc_arbitrage/campbx.rb'
 require 'bitstamp'
-Dir[File.expand_path('../rbtc_arbitrage/*', __FILE__)].each { |f| require f }
+require 'btce'
+Dir["#{File.dirname(__FILE__)}/rbtc_arbitrage/**/*.rb"].each { |f| require(f) }
 
 module RbtcArbitrage
 end

data/rbtc_arbitrage.gemspec

@@ -26,4 +26,6 @@ Gem::Specification.new do |spec|
   spec.add_dependency "activemodel", ">= 3.1"
   spec.add_dependency "activesupport", ">= 3.1"
   spec.add_dependency "thor"
+  spec.add_dependency "btce"
+  spec.add_dependency "bitstamp"
 end

data/spec/cli_spec.rb

@@ -0,0 +1,8 @@
+require 'spec_helper'
+
+describe RbtcArbitrage::CLI do
+  it "calls trade on new trader" do
+    RbtcArbitrage::Trader.any_instance.should_receive(:trade)
+    RbtcArbitrage::CLI.new.trade
+  end
+end

data/spec/client_spec.rb

@@ -0,0 +1,18 @@
+require 'spec_helper'
+
+class FakeClient
+  include RbtcArbitrage::Client
+
+  def trade action
+  end
+end
+
+describe RbtcArbitrage::Client do
+  let(:client) { FakeClient.new }
+  it "aliases buy and sell" do
+    client.should_receive(:trade).with(:sell)
+    client.sell
+    client.should_receive(:trade).with(:buy)
+    client.buy
+  end
+end