rbr 0.3.2 → 0.3.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8b7d0b6b8d0cf90f5663842f750f2a54aca82bbeac46ab4ba6c542889a1dea98
-  data.tar.gz: f54146ad71167e7dd56d4038457c7388f130e67d539c179490f5ee773b642e1a
+  metadata.gz: 5c0e7a109d2816ccffdfaae67030e2b2fdf05ec174f4eed9a3bddfee349a8f25
+  data.tar.gz: 19b465b803e994d549ba2eaa5944d7ca4548fccbe98b54fa917c622fa25a0354
 SHA512:
-  metadata.gz: ab183917580958f97adfbd4e2144f501561c16eb4e330f0c0c806f33407d6402cb3fe87cc85f393f3083ab35dc975cb2ed6e5636cdc430b0b47c5e01ed2e11f3
-  data.tar.gz: 2cf02448bf77d5c58f8f7f6d68067085ec424d723d7a5515254ba50975e687b2f19681f65a30a1b8fa717b9a2ac392ea2ec2a0bbe0fca73662186f877581355c
+  metadata.gz: cb66285e2b739e5cfbb7531785c21d14aa0568a2a96fa1f991d7ab84e19fbc305dd5f89939e88641d2a39fbcf1de07218693db49572141b8404e59f8cc32fa95
+  data.tar.gz: 5ddc4afc2a09a1cd4ee462d2dded97a919609ad117f16c612868ea25e27e43ca25cbdb4090a05ee1d5b4816a07331bd220537766cc37040afd82a64e6ae1f176

data/.rubocop.yml

@@ -5,7 +5,6 @@ require:
 
 AllCops:
   NewCops: enable
-  TargetRubyVersion: 2.6
   Exclude:
     - "test/fixtures/*"
 

data/README.md

@@ -50,7 +50,7 @@ This differs from a file contents search (like grep) in that rbr understands Rub
     test/fixtures/book.rb:50: book.send(:great_method)
     ```
 
-- Find all statements that update an ActiveRecord model attribute named `title`.
+- Find statements that update an ActiveRecord model attribute named `title`.
 
     ```sh
     $ rbr ar_update :title test/fixtures/book.rb
@@ -59,6 +59,16 @@ This differs from a file contents search (like grep) in that rbr understands Rub
     test/fixtures/book.rb:31: book.send(:update_column, :title, "Great Title")
     ```
 
+    Note that this matcher is necessarily incomplete. For example, a parser alone cannot find situations like the following.
+
+    ```ruby
+    def update_record(attrs)
+      record.update(attrs)
+    end
+
+    update_record(title: "Great Author")
+    ```
+
 ### rbr is the *wrong tool* for the following situations:
 
 - Find all appearance of "author" in a codebase.

data/TODO

@@ -1 +1,5 @@
-not_str matcher
+new matchers:
+	not string
+	raw SQL updates
+	text in an if/unless condition
+	symbol or string

data/lib/rbr/matchers.rb

@@ -102,7 +102,7 @@ module Rbr
     end
 
     private_class_method def self.ar_update_hash_element(node, name)
-      node.method_call?(:[]=) && node.children[-2].value == name
+      node.method_call?(:[]=) && node.children[-2].is_a?(Node) && node.children[-2].value == name
     end
   end
 end

data/lib/rbr/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Rbr
-  VERSION = "0.3.2"
+  VERSION = "0.3.4"
 end

data/rbr.gemspec

@@ -23,7 +23,7 @@ Gem::Specification.new do |spec|
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
   spec.files = Dir.chdir(File.expand_path(__dir__)) do
-    `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
+    `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features|LICENSE)/}) }
   end
   spec.bindir = "exe"
   spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rbr
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.3.4
 platform: ruby
 authors:
 - Eddie Lebow
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-02-03 00:00:00.000000000 Z
+date: 2024-08-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parser
@@ -113,7 +113,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.3
+rubygems_version: 3.5.3
 signing_key:
 specification_version: 4
 summary: Semantically-aware code search tool for Ruby