rbook-pacstream 0.5 → 0.6

data/Rakefile

@@ -6,7 +6,7 @@ require 'rake/testtask'
 require "rake/gempackagetask"
 require 'spec/rake/spectask'
 
-PKG_VERSION = "0.5"
+PKG_VERSION = "0.6"
 PKG_NAME = "rbook-pacstream"
 PKG_FILE_NAME = "#{PKG_NAME}-#{PKG_VERSION}"
 RUBYFORGE_PROJECT = 'rbook'

data/lib/rbook/pacstream.rb

@@ -6,7 +6,7 @@ require 'tempfile'
 module RBook
 
   # Ruby class for sending and retrieving electronic orders
-  # via pacstream, a service run by the ECN GRoup 
+  # via pacstream, a service run by the ECN Group 
   # (http://www.ecngroup.com.au/)
   #
   # = Basic Usage
@@ -16,10 +16,16 @@ module RBook
   #  end
   class Pacstream
       
-    FILE_EXTENSIONS = { :orders => "ORD" }
+    FILE_EXTENSIONS = { :orders => "ORD", :invoices => "ASN", :poacks => "POA" }
 
-    # Iterate over each order waiting on the pacstream server, returning
-    # each file as a string
+    # Iterate over each document waiting on the pacstream server, returning
+    # it as a string
+    #
+    # Document types available:
+    # 
+    # Purchase Orders (:orders)
+    # Purchase Order Acknowledgements (:poacks)
+    # Invoices (:invoices)
     #
     #  RBook::Pacstream.get(:orders, :username => "myusername", :password => "mypass") do |order|
     #    puts order
@@ -29,9 +35,7 @@ module RBook
         raise ArgumentError, 'username and password must be specified'
       end
 
-      unless FILE_EXTENSIONS.include?(type)
-        raise ArgumentError, 'unrecognised type'
-      end    
+      raise ArgumentError, 'unrecognised type' unless FILE_EXTENSIONS.include?(type.to_sym)
 
       server = args[0][:servername] || "pacstream.tedis.com.au"
 
@@ -39,7 +43,7 @@ module RBook
         transaction_complete = false
         Net::FTP.open(server) do |ftp|
           
-            file_regexp = Regexp.new(".*\.#{FILE_EXTENSIONS[type]}$", Regexp::IGNORECASE)
+            file_regexp = Regexp.new(".*\.#{FILE_EXTENSIONS[type.to_sym]}$", Regexp::IGNORECASE)
             ftp.login(args[0][:username].to_s, args[0][:password].to_s)
             ftp.chdir("outgoing/")
             ftp.nlst.each do |file|
@@ -48,6 +52,7 @@ module RBook
                 tempfile.close
                 ftp.getbinaryfile(file, tempfile.path)
                 yield File.read(tempfile.path)
+                tempfile.unlink
               end
             end
             transaction_complete = true
@@ -59,6 +64,5 @@ module RBook
         raise "Error while communicating with the pacstream server"
       end
     end
-
   end
 end

metadata

@@ -3,8 +3,8 @@ rubygems_version: 0.9.4
 specification_version: 1
 name: rbook-pacstream
 version: !ruby/object:Gem::Version 
-  version: "0.5"
-date: 2007-07-03 00:00:00 +10:00
+  version: "0.6"
+date: 2007-10-10 00:00:00 +10:00
 summary: A library for interaction with the PACSTREAM service
 require_paths: 
 - lib