rbook-onix 0.5.1 → 0.5.2

data/Rakefile

@@ -6,7 +6,7 @@ require 'rake/testtask'
 require "rake/gempackagetask"
 require 'spec/rake/spectask'
 
-PKG_VERSION = "0.5.1"
+PKG_VERSION = "0.5.2"
 PKG_NAME = "rbook-onix"
 PKG_FILE_NAME = "#{PKG_NAME}-#{PKG_VERSION}"
 RUBYFORGE_PROJECT = 'rbook'
@@ -24,7 +24,14 @@ task :cruise => [ :spec, :spec_report, :doc ]
 desc "Run all rspec files"
 Spec::Rake::SpecTask.new("spec") do |t|
   t.spec_files = FileList['specs/**/*.rb']
-  t.rcov = true
+  
+  if RUBY_VERSION >= "1.8.6" && RUBY_PATCHLEVEL >= 110
+    t.rcov = false
+  else
+    t.rcov = true
+  end
+
+  t.rcov_dir = (ENV['CC_BUILD_ARTIFACTS'] || 'doc') + "/rcov"
   t.rcov_dir = (ENV['CC_BUILD_ARTIFACTS'] || 'doc') + "/rcov"
   t.rcov_opts = ["--exclude","spec.*\.rb"]
 end

data/lib/rbook/onix/contributor.rb

@@ -49,9 +49,15 @@ module Onix
  
     # Return an XML string representing this contributor
     def to_s
-      tmp = to_element
       output = ''
-      tmp.write(output, 0)
+
+      # handle the REXML API change in 1.8.6.110. bah!
+      if RUBY_VERSION >= "1.8.6" && RUBY_PATCHLEVEL >= 110
+        formatter = REXML::Formatters::Pretty.new( 2 )
+        formatter.write( to_element , output )
+      else
+        to_element.write(output, 0)
+      end
       return output
     end
   end

data/lib/rbook/onix/message.rb

@@ -77,7 +77,12 @@ module RBook
       def to_s
         doc = to_xml
         output = ''
-        doc.write(output, 2)
+        # stupid hack, because the ruby release mangers imported a broken REXML for this patchset
+        if RUBY_VERSION == "1.8.6" && (RUBY_PATCHLEVEL == 110 || RUBY_PATCHLEVEL == 111)
+         doc.write(output,-1)
+        else
+          doc.write(output,0)
+        end
         return output
       end
     

data/lib/rbook/onix/product.rb

@@ -199,7 +199,14 @@ module RBook
       # return an XML string representing this contributor
       def to_s
         output = ''
-        to_element.write(output, 0)
+
+        # handle the REXML API change in 1.8.6.110. bah!
+        if RUBY_VERSION >= "1.8.6" && RUBY_PATCHLEVEL >= 110
+          formatter = REXML::Formatters::Pretty.new( 2 )
+          formatter.write( to_element , output )
+        else
+          to_element.write(output, 0)
+        end
         return output
       end
     end

data/lib/rbook/onix/sales_restriction.rb

@@ -40,9 +40,15 @@ module Onix
  
     # Return an XML string representing this contributor
     def to_s
-      tmp = to_element
       output = ''
-      tmp.write(output, 0)
+
+      # handle the REXML API change in 1.8.6.110. bah!
+      if RUBY_VERSION >= "1.8.6" && RUBY_PATCHLEVEL >= 110
+        formatter = REXML::Formatters::Pretty.new( 2 )
+        formatter.write( to_element , output )
+      else
+        to_element.write(output, 0)
+      end
       return output
     end
   end

data/lib/rbook/onix/supply_detail.rb

@@ -65,9 +65,15 @@ module Onix
  
     # Return an XML string representing this contributor
     def to_s
-      tmp = to_element
       output = ''
-      tmp.write(output, 0)
+
+      # handle the REXML API change in 1.8.6.110. bah!
+      if RUBY_VERSION >= "1.8.6" && RUBY_PATCHLEVEL >= 110
+        formatter = REXML::Formatters::Pretty.new( 2 )
+        formatter.write( to_element , output )
+      else
+        to_element.write(output, 0)
+      end
       return output
     end
   end

data/specs/message_with_data_spec.rb

@@ -55,6 +55,19 @@ context "A message object with valid data" do
     msg.to_s.should be_a_kind_of(String)
   end
 
+  specify "should output a valid string with no line breaks between tags and content" do
+    msg = RBook::Onix::Message.new
+    msg.from_person = "James Healy"
+    msg.from_company = "Healy Inc."
+    msg.to_person = "RSpec"
+
+    product = RBook::Onix::Product.new
+    product.product_identifier = '0977616606'
+    msg.add_product(product)
+
+    msg.to_s.include?("<ToPerson>RSpec</ToPerson>").should be_true
+  end
+
   # ensure all output is cleansed UTF-8
   specify "should output valid UTF-8, regardless of the input" do
     msg = RBook::Onix::Message.new

metadata

@@ -3,8 +3,8 @@ rubygems_version: 0.9.4
 specification_version: 1
 name: rbook-onix
 version: !ruby/object:Gem::Version 
-  version: 0.5.1
-date: 2007-10-19 00:00:00 +10:00
+  version: 0.5.2
+date: 2007-10-24 00:00:00 +10:00
 summary: A library for manipulating ONIX files
 require_paths: 
 - lib