rbi 0.0.1 → 0.0.2

data/lib/rbi/rewriters/group_nodes.rb

@@ -0,0 +1,104 @@
+# typed: strict
+# frozen_string_literal: true
+
+module RBI
+  module Rewriters
+    class GroupNodes < Visitor
+      extend T::Sig
+
+      sig { override.params(node: T.nilable(Node)).void }
+      def visit(node)
+        return unless node
+
+        case node
+        when Tree
+          kinds = node.nodes.map(&:group_kind)
+          kinds.compact!
+          kinds.uniq!
+
+          groups = {}
+          kinds.each { |kind| groups[kind] = Group.new(kind) }
+
+          node.nodes.dup.each do |child|
+            visit(child)
+            child.detach
+            groups[child.group_kind] << child
+          end
+
+          groups.each { |_, group| node << group }
+        end
+      end
+    end
+  end
+
+  class Tree
+    extend T::Sig
+
+    sig { void }
+    def group_nodes!
+      visitor = Rewriters::GroupNodes.new
+      visitor.visit(self)
+    end
+  end
+
+  class Node
+    extend T::Sig
+
+    sig { returns(Group::Kind) }
+    def group_kind
+      case self
+      when Include, Extend
+        Group::Kind::Mixins
+      when Helper
+        Group::Kind::Helpers
+      when TypeMember
+        Group::Kind::TypeMembers
+      when MixesInClassMethods
+        Group::Kind::MixesInClassMethods
+      when TStructField
+        Group::Kind::TStructFields
+      when TEnumBlock
+        Group::Kind::TEnums
+      when VisibilityGroup
+        Group::Kind::Methods
+      when Method
+        if name == "initialize"
+          Group::Kind::Inits
+        else
+          Group::Kind::Methods
+        end
+      when Scope, Const
+        Group::Kind::Consts
+      else
+        raise "Unknown group for #{self}"
+      end
+    end
+  end
+
+  class Group < Tree
+    extend T::Sig
+
+    sig { returns(Kind) }
+    attr_reader :kind
+
+    sig { params(kind: Kind).void }
+    def initialize(kind)
+      super()
+      @kind = kind
+    end
+
+    class Kind < T::Enum
+      enums do
+        Mixins              = new
+        Helpers             = new
+        TypeMembers         = new
+        MixesInClassMethods = new
+        TStructFields       = new
+        TEnums              = new
+        Inits               = new
+        Methods             = new
+        Consts              = new
+      end
+    end
+  end
+end

data/lib/rbi/rewriters/merge_trees.rb

@@ -0,0 +1,587 @@
+# typed: strict
+# frozen_string_literal: true
+
+module RBI
+  module Rewriters
+    # Merge two RBI trees together
+    #
+    # Be this `Tree`:
+    # ~~~rb
+    # class Foo
+    #   attr_accessor :a
+    #   def m; end
+    #   C = 10
+    # end
+    # ~~~
+    #
+    # Merged with this one:
+    # ~~~rb
+    # class Foo
+    #   attr_reader :a
+    #   def m(x); end
+    #   C = 10
+    # end
+    # ~~~
+    #
+    # Compatible definitions are merged together while incompatible definitions are moved into a `ConflictTree`:
+    # ~~~rb
+    # class Foo
+    #   <<<<<<< left
+    #   attr_accessor :a
+    #   def m; end
+    #   =======
+    #   attr_reader :a
+    #   def m(x); end
+    #   >>>>>>> right
+    #   C = 10
+    # end
+    # ~~~
+    class Merge
+      extend T::Sig
+
+      sig { params(left: Tree, right: Tree, left_name: String, right_name: String).returns(Tree) }
+      def self.merge_trees(left, right, left_name: "left", right_name: "right")
+        rewriter = Rewriters::Merge.new(left_name: left_name, right_name: right_name)
+        rewriter.merge(left)
+        rewriter.merge(right)
+        tree = rewriter.tree
+        ConflictTreeMerger.new.visit(tree)
+        tree
+      end
+
+      sig { returns(Tree) }
+      attr_reader :tree
+
+      sig { params(left_name: String, right_name: String).void }
+      def initialize(left_name: "left", right_name: "right")
+        @left_name = left_name
+        @right_name = right_name
+        @tree = T.let(Tree.new, Tree)
+        @scope_stack = T.let([@tree], T::Array[Tree])
+      end
+
+      sig { params(tree: Tree).returns(T::Array[Conflict]) }
+      def merge(tree)
+        v = TreeMerger.new(@tree, left_name: @left_name, right_name: @right_name)
+        v.visit(tree)
+        v.conflicts
+      end
+
+      # Used for logging / error displaying purpose
+      class Conflict < T::Struct
+        extend T::Sig
+
+        const :left, Node
+        const :right, Node
+        const :left_name, String
+        const :right_name, String
+
+        sig { returns(String) }
+        def to_s
+          "Conflicting definitions for `#{left}`"
+        end
+      end
+
+      class TreeMerger < Visitor
+        extend T::Sig
+
+        sig { returns(T::Array[Conflict]) }
+        attr_reader :conflicts
+
+        sig { params(output: Tree, left_name: String, right_name: String).void }
+        def initialize(output, left_name: "left", right_name: "right")
+          super()
+          @tree = output
+          @index = T.let(output.index, Index)
+          @scope_stack = T.let([@tree], T::Array[Tree])
+          @left_name = left_name
+          @right_name = right_name
+          @conflicts = T.let([], T::Array[Conflict])
+        end
+
+        sig { override.params(node: T.nilable(Node)).void }
+        def visit(node)
+          return unless node
+
+          case node
+          when Scope
+            prev = previous_definition(node)
+
+            if prev.is_a?(Scope)
+              if node.compatible_with?(prev)
+                prev.merge_with(node)
+              else
+                make_conflict_scope(prev, node)
+              end
+              @scope_stack << prev
+            else
+              copy = node.dup_empty
+              current_scope << copy
+              @scope_stack << copy
+            end
+            visit_all(node.nodes)
+            @scope_stack.pop
+          when Tree
+            current_scope.merge_with(node)
+            visit_all(node.nodes)
+          when Indexable
+            prev = previous_definition(node)
+            if prev
+              if node.compatible_with?(prev)
+                prev.merge_with(node)
+              else
+                make_conflict_tree(prev, node)
+              end
+            else
+              current_scope << node.dup
+            end
+          end
+        end
+
+        private
+
+        sig { returns(Tree) }
+        def current_scope
+          T.must(@scope_stack.last)
+        end
+
+        sig { params(node: Node).returns(T.nilable(Node)) }
+        def previous_definition(node)
+          case node
+          when Indexable
+            node.index_ids.each do |id|
+              others = @index[id]
+              return others.last unless others.empty?
+            end
+          end
+          nil
+        end
+
+        sig { params(left: Scope, right: Scope).void }
+        def make_conflict_scope(left, right)
+          @conflicts << Conflict.new(left: left, right: right, left_name: @left_name, right_name: @right_name)
+          scope_conflict = ScopeConflict.new(left: left, right: right, left_name: @left_name, right_name: @right_name)
+          left.replace(scope_conflict)
+        end
+
+        sig { params(left: Node, right: Node).void }
+        def make_conflict_tree(left, right)
+          @conflicts << Conflict.new(left: left, right: right, left_name: @left_name, right_name: @right_name)
+          tree = left.parent_conflict_tree
+          unless tree
+            tree = ConflictTree.new(left_name: @left_name, right_name: @right_name)
+            left.replace(tree)
+            tree.left << left
+          end
+          tree.right << right
+        end
+      end
+
+      # Merge adjacent conflict trees
+      #
+      # Transform this:
+      # ~~~rb
+      # class Foo
+      #   <<<<<<< left
+      #   def m1; end
+      #   =======
+      #   def m1(a); end
+      #   >>>>>>> right
+      #   <<<<<<< left
+      #   def m2(a); end
+      #   =======
+      #   def m2; end
+      #   >>>>>>> right
+      # end
+      # ~~~
+      #
+      # Into this:
+      # ~~~rb
+      # class Foo
+      #   <<<<<<< left
+      #   def m1; end
+      #   def m2(a); end
+      #   =======
+      #   def m1(a); end
+      #   def m2; end
+      #   >>>>>>> right
+      # end
+      # ~~~
+      class ConflictTreeMerger < Visitor
+        sig { override.params(node: T.nilable(Node)).void }
+        def visit(node)
+          visit_all(node.nodes) if node.is_a?(Tree)
+        end
+
+        sig { override.params(nodes: T::Array[Node]).void }
+        def visit_all(nodes)
+          last_conflict_tree = T.let(nil, T.nilable(ConflictTree))
+          nodes.dup.each do |node|
+            if node.is_a?(ConflictTree)
+              if last_conflict_tree
+                merge_conflict_trees(last_conflict_tree.left, node.left)
+                merge_conflict_trees(last_conflict_tree.right, node.right)
+                node.detach
+                next
+              else
+                last_conflict_tree = node
+              end
+            end
+
+            visit(node)
+          end
+        end
+
+        private
+
+        sig { params(left: Tree, right: Tree).void }
+        def merge_conflict_trees(left, right)
+          right.nodes.dup.each do |node|
+            left << node
+          end
+        end
+      end
+    end
+  end
+
+  class Node
+    extend T::Sig
+
+    # Can `self` and `_other` be merged into a single definition?
+    sig { params(_other: Node).returns(T::Boolean) }
+    def compatible_with?(_other)
+      true
+    end
+
+    # Merge `self` and `other` into a single definition
+    sig { params(other: Node).void }
+    def merge_with(other); end
+
+    sig { returns(T.nilable(ConflictTree)) }
+    def parent_conflict_tree
+      parent = T.let(parent_tree, T.nilable(Node))
+      while parent
+        return parent if parent.is_a?(ConflictTree)
+        parent = parent.parent_tree
+      end
+      nil
+    end
+  end
+
+  class NodeWithComments
+    extend T::Sig
+
+    sig { override.params(other: Node).void }
+    def merge_with(other)
+      return unless other.is_a?(NodeWithComments)
+      other.comments.each do |comment|
+        comments << comment unless comments.include?(comment)
+      end
+    end
+  end
+
+  class Tree
+    extend T::Sig
+
+    sig { params(other: Tree).returns(Tree) }
+    def merge(other)
+      Rewriters::Merge.merge_trees(self, other)
+    end
+  end
+
+  class Scope
+    extend T::Sig
+
+    # Duplicate `self` scope without its body
+    sig { returns(T.self_type) }
+    def dup_empty
+      case self
+      when Module
+        Module.new(name, loc: loc, comments: comments)
+      when Class
+        Class.new(name, superclass_name: superclass_name, loc: loc, comments: comments)
+      when SingletonClass
+        SingletonClass.new(loc: loc, comments: comments)
+      else
+        raise "Can't duplicate node #{self}"
+      end
+    end
+  end
+
+  class Class
+    extend T::Sig
+
+    sig { override.params(other: Node).returns(T::Boolean) }
+    def compatible_with?(other)
+      other.is_a?(Class) && superclass_name == other.superclass_name
+    end
+  end
+
+  class Module
+    extend T::Sig
+
+    sig { override.params(other: Node).returns(T::Boolean) }
+    def compatible_with?(other)
+      other.is_a?(Module)
+    end
+  end
+
+  class Const
+    extend T::Sig
+
+    sig { override.params(other: Node).returns(T::Boolean) }
+    def compatible_with?(other)
+      other.is_a?(Const) && name == other.name && value == other.value
+    end
+  end
+
+  class Attr
+    extend T::Sig
+
+    sig { override.params(other: Node).returns(T::Boolean) }
+    def compatible_with?(other)
+      return false unless other.is_a?(Attr)
+      return false unless names == other.names
+      sigs.empty? || other.sigs.empty? || sigs == other.sigs
+    end
+
+    sig { override.params(other: Node).void }
+    def merge_with(other)
+      return unless other.is_a?(Attr)
+      super
+      other.sigs.each do |sig|
+        sigs << sig unless sigs.include?(sig)
+      end
+    end
+  end
+
+  class AttrReader
+    extend T::Sig
+
+    sig { override.params(other: Node).returns(T::Boolean) }
+    def compatible_with?(other)
+      other.is_a?(AttrReader) && super
+    end
+  end
+
+  class AttrWriter
+    extend T::Sig
+
+    sig { override.params(other: Node).returns(T::Boolean) }
+    def compatible_with?(other)
+      other.is_a?(AttrWriter) && super
+    end
+  end
+
+  class AttrAccessor
+    extend T::Sig
+
+    sig { override.params(other: Node).returns(T::Boolean) }
+    def compatible_with?(other)
+      other.is_a?(AttrAccessor) && super
+    end
+  end
+
+  class Method
+    extend T::Sig
+
+    sig { override.params(other: Node).returns(T::Boolean) }
+    def compatible_with?(other)
+      return false unless other.is_a?(Method)
+      return false unless name == other.name
+      return false unless params == other.params
+      sigs.empty? || other.sigs.empty? || sigs == other.sigs
+    end
+
+    sig { override.params(other: Node).void }
+    def merge_with(other)
+      return unless other.is_a?(Method)
+      super
+      other.sigs.each do |sig|
+        sigs << sig unless sigs.include?(sig)
+      end
+    end
+  end
+
+  class Mixin
+    extend T::Sig
+
+    sig { override.params(other: Node).returns(T::Boolean) }
+    def compatible_with?(other)
+      other.is_a?(Mixin) && names == other.names
+    end
+  end
+
+  class Include
+    extend T::Sig
+
+    sig { override.params(other: Node).returns(T::Boolean) }
+    def compatible_with?(other)
+      other.is_a?(Include) && super
+    end
+  end
+
+  class Extend
+    extend T::Sig
+
+    sig { override.params(other: Node).returns(T::Boolean) }
+    def compatible_with?(other)
+      other.is_a?(Extend) && super
+    end
+  end
+
+  class MixesInClassMethods
+    extend T::Sig
+
+    sig { override.params(other: Node).returns(T::Boolean) }
+    def compatible_with?(other)
+      other.is_a?(MixesInClassMethods) && super
+    end
+  end
+
+  class Helper
+    extend T::Sig
+
+    sig { override.params(other: Node).returns(T::Boolean) }
+    def compatible_with?(other)
+      other.is_a?(Helper) && name == other.name
+    end
+  end
+
+  class TStructField
+    extend T::Sig
+
+    sig { override.params(other: Node).returns(T::Boolean) }
+    def compatible_with?(other)
+      other.is_a?(TStructField) && name == other.name && type == other.type && default == other.default
+    end
+  end
+
+  class TStructConst
+    extend T::Sig
+
+    sig { override.params(other: Node).returns(T::Boolean) }
+    def compatible_with?(other)
+      other.is_a?(TStructConst) && super
+    end
+  end
+
+  class TEnumBlock
+    extend T::Sig
+
+    sig { override.params(other: Node).void }
+    def merge_with(other)
+      return unless other.is_a?(TEnumBlock)
+      super
+      other.names.each do |name|
+        names << name unless names.include?(name)
+      end
+    end
+  end
+
+  class TStructProp
+    extend T::Sig
+
+    sig { override.params(other: Node).returns(T::Boolean) }
+    def compatible_with?(other)
+      other.is_a?(TStructProp) && super
+    end
+  end
+
+  # A tree showing incompatibles nodes
+  #
+  # Is rendered as a merge conflict between `left` and` right`:
+  # ~~~rb
+  # class Foo
+  #   <<<<<<< left
+  #   def m1; end
+  #   def m2(a); end
+  #   =======
+  #   def m1(a); end
+  #   def m2; end
+  #   >>>>>>> right
+  # end
+  # ~~~
+  class ConflictTree < Tree
+    extend T::Sig
+
+    sig { returns(Tree) }
+    attr_reader :left, :right
+
+    sig { params(left_name: String, right_name: String).void }
+    def initialize(left_name: "left", right_name: "right")
+      super()
+      @left_name = left_name
+      @right_name = right_name
+      @left = T.let(Tree.new, Tree)
+      @left.parent_tree = self
+      @right = T.let(Tree.new, Tree)
+      @right.parent_tree = self
+    end
+
+    sig { override.params(v: Printer).void }
+    def accept_printer(v)
+      v.printl("<<<<<<< #{@left_name}")
+      v.visit(left)
+      v.printl("=======")
+      v.visit(right)
+      v.printl(">>>>>>> #{@right_name}")
+    end
+  end
+
+  # A conflict between two scope headers
+  #
+  # Is rendered as a merge conflict between `left` and` right` for scope definitions:
+  # ~~~rb
+  # <<<<<<< left
+  # class Foo
+  # =======
+  # module Foo
+  # >>>>>>> right
+  #   def m1; end
+  # end
+  # ~~~
+  class ScopeConflict < Tree
+    extend T::Sig
+
+    sig { returns(Scope) }
+    attr_reader :left, :right
+
+    sig do
+      params(
+        left: Scope,
+        right: Scope,
+        left_name: String,
+        right_name: String
+      ).void
+    end
+    def initialize(left:, right:, left_name: "left", right_name: "right")
+      super()
+      @left = left
+      @right = right
+      @left_name = left_name
+      @right_name = right_name
+    end
+
+    sig { override.params(v: Printer).void }
+    def accept_printer(v)
+      previous_node = v.previous_node
+      v.printn if previous_node && (!previous_node.oneline? || !oneline?)
+
+      v.printl("# #{loc}") if loc && v.print_locs
+      v.visit_all(comments)
+
+      v.printl("<<<<<<< #{@left_name}")
+      left.print_header(v)
+      v.printl("=======")
+      right.print_header(v)
+      v.printl(">>>>>>> #{@right_name}")
+      left.print_body(v)
+    end
+
+    sig { override.returns(T::Boolean) }
+    def oneline?
+      left.oneline?
+    end
+  end
+end