rbhint 0.85.1.rc1 → 0.85.1.rc2

data/lib/rubocop/cop/layout/end_alignment.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Layout
-      # This cop checks whether the end keywords are aligned properly.
+      # This hint checks whether the end keywords are aligned properly.
       #
       # Three modes are supported through the `EnforcedStyleAlignWith`
       # configuration parameter:

data/lib/rubocop/cop/layout/end_of_line.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Layout
-      # This cop checks for Windows-style line endings in the source code.
+      # This hint checks for Windows-style line endings in the source code.
       #
       # @example EnforcedStyle: native (default)
       #   # The `native` style means that CR+LF (Carriage Return + Line Feed) is
@@ -65,7 +65,7 @@ module RuboCop
 
         # If there is no LF on the last line, we don't care if there's no CR.
         def unimportant_missing_cr?(index, last_line, line)
-          style == :crlf && index == last_line - 1 && line !~ /\n$/
+          style == :crlf && index == last_line - 1 && !/\n$/.match?(line)
         end
 
         def offense_message(line)

data/lib/rubocop/cop/layout/extra_spacing.rb

@@ -5,20 +5,20 @@ require 'set'
 module RuboCop
   module Cop
     module Layout
-      # This cop checks for extra/unnecessary whitespace.
+      # This hint checks for extra/unnecessary whitespace.
       #
       # @example
       #
       #   # good if AllowForAlignment is true
-      #   name      = "RuboCop"
+      #   name      = "RbHint"
       #   # Some comment and an empty line
       #
-      #   website  += "/rubocop-hq/rubocop" unless cond
-      #   puts        "rubocop"          if     debug
+      #   website  += "/zspencer/rbhint" unless cond
+      #   puts        "rbhint"          if     debug
       #
       #   # bad for any configuration
-      #   set_app("RuboCop")
-      #   website  = "https://github.com/rubocop-hq/rubocop"
+      #   set_app("RbHint")
+      #   website  = "https://github.com/zspencer/rbhint"
       #
       #   # good only if AllowBeforeTrailingComments is true
       #   object.method(arg)  # this is a comment

data/lib/rubocop/cop/layout/first_argument_indentation.rb

@@ -3,9 +3,9 @@
 module RuboCop
   module Cop
     module Layout
-      # This cop checks the indentation of the first argument in a method call.
+      # This hint checks the indentation of the first argument in a method call.
       # Arguments after the first one are checked by Layout/ArgumentAlignment,
-      # not by this cop.
+      # not by this hint.
       #
       # For indenting the first parameter of method _definitions_, check out
       # Layout/FirstParameterIndentation.
@@ -168,7 +168,7 @@ module RuboCop
 
           send_node = arg_node.parent
           text = base_range(send_node, arg_node).source.strip
-          base = if text !~ /\n/ && special_inner_call_indentation?(send_node)
+          base = if !/\n/.match?(text) && special_inner_call_indentation?(send_node)
                    "`#{text}`"
                  elsif comment_line?(text.lines.reverse_each.first)
                    'the start of the previous line (not counting the comment)'

data/lib/rubocop/cop/layout/first_array_element_indentation.rb

@@ -3,9 +3,9 @@
 module RuboCop
   module Cop
     module Layout
-      # This cop checks the indentation of the first element in an array literal
+      # This hint checks the indentation of the first element in an array literal
       # where the opening bracket and the first element are on separate lines.
-      # The other elements' indentations are handled by the ArrayAlignment cop.
+      # The other elements' indentations are handled by the ArrayAlignment hint.
       #
       # By default, array literals that are arguments in a method call with
       # parentheses, and where the opening square bracket of the array is on the

data/lib/rubocop/cop/layout/first_array_element_line_break.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Layout
-      # This cop checks for a line break before the first element in a
+      # This hint checks for a line break before the first element in a
       # multi-line array.
       #
       # @example
@@ -37,7 +37,7 @@ module RuboCop
 
         def assignment_on_same_line?(node)
           source = node.source_range.source_line[0...node.loc.column]
-          source =~ /\s*=\s*$/
+          /\s*=\s*$/.match?(source)
         end
       end
     end

data/lib/rubocop/cop/layout/first_hash_element_indentation.rb

@@ -3,9 +3,9 @@
 module RuboCop
   module Cop
     module Layout
-      # This cop checks the indentation of the first key in a hash literal
+      # This hint checks the indentation of the first key in a hash literal
       # where the opening brace and the first key are on separate lines. The
-      # other keys' indentations are handled by the HashAlignment cop.
+      # other keys' indentations are handled by the HashAlignment hint.
       #
       # By default, Hash literals that are arguments in a method call with
       # parentheses, and where the opening curly brace of the hash is on the

data/lib/rubocop/cop/layout/first_hash_element_line_break.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Layout
-      # This cop checks for a line break before the first element in a
+      # This hint checks for a line break before the first element in a
       # multi-line hash.
       #
       # @example

data/lib/rubocop/cop/layout/first_method_argument_line_break.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Layout
-      # This cop checks for a line break before the first argument in a
+      # This hint checks for a line break before the first argument in a
       # multi-line method call.
       #
       # @example

data/lib/rubocop/cop/layout/first_method_parameter_line_break.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Layout
-      # This cop checks for a line break before the first parameter in a
+      # This hint checks for a line break before the first parameter in a
       # multi-line method parameter definition.
       #
       # @example

data/lib/rubocop/cop/layout/first_parameter_indentation.rb

@@ -3,9 +3,9 @@
 module RuboCop
   module Cop
     module Layout
-      # This cop checks the indentation of the first parameter in a method
+      # This hint checks the indentation of the first parameter in a method
       # definition. Parameters after the first one are checked by
-      # Layout/ParameterAlignment, not by this cop.
+      # Layout/ParameterAlignment, not by this hint.
       #
       # For indenting the first argument of method _calls_, check out
       # Layout/FirstArgumentIndentation, which supports options related to

data/lib/rubocop/cop/layout/hash_alignment.rb

@@ -200,7 +200,7 @@ module RuboCop
         alias on_super on_send
         alias on_yield on_send
 
-        def on_hash(node)
+        def on_hash(node) # rubocop:todo Metrics/CyclomaticComplexity
           return if ignored_node?(node)
           return if node.pairs.empty? || node.single_line?
 

data/lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Layout
-      # This cop checks for the placement of the closing parenthesis
+      # This hint checks for the placement of the closing parenthesis
       # in a method call that passes a HEREDOC string as an argument.
       # It should be placed at the end of the line containing the
       # opening HEREDOC tag.

data/lib/rubocop/cop/layout/heredoc_indentation.rb

@@ -3,12 +3,12 @@
 module RuboCop
   module Cop
     module Layout
-      # This cop checks the indentation of the here document bodies. The bodies
+      # This hint checks the indentation of the here document bodies. The bodies
       # are indented one step.
       #
       # Note: When ``Layout/LineLength``'s `AllowHeredoc` is false (not default),
-      #       this cop does not add any offenses for long here documents to
-      #       avoid `Layout/LineLength`'s offenses.
+      #       this hint does not add any flags for long here documents to
+      #       avoid `Layout/LineLength`'s flags.
       #
       # @example
       #   # bad

data/lib/rubocop/cop/layout/indentation_consistency.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Layout
-      # This cop checks for inconsistent indentation.
+      # This hint checks for inconsistent indentation.
       #
       # The difference between `indented_internal_methods` and `normal` is
       # that the `indented_internal_methods` style prescribes that in

data/lib/rubocop/cop/layout/indentation_style.rb

@@ -5,7 +5,7 @@ require 'set'
 module RuboCop
   module Cop
     module Layout
-      # This cop checks that the indentation method is consistent.
+      # This hint checks that the indentation method is consistent.
       # Either tabs only or spaces only are used for indentation.
       #
       # @example EnforcedStyle: spaces (default)

data/lib/rubocop/cop/layout/indentation_width.rb

@@ -3,10 +3,10 @@
 module RuboCop
   module Cop
     module Layout
-      # This cop checks for indentation that doesn't use the specified number
+      # This hint checks for indentation that doesn't use the specified number
       # of spaces.
       #
-      # See also the IndentationConsistency cop which is the companion to this
+      # See also the IndentationConsistency hint which is the companion to this
       # one.
       #
       # @example

data/lib/rubocop/cop/layout/initial_indentation.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Layout
-      # This cop checks for indentation of the first non-blank non-comment
+      # This hint checks for indentation of the first non-blank non-comment
       # line in a file.
       #
       # @example

data/lib/rubocop/cop/layout/leading_comment_space.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Layout
-      # This cop checks whether comments have a leading space after the
+      # This hint checks whether comments have a leading space after the
       # `#` denoting the start of the comment. The leading space is not
       # required for some RDoc special syntax, like `#++`, `#--`,
       # `#:nodoc`, `=begin`- and `=end` comments, "shebang" directives,

data/lib/rubocop/cop/layout/leading_empty_lines.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Layout
-      # This cop checks for unnecessary leading blank lines at the beginning
+      # This hint checks for unnecessary leading blank lines at the beginning
       # of a file.
       #
       # @example

data/lib/rubocop/cop/layout/line_length.rb

@@ -5,19 +5,19 @@ require 'uri'
 module RuboCop
   module Cop
     module Layout
-      # This cop checks the length of lines in the source code.
+      # This hint checks the length of lines in the source code.
       # The maximum length is configurable.
       # The tab size is configured in the `IndentationWidth`
-      # of the `Layout/IndentationStyle` cop.
+      # of the `Layout/IndentationStyle` hint.
       # It also ignores a shebang line by default.
       #
-      # This cop has some autocorrection capabilities.
+      # This hint has some autocorrection capabilities.
       # It can programmatically shorten certain long lines by
       # inserting line breaks into expressions that can be safely
       # split across lines. These include arrays, hashes, and
       # method calls with argument lists.
       #
-      # If autocorrection is enabled, the following Layout cops
+      # If autocorrection is enabled, the following Layout hints
       # are recommended to further format the broken lines.
       # (Many of these are enabled by default.)
       #
@@ -39,7 +39,7 @@ module RuboCop
       # * MultilineMethodArgumentLineBreaks
       # * ParameterAlignment
       #
-      # Together, these cops will pretty print hashes, arrays,
+      # Together, these hints will pretty print hashes, arrays,
       # method calls, etc. For example, let's say the max columns
       # is 25:
       #
@@ -52,7 +52,7 @@ module RuboCop
       #   {foo: "0000000000",
       #   bar: "0000000000", baz: "0000000000"}
       #
-      #   # good (with recommended cops enabled)
+      #   # good (with recommended hints enabled)
       #   {
       #     foo: "0000000000",
       #     bar: "0000000000",

data/lib/rubocop/cop/layout/multiline_array_brace_layout.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Layout
-      # This cop checks that the closing brace in an array literal is either
+      # This hint checks that the closing brace in an array literal is either
       # on the same line as the last array element or on a new line.
       #
       # When using the `symmetrical` (default) style:

data/lib/rubocop/cop/layout/multiline_array_line_breaks.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Layout
-      # This cop ensures that each item in a multi-line array
+      # This hint ensures that each item in a multi-line array
       # starts on a separate line.
       #
       # @example

data/lib/rubocop/cop/layout/multiline_assignment_layout.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Layout
-      # This cop checks whether the multiline assignments have a newline
+      # This hint checks whether the multiline assignments have a newline
       # after the assignment operator.
       #
       # @example EnforcedStyle: new_line (default)

data/lib/rubocop/cop/layout/multiline_block_layout.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Layout
-      # This cop checks whether the multiline do end blocks have a newline
+      # This hint checks whether the multiline do end blocks have a newline
       # after the start of the block. Additionally, it checks whether the block
       # arguments, if any, are on the same line as the start of the
       # block. Putting block arguments on separate lines, because the whole

data/lib/rubocop/cop/layout/multiline_hash_brace_layout.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Layout
-      # This cop checks that the closing brace in a hash literal is either
+      # This hint checks that the closing brace in a hash literal is either
       # on the same line as the last hash element, or a new line.
       #
       # When using the `symmetrical` (default) style:

data/lib/rubocop/cop/layout/multiline_hash_key_line_breaks.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Layout
-      # This cop ensures that each key in a multi-line hash
+      # This hint ensures that each key in a multi-line hash
       # starts on a separate line.
       #
       # @example

data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Layout
-      # This cop ensures that each argument in a multi-line method call
+      # This hint ensures that each argument in a multi-line method call
       # starts on a separate line.
       #
       # @example

data/lib/rubocop/cop/layout/multiline_method_call_brace_layout.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Layout
-      # This cop checks that the closing brace in a method call is either
+      # This hint checks that the closing brace in a method call is either
       # on the same line as the last method argument, or a new line.
       #
       # When using the `symmetrical` (default) style:

data/lib/rubocop/cop/layout/multiline_method_call_indentation.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Layout
-      # This cop checks the indentation of the method name part in method calls
+      # This hint checks the indentation of the method name part in method calls
       # that span more than one line.
       #
       # @example EnforcedStyle: aligned (default)

data/lib/rubocop/cop/layout/multiline_method_definition_brace_layout.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Layout
-      # This cop checks that the closing brace in a method definition is either
+      # This hint checks that the closing brace in a method definition is either
       # on the same line as the last method parameter, or a new line.
       #
       # When using the `symmetrical` (default) style:

data/lib/rubocop/cop/layout/multiline_operation_indentation.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Layout
-      # This cop checks the indentation of the right hand side operand in
+      # This hint checks the indentation of the right hand side operand in
       # binary operations that span more than one line.
       #
       # The `aligned` style checks that operators are aligned if they are part

data/lib/rubocop/cop/layout/parameter_alignment.rb

@@ -6,7 +6,7 @@ module RuboCop
       # Here we check if the parameters on a multi-line method call or
       # definition are aligned.
       #
-      # To set the alignment of the first argument, use the cop
+      # To set the alignment of the first argument, use the hint
       # FirstParameterIndentation.
       #
       # @example EnforcedStyle: with_first_parameter (default)

data/lib/rubocop/cop/layout/space_after_colon.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Cop
     module Layout
       # Checks for colon (:) not followed by some kind of space.
-      # N.B. this cop does not handle spaces after a ternary operator, which are
+      # N.B. this hint does not handle spaces after a ternary operator, which are
       # instead handled by Layout/SpaceAroundOperators.
       #
       # @example
@@ -39,7 +39,7 @@ module RuboCop
         private
 
         def followed_by_space?(colon)
-          colon.source_buffer.source[colon.end_pos] =~ /\s/
+          /\s/.match?(colon.source_buffer.source[colon.end_pos])
         end
       end
     end

data/lib/rubocop/cop/layout/space_around_block_parameters.rb

@@ -5,7 +5,7 @@ module RuboCop
     module Layout
       # Checks the spacing inside and after block parameters pipes. Line breaks
       # inside parameter pipes are checked by `Layout/MultilineBlockLayout` and
-      # not by this cop.
+      # not by this hint.
       #
       # @example EnforcedStyleInsidePipes: no_space (default)
       #   # bad