rbexy 2.0.0.beta3 → 2.0.0.beta8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ee91f09f1492ee300b112dcc61edee9fb96f4938e18753ed435091d212b702ee
-  data.tar.gz: a1ee23c58ac112b8596c0451d2b42b19c35be12a8cd43a8512523f76d454f491
+  metadata.gz: 1e6c7e84344a63e1d1992827aedcafdd968ce9372e35bb6a8d01e66b46be34e0
+  data.tar.gz: 497be0f074210d5f43efe9a38e72d41972b309fc8294fa413db097afdf0cb8e5
 SHA512:
-  metadata.gz: cfb9b92d18a403a5c5e3d4b87f1120101f7dc961b0e480460bab56d6786f68c2cf06743a759174d1637a34c057299ca2f9391e7895979de1e33694c61ae66654
-  data.tar.gz: 66f9e6e960b87e524fa97b768f61117cdfcc151d68a1cb388607532ecf39df31c1a81f379bffe264ffd31f12600c71bf36d637c8aaa6b56b45df973774207d3b
+  metadata.gz: 8c18d3a259f7ce7ad630e2a39a8241ad0b6ce6bde8ea9ac55bd601cd6378b39e3201c011f8b6348bd4aaf86b780817a6b52db45cfa86a851e854b7c62cfb4285
+  data.tar.gz: dcf0db849b73ef8c817247c53812359273ed23f4016325288f91d066c449e41ddfc98cb94a924c2dc06ddf1f3d4e56f1998cc91728619c8ddd66c30f2f4faab2

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rbexy (2.0.0.beta3)
+    rbexy (2.0.0.beta8)
       actionview (>= 6.0, < 7.0)
       activesupport (>= 6.0, < 7.0)
 

data/README.md

@@ -301,7 +301,7 @@ By default, we'll look for a template file in the same directory as the class an
 <h1>{@title}</h1>
 ```
 
-You can call this component from another `.rbx` template file (`<PageHeader title="Hello" />`)—either one rendered by another component class or a Rails view file like `app/views/products/index.rbx`. Or you can call it from ERB (or any other template language) like `PageHeaderComponent.new(self, title: "Hello").render`.
+You can call this component from another `.rbx` template file (`<PageHeader title="Hello" />`)—either one rendered by another component class or a Rails view file like `app/views/products/index.rbx`. Or you can call it from ERB (or any other template language) like `PageHeaderComponent.new(self, title: "Hello").render_in`.
 
 Your components and their templates run in the same context as traditional Rails views, so you have access to all of the view helpers you're used to as well as any custom helpers you've defined in `app/helpers/`.
 

data/lib/rbexy/cache_component.rb

@@ -0,0 +1,17 @@
+module Rbexy
+  class CacheComponent < Rbexy::Component
+    def setup(key:)
+      @key = key
+    end
+
+    def call
+      @current_template = view_context.instance_variable_get(:@current_template)
+
+      capture do
+        cache @key, virtual_path: @current_template.virtual_path do
+          @output_buffer << content
+        end
+      end
+    end
+  end
+end

data/lib/rbexy/component.rb

@@ -1,4 +1,5 @@
 require "action_view"
+require "active_support/core_ext/class/attribute"
 
 module Rbexy
   class Component < ActionView::Base
@@ -10,12 +11,22 @@ module Rbexy
       end
     end
 
-    def self.component_name
-      name.underscore
+    class_attribute :component_file_location
+
+    def self.inherited(klass)
+      klass.component_file_location = caller_locations(1, 10).reject { |l| l.label == "inherited" }[0].absolute_path
     end
 
-    def component_name
-      self.class.component_name
+    def self.template_path
+      TemplatePath.new(component_name)
+    end
+
+    def self.call_component?
+      method_defined?(:call)
+    end
+
+    def self.component_name
+      name.underscore
     end
 
     def initialize(view_context, **props)
@@ -35,18 +46,15 @@ module Rbexy
     # call super(view_context).
     def setup(**props); end
 
-    def render(&block)
+    def render_in(_context = view_context, &block)
       @content_block = block_given? ? block : nil
-      call
+      self.class.call_component? ? call : _render
     end
 
-    def call
-      path = TemplatePath.new(component_name)
-      template = view_context.lookup_context.find(path)
-      template.render(self, {})
-    rescue ActionView::Template::Error => error
-      error.set_backtrace clean_template_backtrace(error.backtrace)
-      raise error
+    # Explicitly delegate `render` to the view_context rather than super,
+    # so `render partial: "..."` calls run in the expected context.
+    def render(*args)
+      view_context.render(*args)
     end
 
     def content
@@ -61,6 +69,15 @@ module Rbexy
 
     attr_reader :view_context, :content_block
 
+    def _render
+      path = self.class.template_path
+      template = view_context.lookup_context.find(path)
+      template.render(self, {})
+    rescue ActionView::Template::Error => error
+      error.set_backtrace clean_template_backtrace(error.backtrace)
+      raise error
+    end
+
     def method_missing(meth, *args, &block)
       view_context.send(meth, *args, &block)
     end

data/lib/rbexy/component_resolver.rb

@@ -19,6 +19,13 @@ module Rbexy
       tspan tt u ul unknown use var video view wbr xmp
     ).to_set
 
+    def self.try_constantize
+      yield
+    rescue NameError => e
+      raise e unless e.message =~ /wrong constant name/ || e.message =~ /uninitialized constant/
+      nil
+    end
+
     attr_reader :component_namespaces
 
     def initialize
@@ -43,18 +50,11 @@ module Rbexy
     private
 
     def find(name)
-      find!(name)
-    rescue NameError => e
-      raise e unless e.message =~ /wrong constant name/ || e.message =~ /uninitialized constant/
-      nil
+      self.class.try_constantize { ActiveSupport::Inflector.constantize("#{name.gsub(".", "::")}Component") }
     end
 
     def matching_namespaces(template)
       component_namespaces.select { |path, ns| template.identifier.start_with?(path) }.values.flatten.uniq
     end
-
-    def find!(name)
-      ActiveSupport::Inflector.constantize("#{name.gsub(".", "::")}Component")
-    end
   end
 end

data/lib/rbexy/configuration.rb

@@ -22,7 +22,7 @@ module Rbexy
     def component_rendering_templates
       @component_rendering_templates ||= {
         children: "{capture{%{children}}}",
-        component: "::%{component_class}.new(%{view_context},%{kwargs}).render%{children_block}"
+        component: "::%{component_class}.new(%{view_context},%{kwargs}).render_in%{children_block}"
       }
     end
   end

data/lib/rbexy/nodes/component_element.rb

@@ -36,7 +36,7 @@ module Rbexy
         members.each_with_object("") do |member, result|
           case member
           when ExpressionGroup
-            result << "**#{member.compile},"
+            result << "**#{member.compile}.transform_keys { |k| ActiveSupport::Inflector.underscore(k).to_sym },"
           when Newline
             result << member.compile
           else

data/lib/rbexy/nodes/expression_group.rb

@@ -7,19 +7,27 @@ module Rbexy
       attr_accessor :members
       attr_reader :outer_template, :inner_template
 
+      DEBUGGERS = %w[debugger binding.pry]
+
       OUTPUT_UNSAFE = "@output_buffer.concat(Rbexy::Runtime.expr_out(%s));"
       OUTPUT_SAFE = "@output_buffer.safe_concat(Rbexy::Runtime.expr_out(%s));"
-      SUB_EXPR = "%s"
+      RAW = "%s"
+      DEBUGGER = "#{RAW}\n"
+      SUB_EXPR = RAW
       SUB_EXPR_OUT = "Rbexy::Runtime.expr_out(%s)"
 
-      def initialize(members, outer_template: OUTPUT_UNSAFE, inner_template: "%s")
+      def initialize(members, outer_template: OUTPUT_UNSAFE, inner_template: RAW)
         @members = members
         @outer_template = outer_template
         @inner_template = inner_template
       end
 
       def precompile
-        [ExpressionGroup.new(precompile_members, outer_template: outer_template, inner_template: inner_template)]
+        [if debugger?
+          ExpressionGroup.new(precompile_members, outer_template: DEBUGGER, inner_template: RAW)
+        else
+          ExpressionGroup.new(precompile_members, outer_template: outer_template, inner_template: inner_template)
+        end]
       end
 
       def compile
@@ -50,6 +58,12 @@ module Rbexy
           Expression.new("+")
         end
       end
+
+      def debugger?
+        members.length == 1 &&
+          members.first.is_a?(Expression) &&
+          DEBUGGERS.include?(members.first.content.strip)
+      end
     end
   end
 end

data/lib/rbexy/rails.rb

@@ -1,9 +1,11 @@
 module Rbexy
   autoload :Component, "rbexy/component"
+  autoload :CacheComponent, "rbexy/cache_component"
 
   module Rails
     autoload :Engine, "rbexy/rails/engine"
     autoload :ControllerHelper, "rbexy/rails/controller_helper"
     autoload :ComponentTemplateResolver, "rbexy/rails/component_template_resolver"
+    autoload :RbxDependencyTracker, "rbexy/rails/rbx_dependency_tracker"
   end
 end

data/lib/rbexy/rails/component_template_resolver.rb

@@ -1,7 +1,14 @@
+require "active_support/digest"
+
 module Rbexy
   module Rails
     class ComponentTemplateResolver < ActionView::FileSystemResolver
-      VIRTUAL_ROOT = "rbexy_component".freeze
+      COMMENT_SYNTAX = {
+        rbx: "# %s",
+        erb: "<%%# %s %%>",
+        haml: "-# %s",
+        slim: "/ %s"
+      }
 
       # Rails 6 requires us to override `_find_all` in order to hook
       def _find_all(name, prefix, partial, details, key, locals)
@@ -14,22 +21,72 @@ module Rbexy
         return [] unless name.is_a? Rbexy::Component::TemplatePath
 
         templates_path = File.join(@path, prefix, name)
+        component_name = prefix.present? ? File.join(prefix, name) : name
+        virtual_path = Rbexy::Component::TemplatePath.new(component_name)
+
         extensions = details[:handlers].join(",")
+        templates = find_rbx_templates(templates_path, extensions, component_name, virtual_path)
+
+        if templates.none?
+          templates = find_call_component_cachebuster_templates(templates_path, component_name, virtual_path)
+        end
+
+        templates
+      end
 
+      def find_rbx_templates(templates_path, extensions, component_name, virtual_path)
         Dir["#{templates_path}.*{#{extensions}}"].map do |template_path|
           source = File.binread(template_path)
-          handler = ActionView::Template.handler_for_extension(File.extname(template_path)[1..-1])
-          virtual_path = File.join(VIRTUAL_ROOT, prefix, name)
+          extension = File.extname(template_path)[1..-1]
+          handler = ActionView::Template.handler_for_extension(extension)
 
           ActionView::Template.new(
-            source,
+            "#{source}#{component_class_cachebuster(component_name, extension)}",
             template_path,
             handler,
+            format: extension.to_sym,
             locals: [],
             virtual_path: virtual_path
           )
         end
       end
+
+      def find_call_component_cachebuster_templates(templates_path, component_name, virtual_path)
+        component_class = find_component_class(component_name)
+        return [] unless component_class && component_class.call_component?
+
+        [
+          ActionView::Template.new(
+            cachebuster_digest_as_comment(component_class.component_file_location, :rbx),
+            "#{templates_path}.rbexycall",
+            ActionView::Template.handler_for_extension(:rbx),
+            format: :rbx,
+            locals: [],
+            virtual_path: virtual_path
+          )
+        ]
+      end
+
+      def component_class_cachebuster(component_name, template_format)
+        component_class = find_component_class(component_name)
+        return unless component_class
+
+        cachebuster_digest_as_comment(component_class.component_file_location, template_format)
+      end
+
+      def find_component_class(component_name)
+        Rbexy::ComponentResolver.try_constantize { component_name.classify.constantize }
+      end
+
+      def cachebuster_digest_as_comment(filename, format)
+        comment_template = COMMENT_SYNTAX[format.to_sym]
+        return "" unless comment_template
+
+        source = File.binread(filename)
+        digest = ActiveSupport::Digest.hexdigest(source)
+
+        "\n#{comment_template % digest}"
+      end
     end
   end
 end

data/lib/rbexy/rails/engine.rb

@@ -1,12 +1,14 @@
 require "rbexy/rails"
+require "action_view/dependency_tracker"
 
 module Rbexy
   module Rails
     class Engine < ::Rails::Engine
       initializer "rbexy" do |app|
-        template_handler = proc { |template, source| Rbexy.compile(template) }
+        template_handler = proc { |template, source| Rbexy.compile(Rbexy::Template.new(source, template.identifier)) }
 
         ActionView::Template.register_template_handler(:rbx, template_handler)
+        ActionView::DependencyTracker.register_tracker(:rbx, RbxDependencyTracker)
 
         ActiveSupport.on_load :action_controller_base do
           include ControllerHelper

data/lib/rbexy/rails/rbx_dependency_tracker.rb

@@ -0,0 +1,37 @@
+module Rbexy
+  module Rails
+    class RbxDependencyTracker
+      def self.supports_view_paths?
+        true
+      end
+
+      def self.call(name, template, view_paths = nil)
+        new(name, template, view_paths).dependencies
+      end
+
+      def initialize(name, template, view_paths = nil)
+        @name, @template, @view_paths = name, template, view_paths
+      end
+
+      def dependencies
+        rails_render_helper_dependencies + rbexy_dependencies
+      end
+
+      private
+
+      attr_reader :name, :template, :view_paths
+
+      def rails_render_helper_dependencies
+        ActionView::DependencyTracker::ERBTracker.call(name, template, view_paths)
+      end
+
+      def rbexy_dependencies
+        Lexer.new(template, Rbexy.configuration.element_resolver).tokenize
+          .select { |t| t[0] == :TAG_DETAILS && t[1][:type] == :component }
+          .map { |t| t[1][:component_class] }
+          .uniq
+          .map(&:template_path)
+      end
+    end
+  end
+end

data/lib/rbexy/runtime.rb

@@ -11,7 +11,7 @@ module Rbexy
     end
 
     def self.splat_attrs(attrs_hash)
-      tag_builder.tag_options(attrs_hash).html_safe
+      tag_builder.tag_options(attrs_hash)&.html_safe
     end
 
     def self.expr_out(*value)

data/lib/rbexy/version.rb

@@ -1,3 +1,3 @@
 module Rbexy
-  VERSION = "2.0.0.beta3"
+  VERSION = "2.0.0.beta8"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rbexy
 version: !ruby/object:Gem::Version
-  version: 2.0.0.beta3
+  version: 2.0.0.beta8
 platform: ruby
 authors:
 - Nick Giancola
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-01-12 00:00:00.000000000 Z
+date: 2021-01-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -217,6 +217,7 @@ files:
 - docker-compose.yml
 - lib/rbexy.rb
 - lib/rbexy/ast_transformer.rb
+- lib/rbexy/cache_component.rb
 - lib/rbexy/component.rb
 - lib/rbexy/component/backtrace_cleaner.rb
 - lib/rbexy/component_context.rb
@@ -244,6 +245,7 @@ files:
 - lib/rbexy/rails/component_template_resolver.rb
 - lib/rbexy/rails/controller_helper.rb
 - lib/rbexy/rails/engine.rb
+- lib/rbexy/rails/rbx_dependency_tracker.rb
 - lib/rbexy/refinements.rb
 - lib/rbexy/refinements/array.rb
 - lib/rbexy/refinements/array/find_map.rb