rbenv-migrate 0.1 → 0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4ecdf659d12926e87bfcb55be76aea2f76382e41c2b846d67edb2d4606f6705a
-  data.tar.gz: a0bd87a26684ef260fe59b2eabb8e2704eece12d2e601057787c9c091ea34e5d
+  metadata.gz: 49145e22acf7d4b7af8be7c2569f25b95b66403c28497edebc7f90bc006254ef
+  data.tar.gz: 784858699e46829747ce23c4359e5720ee685253c26d5c900a0ef605069d25be
 SHA512:
-  metadata.gz: '0270908d16018af97ecab7c9a0014cb00e2fcae65958feb04e302c0b0f876f2a7a42390e2c8e5217d624e0e74a40154d86ce71975381b5ba10ba4f2f224466e3'
-  data.tar.gz: ce9295a66861ea8656c0cee0b04b66655d9e8551ccc7891f008009a867fbd00352a9173feb8e35f2fc2b5d5a7cf9dbd631106216c6bbbebdaab2c5fb6981749c
+  metadata.gz: b32e825c07fa1f0c50071c322b62120f0abac62a85d9953501d49fe91a9adb827ff3ecd714a179c925590359ab1c9713d5a508d4b4e611bc6dbec410abf70bdf
+  data.tar.gz: a561957be5b6dc85c8367696a9eba8233c2e6516f8798a79fcbaf0bc17f6bfbe5e13915104871c4bb578f70b0c2695d19ea4c4fbf6259fb62e622d0dfb41d16f

data/VERSION

@@ -1 +1 @@
-0.1
+0.2

data/lib/rbenv_migrate.rb

@@ -15,14 +15,25 @@ module RBEMigrate
         educate_on_error
       end
 
-      Optimist::educate if ARGV.empty?
-
       @old_version = ARGV.first
+
+      if @old_version.nil? || @old_version == RUBY_VERSION ||
+         !Dir["#{ENV['RBENV_ROOT']}/versions/**"].map { |f| File.basename f }.include?(@old_version)
+        Optimist::educate
+      end
     end
 
     def run
-      old_gems = gemspecs_for @old_version
-      current_gems = gemspecs_for RUBY_VERSION
+      old_gems = gemspecs_for(@old_version).select do |gem|
+        if gem.required_ruby_version =~ Gem::Version.new(RUBY_VERSION)
+          true
+        else
+          $stderr.puts "#{gem.name} #{gem.version} is not compatible with Ruby #{RUBY_VERSION}, skipping."
+          false
+        end
+      end.map(&:name)
+
+      current_gems = gemspecs_for(RUBY_VERSION).map(&:name)
 
       if (gems_to_install = old_gems - current_gems).any?
         command = Gem::Commands::InstallCommand.new.tap { |c| c.handle_options gems_to_install }
@@ -43,7 +54,7 @@ module RBEMigrate
 
     def gemspecs_for(version)
       gemspecs = "#{ENV['RBENV_ROOT']}/versions/#{version}/lib/ruby/gems/*/specifications/*.gemspec"
-      Dir.glob(File.join gemspecs).map { |s| Gem::Specification.load(s).name }
+      Dir.glob(File.join gemspecs).map { |s| Gem::Specification.load(s) }
     end
   end
 end

data/rbenv-migrate.gemspec

@@ -14,9 +14,13 @@ Gem::Specification.new do |gem|
   gem.bindir = "bin"
   gem.executables = %w[rbenv-migrate]
   gem.require_paths = %w[lib]
+  gem.test_files = Dir["spec/**/*"]
   gem.files = `git ls-files -z`.split "\x0"
 
   gem.required_ruby_version = "~> 3.0"
 
   gem.add_dependency "optimist", "~> 3.0"
+  gem.add_development_dependency "rake", "~> 13.0"
+  gem.add_development_dependency "rspec", "~> 3.12"
+  gem.add_development_dependency "fuubar", "~> 2.5"
 end

data/spec/migrate_spec.rb

@@ -0,0 +1,117 @@
+require "spec_helper"
+require "stringio"
+
+# Arbitrary valid old version
+OLD_VERSION = "2.7.8"
+
+def set_version(version=OLD_VERSION)
+  ARGV.replace version.nil? ? [] : [version]
+end
+
+def args_should_trigger_help_screen(args)
+  it "shows the help screen" do
+    set_version args
+    expect(Optimist).to receive :educate
+
+    RBEMigrate::CLI.new
+  end
+end
+
+RSpec.describe RBEMigrate::CLI do
+  let(:cli) { described_class.new }
+  let(:gemspecs) { "/path/to/versions/#{OLD_VERSION}/lib/ruby/gems/*/specifications/*.gemspec" }
+
+  before(:each) do
+    set_version
+
+    allow(ENV).to receive(:[]).with("RBENV_ROOT").and_return("/path/to")
+
+    allow(Dir).to receive(:[]).with("/path/to/versions/**").
+      and_return instance_double(Dir, map: [OLD_VERSION, RUBY_VERSION])
+    allow(Dir).to receive(:glob).with(gemspecs).
+      and_return instance_double(Dir, map: %w[spec1 spec2])
+  end
+
+  describe "#initialize" do
+    context "when no argument is provided" do
+      args_should_trigger_help_screen nil
+    end
+
+    context "when an invalid argument is provided" do
+      args_should_trigger_help_screen "not a version"
+    end
+
+    context "when the current version is given as an argument" do
+      args_should_trigger_help_screen RUBY_VERSION
+    end
+  end
+
+  describe "#run" do
+    context "when there are no gems to migrate" do
+      it "prints a message and exits" do
+        allow(cli).to receive(:gemspecs_for).and_return([])
+        expect { cli.run }.to output(/appear to be up-to-date/).
+          to_stdout.and raise_error(SystemExit)
+      end
+    end
+
+    context "when there are gems to migrate" do
+      let(:install_command_double) { instance_double Gem::Commands::InstallCommand, execute: true }
+
+      before :each do
+        allow(cli).to receive(:gemspecs_for).with(OLD_VERSION).and_return(old_gems)
+        allow(cli).to receive(:gemspecs_for).with(RUBY_VERSION).and_return(current_gems)
+        allow(Gem::Commands::InstallCommand).to receive(:new).and_return(install_command_double)
+      end
+
+      context "when some gems are already installed on the target version" do
+        let(:old_gems_names)     { %w[gem1 gem2 gem3 gem4] }
+        let(:current_gems_names) { %w[gem1      gem3     ] }
+        let(:result)             { %w[     gem2      gem4] }
+
+        %i[old_gems current_gems].each do |var|
+          let var do
+            send(:"#{var}_names").map do |name|
+              Gem::Specification.new do |gem|
+                gem.name = name
+                gem.version = "0.1"
+                gem.required_ruby_version = ">= #{OLD_VERSION}"
+              end
+            end
+          end
+        end
+
+        it "passes the correct gems to RubyGems" do
+          expect(install_command_double).to receive(:handle_options).with(result)
+          expect { cli.run }.not_to output(/skipping/).to_stdout
+        end
+      end
+
+      context "when an old gem is incompatible" do
+        let(:current_gems) { [] }
+        let :old_gems do
+          %w[gem1 gem2 gem3].each_with_index.map do |name, i|
+            Gem::Specification.new do |gem|
+              gem.name = name
+              gem.version = "0.1"
+              # First one tested will be skipped
+              gem.required_ruby_version = "#{i == 0 ? '~>' : '>='} #{OLD_VERSION}"
+            end
+          end
+        end
+        let(:result)             { %w[gem2 gem3] }
+
+        it "passes the correct gems to RubyGems" do
+          allow(install_command_double).to receive(:handle_options).with(result)
+          expect { cli.run }.to output(/skipping/).to_stderr
+        end
+      end
+    end
+  end
+
+  describe "#gemspecs_for" do
+    it "returns the gemspecs for the specified version" do
+      expect(cli.send(:gemspecs_for, OLD_VERSION)).to eq(%w[spec1 spec2])
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,28 @@
+require "rbenv_migrate"
+
+# Include all files in spec/support
+Dir[File.expand_path("../support/**/*.rb", __FILE__)].each { |f| require f }
+
+RSpec.configure do |config|
+  # Add `focus: true` hash parameter to a describe/context/it block
+  # to only run the specs in that block
+  config.filter_run_when_matching :focus
+
+  # Fuubar
+  config.add_formatter "Fuubar"
+  config.fuubar_progress_bar_options = { format: "  %c/%C |%b>%i|%e " }
+
+  # More verbose output if only running one spec
+  config.default_formatter = "doc" if config.files_to_run.one?
+
+  # Print the 10 slowest examples and example groups at the
+  # end of the spec run, to help surface which specs are running
+  # particularly slow.
+  config.profile_examples = 10
+
+  # Run specs in random order to surface order dependencies. If you find an
+  # order dependency and want to debug it, fix the order by providing the seed,
+  # which is printed after each run, e.g. --seed 1234
+  config.order = :random
+  Kernel.srand config.seed
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rbenv-migrate
 version: !ruby/object:Gem::Version
-  version: '0.1'
+  version: '0.2'
 platform: ruby
 authors:
 - Vinny Diehl
@@ -24,6 +24,48 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '13.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '13.0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.12'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.12'
+- !ruby/object:Gem::Dependency
+  name: fuubar
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.5'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.5'
 description: Installs all of your gems from an old version of Ruby so that you may
   uninstall it.
 email: vinny.diehl@gmail.com
@@ -41,6 +83,8 @@ files:
 - bin/rbenv-migrate
 - lib/rbenv_migrate.rb
 - rbenv-migrate.gemspec
+- spec/migrate_spec.rb
+- spec/spec_helper.rb
 homepage: https://github.com/vinnydiehl/rbenv-migrate
 licenses:
 - MIT
@@ -64,4 +108,6 @@ rubygems_version: 3.4.10
 signing_key:
 specification_version: 4
 summary: Transfer your gems from old rbenv installs.
-test_files: []
+test_files:
+- spec/migrate_spec.rb
+- spec/spec_helper.rb